)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-22 18:02:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_c995418a","line":7,"updated":"2020-09-23 00:19:01.000000000","message":"Can we make this a bit more descriptive?\n\nAdd resources for Redfish management clean steps","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-09-22 18:02:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_098c597e","line":8,"updated":"2020-09-23 00:19:01.000000000","message":"Please create a task on StoryBoard for this: https://storyboard.openstack.org/#!/story/2007617. A task can affect another project. Then add the story and task references to this message.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-27 08:22:36 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"},{"line_number":10,"context_line":"Story: 2007617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cd101aec_cb05150d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2020-11-24 08:54:52.000000000","message":"nit: in sushy-oem-idrac project having label \"DRAC:\" feels redundant, could remove it.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a67190877681160e7e1305c93112a3fee00cd087","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-27 08:22:36 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"},{"line_number":10,"context_line":"Story: 2007617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"10e5b560_72055690","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"cd101aec_cb05150d","updated":"2021-01-12 09:56:18.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3a12d2086a3633d35e9c14cb91a562eedb3bb766","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-10 09:06:36 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"0ebe0a85_06a63efe","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2021-03-11 13:28:41.000000000","message":"suggestion for title: Add resources to put iDRAC in known good state","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2b1661f4b4233fdd7b377dab9b3b0f769806a959","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-10 09:06:36 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fd1a42c2_30044b1f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"0ebe0a85_06a63efe","updated":"2021-03-12 10:30:07.000000000","message":"Done.","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DhuldevValekar3 \u003cdhuldev.valekar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-10 09:06:36 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"8bdf474d_ec49d3d5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"fd1a42c2_30044b1f","updated":"2021-03-12 13:19:46.000000000","message":"Done","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"03a32e8a895f49059c3371684ae105f58b0f43e6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"},{"line_number":11,"context_line":"and clears the job queue to get the iDRAC into known good state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"af4b8e0d_6f489a9d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":34},"updated":"2021-03-11 08:47:58.000000000","message":"this is sushy-oem-idrac library, but \u0027cleaning step\u0027 and \u0027iDRAC driver\u0027 are concepts of Ironic. Here these are just methods.","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2b1661f4b4233fdd7b377dab9b3b0f769806a959","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"},{"line_number":11,"context_line":"and clears the job queue to get the iDRAC into known good state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"73fc07ba_bdfa86b0","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":34},"in_reply_to":"13f9daa9_52aee723","updated":"2021-03-12 10:30:07.000000000","message":"Done.","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"},{"line_number":11,"context_line":"and clears the job queue to get the iDRAC into known good state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"c222f0d7_9514a414","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":34},"in_reply_to":"73fc07ba_bdfa86b0","updated":"2021-03-12 13:19:46.000000000","message":"Done","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3a12d2086a3633d35e9c14cb91a562eedb3bb766","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Redfish management clean steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added reset_idrac, clear_job_queue and known_good_state"},{"line_number":10,"context_line":"cleaning steps in the iDRAC driver that resets the iDRAC"},{"line_number":11,"context_line":"and clears the job queue to get the iDRAC into known good state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"13f9daa9_52aee723","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":34},"in_reply_to":"af4b8e0d_6f489a9d","updated":"2021-03-11 13:28:41.000000000","message":"mention resources and actions, use Redfish schema names here (not Python classes)","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add resources to put iDRAC in known good state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added resources iDRACCardService,JobService,JobCollection"},{"line_number":10,"context_line":"and LCService where each resource contains associated"},{"line_number":11,"context_line":"methods like reset idrac,get jobs,delete jobs and check"},{"line_number":12,"context_line":"is idrac ready."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"a12cced0_ceb98ee0","line":9,"updated":"2021-03-12 13:19:46.000000000","message":"white space after resource names, same for method names in line 11","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"cc436a55a586ca245cab64b33afd67c5603940fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add resources to put iDRAC in known good state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added resources iDRACCardService,JobService,JobCollection"},{"line_number":10,"context_line":"and LCService where each resource contains associated"},{"line_number":11,"context_line":"methods like reset idrac,get jobs,delete jobs and check"},{"line_number":12,"context_line":"is idrac ready."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7734cb91_4871ffc0","line":9,"in_reply_to":"a12cced0_ceb98ee0","updated":"2021-03-12 17:55:29.000000000","message":"Done","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Added resources iDRACCardService,JobService,JobCollection"},{"line_number":10,"context_line":"and LCService where each resource contains associated"},{"line_number":11,"context_line":"methods like reset idrac,get jobs,delete jobs and check"},{"line_number":12,"context_line":"is idrac ready."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"},{"line_number":15,"context_line":"Story: 2007617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"40c9b521_d9eecd82","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":9},"updated":"2021-03-12 13:19:46.000000000","message":"casing: iDRAC","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"cc436a55a586ca245cab64b33afd67c5603940fd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added resources iDRACCardService,JobService,JobCollection"},{"line_number":10,"context_line":"and LCService where each resource contains associated"},{"line_number":11,"context_line":"methods like reset idrac,get jobs,delete jobs and check"},{"line_number":12,"context_line":"is idrac ready."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I29ce49c0865a610f2fb10f5072893bbf51b47303"},{"line_number":15,"context_line":"Story: 2007617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"148ce47e_897763ac","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":9},"in_reply_to":"40c9b521_d9eecd82","updated":"2021-03-12 17:55:29.000000000","message":"Done","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"}],"sushy_oem_idrac/resources/manager/constants.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3a12d2086a3633d35e9c14cb91a562eedb3bb766","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"239ea429_fa403fc1","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2021-03-11 13:28:41.000000000","message":"2020-2021 and other files too","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2b1661f4b4233fdd7b377dab9b3b0f769806a959","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"c5ff7491_9a8d09ef","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"239ea429_fa403fc1","updated":"2021-03-12 10:30:07.000000000","message":"Done.Addressed in other files also.","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"c16eabde_533737c1","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"c5ff7491_9a8d09ef","updated":"2021-03-12 13:19:46.000000000","message":"Done","commit_id":"6eb18c5e7f12d3ca908e641c8c3a541c302efed4"}],"sushy_oem_idrac/resources/manager/idrac_card_service.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"from sushy.resources import base"},{"line_number":15,"context_line":"from sushy.resources import common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_87db377b","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027from sushy.resources import base\u0027 is identified as Third Party and \u0027import logging\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a9d72d4f","line":1,"updated":"2020-09-23 00:19:01.000000000","message":"nit: Please add Dell Inc.\u0027s copyright notice above this line.\n\n    # Copyright (c) 2020 Dell Inc. or its subsidiaries.\n    #","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d7ad86ea","line":1,"in_reply_to":"9f560f44_a9d72d4f","updated":"2020-09-27 14:19:09.000000000","message":"Done.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    reset_idrac \u003d common.ActionField(\"#DelliDRACCardService.iDRACReset\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_09e1f92b","line":22,"updated":"2020-09-23 00:19:01.000000000","message":"nit: Remove this blank line.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    reset_idrac \u003d common.ActionField(\"#DelliDRACCardService.iDRACReset\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_77a3daff","line":22,"in_reply_to":"9f560f44_09e1f92b","updated":"2020-09-27 14:19:09.000000000","message":"Done.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DelliDRACCardService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_49d01154","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":38},"updated":"2020-09-23 00:19:01.000000000","message":"Should this be required?\n\n    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DelliDRACCardService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_17b41e35","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":38},"in_reply_to":"9f560f44_49d01154","updated":"2020-09-27 14:19:09.000000000","message":"No, Its not required. Refering this file https://github.com/openstack/sushy/blob/master/sushy/resources/chassis/chassis.py#L145","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":32,"context_line":"                 registries\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"A class represents a DelliDRACCardService"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param connector: A Connector instance"},{"line_number":36,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_690eb5e4","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":52},"updated":"2020-09-23 00:19:01.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":32,"context_line":"                 registries\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"A class represents a DelliDRACCardService"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param connector: A Connector instance"},{"line_number":36,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4903f1be","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":29},"updated":"2020-09-23 00:19:01.000000000","message":"nit: representing","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":32,"context_line":"                 registries\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"A class represents a DelliDRACCardService"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param connector: A Connector instance"},{"line_number":36,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f7aecae1","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":29},"in_reply_to":"9f560f44_4903f1be","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":32,"context_line":"                 registries\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"A class represents a DelliDRACCardService"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param connector: A Connector instance"},{"line_number":36,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_57e85614","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":52},"in_reply_to":"9f560f44_690eb5e4","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(DelliDRACCardService, self).__init__("},{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_29631db3","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":42},"updated":"2020-09-23 00:19:01.000000000","message":"Does not this parameter represent the type of reset? If it does, please rename it.\n\nIts values should be represented by a mapping. For an example of the pattern, please see https://github.com/openstack/sushy/blob/b1bf4335120819268aa252762b98aede7b180958/sushy/resources/manager/manager.py#L188.\n\nThe argument value should be compared against the values allowed by the service, e.g., https://github.com/openstack/sushy/blob/b1bf4335120819268aa252762b98aede7b180958/sushy/resources/manager/manager.py#L183-L186.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(DelliDRACCardService, self).__init__("},{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_57833656","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":42},"in_reply_to":"9f560f44_29631db3","updated":"2020-09-27 14:19:09.000000000","message":"Done, followed the above pattern to use allowed values.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"},{"line_number":49,"context_line":"        and it defaults to a graceful reset."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c9f6e1d8","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":27},"updated":"2020-09-23 00:19:01.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"},{"line_number":49,"context_line":"        and it defaults to a graceful reset."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_09fd79b1","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":17},"updated":"2020-09-23 00:19:01.000000000","message":"nit: Reset","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"},{"line_number":49,"context_line":"        and it defaults to a graceful reset."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_37868266","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":17},"in_reply_to":"9f560f44_09fd79b1","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def reset_idrac(self, force\u003d\"Graceful\"):"},{"line_number":46,"context_line":"        \"\"\"Resets the iDRAC"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param force: does a force reset when caller pass \"Force\" as value"},{"line_number":49,"context_line":"        and it defaults to a graceful reset."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_97794e83","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":27},"in_reply_to":"9f560f44_c9f6e1d8","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"522ef806196e6d627adb7bccccf678d5bd0eec77","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        target_uri \u003d self._actions.reset_idrac.target_uri"},{"line_number":53,"context_line":"        LOG.debug(\u0027Resetting the iDRAC %s ...\u0027, self.identity)"},{"line_number":54,"context_line":"        self._conn.post(target_uri, data\u003dpayload)"},{"line_number":55,"context_line":"        LOG.info(\u0027The iDRAC %s is being reset\u0027, self.identity)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_86085880","line":55,"updated":"2020-09-23 20:02:41.000000000","message":"I don\u0027t think we need the logging statement directly above.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        target_uri \u003d self._actions.reset_idrac.target_uri"},{"line_number":53,"context_line":"        LOG.debug(\u0027Resetting the iDRAC %s ...\u0027, self.identity)"},{"line_number":54,"context_line":"        self._conn.post(target_uri, data\u003dpayload)"},{"line_number":55,"context_line":"        LOG.info(\u0027The iDRAC %s is being reset\u0027, self.identity)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_777c7a70","line":55,"in_reply_to":"9f560f44_86085880","updated":"2020-09-27 14:19:09.000000000","message":"Following below way to logging statement.\nhttps://github.com/openstack/sushy/blob/b1bf4335120819268aa252762b98aede7b180958/sushy/resources/manager/manager.py#L191","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"},{"line_number":41,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":42,"context_line":"            the object according to schema of the given version."},{"line_number":43,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":44,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"69ca232c_d6955552","line":41,"range":{"start_line":41,"start_character":47,"end_line":41,"end_character":54},"updated":"2020-11-24 08:54:52.000000000","message":"case: Redfish","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DelliDRACCardService resource"},{"line_number":41,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":42,"context_line":"            the object according to schema of the given version."},{"line_number":43,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":44,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"bcf0b4a4_1c0674b7","line":41,"range":{"start_line":41,"start_character":47,"end_line":41,"end_character":54},"in_reply_to":"69ca232c_d6955552","updated":"2020-12-07 12:43:58.000000000","message":"Done.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":63,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def reset_idrac(self, reset_type\u003d\"Graceful\"):"},{"line_number":66,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        :param reset_type: does a force reset when caller pass \"Force\" as value"}],"source_content_type":"text/x-python","patch_set":7,"id":"03748604_014e45b5","line":65,"range":{"start_line":65,"start_character":37,"end_line":65,"end_character":47},"updated":"2020-11-24 08:54:52.000000000","message":"this should use constant instead of string","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":63,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def reset_idrac(self, reset_type\u003d\"Graceful\"):"},{"line_number":66,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        :param reset_type: does a force reset when caller pass \"Force\" as value"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff78be28_866ad5a3","line":65,"range":{"start_line":65,"start_character":37,"end_line":65,"end_character":47},"in_reply_to":"03748604_014e45b5","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    def reset_idrac(self, reset_type\u003d\"Graceful\"):"},{"line_number":66,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        :param reset_type: does a force reset when caller pass \"Force\" as value"},{"line_number":69,"context_line":"        and it defaults to a graceful reset."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        valid_resets \u003d self.get_allowed_reset_idrac_values()"},{"line_number":72,"context_line":"        if reset_type not in valid_resets:"}],"source_content_type":"text/x-python","patch_set":7,"id":"58e97065_f48707ad","line":69,"range":{"start_line":68,"start_character":27,"end_line":69,"end_character":43},"updated":"2020-11-24 08:54:52.000000000","message":"should mention to which constants these correspond. Also that allowed values can get from `get_allowed_reset_idrac_values`.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def reset_idrac(self, reset_type\u003d\"Graceful\"):"},{"line_number":66,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        :param reset_type: does a force reset when caller pass \"Force\" as value"},{"line_number":69,"context_line":"        and it defaults to a graceful reset."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        valid_resets \u003d self.get_allowed_reset_idrac_values()"},{"line_number":72,"context_line":"        if reset_type not in valid_resets:"}],"source_content_type":"text/x-python","patch_set":7,"id":"180beeaf_09bc8e9e","line":69,"range":{"start_line":68,"start_character":27,"end_line":69,"end_character":43},"in_reply_to":"58e97065_f48707ad","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        target_uri \u003d self._actions.reset_idrac.target_uri"},{"line_number":77,"context_line":"        payload \u003d {\"Force\": reset_type}"},{"line_number":78,"context_line":"        LOG.debug(\u0027Resetting the iDRAC %s ...\u0027, self.identity)"},{"line_number":79,"context_line":"        self._conn.post(target_uri, data\u003dpayload)"},{"line_number":80,"context_line":"        LOG.info(\u0027The iDRAC %s is being reset\u0027, self.identity)"}],"source_content_type":"text/x-python","patch_set":7,"id":"41cde999_2b5d3abf","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":49},"updated":"2020-11-24 08:54:52.000000000","message":"How is it meant to use this as it can take some time to reset iDRAC? How is it determined that iDRAC reset is done?","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        target_uri \u003d self._actions.reset_idrac.target_uri"},{"line_number":77,"context_line":"        payload \u003d {\"Force\": reset_type}"},{"line_number":78,"context_line":"        LOG.debug(\u0027Resetting the iDRAC %s ...\u0027, self.identity)"},{"line_number":79,"context_line":"        self._conn.post(target_uri, data\u003dpayload)"},{"line_number":80,"context_line":"        LOG.info(\u0027The iDRAC %s is being reset\u0027, self.identity)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4a648a6a_010f2538","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":49},"in_reply_to":"41cde999_2b5d3abf","updated":"2020-12-07 12:43:58.000000000","message":"Done. The code which determines this is implemented on ironic side, refer below patch. https://review.opendev.org/c/openstack/ironic/+/721593","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":28,"context_line":"    reset_idrac \u003d common.ResetActionField(\"#DelliDRACCardService.iDRACReset\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DelliDRACCardService(base.ResourceBase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5de63495_0af2a2bf","line":28,"range":{"start_line":28,"start_character":25,"end_line":28,"end_character":41},"updated":"2020-12-28 17:12:57.000000000","message":"I\u0027m suspecting this is not suitable for this case - it\u0027s not `ResetType`, but `Force`. I have commented about this in corresponding sample JSON file.\n\nI couldn\u0027t find a field named \u0027Force\u0027 in Redfish spec, so it looks like it\u0027s Dell OEM specific. Instead of referring to `common.ResetActionField` new field needs to be defined in this project. It can be part of common as at least there is another action that uses the same - iDRACResetCfg.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"32b0270d8a8aa496e8b6296b5a8b4b0b34452256","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":28,"context_line":"    reset_idrac \u003d common.ResetActionField(\"#DelliDRACCardService.iDRACReset\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DelliDRACCardService(base.ResourceBase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"8127945d_864a472c","line":28,"range":{"start_line":28,"start_character":25,"end_line":28,"end_character":41},"in_reply_to":"5de63495_0af2a2bf","updated":"2021-01-08 10:42:41.000000000","message":"Done.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"e3b6d7fbe46de88e2b20de48a52cccd858cdeb50","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":69,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def reset_idrac(self, reset_type\u003dres_cons.RESET_TYPE_GRACEFUL_RESTART):"},{"line_number":72,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param reset_type: does a force reset when caller pass \"force restart\""}],"source_content_type":"text/x-python","patch_set":13,"id":"457f7184_f732912a","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":73},"updated":"2021-03-08 15:05:25.000000000","message":"as discussed in the meeting, let\u0027s not have `reset_type` param for now, but have this as default inside the function","commit_id":"8d7f15255f48b93981ff368e20c2264097599dbc"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"03a32e8a895f49059c3371684ae105f58b0f43e6","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":69,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def reset_idrac(self, reset_type\u003dres_cons.RESET_TYPE_GRACEFUL_RESTART):"},{"line_number":72,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param reset_type: does a force reset when caller pass \"force restart\""}],"source_content_type":"text/x-python","patch_set":13,"id":"c77bd649_8b571b45","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":73},"in_reply_to":"457f7184_f732912a","updated":"2021-03-11 08:47:58.000000000","message":"from what I got idea was to remove reset_type as param and for now use default value directly inside the method. Let\u0027s discuss this in the meeting.","commit_id":"8d7f15255f48b93981ff368e20c2264097599dbc"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3a12d2086a3633d35e9c14cb91a562eedb3bb766","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":69,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def reset_idrac(self, reset_type\u003dres_cons.RESET_TYPE_GRACEFUL_RESTART):"},{"line_number":72,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param reset_type: does a force reset when caller pass \"force restart\""}],"source_content_type":"text/x-python","patch_set":13,"id":"dee8573b_541e506a","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":73},"in_reply_to":"c77bd649_8b571b45","updated":"2021-03-11 13:28:41.000000000","message":"clarified: param reset_type needs to be deleted for now - move to local variable after line 80, so that logic is kept as it is (and delete it from the docstring)","commit_id":"8d7f15255f48b93981ff368e20c2264097599dbc"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"2b1661f4b4233fdd7b377dab9b3b0f769806a959","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                    set(mgr_maps.RESET_IDRAC_VALUE_MAP)."},{"line_number":69,"context_line":"                   intersection(reset_action.allowed_values)])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def reset_idrac(self, reset_type\u003dres_cons.RESET_TYPE_GRACEFUL_RESTART):"},{"line_number":72,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param reset_type: does a force reset when caller pass \"force restart\""}],"source_content_type":"text/x-python","patch_set":13,"id":"c3ee318d_88dd5d54","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":73},"in_reply_to":"dee8573b_541e506a","updated":"2021-03-12 10:30:07.000000000","message":"Done.","commit_id":"8d7f15255f48b93981ff368e20c2264097599dbc"}],"sushy_oem_idrac/resources/manager/job_collection.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        :param connector: A Connector instance"},{"line_number":32,"context_line":"        :param identity: The identity of the DellJobCollection resource"},{"line_number":33,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":34,"context_line":"            the object according to schema of the given version."},{"line_number":35,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":36,"context_line":"            used in any resource that needs registries to parse messages"}],"source_content_type":"text/x-python","patch_set":7,"id":"940d3110_d8f43435","line":33,"range":{"start_line":33,"start_character":47,"end_line":33,"end_character":54},"updated":"2020-11-24 08:54:52.000000000","message":"casing: Redfish","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        :param connector: A Connector instance"},{"line_number":32,"context_line":"        :param identity: The identity of the DellJobCollection resource"},{"line_number":33,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":34,"context_line":"            the object according to schema of the given version."},{"line_number":35,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":36,"context_line":"            used in any resource that needs registries to parse messages"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7d54a57_0ba828ab","line":33,"range":{"start_line":33,"start_character":47,"end_line":33,"end_character":54},"in_reply_to":"940d3110_d8f43435","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self._JOB_EXPAND)"},{"line_number":47,"context_line":"        unfinished_jobs \u003d []"},{"line_number":48,"context_line":"        LOG.debug(\u0027Getting unfnished jobs...\u0027)"},{"line_number":49,"context_line":"        job_response \u003d self._conn.get(job_expand_uri)"},{"line_number":50,"context_line":"        data \u003d job_response.json()"},{"line_number":51,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"c71d4e52_7c71203e","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":46},"updated":"2020-11-24 08:54:52.000000000","message":"missing context in the log message for system being used","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self._JOB_EXPAND)"},{"line_number":47,"context_line":"        unfinished_jobs \u003d []"},{"line_number":48,"context_line":"        LOG.debug(\u0027Getting unfnished jobs...\u0027)"},{"line_number":49,"context_line":"        job_response \u003d self._conn.get(job_expand_uri)"},{"line_number":50,"context_line":"        data \u003d job_response.json()"},{"line_number":51,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"afc1300e_201798a1","line":48,"range":{"start_line":48,"start_character":27,"end_line":48,"end_character":37},"updated":"2020-11-24 08:54:52.000000000","message":"typo: unfinished","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self._JOB_EXPAND)"},{"line_number":47,"context_line":"        unfinished_jobs \u003d []"},{"line_number":48,"context_line":"        LOG.debug(\u0027Getting unfnished jobs...\u0027)"},{"line_number":49,"context_line":"        job_response \u003d self._conn.get(job_expand_uri)"},{"line_number":50,"context_line":"        data \u003d job_response.json()"},{"line_number":51,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"8afcb939_26ffbf4a","line":48,"range":{"start_line":48,"start_character":27,"end_line":48,"end_character":37},"in_reply_to":"afc1300e_201798a1","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self._JOB_EXPAND)"},{"line_number":47,"context_line":"        unfinished_jobs \u003d []"},{"line_number":48,"context_line":"        LOG.debug(\u0027Getting unfnished jobs...\u0027)"},{"line_number":49,"context_line":"        job_response \u003d self._conn.get(job_expand_uri)"},{"line_number":50,"context_line":"        data \u003d job_response.json()"},{"line_number":51,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"788e075e_f96be666","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":46},"in_reply_to":"c71d4e52_7c71203e","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            if ((job[u\u0027JobState\u0027] \u003d\u003d \u0027Scheduled\u0027) or ("},{"line_number":53,"context_line":"                    job[u\u0027JobState\u0027] \u003d\u003d \u0027Running\u0027)):"},{"line_number":54,"context_line":"                unfinished_jobs.append(job[\u0027Id\u0027])"},{"line_number":55,"context_line":"        LOG.info(\u0027Got unfinished jobs\u0027)"},{"line_number":56,"context_line":"        return unfinished_jobs"}],"source_content_type":"text/x-python","patch_set":7,"id":"e398bd6d_f8d2a154","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":39},"updated":"2020-11-24 08:54:52.000000000","message":"missing context for system being used","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            if ((job[u\u0027JobState\u0027] \u003d\u003d \u0027Scheduled\u0027) or ("},{"line_number":53,"context_line":"                    job[u\u0027JobState\u0027] \u003d\u003d \u0027Running\u0027)):"},{"line_number":54,"context_line":"                unfinished_jobs.append(job[\u0027Id\u0027])"},{"line_number":55,"context_line":"        LOG.info(\u0027Got unfinished jobs\u0027)"},{"line_number":56,"context_line":"        return unfinished_jobs"}],"source_content_type":"text/x-python","patch_set":7,"id":"5e2f1b47_35d6cebe","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":39},"in_reply_to":"e398bd6d_f8d2a154","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"}],"sushy_oem_idrac/resources/manager/job_service.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class DellJobService(base.ResourceBase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_2e21d3a0","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Please remove blank line","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_0e2697b8","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            as the job_id."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        target_uri \u003d self._actions.delete_job_queue.target_uri"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        LOG.debug(\u0027Deleting the job queue ...\u0027)"},{"line_number":57,"context_line":"        for job_id in job_ids:"},{"line_number":58,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_6e3abbcd","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"from sushy.resources import base"},{"line_number":15,"context_line":"from sushy.resources import common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_47ee3f21","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027from sushy.resources import base\u0027 is identified as Third Party and \u0027import logging\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_ca1cfd67","line":1,"updated":"2020-09-23 22:44:16.000000000","message":"nit: Please add Dell Inc.\u0027s copyright notice above this line.\n\n    # Copyright (c) 2020 Dell Inc. or its subsidiaries.\n    #","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_37eb2212","line":1,"in_reply_to":"9f560f44_ca1cfd67","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    delete_job_queue \u003d common.ActionField(\"#DellJobService.DeleteJobQueue\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_ea3621e7","line":22,"updated":"2020-09-23 22:44:16.000000000","message":"nit: Remove this blank line.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    delete_job_queue \u003d common.ActionField(\"#DellJobService.DeleteJobQueue\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_97ee6e1e","line":22,"in_reply_to":"9f560f44_ea3621e7","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DellJobService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_ea6461e7","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":38},"updated":"2020-09-23 22:44:16.000000000","message":"Should this be required?\n\n    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DellJobService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_77f11a00","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":38},"in_reply_to":"9f560f44_ea6461e7","updated":"2020-09-27 14:19:09.000000000","message":"No, Its not required. Refering see this file https://github.com/openstack/sushy/blob/master/sushy/resources/chassis/chassis.py#L145","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class DellJobService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_6a797191","line":29,"updated":"2020-09-23 22:44:16.000000000","message":"Is this a private constant? If so, please change its name to start with an underscore.\n\nNote that I have a question about whether or not it is needed below.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class DellJobService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":30,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d7dbc679","line":29,"in_reply_to":"9f560f44_6a797191","updated":"2020-09-27 14:19:09.000000000","message":"Its not needed, Removed it","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":33,"context_line":"                 registries\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"A class representing a DellJobService"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param connector: A Connector instance"},{"line_number":37,"context_line":"        :param identity: The identity of the DellJobService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_8adb251f","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":48},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":33,"context_line":"                 registries\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"A class representing a DellJobService"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param connector: A Connector instance"},{"line_number":37,"context_line":"        :param identity: The identity of the DellJobService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b7d61252","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":48},"in_reply_to":"9f560f44_8adb251f","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def delete_jobs(self, job_ids\u003d[\u0027JID_CLEARALL\u0027]):"},{"line_number":47,"context_line":"        \"\"\"Deletes the given jobs, or all jobs"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param job_ids: a list of job ids to delete. Clearing all the"},{"line_number":50,"context_line":"            jobs may be accomplished using the keyword JID_CLEARALL"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_cae19dd1","line":47,"range":{"start_line":47,"start_character":42,"end_line":47,"end_character":46},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def delete_jobs(self, job_ids\u003d[\u0027JID_CLEARALL\u0027]):"},{"line_number":47,"context_line":"        \"\"\"Deletes the given jobs, or all jobs"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param job_ids: a list of job ids to delete. Clearing all the"},{"line_number":50,"context_line":"            jobs may be accomplished using the keyword JID_CLEARALL"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0a3d552b","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":18},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Delete","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def delete_jobs(self, job_ids\u003d[\u0027JID_CLEARALL\u0027]):"},{"line_number":47,"context_line":"        \"\"\"Deletes the given jobs, or all jobs"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param job_ids: a list of job ids to delete. Clearing all the"},{"line_number":50,"context_line":"            jobs may be accomplished using the keyword JID_CLEARALL"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_17e25e30","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":18},"in_reply_to":"9f560f44_0a3d552b","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def delete_jobs(self, job_ids\u003d[\u0027JID_CLEARALL\u0027]):"},{"line_number":47,"context_line":"        \"\"\"Deletes the given jobs, or all jobs"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param job_ids: a list of job ids to delete. Clearing all the"},{"line_number":50,"context_line":"            jobs may be accomplished using the keyword JID_CLEARALL"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f7dc0a72","line":47,"range":{"start_line":47,"start_character":42,"end_line":47,"end_character":46},"in_reply_to":"9f560f44_cae19dd1","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"522ef806196e6d627adb7bccccf678d5bd0eec77","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            as the job_id."},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        target_uri \u003d self._actions.delete_job_queue.target_uri"},{"line_number":54,"context_line":"        LOG.debug(\u0027Deleting the job queue ...\u0027)"},{"line_number":55,"context_line":"        for job_id in job_ids:"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e63f941f","line":54,"updated":"2020-09-23 20:02:41.000000000","message":"This is deleting jobs, not the job queue itself. Can you change the above logging statement to reflect that and also log the job_ids being deleted?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            as the job_id."},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        target_uri \u003d self._actions.delete_job_queue.target_uri"},{"line_number":54,"context_line":"        LOG.debug(\u0027Deleting the job queue ...\u0027)"},{"line_number":55,"context_line":"        for job_id in job_ids:"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_57d17656","line":54,"in_reply_to":"9f560f44_e63f941f","updated":"2020-09-27 14:19:09.000000000","message":"Done, Added job_ids being deleted while logging.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for job_id in job_ids:"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0ac43591","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":48},"updated":"2020-09-23 22:44:16.000000000","message":"Is this argument necessary? I see it is not used at https://review.opendev.org/#/c/721596/6/sushy_oem_idrac/resources/manager/idrac_card_service.py@54.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for job_id in job_ids:"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_37d4c246","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":48},"in_reply_to":"9f560f44_0ac43591","updated":"2020-09-27 14:19:09.000000000","message":"Its not needed, Removed it.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4abaad0a","line":60,"range":{"start_line":60,"start_character":28,"end_line":60,"end_character":40},"updated":"2020-09-23 22:44:16.000000000","message":"Ditto re: necessity of this argument.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d7c46694","line":60,"range":{"start_line":60,"start_character":28,"end_line":60,"end_character":40},"in_reply_to":"9f560f44_4abaad0a","updated":"2020-09-27 14:19:09.000000000","message":"Its not needed. Removed it.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"522ef806196e6d627adb7bccccf678d5bd0eec77","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2617cca5","line":61,"updated":"2020-09-23 20:02:41.000000000","message":"Can you remove the logging statement above?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                            headers\u003dself.HEADERS,"},{"line_number":59,"context_line":"                            data\u003dpayload,"},{"line_number":60,"context_line":"                            verify\u003dFalse)"},{"line_number":61,"context_line":"        LOG.info(\u0027Deleted the job queue\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b7bf32fa","line":61,"in_reply_to":"9f560f44_2617cca5","updated":"2020-09-27 14:19:09.000000000","message":"Done. added meaningful log msg.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param connector: A Connector instance"},{"line_number":37,"context_line":"        :param identity: The identity of the DellJobService resource"},{"line_number":38,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":39,"context_line":"            the object according to schema of the given version."},{"line_number":40,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":41,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"8ac9f0fe_7fc840ae","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":54},"updated":"2020-11-24 08:54:52.000000000","message":"case: Redfish","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param connector: A Connector instance"},{"line_number":37,"context_line":"        :param identity: The identity of the DellJobService resource"},{"line_number":38,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":39,"context_line":"            the object according to schema of the given version."},{"line_number":40,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":41,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"0491b105_53e99c6e","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":54},"in_reply_to":"8ac9f0fe_7fc840ae","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        target_uri \u003d self._actions.delete_job_queue.target_uri"},{"line_number":54,"context_line":"        for job_id in job_ids:"},{"line_number":55,"context_line":"            LOG.debug(\u0027Deleting the job %s\u0027, job_id)"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            data\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ac5d5fa1_e1479802","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":52},"updated":"2020-11-24 08:54:52.000000000","message":"here and below add context for system","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        target_uri \u003d self._actions.delete_job_queue.target_uri"},{"line_number":54,"context_line":"        for job_id in job_ids:"},{"line_number":55,"context_line":"            LOG.debug(\u0027Deleting the job %s\u0027, job_id)"},{"line_number":56,"context_line":"            payload \u003d {\u0027JobID\u0027: job_id}"},{"line_number":57,"context_line":"            self._conn.post(target_uri,"},{"line_number":58,"context_line":"                            data\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c7e1d0cc_f644ef7b","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":52},"in_reply_to":"ac5d5fa1_e1479802","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"}],"sushy_oem_idrac/resources/manager/jobs.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class DellJobCollection(base.ResourceBase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    JOB_EXPAND \u003d \u0027?$expand\u003d.($levels\u003d1)\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_4e37ffe4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Same here","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        unfinished_jobs \u003d []"},{"line_number":48,"context_line":"        LOG.debug(\u0027Filtering unfnished jobs...\u0027)"},{"line_number":49,"context_line":"        job_response \u003d self._conn.get(job_expand_uri, verify\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_ae34c3df","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"from sushy.resources import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_27f34b0b","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027from sushy.resources import base\u0027 is identified as Third Party and \u0027import logging\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_aa8269c5","line":1,"updated":"2020-09-23 22:44:16.000000000","message":"Seems like this file would be better named job_collection.py.\n\nnit: Please add Dell Inc.\u0027s copyright notice above this line.\n\n    # Copyright (c) 2020 Dell Inc. or its subsidiaries.\n    #","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f7b52a1a","line":1,"in_reply_to":"9f560f44_aa8269c5","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class DellJobCollection(base.ResourceBase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":23,"context_line":"    JOB_EXPAND \u003d \u0027?$expand\u003d.($levels\u003d1)\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1ee8f6dc","line":23,"updated":"2020-09-23 22:44:16.000000000","message":"Is this a private constant? If so, please change its name to start with an underscore.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class DellJobCollection(base.ResourceBase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":23,"context_line":"    JOB_EXPAND \u003d \u0027?$expand\u003d.($levels\u003d1)\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_573696b5","line":23,"in_reply_to":"9f560f44_1ee8f6dc","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"A class represents a DellJobCollection"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connector: A Connector instance"},{"line_number":30,"context_line":"        :param identity: The identity of the DellJobCollection resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_8a604537","line":27,"range":{"start_line":27,"start_character":32,"end_line":27,"end_character":49},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"A class represents a DellJobCollection"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connector: A Connector instance"},{"line_number":30,"context_line":"        :param identity: The identity of the DellJobCollection resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2a6e592b","line":27,"range":{"start_line":27,"start_character":19,"end_line":27,"end_character":29},"updated":"2020-09-23 22:44:16.000000000","message":"nit: representing","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"A class represents a DellJobCollection"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connector: A Connector instance"},{"line_number":30,"context_line":"        :param identity: The identity of the DellJobCollection resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_373962a2","line":27,"range":{"start_line":27,"start_character":19,"end_line":27,"end_character":29},"in_reply_to":"9f560f44_2a6e592b","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":26,"context_line":"                 registries\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"A class represents a DellJobCollection"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param connector: A Connector instance"},{"line_number":30,"context_line":"        :param identity: The identity of the DellJobCollection resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_973cae92","line":27,"range":{"start_line":27,"start_character":32,"end_line":27,"end_character":49},"in_reply_to":"9f560f44_8a604537","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_unfinished_jobs(self):"},{"line_number":40,"context_line":"        \"\"\"Returns a list of unfinished jobs from the job queue"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: a list of unfinished jobs."},{"line_number":43,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_722cc349","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":63},"updated":"2020-09-23 22:44:16.000000000","message":"How about the following, instead?\n\n    \"\"\"Get the unfinished jobs.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            connector, identity, redfish_version, registries)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_unfinished_jobs(self):"},{"line_number":40,"context_line":"        \"\"\"Returns a list of unfinished jobs from the job queue"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: a list of unfinished jobs."},{"line_number":43,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_773f5a85","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":63},"in_reply_to":"9f560f44_722cc349","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def get_unfinished_jobs(self):"},{"line_number":40,"context_line":"        \"\"\"Returns a list of unfinished jobs from the job queue"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: a list of unfinished jobs."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":45,"context_line":"        unfinished_jobs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4168d386","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":19},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Capitalize -- \u0027A\u0027","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def get_unfinished_jobs(self):"},{"line_number":40,"context_line":"        \"\"\"Returns a list of unfinished jobs from the job queue"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: a list of unfinished jobs."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":45,"context_line":"        unfinished_jobs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d7490632","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":19},"in_reply_to":"9f560f44_4168d386","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"522ef806196e6d627adb7bccccf678d5bd0eec77","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":45,"context_line":"        unfinished_jobs \u003d []"},{"line_number":46,"context_line":"        LOG.debug(\u0027Filtering unfnished jobs...\u0027)"},{"line_number":47,"context_line":"        job_response \u003d self._conn.get(job_expand_uri, verify\u003dFalse)"},{"line_number":48,"context_line":"        data \u003d job_response.json()"},{"line_number":49,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c6ced059","line":46,"updated":"2020-09-23 20:02:41.000000000","message":"A logging statement like the above that doesn\u0027t log any variable data isn\u0027t all that useful. Let\u0027s remove it.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":45,"context_line":"        unfinished_jobs \u003d []"},{"line_number":46,"context_line":"        LOG.debug(\u0027Filtering unfnished jobs...\u0027)"},{"line_number":47,"context_line":"        job_response \u003d self._conn.get(job_expand_uri, verify\u003dFalse)"},{"line_number":48,"context_line":"        data \u003d job_response.json()"},{"line_number":49,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_de1cbe14","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":28},"updated":"2020-09-23 22:44:16.000000000","message":"s/Filtering/Getting/","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        job_expand_uri \u003d \u0027%s%s\u0027 % (self._path, self.JOB_EXPAND)"},{"line_number":45,"context_line":"        unfinished_jobs \u003d []"},{"line_number":46,"context_line":"        LOG.debug(\u0027Filtering unfnished jobs...\u0027)"},{"line_number":47,"context_line":"        job_response \u003d self._conn.get(job_expand_uri, verify\u003dFalse)"},{"line_number":48,"context_line":"        data \u003d job_response.json()"},{"line_number":49,"context_line":"        for job in data[u\u0027Members\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b744521a","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":28},"in_reply_to":"9f560f44_de1cbe14","updated":"2020-09-27 14:19:09.000000000","message":"Done.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"522ef806196e6d627adb7bccccf678d5bd0eec77","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            if ((job[u\u0027JobState\u0027] \u003d\u003d \u0027Scheduled\u0027) or ("},{"line_number":51,"context_line":"                    job[u\u0027JobState\u0027] \u003d\u003d \u0027Running\u0027)):"},{"line_number":52,"context_line":"                unfinished_jobs.append(job[\u0027Id\u0027])"},{"line_number":53,"context_line":"        LOG.info(\u0027Filtered unfinished jobs\u0027)"},{"line_number":54,"context_line":"        return unfinished_jobs"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a6391c40","line":53,"updated":"2020-09-23 20:02:41.000000000","message":"Can you either remove the above logging statement, or change it so that it logs the unfinished jobs?\nI think something like this would work:\nLOG.info(\u0027Returning unfinished jobs: %(unfinished_jobs)s\u0027, {\u0027unfinished_jobs\u0027: \u0027, \u0027.join(unfinished_jobs)})","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            if ((job[u\u0027JobState\u0027] \u003d\u003d \u0027Scheduled\u0027) or ("},{"line_number":51,"context_line":"                    job[u\u0027JobState\u0027] \u003d\u003d \u0027Running\u0027)):"},{"line_number":52,"context_line":"                unfinished_jobs.append(job[\u0027Id\u0027])"},{"line_number":53,"context_line":"        LOG.info(\u0027Filtered unfinished jobs\u0027)"},{"line_number":54,"context_line":"        return unfinished_jobs"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1e13d602","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":26},"updated":"2020-09-23 22:44:16.000000000","message":"s/Filtered/Got/","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"}],"sushy_oem_idrac/resources/manager/lc_service.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class DellLCService(base.ResourceBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_8e3107f0","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":33,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_ee4b6b5c","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":33,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_ce502f0e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":0},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"from sushy.resources import base"},{"line_number":15,"context_line":"from sushy.resources import common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e7ecb32a","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027from sushy.resources import base\u0027 is identified as Third Party and \u0027import logging\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_fe7b8225","line":1,"updated":"2020-09-23 22:44:16.000000000","message":"nit: Please add Dell Inc.\u0027s copyright notice above this line.\n\n    # Copyright (c) 2020 Dell Inc. or its subsidiaries.\n    #","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f74a4a21","line":1,"in_reply_to":"9f560f44_fe7b8225","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    lc_service \u003d common.ActionField("},{"line_number":24,"context_line":"        \"#DellLCService.GetRemoteServicesAPIStatus\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_de083e2e","line":22,"updated":"2020-09-23 22:44:16.000000000","message":"nit: Remove this blank line.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    lc_service \u003d common.ActionField("},{"line_number":24,"context_line":"        \"#DellLCService.GetRemoteServicesAPIStatus\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_376202ae","line":22,"in_reply_to":"9f560f44_de083e2e","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    lc_service \u003d common.ActionField("},{"line_number":24,"context_line":"        \"#DellLCService.GetRemoteServicesAPIStatus\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e13647e7","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":14},"updated":"2020-09-23 22:44:16.000000000","message":"This name, while short, does not seem to align very closely with the action\u0027s name. Please consider changing it.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ActionsField(base.CompositeField):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    lc_service \u003d common.ActionField("},{"line_number":24,"context_line":"        \"#DellLCService.GetRemoteServicesAPIStatus\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9755cec4","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":14},"in_reply_to":"9f560f44_e13647e7","updated":"2020-09-27 14:19:09.000000000","message":"Done, Changed it to \"remote_service_api_status\"","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DellLCService(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":32,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_de783e2c","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":38},"updated":"2020-09-23 22:44:16.000000000","message":"Should this be required?\n\n    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DellLCService(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":32,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_7758faf7","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":38},"in_reply_to":"9f560f44_de783e2c","updated":"2020-09-27 14:19:09.000000000","message":"No, Its not required. Refering this file https://github.com/openstack/sushy/blob/master/sushy/resources/chassis/chassis.py#L145","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class DellLCService(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":32,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"},{"line_number":33,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e178072c","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":32},"updated":"2020-09-23 22:44:16.000000000","message":"These seem to be private constants.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class DellLCService(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027)"},{"line_number":30,"context_line":"    HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":31,"context_line":"    IDRAC_READY_STATUS_CODE \u003d 200"},{"line_number":32,"context_line":"    IDRAC_READY_STATUS \u003d \u0027Ready\u0027"},{"line_number":33,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d772a67b","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":32},"in_reply_to":"9f560f44_e178072c","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":36,"context_line":"                 registries\u003dNone):"},{"line_number":37,"context_line":"        \"\"\"A class represents a DellLCService"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_21de7f69","line":37,"range":{"start_line":37,"start_character":32,"end_line":37,"end_character":45},"updated":"2020-09-23 22:44:16.000000000","message":"nit: Add a period at the end.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":36,"context_line":"                 registries\u003dNone):"},{"line_number":37,"context_line":"        \"\"\"A class represents a DellLCService"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_613a3798","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":29},"updated":"2020-09-23 22:44:16.000000000","message":"nit: representing","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":36,"context_line":"                 registries\u003dNone):"},{"line_number":37,"context_line":"        \"\"\"A class represents a DellLCService"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b76d729a","line":37,"range":{"start_line":37,"start_character":32,"end_line":37,"end_character":45},"in_reply_to":"9f560f44_21de7f69","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":36,"context_line":"                 registries\u003dNone):"},{"line_number":37,"context_line":"        \"\"\"A class represents a DellLCService"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1769be8a","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":29},"in_reply_to":"9f560f44_613a3798","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def is_idrac_ready(self):"},{"line_number":50,"context_line":"        \"\"\"Indicates if the iDRAC is ready to accept commands."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Returns a remote service api status which indicates"},{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.lc_service.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c17ea319","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":46},"updated":"2020-09-23 22:44:16.000000000","message":"Please tidy this up.\n\n    :returns ...","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def is_idrac_ready(self):"},{"line_number":50,"context_line":"        \"\"\"Indicates if the iDRAC is ready to accept commands."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Returns a remote service api status which indicates"},{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.lc_service.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_5704d6c5","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":46},"in_reply_to":"9f560f44_c17ea319","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        target_uri \u003d self._actions.lc_service.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post("},{"line_number":58,"context_line":"            target_uri, headers\u003dself.HEADERS, data\u003d{}, verify\u003dFalse)"},{"line_number":59,"context_line":"        if idrac_ready_response.status_code !\u003d self.IDRAC_READY_STATUS_CODE:"},{"line_number":60,"context_line":"            return False"},{"line_number":61,"context_line":"        data \u003d idrac_ready_response.json()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f701e53a","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":67},"updated":"2020-09-23 22:44:16.000000000","message":"Are these arguments necessary?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        target_uri \u003d self._actions.lc_service.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post("},{"line_number":58,"context_line":"            target_uri, headers\u003dself.HEADERS, data\u003d{}, verify\u003dFalse)"},{"line_number":59,"context_line":"        if idrac_ready_response.status_code !\u003d self.IDRAC_READY_STATUS_CODE:"},{"line_number":60,"context_line":"            return False"},{"line_number":61,"context_line":"        data \u003d idrac_ready_response.json()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3707a2cb","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":67},"in_reply_to":"9f560f44_f701e53a","updated":"2020-09-27 14:19:09.000000000","message":"No, Its not needed. Removed it.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            target_uri, headers\u003dself.HEADERS, data\u003d{}, verify\u003dFalse)"},{"line_number":59,"context_line":"        if idrac_ready_response.status_code !\u003d self.IDRAC_READY_STATUS_CODE:"},{"line_number":60,"context_line":"            return False"},{"line_number":61,"context_line":"        data \u003d idrac_ready_response.json()"},{"line_number":62,"context_line":"        lc_status \u003d data[\u0027LCStatus\u0027]"},{"line_number":63,"context_line":"        return lc_status \u003d\u003d self.IDRAC_READY_STATUS"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_66e6e4e9","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":51},"updated":"2020-09-23 00:19:01.000000000","message":"Please add a unit test to cover this happy path.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            target_uri, headers\u003dself.HEADERS, data\u003d{}, verify\u003dFalse)"},{"line_number":59,"context_line":"        if idrac_ready_response.status_code !\u003d self.IDRAC_READY_STATUS_CODE:"},{"line_number":60,"context_line":"            return False"},{"line_number":61,"context_line":"        data \u003d idrac_ready_response.json()"},{"line_number":62,"context_line":"        lc_status \u003d data[\u0027LCStatus\u0027]"},{"line_number":63,"context_line":"        return lc_status \u003d\u003d self.IDRAC_READY_STATUS"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_970aeecd","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":51},"in_reply_to":"9f560f44_66e6e4e9","updated":"2020-09-27 14:19:09.000000000","message":"Done, Added two new test case.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"}],"sushy_oem_idrac/resources/manager/lifecycle_service.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"},{"line_number":41,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":42,"context_line":"            the object according to schema of the given version."},{"line_number":43,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":44,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"4ba00186_17d52c39","line":41,"range":{"start_line":41,"start_character":47,"end_line":41,"end_character":54},"updated":"2020-11-24 08:54:52.000000000","message":"nit: casing - Redfish","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param identity: The identity of the DellLCService resource"},{"line_number":41,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":42,"context_line":"            the object according to schema of the given version."},{"line_number":43,"context_line":"        :param registries: Dict of Redfish Message Registry objects to be"},{"line_number":44,"context_line":"            used in any resource that needs registries to parse messages."}],"source_content_type":"text/x-python","patch_set":7,"id":"9793d070_6f79c27b","line":41,"range":{"start_line":41,"start_character":47,"end_line":41,"end_character":54},"in_reply_to":"4ba00186_17d52c39","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    def is_idrac_ready(self):"},{"line_number":50,"context_line":"        \"\"\"Indicates if the iDRAC is ready to accept commands."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :returns: A remote service api status which indicates"},{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d79fd0de_e044959a","line":53,"range":{"start_line":52,"start_character":18,"end_line":53,"end_character":46},"updated":"2020-11-24 08:54:52.000000000","message":"is it boolean? From the comment it reads like it\u0027s a string indicating name of the status.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def is_idrac_ready(self):"},{"line_number":50,"context_line":"        \"\"\"Indicates if the iDRAC is ready to accept commands."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :returns: A remote service api status which indicates"},{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"606cdca1_7dd5541d","line":53,"range":{"start_line":52,"start_character":18,"end_line":53,"end_character":46},"in_reply_to":"d79fd0de_e044959a","updated":"2020-12-07 12:43:58.000000000","message":"Yes it is boolean,Corrected the above sentence.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post(target_uri)"},{"line_number":58,"context_line":"        if idrac_ready_response.status_code !\u003d self._IDRAC_READY_STATUS_CODE:"},{"line_number":59,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"96d3f47b_d35b35a5","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":61},"updated":"2020-11-24 08:54:52.000000000","message":"in the log missing info about the system this is being checked for","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        the iDRAC is ready to accept commands."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post(target_uri)"},{"line_number":58,"context_line":"        if idrac_ready_response.status_code !\u003d self._IDRAC_READY_STATUS_CODE:"},{"line_number":59,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"f49bb46b_66e0d865","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":61},"in_reply_to":"96d3f47b_d35b35a5","updated":"2021-01-08 13:17:39.000000000","message":"Ack","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"95d1b554d51fddffe7250112fd2614d8408f1e9c","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post(target_uri)"},{"line_number":58,"context_line":"        if idrac_ready_response.status_code !\u003d self._IDRAC_READY_STATUS_CODE:"},{"line_number":59,"context_line":"            return False"},{"line_number":60,"context_line":"        data \u003d idrac_ready_response.json()"}],"source_content_type":"text/x-python","patch_set":12,"id":"cf0803c6_13f25bc2","line":57,"range":{"start_line":57,"start_character":47,"end_line":57,"end_character":58},"updated":"2021-02-16 15:58:45.000000000","message":"has this been tested against baremetal? iDRAC does not like POST with empty body, that is, in this case it should be `data\u003d{}` to get around an error","commit_id":"13fd970790f2ad1ee1872ef008bfc200353f3954"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"e61aae6bf9d318dc61f4dcf5b3c3ebc86bf19b56","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        target_uri \u003d self._actions.remote_service_api_status.target_uri"},{"line_number":56,"context_line":"        LOG.debug(\u0027Checking to see if the iDRAC is ready...\u0027)"},{"line_number":57,"context_line":"        idrac_ready_response \u003d self._conn.post(target_uri)"},{"line_number":58,"context_line":"        if idrac_ready_response.status_code !\u003d self._IDRAC_READY_STATUS_CODE:"},{"line_number":59,"context_line":"            return False"},{"line_number":60,"context_line":"        data \u003d idrac_ready_response.json()"}],"source_content_type":"text/x-python","patch_set":12,"id":"46bc9f22_2dcc9bb4","line":57,"range":{"start_line":57,"start_character":47,"end_line":57,"end_character":58},"in_reply_to":"cf0803c6_13f25bc2","updated":"2021-02-23 08:24:54.000000000","message":"Done,We should add `data\u003d{}` in post request.","commit_id":"13fd970790f2ad1ee1872ef008bfc200353f3954"}],"sushy_oem_idrac/resources/manager/manager.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    @sushy_utils.cache_it"},{"line_number":89,"context_line":"    def idrac_card_service(self):"},{"line_number":90,"context_line":"        \"\"\"Returns a \"DelliDRACCardService\" object"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":93,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_573411fb","line":90,"updated":"2020-09-23 22:44:16.000000000","message":"Let us describe this as a property, instead of method.\n\n    \"\"\"Property to reference `DelliDRACCardService` instance of this manager.\"\"\"","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    @sushy_utils.cache_it"},{"line_number":89,"context_line":"    def idrac_card_service(self):"},{"line_number":90,"context_line":"        \"\"\"Returns a \"DelliDRACCardService\" object"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":93,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b7f292e1","line":90,"in_reply_to":"9f560f44_573411fb","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @sushy_utils.cache_it"},{"line_number":89,"context_line":"    def idrac_card_service(self):"},{"line_number":90,"context_line":"        \"\"\"Returns a \"DelliDRACCardService\" object"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_973a29e3","line":91,"updated":"2020-09-23 22:44:16.000000000","message":"Please add the \":returns:\" information.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DelliDRACCardService\"],"},{"line_number":96,"context_line":"            is_collection\u003dFalse)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        from sushy_oem_idrac.resources.manager import idrac_card_service"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return idrac_card_service.DelliDRACCardService("},{"line_number":101,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f70ba527","line":98,"updated":"2020-09-23 22:44:16.000000000","message":"Why is this imported here? The same question applies below.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DelliDRACCardService\"],"},{"line_number":96,"context_line":"            is_collection\u003dFalse)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        from sushy_oem_idrac.resources.manager import idrac_card_service"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return idrac_card_service.DelliDRACCardService("},{"line_number":101,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_17fedead","line":98,"in_reply_to":"9f560f44_f70ba527","updated":"2020-09-27 14:19:09.000000000","message":"Done, Moved it to the top.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    @sushy_utils.cache_it"},{"line_number":105,"context_line":"    def lc_service(self):"},{"line_number":106,"context_line":"        \"\"\"Returns a \"DellLCService\" object"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_92087727","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":10},"updated":"2020-09-23 22:44:16.000000000","message":"Let us change this to \u0027lifecycle\u0027, since it does not seem too long.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    @sushy_utils.cache_it"},{"line_number":105,"context_line":"    def lc_service(self):"},{"line_number":106,"context_line":"        \"\"\"Returns a \"DellLCService\" object"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f7f88ac1","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":10},"in_reply_to":"9f560f44_92087727","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    @sushy_utils.cache_it"},{"line_number":105,"context_line":"    def lc_service(self):"},{"line_number":106,"context_line":"        \"\"\"Returns a \"DellLCService\" object"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":109,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_52025f0a","line":106,"updated":"2020-09-23 22:44:16.000000000","message":"Let us describe this as a property, instead of method.\n\n    \"\"\"Property to reference `DellLCService` instance of this manager.\"\"\"","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    @sushy_utils.cache_it"},{"line_number":105,"context_line":"    def lc_service(self):"},{"line_number":106,"context_line":"        \"\"\"Returns a \"DellLCService\" object"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":109,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_572df643","line":106,"in_reply_to":"9f560f44_52025f0a","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @sushy_utils.cache_it"},{"line_number":105,"context_line":"    def lc_service(self):"},{"line_number":106,"context_line":"        \"\"\"Returns a \"DellLCService\" object"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_722683bc","line":107,"updated":"2020-09-23 22:44:16.000000000","message":"Please add the \":returns:\" information.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DellLCService\"],"},{"line_number":112,"context_line":"            is_collection\u003dFalse)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        from sushy_oem_idrac.resources.manager import lc_service"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return lc_service.DellLCService("},{"line_number":117,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_522b7f80","line":114,"updated":"2020-09-23 22:44:16.000000000","message":"Why is this imported here?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DellLCService\"],"},{"line_number":112,"context_line":"            is_collection\u003dFalse)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        from sushy_oem_idrac.resources.manager import lc_service"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return lc_service.DellLCService("},{"line_number":117,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3730429e","line":114,"in_reply_to":"9f560f44_522b7f80","updated":"2020-09-27 14:19:09.000000000","message":"Done, Moved it to the top.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    @property"},{"line_number":120,"context_line":"    @sushy_utils.cache_it"},{"line_number":121,"context_line":"    def job_service(self):"},{"line_number":122,"context_line":"        \"\"\"Returns a \"DellJobService\" object"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":125,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_122d878e","line":122,"updated":"2020-09-23 22:44:16.000000000","message":"Let us describe this as a property, instead of method.\n\n    \"\"\"Property to reference `DellJobService` instance of this manager.\"\"\"","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    @property"},{"line_number":120,"context_line":"    @sushy_utils.cache_it"},{"line_number":121,"context_line":"    def job_service(self):"},{"line_number":122,"context_line":"        \"\"\"Returns a \"DellJobService\" object"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":125,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_97230e58","line":122,"in_reply_to":"9f560f44_122d878e","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    @sushy_utils.cache_it"},{"line_number":121,"context_line":"    def job_service(self):"},{"line_number":122,"context_line":"        \"\"\"Returns a \"DellJobService\" object"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":125,"context_line":"        \"\"\""},{"line_number":126,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b2513b10","line":123,"updated":"2020-09-23 22:44:16.000000000","message":"Please add the \":returns:\" information.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DellJobService\"],"},{"line_number":128,"context_line":"            is_collection\u003dFalse)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        from sushy_oem_idrac.resources.manager import job_service"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        return job_service.DellJobService("},{"line_number":133,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b21c9b66","line":130,"updated":"2020-09-23 22:44:16.000000000","message":"Why is this imported here?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"DellJobService\"],"},{"line_number":128,"context_line":"            is_collection\u003dFalse)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        from sushy_oem_idrac.resources.manager import job_service"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        return job_service.DellJobService("},{"line_number":133,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_77263a69","line":130,"in_reply_to":"9f560f44_b21c9b66","updated":"2020-09-27 14:19:09.000000000","message":"Done, Moved it to the top.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    @property"},{"line_number":136,"context_line":"    @sushy_utils.cache_it"},{"line_number":137,"context_line":"    def job_collection(self):"},{"line_number":138,"context_line":"        \"\"\"Returns a \"DellJobCollection\" object"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":141,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d23b0fc5","line":138,"updated":"2020-09-23 22:44:16.000000000","message":"Let us describe this as a property, instead of method.\n\n    \"\"\"Property to reference `DellJobCollection` instance of this manager.\"\"\"","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    @property"},{"line_number":136,"context_line":"    @sushy_utils.cache_it"},{"line_number":137,"context_line":"    def job_collection(self):"},{"line_number":138,"context_line":"        \"\"\"Returns a \"DellJobCollection\" object"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":141,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d720e64b","line":138,"in_reply_to":"9f560f44_d23b0fc5","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    @sushy_utils.cache_it"},{"line_number":137,"context_line":"    def job_collection(self):"},{"line_number":138,"context_line":"        \"\"\"Returns a \"DellJobCollection\" object"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :raises: MissingAttributeError if \u0027@odata.id\u0027 field is missing."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9256b704","line":139,"updated":"2020-09-23 22:44:16.000000000","message":"Please add the \":returns:\" information.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("},{"line_number":143,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"Jobs\"], is_collection\u003dFalse)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        from sushy_oem_idrac.resources.manager import jobs"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        return jobs.DellJobCollection("},{"line_number":148,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_922197a1","line":145,"updated":"2020-09-23 22:44:16.000000000","message":"Why is this imported here?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        path \u003d sushy_utils.get_sub_resource_path_by("},{"line_number":143,"context_line":"            self, [\"Links\", \"Oem\", \"Dell\", \"Jobs\"], is_collection\u003dFalse)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        from sushy_oem_idrac.resources.manager import jobs"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        return jobs.DellJobCollection("},{"line_number":148,"context_line":"            self._conn, path, self.redfish_version, self.registries)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b71bb219","line":145,"in_reply_to":"9f560f44_922197a1","updated":"2020-09-27 14:19:09.000000000","message":"Done, Moved it to the top.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"}],"sushy_oem_idrac/tests/unit/json_samples/idrac_card_service.json":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"ff55ac02_e23fad11","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":43},"updated":"2020-11-24 08:54:52.000000000","message":"the file name seems to be incorrect, if this is manager, then let\u0027s name it manager.json","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"729df630_595812c3","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":43},"in_reply_to":"ff55ac02_e23fad11","updated":"2020-12-07 12:43:58.000000000","message":"Done. Created separate file for OEM idrac card service.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"         ],"},{"line_number":10,"context_line":"         \"target\":\"/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset\""},{"line_number":11,"context_line":"      },"},{"line_number":12,"context_line":"      \"#DelliDRACCardService.iDRACReset\":{"},{"line_number":13,"context_line":"         \"ResetType@Redfish.AllowableValues\":["},{"line_number":14,"context_line":"            \"Graceful\","},{"line_number":15,"context_line":"            \"Force\""},{"line_number":16,"context_line":"         ],"},{"line_number":17,"context_line":"         \"target\":\"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":"   },"},{"line_number":20,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":21,"context_line":"   \"Links\":{"}],"source_content_type":"application/json","patch_set":7,"id":"05f12f76_aac1bdef","line":18,"range":{"start_line":12,"start_character":6,"end_line":18,"end_character":7},"updated":"2020-11-24 08:54:52.000000000","message":"this does not belong here, this looks like to be from resource that is fetched via link below -/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService . Thus this needs to be moved to new test json file (named idrac_card_service.json, .. or other way round, but need to have 2 files, 1 for manager and another for OEM iDRAC Card Service)","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"         ],"},{"line_number":10,"context_line":"         \"target\":\"/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset\""},{"line_number":11,"context_line":"      },"},{"line_number":12,"context_line":"      \"#DelliDRACCardService.iDRACReset\":{"},{"line_number":13,"context_line":"         \"ResetType@Redfish.AllowableValues\":["},{"line_number":14,"context_line":"            \"Graceful\","},{"line_number":15,"context_line":"            \"Force\""},{"line_number":16,"context_line":"         ],"},{"line_number":17,"context_line":"         \"target\":\"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":"   },"},{"line_number":20,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":21,"context_line":"   \"Links\":{"}],"source_content_type":"application/json","patch_set":7,"id":"c70d5964_fd0dfc08","line":18,"range":{"start_line":12,"start_character":6,"end_line":18,"end_character":7},"in_reply_to":"05f12f76_aac1bdef","updated":"2020-12-07 12:43:58.000000000","message":"Done. Created separate file for OEM idrac card service.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f3fd36d019e0ce3264b2948b8f87acd41f889c33","unresolved":true,"context_lines":[{"line_number":11,"context_line":"         \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":12,"context_line":"      }"},{"line_number":13,"context_line":"   },"},{"line_number":14,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":15,"context_line":"   \"Links\": {"},{"line_number":16,"context_line":"      \"Oem\": {"},{"line_number":17,"context_line":"         \"Dell\": {"},{"line_number":18,"context_line":"               \"DelliDRACCardService\": {"},{"line_number":19,"context_line":"                  \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\""},{"line_number":20,"context_line":"               }"},{"line_number":21,"context_line":"         }"},{"line_number":22,"context_line":"      }"},{"line_number":23,"context_line":"   }"},{"line_number":24,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"451b4b98_a6aae59a","line":23,"range":{"start_line":14,"start_character":2,"end_line":23,"end_character":4},"updated":"2020-12-08 18:41:47.000000000","message":"this (Id, Links) still seems to be leftover from manager. This is what I have from 14G for iDRAC Card service (removing unrelated Actions)\n\n\t{\n\t\t\"@odata.context\": \"/redfish/v1/$metadata#DelliDRACCardService.DelliDRACCardService\",\n\t\t\"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\",\n\t\t\"@odata.type\": \"#DelliDRACCardService.v1_1_0.DelliDRACCardService\",\n\t\t\"Actions\": {\n\t\t\t\"#DelliDRACCardService.iDRACReset\": {\n\t\t\t\t\"Force@Redfish.AllowableValues\": [\n\t\t\t\t\t\"Force\",\n\t\t\t\t\t\"Graceful\"\n\t\t\t\t],\n\t\t\t\t\"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\"\n\t\t\t}\n\t\t},\n\t\t\"Description\": \"The DelliDRACCardService resource provides some actions to support iDRAC configurations.\",\n\t\t\"Id\": \"DelliDRACCardService\",\n\t\t\"Name\": \"DelliDRACCardService\"\n\t}","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"f0373310f9a57ab44a009ea08473ec7515298da2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"         \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":12,"context_line":"      }"},{"line_number":13,"context_line":"   },"},{"line_number":14,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":15,"context_line":"   \"Links\": {"},{"line_number":16,"context_line":"      \"Oem\": {"},{"line_number":17,"context_line":"         \"Dell\": {"},{"line_number":18,"context_line":"               \"DelliDRACCardService\": {"},{"line_number":19,"context_line":"                  \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\""},{"line_number":20,"context_line":"               }"},{"line_number":21,"context_line":"         }"},{"line_number":22,"context_line":"      }"},{"line_number":23,"context_line":"   }"},{"line_number":24,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"10fe1e6e_055b54bb","line":23,"range":{"start_line":14,"start_character":2,"end_line":23,"end_character":4},"in_reply_to":"451b4b98_a6aae59a","updated":"2020-12-21 11:30:12.000000000","message":"Done.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\": \"/redfish/v1/$metadata#DelliDRACCard.DelliDRACCard\","},{"line_number":3,"context_line":"   \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\","},{"line_number":4,"context_line":"   \"@odata.type\": \"#DelliDRACCardService.v1_1_0.DelliDRACCardService\","},{"line_number":5,"context_line":"   \"Actions\": {"}],"source_content_type":"application/json","patch_set":10,"id":"47b72fe5_9eee90d2","line":2,"range":{"start_line":2,"start_character":58,"end_line":2,"end_character":71},"updated":"2020-12-28 17:12:57.000000000","message":"should this end with DelliDRACCardService? At least the one I\u0027m checking is having\n\n  \"@odata.context\": \"/redfish/v1/$metadata#DelliDRACCardService.DelliDRACCardService\"","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"32b0270d8a8aa496e8b6296b5a8b4b0b34452256","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\": \"/redfish/v1/$metadata#DelliDRACCard.DelliDRACCard\","},{"line_number":3,"context_line":"   \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\","},{"line_number":4,"context_line":"   \"@odata.type\": \"#DelliDRACCardService.v1_1_0.DelliDRACCardService\","},{"line_number":5,"context_line":"   \"Actions\": {"}],"source_content_type":"application/json","patch_set":10,"id":"e57ed79d_d4e79a34","line":2,"range":{"start_line":2,"start_character":58,"end_line":2,"end_character":71},"in_reply_to":"47b72fe5_9eee90d2","updated":"2021-01-08 10:42:41.000000000","message":"Done.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"   \"@odata.type\": \"#DelliDRACCardService.v1_1_0.DelliDRACCardService\","},{"line_number":5,"context_line":"   \"Actions\": {"},{"line_number":6,"context_line":"      \"#DelliDRACCardService.iDRACReset\": {"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\": ["},{"line_number":8,"context_line":"            \"Graceful\","},{"line_number":9,"context_line":"            \"Force\""},{"line_number":10,"context_line":"         ],"}],"source_content_type":"application/json","patch_set":10,"id":"3617ad73_bd6a6eb7","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":19},"updated":"2020-12-28 17:12:57.000000000","message":"In iDRAC I\u0027m checking, this is named \u0027Force\u0027:\n\n  \"Force@Redfish.AllowableValues\": [\n                \"Force\",\n                \"Graceful\"\n            ],\n\nWhat\u0027s the source of having \u0027ResetType\u0027?","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"32b0270d8a8aa496e8b6296b5a8b4b0b34452256","unresolved":false,"context_lines":[{"line_number":4,"context_line":"   \"@odata.type\": \"#DelliDRACCardService.v1_1_0.DelliDRACCardService\","},{"line_number":5,"context_line":"   \"Actions\": {"},{"line_number":6,"context_line":"      \"#DelliDRACCardService.iDRACReset\": {"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\": ["},{"line_number":8,"context_line":"            \"Graceful\","},{"line_number":9,"context_line":"            \"Force\""},{"line_number":10,"context_line":"         ],"}],"source_content_type":"application/json","patch_set":10,"id":"0763ec5f_f2d9fc27","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":19},"in_reply_to":"3617ad73_bd6a6eb7","updated":"2021-01-08 10:42:41.000000000","message":"Done. It should be \u0027Force\u0027.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"}],"sushy_oem_idrac/tests/unit/json_samples/job_collection.json":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"fafecb1a_a3f8dec8","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"updated":"2020-11-24 08:54:52.000000000","message":"same as for LC service and Card service - this is manager, not job collection, this should be contents of `/redfish/v1/Managers/iDRAC.Embedded.1/Jobs`","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"19d6a33d_87473776","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"in_reply_to":"fafecb1a_a3f8dec8","updated":"2020-12-07 12:43:58.000000000","message":"Done.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f3fd36d019e0ce3264b2948b8f87acd41f889c33","unresolved":true,"context_lines":[{"line_number":2,"context_line":"   \"@odata.context\": \"/redfish/v1/$metadata#DellJobCollection.DellJobCollection\","},{"line_number":3,"context_line":"   \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\","},{"line_number":4,"context_line":"   \"@odata.type\": \"#DellJobCollection.DellJobCollection\","},{"line_number":5,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":6,"context_line":"   \"Links\": {"},{"line_number":7,"context_line":"      \"Oem\": {"},{"line_number":8,"context_line":"         \"Dell\": {"},{"line_number":9,"context_line":"            \"Jobs\": {"},{"line_number":10,"context_line":"               \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"         }"},{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","}],"source_content_type":"application/json","patch_set":8,"id":"fe3e5e65_b38383ff","line":14,"range":{"start_line":5,"start_character":3,"end_line":14,"end_character":5},"updated":"2020-12-08 18:41:47.000000000","message":"same as for iDRAC card service, this shouldn\u0027t be here at all.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"f0373310f9a57ab44a009ea08473ec7515298da2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"   \"@odata.context\": \"/redfish/v1/$metadata#DellJobCollection.DellJobCollection\","},{"line_number":3,"context_line":"   \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\","},{"line_number":4,"context_line":"   \"@odata.type\": \"#DellJobCollection.DellJobCollection\","},{"line_number":5,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":6,"context_line":"   \"Links\": {"},{"line_number":7,"context_line":"      \"Oem\": {"},{"line_number":8,"context_line":"         \"Dell\": {"},{"line_number":9,"context_line":"            \"Jobs\": {"},{"line_number":10,"context_line":"               \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\""},{"line_number":11,"context_line":"            }"},{"line_number":12,"context_line":"         }"},{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","}],"source_content_type":"application/json","patch_set":8,"id":"833ca53a_e937fd9e","line":14,"range":{"start_line":5,"start_character":3,"end_line":14,"end_character":5},"in_reply_to":"fe3e5e65_b38383ff","updated":"2020-12-21 11:30:12.000000000","message":"Done.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f3fd36d019e0ce3264b2948b8f87acd41f889c33","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":18,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":19,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":20,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":21,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":22,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":23,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":24,"context_line":"                \"JobState\": \"Running\","},{"line_number":25,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":26,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":27,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":28,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":29,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":30,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":31,"context_line":"                \"PercentComplete\": 100,"},{"line_number":32,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":33,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":34,"context_line":"    }]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"0f49fe49_8da9e002","line":34,"range":{"start_line":16,"start_character":15,"end_line":34,"end_character":5},"updated":"2020-12-08 18:41:47.000000000","message":"Is this how iDRAC returns it? From 14G it\u0027s just a link to items that need to be fetched following the link. If unit tests need job contents, then need this to move to separate file (e.g. named job.json) and set up unit test to fetch it from dedicated file for each job.\n\nThis file should be something like this:\n\t{\n\t\t\"@odata.context\": \"/redfish/v1/$metadata#DellJobCollection.DellJobCollection\",\n\t\t\"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\",\n\t\t\"@odata.type\": \"#DellJobCollection.DellJobCollection\",\n\t\t\"Description\": \"Collection of Job Instances\",\n\t\t\"Id\": \"JobQueue\",\n\t\t\"Members\": [\n\t\t\t{\n\t\t\t\t\"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/JID_073437350364\"\n\t\t\t}\n\t\t],\n\t\t\"Members@odata.count\": 1,\n\t\t\"Name\": \"JobQueue\"\n\t}","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"f0373310f9a57ab44a009ea08473ec7515298da2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":18,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":19,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":20,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":21,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":22,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":23,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":24,"context_line":"                \"JobState\": \"Running\","},{"line_number":25,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":26,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":27,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":28,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":29,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":30,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":31,"context_line":"                \"PercentComplete\": 100,"},{"line_number":32,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":33,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":34,"context_line":"    }]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"e088ecc3_4f3a8bbe","line":34,"range":{"start_line":16,"start_character":15,"end_line":34,"end_character":5},"in_reply_to":"0f49fe49_8da9e002","updated":"2020-12-21 11:30:12.000000000","message":"Done.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":18,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":19,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":20,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":21,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":22,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":23,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":24,"context_line":"                \"JobState\": \"Running\","},{"line_number":25,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":26,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":27,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":28,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":29,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":30,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":31,"context_line":"                \"PercentComplete\": 100,"},{"line_number":32,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":33,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":34,"context_line":"    }]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"7f1c29f6_ae828989","line":34,"range":{"start_line":16,"start_character":15,"end_line":34,"end_character":5},"in_reply_to":"358bcb2f_f757095a","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      }"},{"line_number":14,"context_line":"   },"},{"line_number":15,"context_line":"    \"Members\": ["},{"line_number":16,"context_line":"               {"},{"line_number":17,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":18,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":19,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":20,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":21,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":22,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":23,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":24,"context_line":"                \"JobState\": \"Running\","},{"line_number":25,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":26,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":27,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":28,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":29,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":30,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":31,"context_line":"                \"PercentComplete\": 100,"},{"line_number":32,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":33,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":34,"context_line":"    }]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"358bcb2f_f757095a","line":34,"range":{"start_line":16,"start_character":15,"end_line":34,"end_character":5},"in_reply_to":"e088ecc3_4f3a8bbe","updated":"2020-12-28 17:12:57.000000000","message":"ok, I got it now, it was fine as it was, this is meant to be used together with `$expand`. I suggest to keep all the properties as they were and rename the file to be \u0027job_collection_expanded\u0027 to make it much clearer that this is not with default parameters.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"}],"sushy_oem_idrac/tests/unit/json_samples/job_service.json":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"c9ae5e69_4c10b9c7","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"updated":"2020-11-24 08:54:52.000000000","message":"same as elsewhere - this is manager, but should be contents of `/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService`","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"0e989375_d9f3c237","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"in_reply_to":"c9ae5e69_4c10b9c7","updated":"2020-12-07 12:43:58.000000000","message":"Done.","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f3fd36d019e0ce3264b2948b8f87acd41f889c33","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      }"},{"line_number":9,"context_line":"   },"},{"line_number":10,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":11,"context_line":"   \"Links\": {"},{"line_number":12,"context_line":"      \"Oem\": {"},{"line_number":13,"context_line":"         \"Dell\": {"},{"line_number":14,"context_line":"            \"DellJobService\": {"},{"line_number":15,"context_line":"               \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService\""},{"line_number":16,"context_line":"            },"},{"line_number":17,"context_line":"            \"Jobs\": {"},{"line_number":18,"context_line":"               \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\""},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"         }"},{"line_number":21,"context_line":"      }"},{"line_number":22,"context_line":"   }"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"9189f4af_e7c22adc","line":20,"range":{"start_line":11,"start_character":3,"end_line":20,"end_character":10},"updated":"2020-12-08 18:41:47.000000000","message":"same as elsewhere, not expecting to see \"Links\" here. From where is it coming? Should be something like this (removed unrelated Actions):\n\n\t{\n\t\t\"@odata.context\": \"/redfish/v1/$metadata#DellJobService.DellJobService\",\n\t\t\"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService\",\n\t\t\"@odata.type\": \"#DellJobService.v1_1_0.DellJobService\",\n\t\t\"Actions\": {\n\t\t\t\"#DellJobService.DeleteJobQueue\": {\n\t\t\t\t\"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService/Actions/DellJobService.DeleteJobQueue\"\n\t\t\t}\n\t\t},\n\t\t\"CurrentNumberOfJobs\": 1,\n\t\t\"DeleteOnCompletionTimeoutMinutes\": 2880,\n\t\t\"Description\": \"The DellJobService resource provides some actions to support Job management functionality.\",\n\t\t\"Id\": \"Job Service\",\n\t\t\"MaximumNumberOfJobs\": 256,\n\t\t\"Name\": \"DellJobService\",\n\t\t\"StartAutoDeleteAtThreshold\": 128\n\t}","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"f0373310f9a57ab44a009ea08473ec7515298da2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      }"},{"line_number":9,"context_line":"   },"},{"line_number":10,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":11,"context_line":"   \"Links\": {"},{"line_number":12,"context_line":"      \"Oem\": {"},{"line_number":13,"context_line":"         \"Dell\": {"},{"line_number":14,"context_line":"            \"DellJobService\": {"},{"line_number":15,"context_line":"               \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService\""},{"line_number":16,"context_line":"            },"},{"line_number":17,"context_line":"            \"Jobs\": {"},{"line_number":18,"context_line":"               \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs\""},{"line_number":19,"context_line":"            }"},{"line_number":20,"context_line":"         }"},{"line_number":21,"context_line":"      }"},{"line_number":22,"context_line":"   }"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"74e86201_25742940","line":20,"range":{"start_line":11,"start_character":3,"end_line":20,"end_character":10},"in_reply_to":"9189f4af_e7c22adc","updated":"2020-12-21 11:30:12.000000000","message":"Done.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"}],"sushy_oem_idrac/tests/unit/json_samples/lifecycle_service.json":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"c5e9ad930bcb75f77d627d93f420ef42fb90c4cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"90194ddf_63eccde2","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"updated":"2020-11-24 08:54:52.000000000","message":"same as for Dell Card service, this is manager, lifecycle_service.json should be contents of /redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"52356e6820915b150b0e55764755d8882d33094f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"@odata.context\":\"/redfish/v1/$metadata#Manager.Manager\","},{"line_number":3,"context_line":"   \"@odata.id\":\"/redfish/v1/Managers/iDRAC.Embedded.1\","},{"line_number":4,"context_line":"   \"@odata.type\":\"#Manager.v1_3_3.Manager\","},{"line_number":5,"context_line":"   \"Actions\":{"},{"line_number":6,"context_line":"      \"#Manager.Reset\":{"},{"line_number":7,"context_line":"         \"ResetType@Redfish.AllowableValues\":["}],"source_content_type":"application/json","patch_set":7,"id":"a8b01825_cabb1b21","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":41},"in_reply_to":"90194ddf_63eccde2","updated":"2020-12-07 12:43:58.000000000","message":"Done","commit_id":"b4ffe4a7aec1d7b8933963fd3bddc780e24cc0df"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f3fd36d019e0ce3264b2948b8f87acd41f889c33","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      }"},{"line_number":9,"context_line":"   },"},{"line_number":10,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":11,"context_line":"   \"Links\": {"},{"line_number":12,"context_line":"      \"Oem\": {"},{"line_number":13,"context_line":"         \"Dell\": {"},{"line_number":14,"context_line":"            \"DellLCService\": {"},{"line_number":15,"context_line":"               \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService\""},{"line_number":16,"context_line":"            }"},{"line_number":17,"context_line":"         }"},{"line_number":18,"context_line":"      }"}],"source_content_type":"application/json","patch_set":8,"id":"b675bdc3_66150dd2","line":15,"range":{"start_line":11,"start_character":2,"end_line":15,"end_character":86},"updated":"2020-12-08 18:41:47.000000000","message":"ditto, Links not expected\n\n\t{\n\t\t\"@odata.context\": \"/redfish/v1/$metadata#DellLCService.DellLCService\",\n\t\t\"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService\",\n\t\t\"@odata.type\": \"#DellLCService.v1_1_0.DellLCService\",\n\t\t\"Actions\": {\n\t\t\t\"#DellLCService.GetRemoteServicesAPIStatus\": {\n\t\t\t\t\"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.GetRemoteServicesAPIStatus\"\n\t\t\t}\n\t\t},\n\t\t\"Description\": \"The DellLCService resource provides some actions to support Lifecycle Controller functionality.\",\n\t\t\"Id\": \"DellLCService\",\n\t\t\"Name\": \"DellLCService\"\n\t}","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"f0373310f9a57ab44a009ea08473ec7515298da2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      }"},{"line_number":9,"context_line":"   },"},{"line_number":10,"context_line":"   \"Id\": \"iDRAC.Embedded.1\","},{"line_number":11,"context_line":"   \"Links\": {"},{"line_number":12,"context_line":"      \"Oem\": {"},{"line_number":13,"context_line":"         \"Dell\": {"},{"line_number":14,"context_line":"            \"DellLCService\": {"},{"line_number":15,"context_line":"               \"@odata.id\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService\""},{"line_number":16,"context_line":"            }"},{"line_number":17,"context_line":"         }"},{"line_number":18,"context_line":"      }"}],"source_content_type":"application/json","patch_set":8,"id":"bb74e887_a994b93e","line":15,"range":{"start_line":11,"start_character":2,"end_line":15,"end_character":86},"in_reply_to":"b675bdc3_66150dd2","updated":"2020-12-21 11:30:12.000000000","message":"Done.","commit_id":"9d7b00c9efea44087dd3bd15debd088dcc674f21"}],"sushy_oem_idrac/tests/unit/json_samples/manager.json":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":8,"context_line":"                \"GracefulRestart\""},{"line_number":9,"context_line":"            ],"},{"line_number":10,"context_line":"            \"target\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset\""},{"line_number":11,"context_line":"        },    "},{"line_number":12,"context_line":"        \"#DelliDRACCardService.iDRACReset\": {"},{"line_number":13,"context_line":"            \"ResetType@Redfish.AllowableValues\": ["},{"line_number":14,"context_line":"                \"Graceful\","}],"source_content_type":"application/json","patch_set":2,"id":"1f493fa4_ae1b2371","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":14},"updated":"2020-05-05 05:18:01.000000000","message":"Remove white space.","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"                \"GracefulRestart\""},{"line_number":9,"context_line":"            ],"},{"line_number":10,"context_line":"            \"target\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"#DelliDRACCardService.iDRACReset\": {"},{"line_number":13,"context_line":"            \"ResetType@Redfish.AllowableValues\": ["},{"line_number":14,"context_line":"                \"Graceful\","},{"line_number":15,"context_line":"\t\t\"Force\""},{"line_number":16,"context_line":"            ],"},{"line_number":17,"context_line":"            \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"\t\"#DellJobService.DeleteJobQueue\": {"},{"line_number":20,"context_line":"\t    \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService/Actions/DellJobService.DeleteJobQueue\""},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"\t\"#DellLCService.GetRemoteServicesAPIStatus\": {"},{"line_number":23,"context_line":"            \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.GetRemoteServicesAPIStatus\""},{"line_number":24,"context_line":"        },"},{"line_number":25,"context_line":"        \"Oem\": {"},{"line_number":26,"context_line":"            \"DellManager.v1_0_0#DellManager.ResetToDefaults\": {"}],"source_content_type":"application/json","patch_set":6,"id":"9f560f44_32e1ab2c","line":23,"range":{"start_line":11,"start_character":0,"end_line":23,"end_character":129},"updated":"2020-09-23 22:44:16.000000000","message":"Is this content in the \u0027Manager\u0027 resource? Are not these actions in other resources which are linked from this one?","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"                \"GracefulRestart\""},{"line_number":9,"context_line":"            ],"},{"line_number":10,"context_line":"            \"target\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset\""},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"        \"#DelliDRACCardService.iDRACReset\": {"},{"line_number":13,"context_line":"            \"ResetType@Redfish.AllowableValues\": ["},{"line_number":14,"context_line":"                \"Graceful\","},{"line_number":15,"context_line":"\t\t\"Force\""},{"line_number":16,"context_line":"            ],"},{"line_number":17,"context_line":"            \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService/Actions/DelliDRACCardService.iDRACReset\""},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"\t\"#DellJobService.DeleteJobQueue\": {"},{"line_number":20,"context_line":"\t    \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellJobService/Actions/DellJobService.DeleteJobQueue\""},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"\t\"#DellLCService.GetRemoteServicesAPIStatus\": {"},{"line_number":23,"context_line":"            \"target\": \"/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.GetRemoteServicesAPIStatus\""},{"line_number":24,"context_line":"        },"},{"line_number":25,"context_line":"        \"Oem\": {"},{"line_number":26,"context_line":"            \"DellManager.v1_0_0#DellManager.ResetToDefaults\": {"}],"source_content_type":"application/json","patch_set":6,"id":"9f560f44_770d9ae5","line":23,"range":{"start_line":11,"start_character":0,"end_line":23,"end_character":129},"in_reply_to":"9f560f44_32e1ab2c","updated":"2020-09-27 14:19:09.000000000","message":"Removed it from here, created new json file for each resource.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3c4b76e882a417bd51181bbb58c122d9acdf8fd5","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/LogServices\""},{"line_number":250,"context_line":"    },"},{"line_number":251,"context_line":"    \"ManagerType\": \"BMC\","},{"line_number":252,"context_line":"    \"Members\": ["},{"line_number":253,"context_line":"               {"},{"line_number":254,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":255,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":256,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":257,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":258,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":259,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":260,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":261,"context_line":"                \"JobState\": \"Running\","},{"line_number":262,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":263,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":264,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":265,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":266,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":267,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":268,"context_line":"                \"PercentComplete\": 100,"},{"line_number":269,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":270,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":271,"context_line":"    }],"},{"line_number":272,"context_line":"    \"Model\": \"14G Monolithic\","},{"line_number":273,"context_line":"    \"Name\": \"Manager\","},{"line_number":274,"context_line":"    \"NetworkProtocol\": {"}],"source_content_type":"application/json","patch_set":6,"id":"9f560f44_725e83e9","line":271,"range":{"start_line":252,"start_character":0,"end_line":271,"end_character":7},"updated":"2020-09-23 22:44:16.000000000","message":"This does not seem right.\n\nIs this the \u0027Members\u0027 property of the \u0027DellJobCollection\u0027 resource? If so, it does not belong in this \u0027Manager\u0027 resource.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/LogServices\""},{"line_number":250,"context_line":"    },"},{"line_number":251,"context_line":"    \"ManagerType\": \"BMC\","},{"line_number":252,"context_line":"    \"Members\": ["},{"line_number":253,"context_line":"               {"},{"line_number":254,"context_line":"                \"@odata.context\": \"/redfish/v1/$metadata#DellJob.DellJob\","},{"line_number":255,"context_line":"                \"@odata.id\": \"/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/RID_878460711202\","},{"line_number":256,"context_line":"                \"@odata.type\": \"#DellJob.v1_0_2.DellJob\","},{"line_number":257,"context_line":"                \"CompletionTime\": \"2020-04-25T15:21:33\","},{"line_number":258,"context_line":"                \"Description\": \"Job Instance\","},{"line_number":259,"context_line":"                \"EndTime\": \"TIME_NA\","},{"line_number":260,"context_line":"                \"Id\": \"RID_878460711202\","},{"line_number":261,"context_line":"                \"JobState\": \"Running\","},{"line_number":262,"context_line":"                \"JobType\": \"RebootForce\","},{"line_number":263,"context_line":"                \"Message\": \"Reboot is complete.\","},{"line_number":264,"context_line":"                \"MessageArgs\": [ ],"},{"line_number":265,"context_line":"                \"MessageArgs@odata.count\": 0,"},{"line_number":266,"context_line":"                \"MessageId\": \"RED030\","},{"line_number":267,"context_line":"                \"Name\": \"Reboot3\","},{"line_number":268,"context_line":"                \"PercentComplete\": 100,"},{"line_number":269,"context_line":"                \"StartTime\": \"TIME_NOW\","},{"line_number":270,"context_line":"                \"TargetSettingsURI\": null"},{"line_number":271,"context_line":"    }],"},{"line_number":272,"context_line":"    \"Model\": \"14G Monolithic\","},{"line_number":273,"context_line":"    \"Name\": \"Manager\","},{"line_number":274,"context_line":"    \"NetworkProtocol\": {"}],"source_content_type":"application/json","patch_set":6,"id":"9f560f44_d7f746d3","line":271,"range":{"start_line":252,"start_character":0,"end_line":271,"end_character":7},"in_reply_to":"9f560f44_725e83e9","updated":"2020-09-27 14:19:09.000000000","message":"Removed it from here and added new json file for each resource.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"}],"sushy_oem_idrac/tests/unit/test_idrac_card_service.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                               \u0027/iDRAC.Embedded.1/\u0027"},{"line_number":49,"context_line":"                                               \u0027DelliDRACCardService\u0027"},{"line_number":50,"context_line":"                                               \u0027/Actions/DelliDRACCardService.\u0027"},{"line_number":51,"context_line":"                                               \u0027iDRACReset\u0027,"},{"line_number":52,"context_line":"                                               data\u003d{\u0027Force\u0027: \u0027Force\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_0e5b372e","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":60},"updated":"2020-05-05 05:18:01.000000000","message":"It would be good to define URL links in Constants.","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8ca5083e5071900e62d720f28ff7cf62a26e7848","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_063120a3","line":3,"updated":"2020-05-07 18:28:17.000000000","message":"Can you remove the 3 lines above since Red Hat is not the author of this code?","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_1209472b","line":3,"in_reply_to":"1f493fa4_063120a3","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_27ccebb9","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027import mock\u0027 is identified as Third Party and \u0027import json\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_87c4d793","line":16,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I202 Additional newline in a group of imports. \u0027from oslotest.base import BaseTestCase\u0027 is identified as Third Party and \u0027import mock\u0027 is identified as Third Party.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5f36db9972f431fee020da9ded0b33976684cd42","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":40,"context_line":"        oem.idrac_card_service.reset_idrac(force\u003d\u0027Force\u0027)"},{"line_number":41,"context_line":"        target_uri \u003d (\u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1/\u0027"},{"line_number":42,"context_line":"                      \u0027DelliDRACCardService\u0027"},{"line_number":43,"context_line":"                      \u0027/Actions/DelliDRACCardService.iDRACReset\u0027)"},{"line_number":44,"context_line":"        self.conn.post.assert_called_once_with(target_uri,"},{"line_number":45,"context_line":"                                               data\u003d{\u0027Force\u0027: \u0027Force\u0027})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_89222953","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"updated":"2020-09-23 00:19:01.000000000","message":"Let us be consistent with the first character in multi-line paths.","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":40,"context_line":"        oem.idrac_card_service.reset_idrac(force\u003d\u0027Force\u0027)"},{"line_number":41,"context_line":"        target_uri \u003d (\u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1/\u0027"},{"line_number":42,"context_line":"                      \u0027DelliDRACCardService\u0027"},{"line_number":43,"context_line":"                      \u0027/Actions/DelliDRACCardService.iDRACReset\u0027)"},{"line_number":44,"context_line":"        self.conn.post.assert_called_once_with(target_uri,"},{"line_number":45,"context_line":"                                               data\u003d{\u0027Force\u0027: \u0027Force\u0027})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1717feef","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"in_reply_to":"9f560f44_89222953","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"8b03d8ca140544e0d2a53424d924c403d287f5f6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from sushy_oem_idrac.resources.manager import idrac_card_service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class IdracCardServiceTestCase(BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(IdracCardServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"05f70755_7759b2da","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":30},"updated":"2020-12-28 17:12:57.000000000","message":"suggesting to rename to `DelliDRACCardServiceTestCase` to match tested class","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from sushy_oem_idrac.resources.manager import idrac_card_service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class IdracCardServiceTestCase(BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(IdracCardServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"e02aac11_28a258e3","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":30},"in_reply_to":"05f70755_7759b2da","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a899e3c0_3f05a451","line":60,"updated":"2020-12-28 17:12:57.000000000","message":"add another test case for `get_allowed_reset_idrac_values` to cover lines 58-60 where allowed values are not provided by iDRAC and expected outcome is to return all available.\n\n(to avoid creating another sample JSON file can remove that property from JSON on the fly at the beginning of this new test case)","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c22e18f_d8cb36cf","line":60,"in_reply_to":"a899e3c0_3f05a451","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"}],"sushy_oem_idrac/tests/unit/test_job_collection.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import job_collection"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class JobsTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(JobsTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"4f2828eb_96c9901b","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":18},"updated":"2020-12-28 17:12:57.000000000","message":"suggesting to change this to `DellJobCollectionTestCase` to match with class being tested.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"1a1c572e71576bb9f987bfcc3c11eae86bd800b4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import job_collection"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class JobsTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(JobsTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f94b244_8b199542","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":18},"in_reply_to":"4f2828eb_96c9901b","updated":"2021-01-08 13:17:39.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5032cabf_1813d5b1","line":43,"updated":"2020-12-28 17:12:57.000000000","message":"assert also returned values","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a67190877681160e7e1305c93112a3fee00cd087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d619193c_de9cf60a","line":43,"in_reply_to":"039a8ab1_3c044e00","updated":"2021-01-12 09:56:18.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"8970efe3103b40a13e34c28d11c3b390d3767081","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"039a8ab1_3c044e00","line":43,"in_reply_to":"5032cabf_1813d5b1","updated":"2021-01-12 09:40:54.000000000","message":"Done.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"}],"sushy_oem_idrac/tests/unit/test_job_service.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":49,"context_line":"        for job_id in job_ids:"},{"line_number":50,"context_line":"            self.conn.post.assert_any_call(\u0027/redfish/v1/Dell/Managers/\u0027"},{"line_number":51,"context_line":"                                           \u0027iDRAC.Embedded.1/DellJobService\u0027"},{"line_number":52,"context_line":"                                           \u0027/Actions/\u0027\u0027DellJobService.\u0027"},{"line_number":53,"context_line":"                                           \u0027DeleteJobQueue\u0027, headers\u003dHEADERS,"},{"line_number":54,"context_line":"                                           data\u003d{\u0027JobID\u0027: job_id},"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_ae496361","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":76},"updated":"2020-05-05 05:18:01.000000000","message":"Please define URL in constant.","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8ca5083e5071900e62d720f28ff7cf62a26e7848","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_06d64028","line":3,"updated":"2020-05-07 18:28:17.000000000","message":"Same here","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_320d6335","line":3,"in_reply_to":"1f493fa4_06d64028","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a7de3b67","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027import mock\u0027 is identified as Third Party and \u0027import json\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_07d1e757","line":16,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I202 Additional newline in a group of imports. \u0027from oslotest.base import BaseTestCase\u0027 is identified as Third Party and \u0027import mock\u0027 is identified as Third Party.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import job_service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class JobServiceTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(JobServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ca220e2f_d0e412e0","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":24},"updated":"2020-12-28 17:12:57.000000000","message":"suggesting to rename to `DellJobServiceTestCase` to match tested class","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"32b0270d8a8aa496e8b6296b5a8b4b0b34452256","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import job_service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class JobServiceTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(JobServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f7a7234_ad965562","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":24},"in_reply_to":"ca220e2f_d0e412e0","updated":"2021-01-08 10:42:41.000000000","message":"Done.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba9dac63_2bbdeabc","line":49,"updated":"2020-12-28 17:12:57.000000000","message":"assert also that there was 1 call with 1st job ID, and another call with 2nd job ID","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"cf2c50bf4fe907c2e0c1e2f67d1ec08c09e55e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7026e89a_9889ff07","line":49,"in_reply_to":"ba9dac63_2bbdeabc","updated":"2021-01-12 09:26:45.000000000","message":"It\u0027s already done in line 46-47, marking as resolved.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"}],"sushy_oem_idrac/tests/unit/test_jobs.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        oem \u003d self.manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":45,"context_line":"        oem.job_collection.get_unfinished_jobs()"},{"line_number":46,"context_line":"        self.conn.get.assert_any_call(\u0027/redfish/v1/Managers/iDRAC.Embedded\u0027"},{"line_number":47,"context_line":"                                      \u0027.1/Jobs?$expand\u003d.($levels\u003d1)\u0027,"},{"line_number":48,"context_line":"                                      verify\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_8e46274f","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":69},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8ca5083e5071900e62d720f28ff7cf62a26e7848","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_e6acf48d","line":3,"updated":"2020-05-07 18:28:17.000000000","message":"Same here","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_7217eb46","line":3,"in_reply_to":"1f493fa4_e6acf48d","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_67d8a37e","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027import mock\u0027 is identified as Third Party and \u0027import json\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c7e1af2d","line":16,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I202 Additional newline in a group of imports. \u0027from oslotest.base import BaseTestCase\u0027 is identified as Third Party and \u0027import mock\u0027 is identified as Third Party.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"}],"sushy_oem_idrac/tests/unit/test_lc_service.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"00f3d1d7c9665b6ad2b2ea60babc04bc717ee5ea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        oem.lc_service.is_idrac_ready()"},{"line_number":48,"context_line":"        HEADERS \u003d {\u0027content-type\u0027: \u0027application/json\u0027}"},{"line_number":49,"context_line":"        self.conn.post.assert_called_once_with("},{"line_number":50,"context_line":"            \u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/\u0027"},{"line_number":51,"context_line":"            \u0027DellLCService.GetRemoteServicesAPIStatus\u0027,"},{"line_number":52,"context_line":"            data\u003d{}, headers\u003dHEADERS, verify\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_28238607","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":79},"updated":"2020-05-05 05:18:01.000000000","message":"Ditto!","commit_id":"f7cb8d9b41982d858061c7b5ae9b3fa2c71e63b3"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8ca5083e5071900e62d720f28ff7cf62a26e7848","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_c6a738a7","line":3,"updated":"2020-05-07 18:28:17.000000000","message":"Same here","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"66329e48154c8c3ec4db3f25ccb16b33d42278ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_1222e7a4","line":3,"in_reply_to":"1f493fa4_c6a738a7","updated":"2020-09-27 14:19:09.000000000","message":"Done","commit_id":"51982d1ba4b201c880ca8f2da1daf534e6874dac"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e7d5d344","line":14,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I201 Missing newline between import groups. \u0027import mock\u0027 is identified as Third Party and \u0027import json\u0027 is identified as Stdlib.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165f98202e08300a319e8745286324bb836a5680","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest.base import BaseTestCase"},{"line_number":17,"context_line":"from sushy.resources.manager import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_47c75f99","line":16,"updated":"2020-09-22 20:18:45.000000000","message":"pep8: I202 Additional newline in a group of imports. \u0027from oslotest.base import BaseTestCase\u0027 is identified as Third Party and \u0027import mock\u0027 is identified as Third Party.","commit_id":"58702303f82648ba95672ebaab3cd19ac127d63f"}],"sushy_oem_idrac/tests/unit/test_lifecycle_service.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import lifecycle_service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LcServiceTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(LcServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"4ef1aed5_59166cd1","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":23},"updated":"2020-12-28 17:12:57.000000000","message":"suggesting to rename to `DellLCServiceTestCase` to match tested class","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"8970efe3103b40a13e34c28d11c3b390d3767081","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import lifecycle_service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LcServiceTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(LcServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"69a9deba_ea31f7ff","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":23},"in_reply_to":"4ef1aed5_59166cd1","updated":"2021-01-12 09:40:54.000000000","message":"Done.","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a67190877681160e7e1305c93112a3fee00cd087","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sushy_oem_idrac.resources.manager import lifecycle_service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LcServiceTestCase(BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(LcServiceTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9bb7f589_7c6497c2","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":23},"in_reply_to":"69a9deba_ea31f7ff","updated":"2021-01-12 09:56:18.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"dbc322bcd1fa38e96343b26ad012f0fdc83344e1","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        target_uri \u003d (\u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1\u0027"},{"line_number":44,"context_line":"                      \u0027/DellLCService\u0027"},{"line_number":45,"context_line":"                      \u0027/Actions/DellLCService.GetRemoteServicesAPIStatus\u0027)"},{"line_number":46,"context_line":"        self.conn.post.assert_called_once_with(target_uri, data\u003d{})"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_is_idrac_ready_true(self):"},{"line_number":49,"context_line":"        mock_response \u003d self.conn.post.return_value"}],"source_content_type":"text/x-python","patch_set":18,"id":"fdd574f2_27d2efdc","line":46,"updated":"2021-03-15 12:25:11.000000000","message":"remove this test case and move the asserts to other 2 tests","commit_id":"24d76312fbd42aa4518f6eb779f3a3d71a1072a3"}],"sushy_oem_idrac/tests/unit/test_manager.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4b824503598b531fab7a58f40b155618cfbe6e9f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        idrac_card_service \u003d oem.idrac_card_service"},{"line_number":71,"context_line":"        self.assertEqual("},{"line_number":72,"context_line":"            \u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\u0027,"},{"line_number":73,"context_line":"            idrac_card_service.path)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":76,"context_line":"    def test_lifecycle_service(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"a319f61f_fed07546","line":73,"updated":"2020-12-28 17:12:57.000000000","message":"here and for other new methods, can also assert that returned value is instance of expected class, e.g., in this case `DelliDRACCardService`","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":31871,"name":"Dhuldev Valekar","email":"dhuldev.valekar@gmail.com","username":"dhuldev30"},"change_message_id":"32b0270d8a8aa496e8b6296b5a8b4b0b34452256","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        idrac_card_service \u003d oem.idrac_card_service"},{"line_number":71,"context_line":"        self.assertEqual("},{"line_number":72,"context_line":"            \u0027/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DelliDRACCardService\u0027,"},{"line_number":73,"context_line":"            idrac_card_service.path)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @mock.patch(\u0027sushy.resources.oem.common._global_extn_mgrs_by_resource\u0027, {})"},{"line_number":76,"context_line":"    def test_lifecycle_service(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfd82bd3_4fc8d3c0","line":73,"in_reply_to":"a319f61f_fed07546","updated":"2021-01-08 10:42:41.000000000","message":"Done","commit_id":"adf92a749c974e5054d6262bff73f878f30c41e7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d6002047800a4a3517d10ad1608bdd5cb5c79970","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"b77e5e25_b2de1408","line":2,"updated":"2021-03-12 13:19:46.000000000","message":"add for Dell so that in the end there is:\n\n# Copyright 2017 Red Hat, Inc.\n#\n# Copyright (c) 2020-2021 Dell Inc. or its subsidiaries.","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"cc436a55a586ca245cab64b33afd67c5603940fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"f3d08477_dd7527b1","line":2,"in_reply_to":"b77e5e25_b2de1408","updated":"2021-03-12 17:55:29.000000000","message":"added by rebasing","commit_id":"f8deb84e669e4b43b74f1bfecf895f6ae74235cf"}]}