)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"994992dd1b305250bf3007bed69aa50eb826ab87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fba44da2_7010715a","updated":"2024-04-26 12:17:47.000000000","message":"Thanks for the feedback, I\u0027ve hopefully addressed your point in the new version.","commit_id":"0002ba9aa26556d3de81c1f172ca47381c20c632"}],"sushy_oem_idrac/resources/manager/idrac_card_service.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"50a3eaf40fa2708f5794ca039b78894d18129916","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self._conn.post(target_uri, data\u003dpayload)"},{"line_number":84,"context_line":"        LOG.info(\u0027The iDRAC %s is being reset\u0027, self.identity)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_kvm_session(self):"},{"line_number":87,"context_line":"        target_uri \u003d self._actions.get_kvm_session.target_uri"},{"line_number":88,"context_line":"        LOG.debug(\u0027Getting KVM session from iDRAC %s ...\u0027, self.identity)"},{"line_number":89,"context_line":"        data \u003d {\"SessionTypeName\": \"ssl_cert.txt\"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"60f040b0_6313eeb7","line":86,"updated":"2024-04-25 11:09:42.000000000","message":"A docstring could be handy (especially to understand what it returns and in which cases it returns None as opposed to raising exceptions).","commit_id":"24b05ee173ee9da61ddf09efd0c96fd3995d7a7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"50a3eaf40fa2708f5794ca039b78894d18129916","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        LOG.debug(\u0027Getting KVM session from iDRAC %s ...\u0027, self.identity)"},{"line_number":89,"context_line":"        data \u003d {\"SessionTypeName\": \"ssl_cert.txt\"}"},{"line_number":90,"context_line":"        result \u003d self._conn.post(target_uri, data\u003ddata)"},{"line_number":91,"context_line":"        LOG.info(\u0027Got KVM session from iDRAC\u0027, result)"},{"line_number":92,"context_line":"        if result.status_code in (200, 202):"},{"line_number":93,"context_line":"            return result.json()"},{"line_number":94,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"de8fd8c4_24a1e195","line":91,"updated":"2024-04-25 11:09:42.000000000","message":"I hope the result does not contain any secrets?","commit_id":"24b05ee173ee9da61ddf09efd0c96fd3995d7a7d"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"994992dd1b305250bf3007bed69aa50eb826ab87","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        LOG.debug(\u0027Getting KVM session from iDRAC %s ...\u0027, self.identity)"},{"line_number":89,"context_line":"        data \u003d {\"SessionTypeName\": \"ssl_cert.txt\"}"},{"line_number":90,"context_line":"        result \u003d self._conn.post(target_uri, data\u003ddata)"},{"line_number":91,"context_line":"        LOG.info(\u0027Got KVM session from iDRAC\u0027, result)"},{"line_number":92,"context_line":"        if result.status_code in (200, 202):"},{"line_number":93,"context_line":"            return result.json()"},{"line_number":94,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f7b0975_03111f0c","line":91,"in_reply_to":"de8fd8c4_24a1e195","updated":"2024-04-26 12:17:47.000000000","message":"True, I have removed it.","commit_id":"24b05ee173ee9da61ddf09efd0c96fd3995d7a7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"50a3eaf40fa2708f5794ca039b78894d18129916","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        LOG.info(\u0027Got KVM session from iDRAC\u0027, result)"},{"line_number":92,"context_line":"        if result.status_code in (200, 202):"},{"line_number":93,"context_line":"            return result.json()"},{"line_number":94,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"49d03d68_c8255067","line":94,"updated":"2024-04-25 11:09:42.000000000","message":"What happens in this case?","commit_id":"24b05ee173ee9da61ddf09efd0c96fd3995d7a7d"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"994992dd1b305250bf3007bed69aa50eb826ab87","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        LOG.info(\u0027Got KVM session from iDRAC\u0027, result)"},{"line_number":92,"context_line":"        if result.status_code in (200, 202):"},{"line_number":93,"context_line":"            return result.json()"},{"line_number":94,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"563e1a34_d8439a0a","line":94,"in_reply_to":"49d03d68_c8255067","updated":"2024-04-26 12:17:47.000000000","message":"I\u0027ve no idea. Just that they are documented cases in the api.\nSee: https://developer.dell.com/apis/2978/versions/5.xx/openapi.yaml/paths/~1redfish~1v1~1Managers~1%7BManagerId%7D~1Oem~1Dell~1DelliDRACCardService~1Actions~1DelliDRACCardService.GetKVMSession/post","commit_id":"24b05ee173ee9da61ddf09efd0c96fd3995d7a7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"af7ff35e3e7ac2c6533d1aa4d237d87681bb554c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        https://{host}/console?username\u003d{}\u0026tempUsername\u003d{}\u0026tempPassword\u003d{}"},{"line_number":94,"context_line":"        The username is the user used to generate these session-credentials."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        :returns: Dict with the fields TempUsername and TempPassword as strings"},{"line_number":97,"context_line":"                  None, if the API did not return any credentials, but did not"},{"line_number":98,"context_line":"                  raise an error. When and why that should happen is unclear,"},{"line_number":99,"context_line":"                  but specifed in the API doc."}],"source_content_type":"text/x-python","patch_set":5,"id":"2f9103d9_01dbbd7b","line":96,"updated":"2024-06-05 10:53:55.000000000","message":"nit: missing dot after \"strings\"","commit_id":"6a955c21482464805ec43aacc879386a8e1bc526"}]}