)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d93a8656a81feae9a30d8a813b87937d81a0107b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"At present just Legacy and Uefi boot modes are supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1741062"},{"line_number":15,"context_line":"Depends-On: 523879"},{"line_number":16,"context_line":"Change-Id: I077d31b37a34d90fc8bfd87d24b66b227088fd7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_cbf3cf09","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":18},"updated":"2018-01-05 14:41:52.000000000","message":"This should be the gerrit change-id value for the change you wish it to be dependent upon, not the review set number.","commit_id":"d3aef027eee866886c41e670342624c3cfc7cb9c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"37072cf769542a9f6a2d1122086dbabf2af0549e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"At present just Legacy and Uefi boot modes are supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1741062"},{"line_number":15,"context_line":"Depends-On: 523879"},{"line_number":16,"context_line":"Change-Id: I077d31b37a34d90fc8bfd87d24b66b227088fd7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_19182dd1","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":18},"in_reply_to":"9f91af0f_cbf3cf09","updated":"2018-01-05 16:25:46.000000000","message":"Done","commit_id":"d3aef027eee866886c41e670342624c3cfc7cb9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f49cc93fcd274f5b822e0960c046986c55db31fd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"At present just Legacy and Uefi boot modes are supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1741062"},{"line_number":15,"context_line":"Depends-On: Iaed42435c27c8624c6a1a24ef886f7a0ec0937ea"},{"line_number":16,"context_line":"Change-Id: I077d31b37a34d90fc8bfd87d24b66b227088fd7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bf659307_be662f29","line":15,"updated":"2018-04-05 11:27:52.000000000","message":"you don\u0027t need Depends-On in one repository, just rebase this patch on top of that","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0d0bbe6b2162728f80f259394a7e089f0dc45e84","unresolved":false,"context_lines":[{"line_number":12,"context_line":"At present just Legacy and Uefi boot modes are supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1741062"},{"line_number":15,"context_line":"Depends-On: Iaed42435c27c8624c6a1a24ef886f7a0ec0937ea"},{"line_number":16,"context_line":"Change-Id: I077d31b37a34d90fc8bfd87d24b66b227088fd7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bf659307_1abce767","line":15,"in_reply_to":"bf659307_be662f29","updated":"2018-04-06 18:00:59.000000000","message":"Done","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"}],"requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b8e82a77e39aed46b98fbd70aea02089c7a729e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask\u003e\u003d0.10,!\u003d0.11,\u003c1.0 # BSD"},{"line_number":7,"context_line":"libvirt-python\u003e\u003d1.2.5 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"9f91af0f_3a11315e","line":9,"updated":"2018-01-08 23:41:09.000000000","message":"Where did this come from?","commit_id":"373799130868be905756afc9b669e4729faac84c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"973f063cec8a15b33a64467031827d0c093f359f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask\u003e\u003d0.10,!\u003d0.11,\u003c1.0 # BSD"},{"line_number":7,"context_line":"libvirt-python\u003e\u003d1.2.5 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"7f96bb07_98510d12","line":9,"in_reply_to":"9f91af0f_3a11315e","updated":"2018-01-10 19:30:23.000000000","message":"That is a forgotten import. The module is used here:\n\nhttps://git.openstack.org/cgit/openstack/sushy-tools/tree/sushy_tools/emulator/drivers/novadriver.py?h\u003drefs/changes/01/526101/7^1#n22","commit_id":"373799130868be905756afc9b669e4729faac84c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f49cc93fcd274f5b822e0960c046986c55db31fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask!\u003d0.11,\u003c1.0,\u003e\u003d0.10 # BSD"},{"line_number":7,"context_line":"libvirt-python!\u003d4.1.0,\u003e\u003d3.5.0 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"bf659307_5e6b53f0","line":9,"updated":"2018-04-05 11:27:52.000000000","message":"this should go to the parent patch","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask!\u003d0.11,\u003c1.0,\u003e\u003d0.10 # BSD"},{"line_number":7,"context_line":"libvirt-python!\u003d4.1.0,\u003e\u003d3.5.0 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"bf659307_75be5400","line":9,"in_reply_to":"bf659307_5a357ff6","updated":"2018-05-10 10:31:00.000000000","message":"Pardon me, that\u0027s right. Done.","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0d0bbe6b2162728f80f259394a7e089f0dc45e84","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask!\u003d0.11,\u003c1.0,\u003e\u003d0.10 # BSD"},{"line_number":7,"context_line":"libvirt-python!\u003d4.1.0,\u003e\u003d3.5.0 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"bf659307_6c88d570","line":9,"in_reply_to":"bf659307_5e6b53f0","updated":"2018-04-06 18:00:59.000000000","message":"I am not sure it should. Because this is the first and the only patch which introduces OpenStack bindings.\n\nParent patch brings in the infrastructure for whatever cloud we want to tap onto, but not OpenStack integration specifically.\n\nCould you please elaborate?","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c91afa1b934166fdfb8e79c529ee4ff8ebd79f38","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Flask!\u003d0.11,\u003c1.0,\u003e\u003d0.10 # BSD"},{"line_number":7,"context_line":"libvirt-python!\u003d4.1.0,\u003e\u003d3.5.0 # LGPLv2+"},{"line_number":8,"context_line":"python-novaclient\u003e\u003d9.1.0 # Apache-2.0"},{"line_number":9,"context_line":"os-client-config\u003e\u003d1.28.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":18,"id":"bf659307_5a357ff6","line":9,"in_reply_to":"bf659307_6c88d570","updated":"2018-04-06 18:05:29.000000000","message":"Patch https://review.openstack.org/#/c/523879/20 introduced OpenStack bindings, not this one, no? And that is the patch using os-client-config.","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"}],"sushy_tools/emulator/drivers/base.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"37e32d2f9e7e9f2171ecd008535027d41cf373a5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def boot_mode(self, identity, boot_mode\u003dNone):"},{"line_number":78,"context_line":"        \"\"\"Get/Set computer system boot mode."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param boot_mode: optional string literal requesting boot mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_33a47257","line":77,"range":{"start_line":77,"start_character":33,"end_line":77,"end_character":48},"updated":"2018-01-02 23:29:34.000000000","message":"I feel like this should almost be addressed in the very first patch :(\n\nSince it is the changing of a kwarg argument name, luckily that patch has not landed and we can land them in rapid succession.","commit_id":"9e0d44c11ce2d55ee7393352658bcc1bea9193bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"23c993ec75b395d9d108b6c61f2129af6ee4a35d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def boot_mode(self, identity, boot_mode\u003dNone):"},{"line_number":78,"context_line":"        \"\"\"Get/Set computer system boot mode."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param boot_mode: optional string literal requesting boot mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_1adb71ed","line":77,"range":{"start_line":77,"start_character":33,"end_line":77,"end_character":48},"in_reply_to":"9f91af0f_33a47257","updated":"2018-01-03 17:31:05.000000000","message":"I just dropped the `boot_mode` method from the parent patch.","commit_id":"9e0d44c11ce2d55ee7393352658bcc1bea9193bb"}],"sushy_tools/emulator/drivers/libvirtdriver.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"37e32d2f9e7e9f2171ecd008535027d41cf373a5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    BOOT_DEVICE_MAP_REV \u003d {v: k for k, v in BOOT_DEVICE_MAP.items()}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    BOOT_MODE_MAP \u003d {"},{"line_number":37,"context_line":"        \u0027Legacy\u0027: \u0027rom\u0027,"},{"line_number":38,"context_line":"        \u0027Uefi\u0027: \u0027pflash\u0027,"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    BOOT_MODE_MAP_REV \u003d {v: k for k, v in BOOT_MODE_MAP.items()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_d388a6c7","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":25},"updated":"2018-01-02 23:29:34.000000000","message":"nit: can we include a link to where this could be referenced for anyone working on this code in the future?","commit_id":"9e0d44c11ce2d55ee7393352658bcc1bea9193bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"23c993ec75b395d9d108b6c61f2129af6ee4a35d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    BOOT_DEVICE_MAP_REV \u003d {v: k for k, v in BOOT_DEVICE_MAP.items()}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    BOOT_MODE_MAP \u003d {"},{"line_number":37,"context_line":"        \u0027Legacy\u0027: \u0027rom\u0027,"},{"line_number":38,"context_line":"        \u0027Uefi\u0027: \u0027pflash\u0027,"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    BOOT_MODE_MAP_REV \u003d {v: k for k, v in BOOT_MODE_MAP.items()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_3a099530","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":25},"in_reply_to":"9f91af0f_d388a6c7","updated":"2018-01-03 17:31:05.000000000","message":"Added here for redundancy. Note that schema link is already present deeper the code (L#181) where the actual XML is handled. ;-)","commit_id":"9e0d44c11ce2d55ee7393352658bcc1bea9193bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d93a8656a81feae9a30d8a813b87937d81a0107b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    BOOT_DEVICE_MAP_REV \u003d {v: k for k, v in BOOT_DEVICE_MAP.items()}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    BOOT_MODE_MAP \u003d {"},{"line_number":36,"context_line":"        \u0027Legacy\u0027: \u0027rom\u0027,"},{"line_number":37,"context_line":"        \u0027Uefi\u0027: \u0027pflash\u0027,"},{"line_number":38,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_cba50f06","line":35,"updated":"2018-01-05 14:41:52.000000000","message":"nit: If you could follow-up with the reference into documentation where this is asserted as the options, so future coders have context. Thanks!","commit_id":"d3aef027eee866886c41e670342624c3cfc7cb9c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"37072cf769542a9f6a2d1122086dbabf2af0549e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    BOOT_DEVICE_MAP_REV \u003d {v: k for k, v in BOOT_DEVICE_MAP.items()}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    BOOT_MODE_MAP \u003d {"},{"line_number":36,"context_line":"        \u0027Legacy\u0027: \u0027rom\u0027,"},{"line_number":37,"context_line":"        \u0027Uefi\u0027: \u0027pflash\u0027,"},{"line_number":38,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_99519d65","line":35,"in_reply_to":"9f91af0f_cba50f06","updated":"2018-01-05 16:25:46.000000000","message":"Oh, I actually added it once, but it got lost later on in the  rebase disaster.\n\nOn the other hand, the docs link is already in the depths of the code.","commit_id":"d3aef027eee866886c41e670342624c3cfc7cb9c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                        self.BOOT_DEVICE_MAP_REV.get(boot_element.get(\u0027dev\u0027))"},{"line_number":220,"context_line":"                    )"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            return boot_source"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def get_boot_mode(self, identity):"},{"line_number":225,"context_line":"        \"\"\"Get computer system boot mode."}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_b36c0137","line":222,"updated":"2018-05-07 13:00:12.000000000","message":"I don\u0027t mind returning something from set_boot_device, but it must be documented in the docstring (both here and in the parent) and should probably be a separate patch","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                        self.BOOT_DEVICE_MAP_REV.get(boot_element.get(\u0027dev\u0027))"},{"line_number":220,"context_line":"                    )"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            return boot_source"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def get_boot_mode(self, identity):"},{"line_number":225,"context_line":"        \"\"\"Get computer system boot mode."}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_5442ea3f","line":222,"in_reply_to":"5f7c97a3_b36c0137","updated":"2018-05-10 10:31:00.000000000","message":"Done","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                loader_element \u003d ET.SubElement(os_element, \u0027loader\u0027)"},{"line_number":278,"context_line":"                loader_element.set(\u0027type\u0027, target)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"            self._conn.defineXML(ET.tostring(tree).decode(\u0027utf-8\u0027))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_total_memory(self, identity):"},{"line_number":283,"context_line":"        \"\"\"Get computer system total memory"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_d3697d25","line":280,"updated":"2018-05-07 13:00:12.000000000","message":"please catch libvirtError and convert it to FishyError as it\u0027s done for setting the boot device","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                loader_element \u003d ET.SubElement(os_element, \u0027loader\u0027)"},{"line_number":278,"context_line":"                loader_element.set(\u0027type\u0027, target)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"            self._conn.defineXML(ET.tostring(tree).decode(\u0027utf-8\u0027))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_total_memory(self, identity):"},{"line_number":283,"context_line":"        \"\"\"Get computer system total memory"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_b4725eac","line":280,"in_reply_to":"5f7c97a3_d3697d25","updated":"2018-05-10 10:31:00.000000000","message":"Done","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"}],"sushy_tools/emulator/drivers/novadriver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        hw_firmware_type \u003d getattr(image, \u0027hw_firmware_type\u0027, None)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if hw_firmware_type in self.BOOT_MODE_MAP_REV:"},{"line_number":218,"context_line":"            return self.BOOT_MODE_MAP_REV[hw_firmware_type]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def set_boot_mode(self, identity, boot_mode):"},{"line_number":221,"context_line":"        \"\"\"Set computer system boot mode."}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_537ecde4","line":218,"updated":"2018-05-07 13:00:12.000000000","message":"nit: instead of these 2 lines\n\n return self.BOOT_MODE_MAP_REV.get(hw_firmware_type)","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        hw_firmware_type \u003d getattr(image, \u0027hw_firmware_type\u0027, None)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if hw_firmware_type in self.BOOT_MODE_MAP_REV:"},{"line_number":218,"context_line":"            return self.BOOT_MODE_MAP_REV[hw_firmware_type]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def set_boot_mode(self, identity, boot_mode):"},{"line_number":221,"context_line":"        \"\"\"Set computer system boot mode."}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_34b3ae4f","line":218,"in_reply_to":"5f7c97a3_537ecde4","updated":"2018-05-10 10:31:00.000000000","message":"Done","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self._get_instance(identity)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        msg \u003d (\u0027The cloud driver %(driver)s does not allow changing boot \u0027"},{"line_number":233,"context_line":"               \u0027mode through Redfish\u0027 % {\u0027driver\u0027: self.driver})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        raise FishyError(msg)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_f38279c8","line":233,"updated":"2018-05-07 13:00:12.000000000","message":"/me sadpanda","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self._get_instance(identity)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        msg \u003d (\u0027The cloud driver %(driver)s does not allow changing boot \u0027"},{"line_number":233,"context_line":"               \u0027mode through Redfish\u0027 % {\u0027driver\u0027: self.driver})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        raise FishyError(msg)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_d4611aab","line":233,"in_reply_to":"5f7c97a3_f38279c8","updated":"2018-05-10 10:31:00.000000000","message":"May be we could emulate boot mode by choosing Glance image based on `hw_firmware_type`? Too much magic...\n\nOr pass the emulator legacy and uefi image IDs explicitly to let it represent boot mode my flipping between those two images...?\n\nAt any rate, I\u0027d do anything like that as a follow up patch.","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f49cc93fcd274f5b822e0960c046986c55db31fd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":184,"context_line":"                        type\u003dstr,"},{"line_number":185,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":186,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":187,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":188,"context_line":"                        type\u003dint,"},{"line_number":189,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf659307_7e7097dd","line":186,"updated":"2018-04-05 11:27:52.000000000","message":"please split out this change","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0d0bbe6b2162728f80f259394a7e089f0dc45e84","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":184,"context_line":"                        type\u003dstr,"},{"line_number":185,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":186,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":187,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":188,"context_line":"                        type\u003dint,"},{"line_number":189,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf659307_7a4723be","line":186,"in_reply_to":"bf659307_7e7097dd","updated":"2018-04-06 18:00:59.000000000","message":"Moved over here https://review.openstack.org/559388","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        ssl_context \u003d ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)"},{"line_number":233,"context_line":"        ssl_context.load_cert_chain(args.ssl_certificate, args.ssl_key)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    app.run(host\u003d\u0027\u0027, port\u003dargs.port, ssl_context\u003dssl_context)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    return 0"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_931ea5b8","line":235,"updated":"2018-05-07 13:00:12.000000000","message":"unrelated change? this is worth a separate commit message with the explanation","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        ssl_context \u003d ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)"},{"line_number":233,"context_line":"        ssl_context.load_cert_chain(args.ssl_certificate, args.ssl_key)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    app.run(host\u003d\u0027\u0027, port\u003dargs.port, ssl_context\u003dssl_context)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    return 0"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_54a42aa6","line":235,"in_reply_to":"5f7c97a3_931ea5b8","updated":"2018-05-10 10:31:00.000000000","message":"Done","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":241,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_3379d1fb","line":241,"updated":"2018-05-07 13:00:12.000000000","message":"unrelated change, please propose separately?","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":241,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_34a72eaa","line":241,"in_reply_to":"5f7c97a3_3379d1fb","updated":"2018-05-10 10:31:00.000000000","message":"https://review.openstack.org/567541","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2b2bd39440b44eb3c1b8d40430f1d8e43ad2850a","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    app.run(host\u003d\u0027127.0.0.1\u0027, port\u003dargs.port, ssl_context\u003dssl_context)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    return 0"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_cfbf25a8","line":237,"updated":"2018-05-11 14:45:12.000000000","message":"Seems like https://review.openstack.org/#/c/567541/ might not mesh with this... Likely going to turn into a merge error... maybe.","commit_id":"89ccd646a75c930d5076071418afda85ec3ac143"}],"sushy_tools/static/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f49cc93fcd274f5b822e0960c046986c55db31fd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":76,"context_line":"                        type\u003dstr,"},{"line_number":77,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":78,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":79,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":80,"context_line":"                        type\u003dint,"},{"line_number":81,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf659307_1e75dbcc","line":78,"updated":"2018-04-05 11:27:52.000000000","message":"ditto","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0d0bbe6b2162728f80f259394a7e089f0dc45e84","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":76,"context_line":"                        type\u003dstr,"},{"line_number":77,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":78,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":79,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":80,"context_line":"                        type\u003dint,"},{"line_number":81,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf659307_9a1d57bf","line":78,"in_reply_to":"bf659307_1e75dbcc","updated":"2018-04-06 18:00:59.000000000","message":"Moved over here https://review.openstack.org/559388","commit_id":"c8c682e4714f91d7810cf34559d91274c1009540"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6fa6184e1a04f0f0540a8dbf26d07c1a2b84b0e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":76,"context_line":"                        type\u003dstr,"},{"line_number":77,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":78,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":79,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":80,"context_line":"                        type\u003dint,"},{"line_number":81,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_138855e5","line":78,"updated":"2018-05-07 13:00:12.000000000","message":"unrelated change, again","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ad3a202a41846b9f078a19f1a087abd359a1134e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.add_argument(\u0027-i\u0027, \u0027--interface\u0027,"},{"line_number":76,"context_line":"                        type\u003dstr,"},{"line_number":77,"context_line":"                        default\u003d\u0027\u0027,"},{"line_number":78,"context_line":"                        help\u003d\u0027Local interface to listen at\u0027)"},{"line_number":79,"context_line":"    parser.add_argument(\u0027-p\u0027, \u0027--port\u0027,"},{"line_number":80,"context_line":"                        type\u003dint,"},{"line_number":81,"context_line":"                        default\u003d8000,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f7c97a3_ffe3cfd7","line":78,"in_reply_to":"5f7c97a3_138855e5","updated":"2018-05-10 10:31:00.000000000","message":"https://review.openstack.org/567549","commit_id":"ad52062ddcf7e25e6bb960449fd6da70b28ca958"}]}
