)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f2c82dc38406cc7a6d3fae8e73aeb0b8361a8e6c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean up unused items from templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The standard does not mandate most of the fields, so we don\u0027t have"},{"line_number":10,"context_line":"to provide fake values and links to non-existing resources."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I45e2701db1de2fd342083e46114a2d276417a632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_a7b6058a","line":10,"updated":"2018-05-18 15:55:15.000000000","message":"To me it feels like it is not really our goal to serve the bare minimum. Because the more we serve the more convincing we (as a mock) look and the more our clients could verify on their end.\n\nI do agree though that serving non-functional stuff like links to non-existing services is pointless, to say the least.\n\nTherefore, may be we would do better if we remove the things that we advertise but do not actually provide, still retaining all the items that we can model reasonably well.\n\nWDYT?","commit_id":"980edc52bf52128179e6e454899a9563eb71887b"}],"sushy_tools/emulator/templates/root.json":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f2c82dc38406cc7a6d3fae8e73aeb0b8361a8e6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"@odata.type\": \"#ServiceRoot.v1_0_2.ServiceRoot\","},{"line_number":3,"context_line":"    \"Id\": \"RedvirtService\","},{"line_number":4,"context_line":"    \"Name\": \"Redvirt Service\","},{"line_number":5,"context_line":"    \"RedfishVersion\": \"1.0.2\","}],"source_content_type":"application/json","patch_set":3,"id":"5f7c97a3_e704fd80","line":2,"updated":"2018-05-18 15:55:15.000000000","message":"nit: this schema seems to be quite old [1], would it make sense to update it within this patch?\n\n1. https://redfish.dmtf.org/schemas/ServiceRoot.v1_3_1.json","commit_id":"980edc52bf52128179e6e454899a9563eb71887b"}],"sushy_tools/emulator/templates/system.json":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f2c82dc38406cc7a6d3fae8e73aeb0b8361a8e6c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"@odata.type\": \"#ComputerSystem.v1_1_0.ComputerSystem\","},{"line_number":3,"context_line":"    \"Id\": \"{{ identity }}\","},{"line_number":4,"context_line":"    \"Name\": \"WebFrontEnd483\","},{"line_number":5,"context_line":"    \"SystemType\": \"Physical\","},{"line_number":6,"context_line":"    \"AssetTag\": \"Chicago-45Z-2381\","},{"line_number":7,"context_line":"    \"Manufacturer\": \"Contoso\","},{"line_number":8,"context_line":"    \"Model\": \"3500RX\","}],"source_content_type":"application/json","patch_set":3,"id":"5f7c97a3_8768a921","side":"PARENT","line":5,"updated":"2018-05-18 15:55:15.000000000","message":"Does it make sense to remove these static constants? They seem reasonably functional (e.g. unlike Actions pointing nowhere) and thus may help clients to test-run their  stuff. WDYT?","commit_id":"3e4724fff916415f054aac01fc81b66964822e42"}]}