)]}'
{"sushy_tools/emulator/drivers/novadriver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"071290086e08f620a1f41a4a0c1ae9c10274f008","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param identity: OpenStack instance name or ID"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: available RAM in GiB as `int` or `None` if total memory"},{"line_number":201,"context_line":"            count can\u0027t be determined"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dbdba77a","line":200,"updated":"2018-06-07 14:11:50.000000000","message":"btw I don\u0027t see how it can return None","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"303f4fb7a4ef31ac6eaa52b22ad9f52e8dfa3474","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param identity: OpenStack instance name or ID"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: available RAM in GiB as `int` or `None` if total memory"},{"line_number":201,"context_line":"            count can\u0027t be determined"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a7079718","line":200,"in_reply_to":"5f7c97a3_6c3f24b5","updated":"2018-06-08 10:41:02.000000000","message":"Sorry, but I still don\u0027t quite get how this function can return None. In theory - yes, but in practice you can only get a number out of it. If flavor is None, you\u0027ll raise an AttributeError","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e15aac1c02561138504f0eb178115d16d11129be","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param identity: OpenStack instance name or ID"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: available RAM in GiB as `int` or `None` if total memory"},{"line_number":201,"context_line":"            count can\u0027t be determined"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_27d94721","line":200,"in_reply_to":"5f7c97a3_a7079718","updated":"2018-06-08 11:14:17.000000000","message":"Are you looking at PS2? Here is what is there:\n\n       try:\n            flavor \u003d self._get_flavor(identity)\n\n        except FishyError:\n            return\n\n        return int(ceil(flavor.ram/1024.))","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5d1969dd1e7efe1a66d5995675eba7aa3c1dc349","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param identity: OpenStack instance name or ID"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: available RAM in GiB as `int` or `None` if total memory"},{"line_number":201,"context_line":"            count can\u0027t be determined"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6c3f24b5","line":200,"in_reply_to":"5f7c97a3_dbdba77a","updated":"2018-06-08 10:04:01.000000000","message":"Actually, Redfish schema suggests to return `null` if we can\u0027t provide reasonable data. So I wrapped potentially failing calls into try/except.","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"071290086e08f620a1f41a4a0c1ae9c10274f008","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return math.ceil(flavor.ram / 1024.)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_total_cpus(self, identity):"},{"line_number":208,"context_line":"        \"\"\"Get computer system total count of available CPUs"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fbd6a353","line":205,"updated":"2018-06-07 14:11:50.000000000","message":"math.ceil returns float, is it intended? I suspect you still need to wrap it in int()","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5d1969dd1e7efe1a66d5995675eba7aa3c1dc349","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        flavor \u003d self._get_flavor(identity)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return math.ceil(flavor.ram / 1024.)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_total_cpus(self, identity):"},{"line_number":208,"context_line":"        \"\"\"Get computer system total count of available CPUs"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8cbf20fb","line":205,"in_reply_to":"5f7c97a3_fbd6a353","updated":"2018-06-08 10:04:01.000000000","message":"Ah, it\u0027s `int` in Py3 and `float` in Py2 (which is surprising since `ceil()` always returns the whole number, right?).\n\nWrapped with the `int` cast anyway.","commit_id":"5d11c3efd8bd0296cbd1d467dc44ebd39c3bce8c"}]}