)]}'
{"sushy_tools/emulator/drivers/novadriver.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"57710273386d6e6f0069bc340b6bb5a428437255","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def get_bios(self, identity):"},{"line_number":277,"context_line":"        \"\"\"Not supported as Openstack SDK does not expose API for BIOS\"\"\""},{"line_number":278,"context_line":"        raise NotImplementedError(\u0027No Such Thing as a Fish!\u0027)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def set_bios(self, identity, attributes):"},{"line_number":281,"context_line":"        \"\"\"Not supported as Openstack SDK does not expose API for BIOS\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_85156540","line":278,"updated":"2018-07-31 16:26:12.000000000","message":"+1 :)","commit_id":"43d667cd238db1a180f17068257da44b7ce5e023"}],"sushy_tools/tests/unit/emulator/test_libvirt.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    reload_module(sys.modules[\u0027sushy_tools.emulator.drivers.libvirtdriver\u0027])"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class LibvirtDriverTestCase(base.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        self.test_driver \u003d LibvirtDriver()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b0776107","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":27},"updated":"2018-11-10 18:42:36.000000000","message":"looks like this is missing test for method `uuid`","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        power_state \u003d self.test_driver.get_power_state(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @mock.patch(\u0027libvirt.open\u0027, autospec\u003dTrue)"},{"line_number":52,"context_line":"    def test_set_power_state_on(self, libvirt_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_707d49e3","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":29},"updated":"2018-11-10 18:42:36.000000000","message":"maybe add another test case for isActive \u003d false?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @mock.patch(\u0027libvirt.open\u0027, autospec\u003dTrue)"},{"line_number":52,"context_line":"    def test_set_power_state_on(self, libvirt_mock):"},{"line_number":53,"context_line":"        conn_mock \u003d libvirt_mock.return_value"},{"line_number":54,"context_line":"        domain_mock \u003d conn_mock.lookupByName.return_value"},{"line_number":55,"context_line":"        domain_mock.isActive.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_30635147","line":52,"updated":"2018-11-10 18:42:36.000000000","message":"could add another test for \u0027ForceOn\u0027 case which was covered in test_main.py","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.assertEqual(1, memory)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @mock.patch(\u0027libvirt.openReadOnly\u0027, autospec\u003dTrue)"},{"line_number":174,"context_line":"    def test_get_total_cpus(self, libvirt_mock):"},{"line_number":175,"context_line":"        conn_mock \u003d libvirt_mock.return_value"},{"line_number":176,"context_line":"        domain_mock \u003d conn_mock.lookupByName.return_value"},{"line_number":177,"context_line":"        domain_mock.isActive.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_905d857d","line":174,"updated":"2018-11-10 18:42:36.000000000","message":"should add another test case for scenario where \u0027total_cpus \u003c\u003d 0\u0027","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"}],"sushy_tools/tests/unit/emulator/test_main.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class EmulatorTestCase(base.BaseTestCase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        main.driver \u003d None"},{"line_number":24,"context_line":"        self.app \u003d main.app.test_client()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        super(EmulatorTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_70d78922","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":26},"updated":"2018-11-10 18:42:36.000000000","message":"this is not necessary anymore as driver is patched, but should there be a test for `init_virt_driver` decorator?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.assertEqual(200, response.status_code)"},{"line_number":31,"context_line":"        self.assertEqual(\u0027RedvirtService\u0027, response.json[\u0027Id\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_collection_resource(self, driver_mock):"},{"line_number":34,"context_line":"        type(driver_mock).systems \u003d mock.PropertyMock("},{"line_number":35,"context_line":"            return_value\u003d[\u0027host0\u0027, \u0027host1\u0027])"},{"line_number":36,"context_line":"        response \u003d self.app.get(\u0027/redfish/v1/Systems\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f0bb99da","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":32},"updated":"2018-11-10 18:42:36.000000000","message":"should name this `test_system_collection_resource` to correspond to method name `system_collection_resource`","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual("},{"line_number":63,"context_line":"            \u0027Legacy\u0027, response.json[\u0027Boot\u0027][\u0027BootSourceOverrideMode\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_system_resource_patch(self, driver_mock):"},{"line_number":66,"context_line":"        data \u003d {\u0027Boot\u0027: {\u0027BootSourceOverrideTarget\u0027: \u0027Cd\u0027}}"},{"line_number":67,"context_line":"        response \u003d self.app.patch(\u0027/redfish/v1/Systems/xxxx-yyyy-zzzz\u0027,"},{"line_number":68,"context_line":"                                  json\u003ddata)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_10cc1560","line":65,"updated":"2018-11-10 18:42:36.000000000","message":"should add other tests where trying to patch other than \u0027Boot\u0027 to cover all paths of PATCH case and other paths related to `mode` and `target`?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        set_power_state \u003d driver_mock.set_power_state"},{"line_number":89,"context_line":"        set_power_state.assert_called_once_with(\u0027xxxx-yyyy-zzzz\u0027, \u0027ForceOn\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_system_reset_action_forceoff(self, driver_mock):"},{"line_number":92,"context_line":"        data \u003d {\u0027ResetType\u0027: \u0027ForceOff\u0027}"},{"line_number":93,"context_line":"        response \u003d self.app.post("},{"line_number":94,"context_line":"            \u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/Actions/ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d0ea1d9f","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":61},"updated":"2018-11-10 18:42:36.000000000","message":"Don\u0027t think this test is necessary in test_main as it tests the same path as previous test `test_system_reset_action_forceon`","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        set_power_state \u003d driver_mock.set_power_state"},{"line_number":98,"context_line":"        set_power_state.assert_called_once_with(\u0027xxxx-yyyy-zzzz\u0027, \u0027ForceOff\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_system_reset_action_shutdown(self, driver_mock):"},{"line_number":101,"context_line":"        data \u003d {\u0027ResetType\u0027: \u0027GracefulShutdown\u0027}"},{"line_number":102,"context_line":"        response \u003d self.app.post("},{"line_number":103,"context_line":"            \u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/Actions/ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f0e5d9cf","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":61},"updated":"2018-11-10 18:42:36.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        set_power_state.assert_called_once_with("},{"line_number":108,"context_line":"            \u0027xxxx-yyyy-zzzz\u0027, \u0027GracefulShutdown\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_system_reset_action_restart(self, driver_mock):"},{"line_number":111,"context_line":"        data \u003d {\u0027ResetType\u0027: \u0027GracefulRestart\u0027}"},{"line_number":112,"context_line":"        response \u003d self.app.post("},{"line_number":113,"context_line":"            \u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/Actions/ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9026e521","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":60},"updated":"2018-11-10 18:42:36.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        set_power_state.assert_called_once_with("},{"line_number":118,"context_line":"            \u0027xxxx-yyyy-zzzz\u0027, \u0027GracefulRestart\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_system_reset_action_forcerestart(self, driver_mock):"},{"line_number":121,"context_line":"        data \u003d {\u0027ResetType\u0027: \u0027ForceRestart\u0027}"},{"line_number":122,"context_line":"        response \u003d self.app.post("},{"line_number":123,"context_line":"            \u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/Actions/ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_502ccdfe","line":120,"range":{"start_line":120,"start_character":4,"end_line":120,"end_character":65},"updated":"2018-11-10 18:42:36.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        set_power_state.assert_called_once_with("},{"line_number":128,"context_line":"            \u0027xxxx-yyyy-zzzz\u0027, \u0027ForceRestart\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_system_reset_action_nmi(self, driver_mock):"},{"line_number":131,"context_line":"        data \u003d {\u0027ResetType\u0027: \u0027Nmi\u0027}"},{"line_number":132,"context_line":"        response \u003d self.app.post("},{"line_number":133,"context_line":"            \u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/Actions/ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_702f89f3","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":56},"updated":"2018-11-10 18:42:36.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        set_power_state \u003d driver_mock.set_power_state"},{"line_number":137,"context_line":"        set_power_state.assert_called_once_with(\u0027xxxx-yyyy-zzzz\u0027, \u0027Nmi\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_bios(self, driver_mock):"},{"line_number":140,"context_line":"        driver_mock.get_bios.return_value \u003d {\"attribute 1\": \"value 1\","},{"line_number":141,"context_line":"                                             \"attribute 2\": \"value 2\"}"},{"line_number":142,"context_line":"        response \u003d self.app.get(\u0027/redfish/v1/Systems/xxxx-yyyy-zzzz/BIOS\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_30359143","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":21},"updated":"2018-11-10 18:42:36.000000000","message":"this should be `test_bios_get` to have the same naming convention as `test_system_resource_get`","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                          \"attribute 2\": \"value 2\"},"},{"line_number":148,"context_line":"                         response.json[\u0027Attributes\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_get_bios_existing(self, driver_mock):"},{"line_number":151,"context_line":"        driver_mock.get_bios.return_value \u003d {\"attribute 1\": \"value 1\","},{"line_number":152,"context_line":"                                             \"attribute 2\": \"value 2\"}"},{"line_number":153,"context_line":"        response \u003d self.app.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f03ab92f","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":30},"updated":"2018-11-10 18:42:36.000000000","message":"similar to `system_reset_action` this is not necessary anymore as it does not test any new path at main.py (should be covered at driver tests)","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.assertEqual(204, response.status_code)"},{"line_number":181,"context_line":"        driver_mock.set_bios.assert_called_once_with("},{"line_number":182,"context_line":"            \u0027xxxx-yyyy-zzzz\u0027, data[\u0027Attributes\u0027])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_reset_bios(self, driver_mock):"},{"line_number":185,"context_line":"        self.app.driver \u003d driver_mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_301ef1bb","line":182,"range":{"start_line":182,"start_character":30,"end_line":182,"end_character":48},"updated":"2018-11-10 18:42:36.000000000","message":"is this or both tests necessary? What\u0027s the difference from `test_bios_settings_patch`?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"}],"sushy_tools/tests/unit/emulator/test_nova.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@mock.patch(\u0027openstack.connect\u0027, autospec\u003dTrue)"},{"line_number":32,"context_line":"class NovaDriverTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_systems(self, nova_mock):"},{"line_number":35,"context_line":"        server0 \u003d mock.Mock(id\u003d\u0027host0\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_304cb1c7","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":24},"updated":"2018-11-10 18:42:36.000000000","message":"missing test for method `uuid`?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@mock.patch(\u0027openstack.connect\u0027, autospec\u003dTrue)"},{"line_number":32,"context_line":"class NovaDriverTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_systems(self, nova_mock):"},{"line_number":35,"context_line":"        server0 \u003d mock.Mock(id\u003d\u0027host0\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_43315058","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":24},"in_reply_to":"3f79a3b5_304cb1c7","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        server1 \u003d mock.Mock(id\u003d\u0027host1\u0027)"},{"line_number":37,"context_line":"        nova_mock.return_value.list_servers.return_value \u003d [server0, server1]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":40,"context_line":"        systems \u003d test_driver.systems"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertEqual([\u0027host0\u0027, \u0027host1\u0027], systems)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ae1372b0","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":51},"updated":"2018-11-12 19:40:37.000000000","message":"here and all the other nova tests - can move this to setUp method and use self.test_driver to avoid repeating this in every test (as already in libvirt tests)","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        server1 \u003d mock.Mock(id\u003d\u0027host1\u0027)"},{"line_number":37,"context_line":"        nova_mock.return_value.list_servers.return_value \u003d [server0, server1]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":40,"context_line":"        systems \u003d test_driver.systems"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertEqual([\u0027host0\u0027, \u0027host1\u0027], systems)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e31e5cbc","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":51},"in_reply_to":"3f79a3b5_ae1372b0","updated":"2018-11-13 08:13:17.000000000","message":"Actually, I tried, but it did not work well with mocking for some reason. So I ended up leaving it as-is.\n\nLet me take a look at this again...","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"64738ad449521be67981413a5465914b30c58e2a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        server1 \u003d mock.Mock(id\u003d\u0027host1\u0027)"},{"line_number":37,"context_line":"        nova_mock.return_value.list_servers.return_value \u003d [server0, server1]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":40,"context_line":"        systems \u003d test_driver.systems"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertEqual([\u0027host0\u0027, \u0027host1\u0027], systems)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8598c57c","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":51},"in_reply_to":"3f79a3b5_e31e5cbc","updated":"2018-11-13 15:54:51.000000000","message":"Moved to setup/teardown.","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":50,"context_line":"        power_state \u003d test_driver.get_power_state(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_set_power_state_on(self, nova_mock):"},{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d0469da8","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":29},"updated":"2018-11-10 18:42:36.000000000","message":"could add another test case for \u0027Off\u0027 scenario?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":50,"context_line":"        power_state \u003d test_driver.get_power_state(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_set_power_state_on(self, nova_mock):"},{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_838be814","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":29},"in_reply_to":"3f79a3b5_d0469da8","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"fc0285057930ca2fd80d417d86c1cc47b87b1e31","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_set_power_state_on(self, nova_mock):"},{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":56,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027On\u0027)"},{"line_number":57,"context_line":"        server \u003d nova_mock.return_value"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f041598f","line":54,"updated":"2018-11-10 18:42:36.000000000","message":"another test case for ForceOn?","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(\u0027On\u0027, power_state)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_set_power_state_on(self, nova_mock):"},{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":56,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027On\u0027)"},{"line_number":57,"context_line":"        server \u003d nova_mock.return_value"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a36e2463","line":54,"in_reply_to":"3f79a3b5_f041598f","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":56,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027On\u0027)"},{"line_number":57,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":58,"context_line":"        server.compute.start_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_set_power_state_forceoff(self, nova_mock):"},{"line_number":61,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cecb4e48","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":70},"updated":"2018-11-12 19:40:37.000000000","message":"here and below, this is not asserting anything - this is magic mock and it can be anything, but `called_once_with` is not the assert method; \ntry to fail the test changing \u0027On\u0027 to \u0027ForceOff\u0027 - the test still passes.","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":56,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027On\u0027)"},{"line_number":57,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":58,"context_line":"        server.compute.start_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_set_power_state_forceoff(self, nova_mock):"},{"line_number":61,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a395c440","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":70},"in_reply_to":"3f79a3b5_cecb4e48","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":62,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027ForceOff\u0027)"},{"line_number":63,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":64,"context_line":"        server.compute.stop_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_set_power_state_gracefulshutdown(self, nova_mock):"},{"line_number":67,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aee5b2d0","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":69},"updated":"2018-11-12 19:40:37.000000000","message":"ditto + need to mock instance.power_state \u003d\u003d \u0027on\u0027 to get this actually called - at the moment this is not covered at all and the test incorrectly passes.","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":62,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027ForceOff\u0027)"},{"line_number":63,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":64,"context_line":"        server.compute.stop_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_set_power_state_gracefulshutdown(self, nova_mock):"},{"line_number":67,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c3bd60d2","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":69},"in_reply_to":"3f79a3b5_aee5b2d0","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":68,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027GracefulShutdown\u0027)"},{"line_number":69,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":70,"context_line":"        server.compute.start_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_set_power_state_gracefulrestart(self, nova_mock):"},{"line_number":73,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4e265e24","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":70},"updated":"2018-11-12 19:40:37.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":68,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027GracefulShutdown\u0027)"},{"line_number":69,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":70,"context_line":"        server.compute.start_server.called_once_with(\u0027zzzz-yyyy-xxxx\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_set_power_state_gracefulrestart(self, nova_mock):"},{"line_number":73,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_63980c7c","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":70},"in_reply_to":"3f79a3b5_4e265e24","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":74,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027GracefulRestart\u0027)"},{"line_number":75,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":76,"context_line":"        server.compute.reboot_server.called_once_with("},{"line_number":77,"context_line":"            \u0027zzzz-yyyy-xxxx\u0027, reboot_type\u003d\u0027SOFT\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_set_power_state_forcerestart(self, nova_mock):"},{"line_number":80,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6e29daee","line":77,"range":{"start_line":76,"start_character":8,"end_line":77,"end_character":49},"updated":"2018-11-12 19:40:37.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0aca7a2dce7ebd2658e97400e2c2078b7ed35987","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":81,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027ForceRestart\u0027)"},{"line_number":82,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":83,"context_line":"        server.compute.reboot_server.called_once_with("},{"line_number":84,"context_line":"            \u0027zzzz-yyyy-xxxx\u0027, reboot_type\u003d\u0027HARD\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_get_boot_device(self, nova_mock):"},{"line_number":87,"context_line":"        server \u003d mock.Mock(id\u003d\u0027zzzz-yyyy-xxxx\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0e2ce6fd","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":49},"updated":"2018-11-12 19:40:37.000000000","message":"ditto","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"564854f6feeebbfba170fa13a8d56c79ae9077fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        test_driver \u003d OpenStackDriver(\u0027fake-cloud\u0027)"},{"line_number":81,"context_line":"        test_driver.set_power_state(\u0027zzzz-yyyy-xxxx\u0027, \u0027ForceRestart\u0027)"},{"line_number":82,"context_line":"        server \u003d nova_mock.return_value"},{"line_number":83,"context_line":"        server.compute.reboot_server.called_once_with("},{"line_number":84,"context_line":"            \u0027zzzz-yyyy-xxxx\u0027, reboot_type\u003d\u0027HARD\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_get_boot_device(self, nova_mock):"},{"line_number":87,"context_line":"        server \u003d mock.Mock(id\u003d\u0027zzzz-yyyy-xxxx\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_839d286d","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":49},"in_reply_to":"3f79a3b5_0e2ce6fd","updated":"2018-11-13 08:13:17.000000000","message":"Done","commit_id":"86aa983af6fac674681074b97c73d822601b14f7"}]}
