)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b8f7812178f29ff8b15fec152c5b5eeb04f0183","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   configuration"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Then create \u003cos\u003e\u003cloader\u003e element. If boot loader path is"},{"line_number":18,"context_line":"empty, then remove \u003cos\u003e\u003cloader\u003e element if it was present."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The rationale is to ensure well-formed domain configuration"},{"line_number":21,"context_line":"upon boot mode change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_cd7f2e13","line":18,"updated":"2019-03-13 09:43:29.000000000","message":"God, I hate libvirt :)","commit_id":"319808c983f80999b37422fa8d8f8cc736b8abba"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e0041c6bc4eda53e0a25576f434e49750f69637d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   configuration"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Then create \u003cos\u003e\u003cloader\u003e element. If boot loader path is"},{"line_number":18,"context_line":"empty, then remove \u003cos\u003e\u003cloader\u003e element if it was present."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The rationale is to ensure well-formed domain configuration"},{"line_number":21,"context_line":"upon boot mode change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_9c264a15","line":18,"in_reply_to":"5fc1f717_cd7f2e13","updated":"2019-04-18 08:40:45.000000000","message":"Blame Hugh ;)","commit_id":"319808c983f80999b37422fa8d8f8cc736b8abba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b8f7812178f29ff8b15fec152c5b5eeb04f0183","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Then create \u003cos\u003e\u003cloader\u003e element. If boot loader path is"},{"line_number":18,"context_line":"empty, then remove \u003cos\u003e\u003cloader\u003e element if it was present."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The rationale is to ensure well-formed domain configuration"},{"line_number":21,"context_line":"upon boot mode change."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_ed7c6a20","line":19,"updated":"2019-03-13 09:43:29.000000000","message":"Let\u0027s mention the added \"readonly\" flag and why it\u0027s needed.","commit_id":"319808c983f80999b37422fa8d8f8cc736b8abba"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e0041c6bc4eda53e0a25576f434e49750f69637d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Then create \u003cos\u003e\u003cloader\u003e element. If boot loader path is"},{"line_number":18,"context_line":"empty, then remove \u003cos\u003e\u003cloader\u003e element if it was present."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The rationale is to ensure well-formed domain configuration"},{"line_number":21,"context_line":"upon boot mode change."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_f7f527ee","line":19,"in_reply_to":"5fc1f717_ed7c6a20","updated":"2019-04-18 08:40:45.000000000","message":"This is something very private to libvirt. Done.","commit_id":"319808c983f80999b37422fa8d8f8cc736b8abba"}],"sushy_tools/emulator/drivers/libvirtdriver.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8a0bf3b098ef73574fd178fd158cb093e14c0044","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            loader_path \u003d None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fce034c_9464c823","line":363,"range":{"start_line":363,"start_character":32,"end_line":363,"end_character":33},"updated":"2019-04-19 08:28:15.000000000","message":"maybe change to !\u003d","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6584c115d8338a4d7522384be79d9980e1762cf2","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            loader_path \u003d None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_c1875dd7","line":363,"range":{"start_line":363,"start_character":32,"end_line":363,"end_character":33},"in_reply_to":"3fce034c_9464c823","updated":"2019-04-23 11:23:46.000000000","message":"\u003e maybe change to !\u003d\n\nThere should be just zero or one `loader` element, but I do not think this is enforced at the definition time. libvirt may fail later, I am not sure.\n\nTherefore I\u0027m trying to be cautious and do not touch XML if it does not look good before our changes.","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cfe94acb18cdd789c12ac78e5277a9df0483e4b2","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            loader_path \u003d None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_da60b135","line":363,"range":{"start_line":363,"start_character":32,"end_line":363,"end_character":33},"in_reply_to":"3fce034c_9464c823","updated":"2019-04-23 03:44:34.000000000","message":"There would be no loader element for bios booting.","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6584c115d8338a4d7522384be79d9980e1762cf2","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            loader_path \u003d None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_61555150","line":363,"range":{"start_line":363,"start_character":32,"end_line":363,"end_character":33},"in_reply_to":"ffb9cba7_01d7b54d","updated":"2019-04-23 11:23:46.000000000","message":"Zero or one `loader` it is!","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"76f2422ffafb6c9f32a928f8510a0ceb7c53f4ab","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            loader_path \u003d None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_01d7b54d","line":363,"range":{"start_line":363,"start_character":32,"end_line":363,"end_character":33},"in_reply_to":"ffb9cba7_da60b135","updated":"2019-04-23 11:06:26.000000000","message":"shouldn\u0027t the loader element be only one ?\nmaybe I\u0027m confusing with something else....","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8a0bf3b098ef73574fd178fd158cb093e14c0044","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"},{"line_number":367,"context_line":"            raise error.FishyError(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fce034c_746fdcfb","line":364,"range":{"start_line":364,"start_character":71,"end_line":364,"end_character":74},"updated":"2019-04-19 08:28:15.000000000","message":"nit: missing blank space","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6584c115d8338a4d7522384be79d9980e1762cf2","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        loader_elements \u003d os_element.findall(\u0027loader\u0027)"},{"line_number":363,"context_line":"        if len(loader_elements) \u003e 1:"},{"line_number":364,"context_line":"            msg \u003d (\u0027Can\\\u0027t set boot mode because \"loader\" element must be\u0027"},{"line_number":365,"context_line":"                   \u0027present exactly once in domain \"%(identity)s\" \u0027"},{"line_number":366,"context_line":"                   \u0027configuration\u0027 % {\u0027identity\u0027: identity})"},{"line_number":367,"context_line":"            raise error.FishyError(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_c1d51dbb","line":364,"range":{"start_line":364,"start_character":71,"end_line":364,"end_character":74},"in_reply_to":"3fce034c_746fdcfb","updated":"2019-04-23 11:23:46.000000000","message":"Done","commit_id":"13cbfa692720ed9597401784fd317afb7e2aad84"}]}