)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"efe0c0d3f50d30bc468aed68455185652a9c4523","unresolved":false,"context_lines":[{"line_number":11,"context_line":"may change PUT/POST to GET on redirect and effectively fail"},{"line_number":12,"context_line":"to perform the change they intended."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/#/c/642830/"},{"line_number":15,"context_line":"Change-Id: I32613e1ebb4a2eaba33c5884ddbd3ec7cf77d6fd"},{"line_number":16,"context_line":"Story: 2005370"},{"line_number":17,"context_line":"Task: 30346"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_2af498f0","line":14,"updated":"2019-04-08 09:04:36.000000000","message":"This dependency doesn\u0027t seem needed (and will delay landing this patch)","commit_id":"62acf2bd280fd7a04f0713043b71ba732f301206"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c134943a1a4f82d45f0134033503108b98024146","unresolved":false,"context_lines":[{"line_number":11,"context_line":"may change PUT/POST to GET on redirect and effectively fail"},{"line_number":12,"context_line":"to perform the change they intended."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/#/c/642830/"},{"line_number":15,"context_line":"Change-Id: I32613e1ebb4a2eaba33c5884ddbd3ec7cf77d6fd"},{"line_number":16,"context_line":"Story: 2005370"},{"line_number":17,"context_line":"Task: 30346"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_0ab2fc06","line":14,"in_reply_to":"5fc1f717_2af498f0","updated":"2019-04-08 09:12:25.000000000","message":"Without this dependency the deployment process runs into the other bug(s) thus rendering this fix harder to test and use even before it\u0027s merged...","commit_id":"62acf2bd280fd7a04f0713043b71ba732f301206"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"efe0c0d3f50d30bc468aed68455185652a9c4523","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def all_exception_handler(message):"},{"line_number":127,"context_line":"    if isinstance(message, error.AliasAccessError):"},{"line_number":128,"context_line":"        url \u003d flask.url_for(flask.request.endpoint, identity\u003dmessage.args[0])"},{"line_number":129,"context_line":"        return flask.redirect(url, code\u003d307, Response\u003dflask.Response)"},{"line_number":130,"context_line":"    return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 500"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_cadcf475","line":129,"updated":"2019-04-08 09:04:36.000000000","message":"It\u0027s an interesting question whether it should be 307 or 308.. I guess a temporary redirect does make sense.","commit_id":"62acf2bd280fd7a04f0713043b71ba732f301206"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c134943a1a4f82d45f0134033503108b98024146","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def all_exception_handler(message):"},{"line_number":127,"context_line":"    if isinstance(message, error.AliasAccessError):"},{"line_number":128,"context_line":"        url \u003d flask.url_for(flask.request.endpoint, identity\u003dmessage.args[0])"},{"line_number":129,"context_line":"        return flask.redirect(url, code\u003d307, Response\u003dflask.Response)"},{"line_number":130,"context_line":"    return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 500"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ea91b053","line":129,"in_reply_to":"5fc1f717_cadcf475","updated":"2019-04-08 09:12:25.000000000","message":"Given that node names can change, as well as UUIDs of the libvirt domains, 307 feels more reliable...","commit_id":"62acf2bd280fd7a04f0713043b71ba732f301206"}]}
