)]}'
{"sushy_tools/emulator/resources/chassis/staticdriver.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ec998f9816180a012955b0b58f4a98675013fb47","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            ]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._chassis_by_position \u003d ["},{"line_number":42,"context_line":"            x[\u0027UUID\u0027] for x in chassis"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        self._chassis_by_uuid \u003d {"},{"line_number":45,"context_line":"            x[\u0027UUID\u0027]: x for x in chassis if \u0027UUID\u0027 in x"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_51073f83","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":19},"updated":"2019-05-28 10:11:14.000000000","message":"shouldn\u0027t this be \u0027Id\u0027 ?","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7e1a23ee7d3bf6bcef248cfb191efe222eac3a73","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            ]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._chassis_by_position \u003d ["},{"line_number":42,"context_line":"            x[\u0027UUID\u0027] for x in chassis"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        self._chassis_by_uuid \u003d {"},{"line_number":45,"context_line":"            x[\u0027UUID\u0027]: x for x in chassis if \u0027UUID\u0027 in x"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_3111f954","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":19},"in_reply_to":"9fb8cfa7_c4c0aa2d","updated":"2019-06-18 10:06:47.000000000","message":"Done","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e0ef06e6c5fc85578302a6a36e10561ce6af4cc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            ]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._chassis_by_position \u003d ["},{"line_number":42,"context_line":"            x[\u0027UUID\u0027] for x in chassis"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        self._chassis_by_uuid \u003d {"},{"line_number":45,"context_line":"            x[\u0027UUID\u0027]: x for x in chassis if \u0027UUID\u0027 in x"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_c4c0aa2d","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":19},"in_reply_to":"bfb3d3c7_51073f83","updated":"2019-06-05 22:45:21.000000000","message":"++ Wondering the same","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7e1a23ee7d3bf6bcef248cfb191efe222eac3a73","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            ]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._chassis_by_position \u003d ["},{"line_number":42,"context_line":"            x[\u0027UUID\u0027] for x in chassis"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        self._chassis_by_uuid \u003d {"},{"line_number":45,"context_line":"            x[\u0027UUID\u0027]: x for x in chassis if \u0027UUID\u0027 in x"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_7107711a","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":19},"in_reply_to":"bfb3d3c7_51073f83","updated":"2019-06-18 10:06:47.000000000","message":"Well, right, I\u0027ve reworked this into by-Id index.","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ec998f9816180a012955b0b58f4a98675013fb47","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if len(self._chassis_by_uuid) !\u003d len(chassis):"},{"line_number":52,"context_line":"            raise error.FishyError("},{"line_number":53,"context_line":"                \u0027Conflicting UUIDs in static chassis configuration\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_chassis(self, identity):"},{"line_number":56,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_b1ed5bb8","line":53,"updated":"2019-05-28 10:11:14.000000000","message":"what about reporting the UUIDs in the message ?","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7e1a23ee7d3bf6bcef248cfb191efe222eac3a73","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if len(self._chassis_by_uuid) !\u003d len(chassis):"},{"line_number":52,"context_line":"            raise error.FishyError("},{"line_number":53,"context_line":"                \u0027Conflicting UUIDs in static chassis configuration\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_chassis(self, identity):"},{"line_number":56,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_7120d19c","line":53,"in_reply_to":"9fb8cfa7_04c7a247","updated":"2019-06-18 10:06:47.000000000","message":"+1","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e0ef06e6c5fc85578302a6a36e10561ce6af4cc","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if len(self._chassis_by_uuid) !\u003d len(chassis):"},{"line_number":52,"context_line":"            raise error.FishyError("},{"line_number":53,"context_line":"                \u0027Conflicting UUIDs in static chassis configuration\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_chassis(self, identity):"},{"line_number":56,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_04c7a247","line":53,"in_reply_to":"bfb3d3c7_b1ed5bb8","updated":"2019-06-05 22:45:21.000000000","message":"It is just mocking, and as such I\u0027m wondering if it is really needed.","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7e1a23ee7d3bf6bcef248cfb191efe222eac3a73","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if len(self._chassis_by_uuid) !\u003d len(chassis):"},{"line_number":52,"context_line":"            raise error.FishyError("},{"line_number":53,"context_line":"                \u0027Conflicting UUIDs in static chassis configuration\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_chassis(self, identity):"},{"line_number":56,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_d12bbd7f","line":53,"in_reply_to":"bfb3d3c7_b1ed5bb8","updated":"2019-06-18 10:06:47.000000000","message":"This may be become a bit bulky code-wise so I am wondering if it\u0027s worth it...?","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"}],"sushy_tools/tests/unit/emulator/resources/chassis/test_static.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ec998f9816180a012955b0b58f4a98675013fb47","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.test_driver.managers \u003d managers_mock"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        super(StaticDriverTestCase, self).setUp()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test__get_chassis_by_name(self):"},{"line_number":68,"context_line":"        self.assertRaises("},{"line_number":69,"context_line":"            error.AliasAccessError, self.test_driver._get_chassis, self.name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_711a83cc","line":66,"updated":"2019-05-28 10:11:14.000000000","message":"let\u0027s add a test for _get_chassis_by_position","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7e1a23ee7d3bf6bcef248cfb191efe222eac3a73","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.test_driver.managers \u003d managers_mock"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        super(StaticDriverTestCase, self).setUp()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test__get_chassis_by_name(self):"},{"line_number":68,"context_line":"        self.assertRaises("},{"line_number":69,"context_line":"            error.AliasAccessError, self.test_driver._get_chassis, self.name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_113155ed","line":66,"in_reply_to":"bfb3d3c7_711a83cc","updated":"2019-06-18 10:06:47.000000000","message":"Done","commit_id":"0e2123d08eab59e35ae1eb57b4f67e90550ce658"}]}