)]}'
{"sushy_tools/emulator/resources/systems/libvirtdriver.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"edc417becb5768c446231ff6898b6a69564509ea","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                raise error.FishyError(msg)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        else:"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"            with libvirt_open(self._uri) as conn:"},{"line_number":846,"context_line":"                conn.defineXML(ET.tostring(domain_tree).decode(\u0027utf-8\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_bc9e5503","line":844,"updated":"2019-08-23 09:48:18.000000000","message":"nit: remove blank line","commit_id":"fb481f05749124555762c651b08198557997a171"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"61d37c1b5941d3d455b471bbffc579a1667df914","unresolved":false,"context_lines":[{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        else:"},{"line_number":844,"context_line":"            with libvirt_open(self._uri) as conn:"},{"line_number":845,"context_line":"                conn.defineXML(ET.tostring(domain_tree).decode(\u0027utf-8\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_c21cdf67","line":845,"updated":"2019-08-30 14:40:16.000000000","message":"Would it make sense to ditch the same thing at line #779 and make this call unconditional?","commit_id":"86af2253e28a972303fe5b8f999b6179347b5575"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2cf754feb4bbebd6cdf5766b6031beaca87f4744","unresolved":false,"context_lines":[{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        else:"},{"line_number":844,"context_line":"            with libvirt_open(self._uri) as conn:"},{"line_number":845,"context_line":"                conn.defineXML(ET.tostring(domain_tree).decode(\u0027utf-8\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_a6dcbb46","line":845,"in_reply_to":"7faddb67_c21cdf67","updated":"2019-09-09 09:47:17.000000000","message":"Done","commit_id":"86af2253e28a972303fe5b8f999b6179347b5575"}],"sushy_tools/emulator/resources/vmedia/staticdriver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"489e73998a47c642b7dc56cb779b7d44b5e303f1","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        device_info[\u0027WriteProtected\u0027] \u003d write_protected"},{"line_number":201,"context_line":"        device_info[\u0027_local_file_path\u0027] \u003d local_file_path"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self._devices.update("},{"line_number":204,"context_line":"            {(identity, device): device_info})"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        return local_file_path"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_94ebfb76","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":46},"updated":"2019-08-23 13:00:53.000000000","message":"nit:\n\n self._devices[(identity, device)] \u003d device_info","commit_id":"738ce6121a1ab240d6e2ed1d92c81fdeb6491ae1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"489e73998a47c642b7dc56cb779b7d44b5e303f1","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        device_info[\u0027WriteProtected\u0027] \u003d False"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        self._devices.update("},{"line_number":223,"context_line":"            {(identity, device): device_info})"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        local_file \u003d device_info.pop(\u0027_local_file\u0027, None)"},{"line_number":226,"context_line":"        if local_file:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_34000736","line":223,"updated":"2019-08-23 13:00:53.000000000","message":"ditto","commit_id":"738ce6121a1ab240d6e2ed1d92c81fdeb6491ae1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d16a1b3fbe43d4430b65b67a537d0cc184dfdb7a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        device_info[\u0027WriteProtected\u0027] \u003d False"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self._devices.update({(identity, device): device_info})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        local_file \u003d device_info.pop(\u0027_local_file\u0027, None)"},{"line_number":224,"context_line":"        if local_file:"},{"line_number":225,"context_line":"            os.unlink(local_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_30221aa5","line":222,"updated":"2019-08-27 18:20:12.000000000","message":"Great find, Thanks!","commit_id":"86af2253e28a972303fe5b8f999b6179347b5575"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"61d37c1b5941d3d455b471bbffc579a1667df914","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        device_info[\u0027WriteProtected\u0027] \u003d False"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self._devices.update({(identity, device): device_info})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        local_file \u003d device_info.pop(\u0027_local_file\u0027, None)"},{"line_number":224,"context_line":"        if local_file:"},{"line_number":225,"context_line":"            os.unlink(local_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_67a3bd44","line":222,"in_reply_to":"7faddb67_30221aa5","updated":"2019-08-30 14:40:16.000000000","message":"Ah, I just found this as well and pushed similar, though a bit more generic, patch... [1]\n\n1.. https://review.opendev.org/679456","commit_id":"86af2253e28a972303fe5b8f999b6179347b5575"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2cf754feb4bbebd6cdf5766b6031beaca87f4744","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        device_info[\u0027WriteProtected\u0027] \u003d False"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self._devices.update({(identity, device): device_info})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        local_file \u003d device_info.pop(\u0027_local_file\u0027, None)"},{"line_number":224,"context_line":"        if local_file:"},{"line_number":225,"context_line":"            os.unlink(local_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_86e3bf05","line":222,"in_reply_to":"7faddb67_67a3bd44","updated":"2019-09-09 09:47:17.000000000","message":"@Maël given we are approaching release cut, I\u0027ve rebased your patch and then refactored it moving unicode-related fixes to [1] entirely.\n\n1. https://review.opendev.org/679456","commit_id":"86af2253e28a972303fe5b8f999b6179347b5575"}]}
