)]}'
{"sushy_tools/emulator/resources/systems/libvirtdriver.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8e95762c439431fd9b69a19d655d734b1e64ddba","unresolved":true,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        tree \u003d ET.fromstring(domain.XMLDesc())"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        model \u003d tree.find(\u0027.//cpu/model\u0027).text"},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            vendor \u003d tree.find(\u0027.//cpu/vendor\u0027).text"},{"line_number":788,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4cc8c880_eab7472b","line":785,"updated":"2021-03-24 08:37:18.000000000","message":"what if the cpu model doesn\u0027t have a text entry because for example the fallback is forbid or because the cpu mode is host-passthrough?","commit_id":"64af19a9581ef71e79fb78c3da93a9795b368e55"},{"author":{"_account_id":33176,"name":"Francois Rigault","email":"rigault.francois@gmail.com","username":"frigo"},"change_message_id":"289a6cd787dbe9f7d039b8a20974d7d06438f3ba","unresolved":true,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        tree \u003d ET.fromstring(domain.XMLDesc())"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        model \u003d tree.find(\u0027.//cpu/model\u0027).text"},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            vendor \u003d tree.find(\u0027.//cpu/vendor\u0027).text"},{"line_number":788,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"92b20769_c072aa25","line":785,"in_reply_to":"4cc8c880_eab7472b","updated":"2021-03-24 11:48:38.000000000","message":"indeed, we need one more try catch then right? The existing code is broken already in that case?","commit_id":"64af19a9581ef71e79fb78c3da93a9795b368e55"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"66bac327920344dcbe4dc08fa7eedd90c4bc2b13","unresolved":true,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        tree \u003d ET.fromstring(domain.XMLDesc())"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        model \u003d tree.find(\u0027.//cpu/model\u0027).text"},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            vendor \u003d tree.find(\u0027.//cpu/vendor\u0027).text"},{"line_number":788,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ccd085d3_c930d13f","line":785,"in_reply_to":"92b20769_c072aa25","updated":"2021-03-24 14:00:01.000000000","message":"I guess it doesn\u0027t hurt to wrap that in try-except :)\nand yes, that was definitely overlooked at first","commit_id":"64af19a9581ef71e79fb78c3da93a9795b368e55"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c5925a5a1ee82dfe4fedef0e4753f5eb09078578","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        try:"},{"line_number":785,"context_line":"            model \u003d tree.find(\u0027.//cpu/model\u0027).text"},{"line_number":786,"context_line":"        except AttributeError:"},{"line_number":787,"context_line":"            model \u003d \u0027N/A\u0027"},{"line_number":788,"context_line":"        try:"},{"line_number":789,"context_line":"            vendor \u003d tree.find(\u0027.//cpu/vendor\u0027).text"},{"line_number":790,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"87377cca_c7be68b2","line":787,"updated":"2021-04-20 11:41:13.000000000","message":"Ideally we should omit such values instead of returning a meaningless constant. Doesn\u0027t matter much for sushy-tools.","commit_id":"6f7238135e2d0ebc78dbc3af357809c9438a1ac0"}]}