)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b6516a68ffe600b463b2433ce65feb82dd265139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af0ac262_88e2308b","updated":"2022-05-12 23:55:37.000000000","message":"Hey some feedback on this change would be appreciated before I polish it off","commit_id":"2164982b2cbec49f13b3a4156d6af541b1147f6a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"612b63c5d29d627c25f7f358bca07a278ac1d29d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"924c8b90_78dfb6df","updated":"2022-05-29 23:52:06.000000000","message":"It turns out that \u003cloader secure\u003d\u0027no\u0027/\u003e is not a mechanism to choose a non-secure firmware, and I\u0027m not the first to learn this the hard way[1].\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1929357","commit_id":"bd8c5b95333bdf4f27b8a168af8590f975b1f0fa"}],"sushy_tools/emulator/resources/systems/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3238462d85aa0c8ea2483533e6b2e20733027cae","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :raises: `FishyError` if boot device can\u0027t be set"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @abc.abstractmethod"},{"line_number":110,"context_line":"    def get_boot_mode(self, identity):"},{"line_number":111,"context_line":"        \"\"\"Get computer system boot mode."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"66279591_0f6d5e75","line":109,"updated":"2022-06-01 07:01:26.000000000","message":"Please don\u0027t, it\u0027s not required (not does the fake backend implement it)","commit_id":"b5f22be0f3045693d23343dfbd23fb2a6339d4d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3238462d85aa0c8ea2483533e6b2e20733027cae","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        raise error.NotSupportedError(\u0027Not implemented\u0027)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @abc.abstractmethod"},{"line_number":119,"context_line":"    def set_boot_mode(self, identity, boot_mode):"},{"line_number":120,"context_line":"        \"\"\"Set computer system boot mode."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d26ea7c3_b3a850e5","line":118,"updated":"2022-06-01 07:01:26.000000000","message":"ditto","commit_id":"b5f22be0f3045693d23343dfbd23fb2a6339d4d3"}],"sushy_tools/emulator/resources/systems/libvirtdriver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3238462d85aa0c8ea2483533e6b2e20733027cae","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            os_arch \u003d type_element.get(\u0027arch\u0027)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if \u0027firmware\u0027 in os_element.attrib and current_boot_mode \u003d\u003d identity:"},{"line_number":541,"context_line":"            # The boot mode has not changed and the automatic approach"},{"line_number":542,"context_line":"            # is already used, no change is required"},{"line_number":543,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"0048cd8e_069e5b92","line":540,"updated":"2022-06-01 07:01:26.000000000","message":"Not sure why you\u0027re comparing boot mode to identity...","commit_id":"b5f22be0f3045693d23343dfbd23fb2a6339d4d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3238462d85aa0c8ea2483533e6b2e20733027cae","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            loader_element.text \u003d loader_path"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        if boot_mode \u003d\u003d \u0027UEFI\u0027:"},{"line_number":572,"context_line":"            if loader_path and \u0027secboot\u0027 in loader_path:"},{"line_number":573,"context_line":"                loader_element.set(\u0027secure\u0027, \u0027yes\u0027)"},{"line_number":574,"context_line":"            else:"},{"line_number":575,"context_line":"                loader_element.set(\u0027secure\u0027, \u0027no\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df5167cc_81a55ce8","line":572,"updated":"2022-06-01 07:01:26.000000000","message":"I may not fully understand this code, but \"secboot\" in the load path does not imply that secure boot is enabled, only that it\u0027s supported.","commit_id":"b5f22be0f3045693d23343dfbd23fb2a6339d4d3"}]}