)]}'
{"id":"openstack%2Fsushy-tools~841653","triplet_id":"openstack%2Fsushy-tools~master~I586dc220f9a49b9ae2be2bf40939c321ad877751","project":"openstack/sushy-tools","branch":"master","topic":"secure_boot","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2022-06-08 02:55:12.000000000","reason":"Change was abandoned"},"23851":{"account":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"last_update":"2022-06-08 02:55:12.000000000","reason":"Change was abandoned"},"10239":{"account":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"last_update":"2022-06-01 07:01:26.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I586dc220f9a49b9ae2be2bf40939c321ad877751","subject":"Use libvirt automatic firmware for UEFI boot mode","status":"ABANDONED","created":"2022-05-12 23:53:47.000000000","updated":"2022-06-08 02:55:12.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fef01ce48a7b1fed626409c76c4ac96cfcccda38","_number":841653,"virtual_id_number":841653,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-05-31 03:01:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2022-06-01 07:01:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-12 23:55:37.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2022-05-12 23:55:37.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2022-05-13 00:52:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"56ed76e6dc3fd29e5fc5a94453efc2a52a9d4db6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-12 23:53:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b6516a68ffe600b463b2433ce65feb82dd265139","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-12 23:55:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c88748a33be9071700df366ac0e8737c71cbe6fb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-13 00:52:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a010ce935b3b4f6c9404a20d8dd51b10 : SUCCESS in 2m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/23005e2a687241f88438adfeb2989b91 : FAILURE in 3m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a873d86b05e84fa98e24d2ea7cc3e1ef : FAILURE in 3m 30s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/1b50f7ff66f546af8d2bd6423de7904d : FAILURE in 3m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2334b97f9a7d4422b77829724d324fb8 : SUCCESS in 5m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f05e0e0c63c044cb85354ed4a72c9a62 : SUCCESS in 3m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/856100c65f8246c783031ff154a6ad47 : FAILURE in 4m 01s\n- sushy-tools-tempest-bios-redfish-netboot https://zuul.opendev.org/t/openstack/build/996063f2a828409da1cf243b3a663126 : SUCCESS in 57m 12s\n- sushy-tools-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/f5c69f0ef9e845a6a27adb9b0961c83c : FAILURE in 25m 47s","accounts_in_message":[],"_revision_number":1},{"id":"4310cc4308ded95894c2eb2035ac70bfdc51a394","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-18 05:22:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"48617e211654aace3f616c8e16445b853a38d669","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-18 06:16:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a30aa7a4cfe4009b01a6558c05154bf : SUCCESS in 3m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b3db00d72a1545fd9bbb5075adfde9c9 : SUCCESS in 4m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3331fe299ed344dda28957be8ce7185c : SUCCESS in 4m 13s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/26bdbf21be5e40ada2bc70e625f82239 : SUCCESS in 4m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8df1c47b03b24443b66f5fdb3efa52d3 : SUCCESS in 6m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7f8a6028f7ae4049bbc7ff73c820626b : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fb09fb947c3949c2a516bc5bdc25d51e : SUCCESS in 4m 33s\n- sushy-tools-tempest-bios-redfish-netboot https://zuul.opendev.org/t/openstack/build/45cb777b867c4deb93df70cdec742ef0 : SUCCESS in 49m 14s\n- sushy-tools-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/14fdeefc50a04d82a07c90db7e6f1845 : SUCCESS in 50m 32s","accounts_in_message":[],"_revision_number":2},{"id":"af2e18412f9b7a71b07101296da58cbac15e583a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-27 02:55:25.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"7e93bc6e815e2e92ef82664ab481a8b2e126fc93","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-27 03:53:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17a51afd19a4413bbbe6335ac1e83765 : SUCCESS in 3m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1aa27db10901435cbcb82ac9a390e156 : SUCCESS in 4m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e0dd145e1a5945a9ae4e2e766c454158 : SUCCESS in 4m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b044c68d07104e1a93395ccabc447a04 : SUCCESS in 3m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4828c8c9aec9451daa151ed9347c0b8e : SUCCESS in 6m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/70cf3363bf894b37a54de86be4def7bd : SUCCESS in 4m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/eab899bf5ba94e7e96054e85bd83e744 : SUCCESS in 4m 11s\n- sushy-tools-tempest-bios-redfish-netboot https://zuul.opendev.org/t/openstack/build/8efa5cd7db164e0bb29acc469552fd60 : SUCCESS in 48m 42s\n- sushy-tools-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/08c31151077e4f2fad3bd7acf3184f14 : SUCCESS in 55m 11s","accounts_in_message":[],"_revision_number":3},{"id":"612b63c5d29d627c25f7f358bca07a278ac1d29d","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-29 23:52:06.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a3106f2655c569a584e613301e01f5376d2ef662","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-05-31 01:52:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5532ea9d8e82f436f24245b3c47a0f2b493f3ff5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-31 03:01:58.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0829b350880f4940bd0bc7fe5d775ffc : SUCCESS in 3m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e4496d4fa67849a88bcb1bc060d496cb : SUCCESS in 3m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5c79a62d08154acb82e3127a5388f56e : SUCCESS in 4m 39s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/72fc1a058a4242d4ba2e56ad18bde2a9 : SUCCESS in 3m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/35ee1af96c2b42a2adf6920a39e6656a : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/30b4856eb4e14ee0b617d750230493f5 : FAILURE in 2m 32s\n- sushy-tools-tempest-bios-redfish-netboot https://zuul.opendev.org/t/openstack/build/4d2744a1f04e49c4922ec495089d712e : SUCCESS in 59m 40s\n- sushy-tools-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/cd89fd8527414b458f037b793e05f9ac : SUCCESS in 1h 01m 57s","accounts_in_message":[],"_revision_number":4},{"id":"3238462d85aa0c8ea2483533e6b2e20733027cae","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-06-01 07:01:26.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"fef01ce48a7b1fed626409c76c4ac96cfcccda38","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-06-08 02:55:12.000000000","message":"Abandoned\n\nautomatic firmware provides no mechanism for choosing UEFI+disabled-secure-boot","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b5f22be0f3045693d23343dfbd23fb2a6339d4d3","revisions":{"2164982b2cbec49f13b3a4156d6af541b1147f6a":{"kind":"REWORK","_number":1,"created":"2022-05-12 23:53:47.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/53/841653/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy-tools","ref":"refs/changes/53/841653/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/1"}}},"commit":{"parents":[{"commit":"3f71c53728de05b22a09519d7315ef1b441d16d8","subject":"Document SUSHY_EMULATOR_ALLOWED_INSTANCES","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/3f71c53728de05b22a09519d7315ef1b441d16d8"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-12 23:48:09.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-12 23:53:14.000000000","tz":720},"subject":"WIP use libvirt automatic firmware for UEFI boot mode","message":"WIP use libvirt automatic firmware for UEFI boot mode\n\nThis change switches to automatic firmware selection[1][2] available\nsince libvirt-5.3.0 to simplify setup for UEFI boot.\n\nWIP for some feedback before updating the unit tests, and to discuss\nthe approach for removing config option\nSUSHY_EMULATOR_BOOT_LOADER_MAP.\n\n[1] https://libvirt.org/formatdomain.html#bios-bootloader\n[2] https://that.guru/blog/uefi-secure-boot-in-libvirt/\n\nChange-Id: I586dc220f9a49b9ae2be2bf40939c321ad877751\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/2164982b2cbec49f13b3a4156d6af541b1147f6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/2164982b2cbec49f13b3a4156d6af541b1147f6a"}]},"branch":"refs/heads/master"},"a578e24c1dab2d01430f0fb69ec94dd984a31438":{"kind":"REWORK","_number":2,"created":"2022-05-18 05:22:54.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/53/841653/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy-tools","ref":"refs/changes/53/841653/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/2"}}},"commit":{"parents":[{"commit":"08e3a2a51a38c07027b2c7ba92313945030dcc9a","subject":"Add SecureBoot support to the emulator, all drivers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/08e3a2a51a38c07027b2c7ba92313945030dcc9a"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-12 23:48:09.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-18 05:22:43.000000000","tz":720},"subject":"Use libvirt automatic firmware for UEFI boot mode","message":"Use libvirt automatic firmware for UEFI boot mode\n\nThis change switches to automatic firmware selection[1][2] available\nsince libvirt-5.3.0 to simplify setup for UEFI boot.\n\nget_boot_mode will detect the boot mode with both the old manual os\nXML, and the new automatic XML.\n\nset_boot_mode will convert old manual XML to the new automatic XML.\n\n[1] https://libvirt.org/formatdomain.html#bios-bootloader\n[2] https://that.guru/blog/uefi-secure-boot-in-libvirt/\n\nChange-Id: I586dc220f9a49b9ae2be2bf40939c321ad877751\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/a578e24c1dab2d01430f0fb69ec94dd984a31438"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/a578e24c1dab2d01430f0fb69ec94dd984a31438"}]},"branch":"refs/heads/master"},"bd8c5b95333bdf4f27b8a168af8590f975b1f0fa":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-05-27 02:55:25.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/53/841653/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy-tools","ref":"refs/changes/53/841653/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/3"}}},"commit":{"parents":[{"commit":"d1b563c09e67cb8285b669a18eda78d4b63c4014","subject":"Add SecureBoot support to the emulator, all drivers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/d1b563c09e67cb8285b669a18eda78d4b63c4014"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-12 23:48:09.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-26 23:51:17.000000000","tz":720},"subject":"Use libvirt automatic firmware for UEFI boot mode","message":"Use libvirt automatic firmware for UEFI boot mode\n\nThis change switches to automatic firmware selection[1][2] available\nsince libvirt-5.3.0 to simplify setup for UEFI boot.\n\nget_boot_mode will detect the boot mode with both the old manual os\nXML, and the new automatic XML.\n\nset_boot_mode will convert old manual XML to the new automatic XML.\n\n[1] https://libvirt.org/formatdomain.html#bios-bootloader\n[2] https://that.guru/blog/uefi-secure-boot-in-libvirt/\n\nChange-Id: I586dc220f9a49b9ae2be2bf40939c321ad877751\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/bd8c5b95333bdf4f27b8a168af8590f975b1f0fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/bd8c5b95333bdf4f27b8a168af8590f975b1f0fa"}]},"branch":"refs/heads/master"},"b5f22be0f3045693d23343dfbd23fb2a6339d4d3":{"kind":"REWORK","_number":4,"created":"2022-05-31 01:52:39.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/53/841653/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy-tools","ref":"refs/changes/53/841653/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy-tools refs/changes/53/841653/4"}}},"commit":{"parents":[{"commit":"d1b563c09e67cb8285b669a18eda78d4b63c4014","subject":"Add SecureBoot support to the emulator, all drivers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/d1b563c09e67cb8285b669a18eda78d4b63c4014"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-30 21:39:35.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-05-30 21:39:35.000000000","tz":720},"subject":"Use libvirt automatic firmware for UEFI boot mode","message":"Use libvirt automatic firmware for UEFI boot mode\n\nThis change switches to automatic firmware selection[1] available\nsince libvirt-5.3.0 to simplify setup for UEFI boot.\n\nget_boot_mode will detect the boot mode with both the old manual os\nXML, and the new automatic XML.\n\nset_boot_mode will convert old manual XML to the new automatic XML.\n\nAs described in the \"Secure boot woes\" section of [2], the secure\nattribute does not actually change the firmware path to the\n(non)secure version of the firmware binary, so the loader path still\nneeds to be explicit until libvirt supports a secure selection\nmechanism (tracked by [3])\n\n[1] https://libvirt.org/formatdomain.html#bios-bootloader\n[2] https://that.guru/blog/uefi-secure-boot-in-libvirt/\n[3] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1937150\n\nChange-Id: I586dc220f9a49b9ae2be2bf40939c321ad877751\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/b5f22be0f3045693d23343dfbd23fb2a6339d4d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy-tools/commit/b5f22be0f3045693d23343dfbd23fb2a6339d4d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}