)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f382d33fb330031118384d66b9b1642763c68f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a78d408_58caddfd","updated":"2023-01-11 15:09:05.000000000","message":"libvirtdriver.py code change wise, LGTM.\n\nBut I\u0027m feeling like a unit test would be good to codify the pattern to ensure it is not inadvertently changed down the road.\n\nWould it be feasible to add a test to https://github.com/openstack/sushy-tools/blob/master/sushy_tools/tests/unit/emulator/resources/systems/test_libvirt.py ?","commit_id":"8b0beba734dfdd46455862472ed846790b8f4ac2"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"54efd4a72aa8ba12e120c39d9a9cdb19a46daf4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"845c6841_780e8887","in_reply_to":"9a78d408_58caddfd","updated":"2023-01-12 12:58:38.000000000","message":"Added a test case where we check that\n* boot was removed from os element\n* network device has first order\n* we still have hard drives\n* compare whole config with expected\n\nI am not sure why some other test scenarios has initial fixture with final state which is expected to be set. domain_boot_network.xml already has only interface and a boot order on it... So if I added my test incorrectly, please consult me and help with the process.","commit_id":"8b0beba734dfdd46455862472ed846790b8f4ac2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d9d6f87f263e03b00b4551f46a037d4387972016","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68e025ed_1ed10a29","updated":"2023-02-17 16:53:06.000000000","message":"(\"this\" being, use of sushy-tools outside of Ironic CI)","commit_id":"2a628d40992d581a8a9fc1e7a699121cc0683421"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cc32e154c93c83862e7158283e1f0a2f6d331228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8529c7b_daeb2b8f","updated":"2023-02-17 16:52:50.000000000","message":"I\u0027d really love to know your use case for this. Do you mind sharing it? ","commit_id":"2a628d40992d581a8a9fc1e7a699121cc0683421"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7d59dc1472bc7c01f40551af6181f2644849198c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db2c7cfc_cc13df4a","updated":"2023-03-30 14:23:02.000000000","message":"Thanks for the insight, Denys! Just so you\u0027re aware, we generally discourage use of VirtualBMC, VirtualPDU, and sushy-tools in production as they are designed with CI/testing environments in mind. I\u0027m glad you\u0027ve found a workflow that works for you, though.","commit_id":"2a628d40992d581a8a9fc1e7a699121cc0683421"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"54efd4a72aa8ba12e120c39d9a9cdb19a46daf4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"630978a3_de35aac6","updated":"2023-01-12 12:58:38.000000000","message":"more proper sort order for the disk devices trough lambda.\nadded test case to verify function behavior\nadded new fixture","commit_id":"2a628d40992d581a8a9fc1e7a699121cc0683421"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"88060d8aca36c337cddb1ada3a18dceb790766ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f86c059_09584f67","in_reply_to":"e8529c7b_daeb2b8f","updated":"2023-03-30 09:57:48.000000000","message":"sushi-tool is used as a virtual machines manager which makes them (vms) look as a regular servers. Which can be controlled or configured using company-default tools. In my case it was a MaaS and there is no mistake on the MaaS side to correct. As set boot once is a normal behavior. I know that MaaS can manage vms, but this wasn\u0027t intended in the setup.\n\nP.S. There are many articles on the web how to manage vms using sushi-tools...","commit_id":"2a628d40992d581a8a9fc1e7a699121cc0683421"}],"sushy_tools/emulator/resources/systems/libvirtdriver.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f382d33fb330031118384d66b9b1642763c68f1","unresolved":true,"context_lines":[{"line_number":436,"context_line":"        # Remove per-disk boot configuration"},{"line_number":437,"context_line":"        # We should save at least hdd boot entries instead of just removing"},{"line_number":438,"context_line":"        # everything. In some scenarious PXE after provisioning stops replying"},{"line_number":439,"context_line":"        # and if there is no other boot device, then vm will fail to boot"},{"line_number":440,"context_line":"        # cdrom and floppy are ignored."},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        for disk_element in devices_element.findall(\u0027disk\u0027):"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"10dbbb56_42253693","line":440,"range":{"start_line":439,"start_character":14,"end_line":440,"end_character":39},"updated":"2023-01-11 15:09:05.000000000","message":"outside of ironic, okay, but if this is happening with Ironic, that would seem like a bug.","commit_id":"8b0beba734dfdd46455862472ed846790b8f4ac2"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"54efd4a72aa8ba12e120c39d9a9cdb19a46daf4d","unresolved":true,"context_lines":[{"line_number":436,"context_line":"        # Remove per-disk boot configuration"},{"line_number":437,"context_line":"        # We should save at least hdd boot entries instead of just removing"},{"line_number":438,"context_line":"        # everything. In some scenarious PXE after provisioning stops replying"},{"line_number":439,"context_line":"        # and if there is no other boot device, then vm will fail to boot"},{"line_number":440,"context_line":"        # cdrom and floppy are ignored."},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        for disk_element in devices_element.findall(\u0027disk\u0027):"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9dbe5d85_518751c1","line":440,"range":{"start_line":439,"start_character":14,"end_line":440,"end_character":39},"in_reply_to":"10dbbb56_42253693","updated":"2023-01-12 12:58:38.000000000","message":"I have reproduced this only outside of the ironic. But this is something interesting as redfish spec does allow setonce, while there is no such option in the libvirt. And there is no queue or state keeper in sushy-tools. You can just set what it should be and that is all. There is no option to set it for one boot. And it can be really tricky to find that the server was rebooted if this wasn\u0027t triggered through sushy-tools. So that is the reason for the \"hacky way\" I\u0027ve proposed.","commit_id":"8b0beba734dfdd46455862472ed846790b8f4ac2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"08583a62a19104639fb4cdb542808cbdac834526","unresolved":true,"context_lines":[{"line_number":436,"context_line":"        # Remove per-disk boot configuration"},{"line_number":437,"context_line":"        # We should save at least hdd boot entries instead of just removing"},{"line_number":438,"context_line":"        # everything. In some scenarious PXE after provisioning stops replying"},{"line_number":439,"context_line":"        # and if there is no other boot device, then vm will fail to boot"},{"line_number":440,"context_line":"        # cdrom and floppy are ignored."},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        for disk_element in devices_element.findall(\u0027disk\u0027):"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"16203cf3_f4d99f69","line":440,"range":{"start_line":439,"start_character":14,"end_line":440,"end_character":39},"in_reply_to":"9dbe5d85_518751c1","updated":"2023-01-26 15:58:41.000000000","message":"Ultimately, I think this makes sense in the grand scheme of the universe, because we\u0027ve observed hardware with this sort of behavior as well.","commit_id":"8b0beba734dfdd46455862472ed846790b8f4ac2"}]}