)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cc89f2a04ff7ce96f5129c12858d58c17a361a2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd4f08a4_29bb714e","updated":"2024-02-20 02:19:55.000000000","message":"recheck","commit_id":"34ed4430abf8f75c0eb11829d756f371b66d7ac9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"99f76b24704ba562c8916097f405094a57cb6493","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0b63c85_75c5856a","updated":"2024-03-08 07:56:57.000000000","message":"Thank you for your review Dmitry. I will upload a reworked patch in the next day or two. Specific responses in-line.","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e3de5a7b8c8cb65111d0c3e66b95d28b745f1e0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af6f686c_acc2434d","updated":"2024-03-13 22:14:29.000000000","message":"recheck","commit_id":"09c8c10a1238a756246a170d76396c4b230cc6a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"c82a6dc0cb55c1948fe06a90ada23a3c43cf6dc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b0225bfa_c1ff2d9b","updated":"2024-03-13 20:12:43.000000000","message":"recheck","commit_id":"09c8c10a1238a756246a170d76396c4b230cc6a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fb0612eea090e1350d76ddd3106c5e1a00ab240e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"52d9df71_0ab39a3d","updated":"2024-03-14 02:52:38.000000000","message":"recheck\ntroubleshooting failed job\npassed DNM patch","commit_id":"09c8c10a1238a756246a170d76396c4b230cc6a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dfd7cf4be8f1df9e860326b1cdd18b98629d94ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff8e21c9_7f6cd33e","updated":"2024-05-21 03:19:36.000000000","message":"Thank you for your comments, I re-worked the logic to be in line with the current implementation of BIOS settings.","commit_id":"43bcf6768ddaaf3658afc5567d28d77b08feafce"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e7c0f092cfcf0ebcd9018eff8ed59af0c0a04350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f7a69d70_f470431a","updated":"2024-06-04 00:01:01.000000000","message":"lgtm","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022f933e0eaff1f18383e41edc99e59705d26355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5d9b5eb7_d5b28ddd","updated":"2024-07-03 21:19:55.000000000","message":"Thank you for your review Dmitry. Uploading a revised version addressing the error handling issues (and fixing some minor cosmetic things). The question whether we populate fields on GET (theoretically making it possible that GET will fail with \"cannot update\") remains. I\u0027m inclined to leave it as-is because it\u0027s consistent with BIOS settings emulation and this is testing-only code.","commit_id":"2fe0c23c2cf0ce86e387c6d2dd7125d5dd2cede6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c34fdbf4ab0680abbca216a9809e54360d0fff95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2d4863c5_a310bc68","updated":"2024-07-09 00:26:58.000000000","message":"For a follow-up let\u0027s switch the BIOS update and settings to return default on GET if no values are set in the libvirt.xml \u003d)","commit_id":"bab6feb3a0bc785e2f0a53fcdfaccf14cb26e050"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"292dbd0e34c358d2b603f81b870ce0bed565080f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"53e879fd_d673825a","updated":"2024-07-04 17:13:01.000000000","message":"lgtm, issues raised by dmitry seem to be resolved","commit_id":"bab6feb3a0bc785e2f0a53fcdfaccf14cb26e050"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b4bcd08e143b5d30dcdedd0da0dac93bd8a0d2f","unresolved":true,"context_lines":[{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    bios \u003d app.systems.get_bios(identity)"},{"line_number":416,"context_line":"    bios_version \u003d bios[\u0027BiosVersion\u0027]"},{"line_number":417,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        app.logger.debug(\u0027Serving resources for system \"%s\"\u0027, identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"708bab37_1e848d7a","line":416,"updated":"2024-02-20 07:46:47.000000000","message":"What will happen if an existing environment with sushy-tools is updated? I suspect this may crash with KeyError.","commit_id":"34ed4430abf8f75c0eb11829d756f371b66d7ac9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d2d7c70edfb6dd335eebf465051bf39d733b6ed7","unresolved":true,"context_lines":[{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    bios \u003d app.systems.get_bios(identity)"},{"line_number":416,"context_line":"    bios_version \u003d bios[\u0027BiosVersion\u0027]"},{"line_number":417,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        app.logger.debug(\u0027Serving resources for system \"%s\"\u0027, identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"93a6c91e_a95bc114","line":416,"in_reply_to":"31e332d7_45afdeb4","updated":"2024-02-22 07:13:43.000000000","message":"I fixed it now, but will try find a more efficient way, I just need to learn how to navigate through get_bios() which calls _process_bios() which calls _process_bios_attributes() which is operating on the xml file.","commit_id":"34ed4430abf8f75c0eb11829d756f371b66d7ac9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d0c42328a2c5cbd6f4a57984cf092b76ff3dc0b6","unresolved":true,"context_lines":[{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    bios \u003d app.systems.get_bios(identity)"},{"line_number":416,"context_line":"    bios_version \u003d bios[\u0027BiosVersion\u0027]"},{"line_number":417,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        app.logger.debug(\u0027Serving resources for system \"%s\"\u0027, identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"31e332d7_45afdeb4","line":416,"in_reply_to":"708bab37_1e848d7a","updated":"2024-02-20 11:07:50.000000000","message":"good question - sushy-tools has some smarts installing the BIOS metadata just before they are needed but what happens when this is done just missing the new key is a good question. I will test this scenario out of curiosity.","commit_id":"34ed4430abf8f75c0eb11829d756f371b66d7ac9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dfd7cf4be8f1df9e860326b1cdd18b98629d94ea","unresolved":false,"context_lines":[{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    bios \u003d app.systems.get_bios(identity)"},{"line_number":416,"context_line":"    bios_version \u003d bios[\u0027BiosVersion\u0027]"},{"line_number":417,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        app.logger.debug(\u0027Serving resources for system \"%s\"\u0027, identity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb6871f0_0bb540b7","line":416,"in_reply_to":"93a6c91e_a95bc114","updated":"2024-05-21 03:19:36.000000000","message":"Done","commit_id":"34ed4430abf8f75c0eb11829d756f371b66d7ac9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ad63304c734be29fbfb838f634334696e997921c","unresolved":true,"context_lines":[{"line_number":421,"context_line":"                          \u0027attempting to set default value\u0027, uuid)"},{"line_number":422,"context_line":"        attributes \u003d {\"BiosVersion\": bios_version}"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            flask.current_app.systems.set_bios(identity, attributes)"},{"line_number":425,"context_line":"        except error.NotSupportedError as ex:"},{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff04883_139a90b3","line":424,"updated":"2024-03-07 12:42:26.000000000","message":"I\u0027m not really fond of modifying something in response to a GET request.","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"99f76b24704ba562c8916097f405094a57cb6493","unresolved":true,"context_lines":[{"line_number":421,"context_line":"                          \u0027attempting to set default value\u0027, uuid)"},{"line_number":422,"context_line":"        attributes \u003d {\"BiosVersion\": bios_version}"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            flask.current_app.systems.set_bios(identity, attributes)"},{"line_number":425,"context_line":"        except error.NotSupportedError as ex:"},{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e09036ee_cfc546dd","line":424,"in_reply_to":"bff04883_139a90b3","updated":"2024-03-08 07:56:57.000000000","message":"My understanding is that currently a GET against a /System/ triggers adding BIOS attributes to libvirt xml of the VM in question. Is that OK? It all happens inside the libvirt backend, more regarding this in the next response.","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dfd7cf4be8f1df9e860326b1cdd18b98629d94ea","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                          \u0027attempting to set default value\u0027, uuid)"},{"line_number":422,"context_line":"        attributes \u003d {\"BiosVersion\": bios_version}"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            flask.current_app.systems.set_bios(identity, attributes)"},{"line_number":425,"context_line":"        except error.NotSupportedError as ex:"},{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83016525_db3b1442","line":424,"in_reply_to":"e09036ee_cfc546dd","updated":"2024-05-21 03:19:36.000000000","message":"Done","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ad63304c734be29fbfb838f634334696e997921c","unresolved":true,"context_lines":[{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"},{"line_number":428,"context_line":"            message \u003d \"Failed setting BIOS version\""},{"line_number":429,"context_line":"            return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 500"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c217da03_265fcbe9","line":429,"updated":"2024-03-07 12:42:26.000000000","message":"I\u0027m even less fond of blocking GET/PATCH of the whole System if the backend doesn\u0027t support BIOS settings. Do all existing backends support it at least?","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dfd7cf4be8f1df9e860326b1cdd18b98629d94ea","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"},{"line_number":428,"context_line":"            message \u003d \"Failed setting BIOS version\""},{"line_number":429,"context_line":"            return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 500"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a24f56f4_30244b7d","line":429,"in_reply_to":"4cd5e62c_46a9f553","updated":"2024-05-21 03:19:36.000000000","message":"Done","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"99f76b24704ba562c8916097f405094a57cb6493","unresolved":true,"context_lines":[{"line_number":426,"context_line":"            api_utils.warning(\u0027System failed to set bios with exception %s\u0027,"},{"line_number":427,"context_line":"                              ex)"},{"line_number":428,"context_line":"            message \u003d \"Failed setting BIOS version\""},{"line_number":429,"context_line":"            return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 500"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4cd5e62c_46a9f553","line":429,"in_reply_to":"c217da03_265fcbe9","updated":"2024-03-08 07:56:57.000000000","message":"I am moving firmware version information to a separate constant as requested in other reviews. This will require changes in the libvirt driver and while making those changes I will also move setting the default there, in line with all the other settings.","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bee779e5ccf030e6c4597446547b7a11ceca559","unresolved":true,"context_lines":[{"line_number":412,"context_line":"@api_utils.returns_json"},{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    versions \u003d app.systems.get_versions(identity)"},{"line_number":416,"context_line":"    bios_version \u003d versions.get(\u0027BiosVersion\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"835f44d0_21a47ff9","line":415,"updated":"2024-06-06 12:20:54.000000000","message":"This is going to immediately fail on system backends that don\u0027t support versions, is it? See my other comment.","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022f933e0eaff1f18383e41edc99e59705d26355","unresolved":false,"context_lines":[{"line_number":412,"context_line":"@api_utils.returns_json"},{"line_number":413,"context_line":"def system_resource(identity):"},{"line_number":414,"context_line":"    uuid \u003d app.systems.uuid(identity)"},{"line_number":415,"context_line":"    versions \u003d app.systems.get_versions(identity)"},{"line_number":416,"context_line":"    bios_version \u003d versions.get(\u0027BiosVersion\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    if flask.request.method \u003d\u003d \u0027GET\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ce50be6f_5c89e095","line":415,"in_reply_to":"835f44d0_21a47ff9","updated":"2024-07-03 21:19:55.000000000","message":"Done","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"}],"sushy_tools/emulator/resources/systems/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bee779e5ccf030e6c4597446547b7a11ceca559","unresolved":true,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :raises: `FishyError` if firmware versions cannot be processed"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        raise error.NotSupportedError(\u0027Not implemented\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def set_bios(self, identity, attributes):"},{"line_number":180,"context_line":"        \"\"\"Update BIOS attributes"}],"source_content_type":"text/x-python","patch_set":10,"id":"771f4eb4_290ccdc0","line":177,"updated":"2024-06-06 12:20:54.000000000","message":"This should probably return {} instead. Or the calling code should be able to handle NotSupportedError.","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022f933e0eaff1f18383e41edc99e59705d26355","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :raises: `FishyError` if firmware versions cannot be processed"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        raise error.NotSupportedError(\u0027Not implemented\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def set_bios(self, identity, attributes):"},{"line_number":180,"context_line":"        \"\"\"Update BIOS attributes"}],"source_content_type":"text/x-python","patch_set":10,"id":"d28f0718_d5386c2f","line":177,"in_reply_to":"771f4eb4_290ccdc0","updated":"2024-07-03 21:19:55.000000000","message":"Done","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"}],"sushy_tools/emulator/resources/systems/libvirtdriver.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a5f6e28af16137cafd028d5f561e9986736090e6","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        constants.DEVICE_TYPE_CD: (\u0027hdc\u0027, \u0027ide\u0027),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    DEFAULT_BIOS_ATTRIBUTES \u003d {\"BiosVersion\": \"1.0.0\","},{"line_number":131,"context_line":"                               \"BootMode\": \"Uefi\","},{"line_number":132,"context_line":"                               \"EmbeddedSata\": \"Raid\","},{"line_number":133,"context_line":"                               \"L2Cache\": \"10x256 KB\","}],"source_content_type":"text/x-python","patch_set":2,"id":"576e7b4f_214d7046","line":130,"updated":"2024-03-01 01:58:21.000000000","message":"Don\u0027t we only use DEFAULT_BIOS_ATTRIBUTES for Bios Settings? https://docs.openstack.org/ironic/latest/admin/bios.html#retrieve-bios-settings \nNot sure if would make sense to add BiosVersion here .-.","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a5f6e28af16137cafd028d5f561e9986736090e6","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        constants.DEVICE_TYPE_CD: (\u0027hdc\u0027, \u0027ide\u0027),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    DEFAULT_BIOS_ATTRIBUTES \u003d {\"BiosVersion\": \"1.0.0\","},{"line_number":131,"context_line":"                               \"BootMode\": \"Uefi\","},{"line_number":132,"context_line":"                               \"EmbeddedSata\": \"Raid\","},{"line_number":133,"context_line":"                               \"L2Cache\": \"10x256 KB\","}],"source_content_type":"text/x-python","patch_set":2,"id":"ce4542d1_0947de54","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":27},"updated":"2024-03-01 01:58:21.000000000","message":"I have a feeling this are attributes we can set in the BIOS (","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dfd7cf4be8f1df9e860326b1cdd18b98629d94ea","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        constants.DEVICE_TYPE_CD: (\u0027hdc\u0027, \u0027ide\u0027),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    DEFAULT_BIOS_ATTRIBUTES \u003d {\"BiosVersion\": \"1.0.0\","},{"line_number":131,"context_line":"                               \"BootMode\": \"Uefi\","},{"line_number":132,"context_line":"                               \"EmbeddedSata\": \"Raid\","},{"line_number":133,"context_line":"                               \"L2Cache\": \"10x256 KB\","}],"source_content_type":"text/x-python","patch_set":2,"id":"2009724a_6df12213","line":130,"in_reply_to":"576e7b4f_214d7046","updated":"2024-05-21 03:19:36.000000000","message":"Done","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8432baf167067ba6f04631f0dcd9dd7505e19129","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        constants.DEVICE_TYPE_CD: (\u0027hdc\u0027, \u0027ide\u0027),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    DEFAULT_BIOS_ATTRIBUTES \u003d {\"BiosVersion\": \"1.0.0\","},{"line_number":131,"context_line":"                               \"BootMode\": \"Uefi\","},{"line_number":132,"context_line":"                               \"EmbeddedSata\": \"Raid\","},{"line_number":133,"context_line":"                               \"L2Cache\": \"10x256 KB\","}],"source_content_type":"text/x-python","patch_set":2,"id":"acec7c8d_b2326cf8","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":27},"in_reply_to":"ce4542d1_0947de54","updated":"2024-03-01 01:59:18.000000000","message":"Ignore this one, I started the review in 2 tabs 😄","commit_id":"f739d5846e279ae1e087d0680a3ba13fda80c0c9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bee779e5ccf030e6c4597446547b7a11ceca559","unresolved":true,"context_lines":[{"line_number":989,"context_line":"        :param identity: libvirt domain name or ID"},{"line_number":990,"context_line":"        :returns: dict of firmware version attributes"},{"line_number":991,"context_line":"        \"\"\""},{"line_number":992,"context_line":"        return self._process_versions(identity)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    def set_bios(self, identity, attributes):"},{"line_number":995,"context_line":"        \"\"\"Update BIOS attributes"}],"source_content_type":"text/x-python","patch_set":10,"id":"e36fc678_4ae2938b","line":992,"updated":"2024-06-06 12:20:54.000000000","message":"It feels a bit odd that a call to get a System can fail with \"Error updating firmware versions\". Maybe you want to avoid any changes if update_existing_attributes is False?","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"022f933e0eaff1f18383e41edc99e59705d26355","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        :param identity: libvirt domain name or ID"},{"line_number":990,"context_line":"        :returns: dict of firmware version attributes"},{"line_number":991,"context_line":"        \"\"\""},{"line_number":992,"context_line":"        return self._process_versions(identity)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    def set_bios(self, identity, attributes):"},{"line_number":995,"context_line":"        \"\"\"Update BIOS attributes"}],"source_content_type":"text/x-python","patch_set":10,"id":"39401df0_a946b3ca","line":992,"in_reply_to":"e36fc678_4ae2938b","updated":"2024-07-03 21:19:55.000000000","message":"Fair point, however after giving it some thought I\u0027m leaning towards keeping it as-is as it is consistent with get_bios() and _process_bios() handling BIOS settings (in that part of the code, a GET against a System also updates it in the case where BIOS settings are absent from libvirt xml). Happy to discuss further.","commit_id":"a92781f143971877b4ee04ebe91011346b96ea77"}]}