)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8e1a816623b997cf24882896e432cc28502075b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecceefbc_439c5041","updated":"2024-07-17 05:44:28.000000000","message":"bringing initial draft up for discussion","commit_id":"239b004b9eab7fe73364ffd24f6ec1fd76afa9f1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"ff877671f4da7fdfe936dc2a4906e9e9a0ceef61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52183848_51a938f5","updated":"2024-07-23 01:44:31.000000000","message":"recheck \nunit test issue should be resolved, passing locally","commit_id":"cccaa0a942a11fdd49273058b61f5ffa64a5d529"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df250ee4c1e1edef6770d24573f96b2946d69c54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d223b271_7108b616","updated":"2024-07-24 14:56:15.000000000","message":"Sorry, but no, absolutely no. We have all the information we need in the same process. You could add the actual identity to AliasAccessError and catch it. You could add a new call that returns an identity instead of raising. We could even do away with redirects and just allow two canonical URLs. There are options, this is not one.","commit_id":"a39ace437230521c2e70aec078af9b36856e0a22"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e77455b0fb0ed17d5d09a134b70d252b34de38fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"671e44ee_79fc6c60","updated":"2024-07-30 13:13:58.000000000","message":"Thank you for your review Dmitry, uploaded an updated version","commit_id":"4ff52c56f132bbabf7afbec8bdf06c1b5699158a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee6cf79aefe7964a132e7ef810074c9ed98d168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2cc3068d_f126db81","updated":"2024-07-30 13:55:56.000000000","message":"Thanks!","commit_id":"4ff52c56f132bbabf7afbec8bdf06c1b5699158a"}],"sushy_tools/emulator/controllers/update_service.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3c68f03baec383063ee650a4acdc74daef7705c5","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            message \u003d \"Manager is not currently a supported Target.\""},{"line_number":49,"context_line":"            return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 400"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            name \u003d target.rsplit(\u0027/\u0027, 1)[-1]"},{"line_number":52,"context_line":"            uuid \u003d flask.current_app.systems.uuid(name)"},{"line_number":53,"context_line":"        except error.AliasAccessError as exc:"},{"line_number":54,"context_line":"            api_utils.debug(\u0027Received a redirect in respose to GET System \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa14e22_6d2245a4","line":51,"updated":"2024-07-30 09:51:57.000000000","message":"There is a small chance that a user places a trailing slash, so let\u0027s rstrip it before doing rsplit.","commit_id":"051b7086d2394c1c915788b9db0156228778bcc9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e77455b0fb0ed17d5d09a134b70d252b34de38fd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            message \u003d \"Manager is not currently a supported Target.\""},{"line_number":49,"context_line":"            return flask.render_template(\u0027error.json\u0027, message\u003dmessage), 400"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            name \u003d target.rsplit(\u0027/\u0027, 1)[-1]"},{"line_number":52,"context_line":"            uuid \u003d flask.current_app.systems.uuid(name)"},{"line_number":53,"context_line":"        except error.AliasAccessError as exc:"},{"line_number":54,"context_line":"            api_utils.debug(\u0027Received a redirect in respose to GET System \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2d25856_4b355c8c","line":51,"in_reply_to":"5aa14e22_6d2245a4","updated":"2024-07-30 13:13:58.000000000","message":"Good pickup, done.","commit_id":"051b7086d2394c1c915788b9db0156228778bcc9"}]}
