)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6468fb3_0b05af54","updated":"2024-10-17 08:42:41.000000000","message":"thank you so much for this!\nJust minor adjustments, mainly blank spaces at the end of some lines","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"070b48fa3f78e7813a999acf7814d95832eb17ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80e90832_b22cf2e3","updated":"2024-11-12 13:25:24.000000000","message":"going to merge this\nit\u0027s a docs update, I just did a rebase, no other changes, and it got 2x +2 before","commit_id":"bcd694e90c72e38d0c042fbb38331c016c1757f5"}],"doc/source/admin/index.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Running emulators in the background"},{"line_number":6,"context_line":"-----------------------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The emulators run as interactive processes attached to the terminal by "},{"line_number":9,"context_line":"default. You can create systemd services to run the emulators in the "},{"line_number":10,"context_line":"background."},{"line_number":11,"context_line":"For each emulator, create a systemd unit file, and update ``\u003cfull-path\u003e`` to "}],"source_content_type":"text/x-rst","patch_set":2,"id":"52c85b9c_99b08b08","line":8,"updated":"2024-10-17 08:42:41.000000000","message":"blank spaces at the end of line, also in L9 11 and 12","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Running emulators in the background"},{"line_number":6,"context_line":"-----------------------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The emulators run as interactive processes attached to the terminal by "},{"line_number":9,"context_line":"default. You can create systemd services to run the emulators in the "},{"line_number":10,"context_line":"background."},{"line_number":11,"context_line":"For each emulator, create a systemd unit file, and update ``\u003cfull-path\u003e`` to "}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fc6d17d_a59524e9","line":8,"in_reply_to":"52c85b9c_99b08b08","updated":"2024-10-17 12:03:53.000000000","message":"Acknowledged","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"}],"doc/source/user/dynamic-emulator.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":158,"context_line":"UEFI boot"},{"line_number":159,"context_line":"~~~~~~~~~"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By default, `legacy` or `BIOS` mode is used to boot the instance. However, "},{"line_number":162,"context_line":"the libvirt domain can be configured to boot via UEFI firmware. This process"},{"line_number":163,"context_line":"requires additional preparation on the host side."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"923087b9_cf42c905","line":161,"updated":"2024-10-17 08:42:41.000000000","message":"blank space at the end of the line","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":158,"context_line":"UEFI boot"},{"line_number":159,"context_line":"~~~~~~~~~"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"By default, `legacy` or `BIOS` mode is used to boot the instance. However, "},{"line_number":162,"context_line":"the libvirt domain can be configured to boot via UEFI firmware. This process"},{"line_number":163,"context_line":"requires additional preparation on the host side."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7fa6683c_f998cd7c","line":161,"in_reply_to":"923087b9_cf42c905","updated":"2024-10-17 12:03:53.000000000","message":"Acknowledged","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":209,"context_line":"     ..."},{"line_number":210,"context_line":"   \u003c/domain\u003e"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Because now we need to add this path to the emulator\u0027s configuration matching the VM"},{"line_number":213,"context_line":"architecture we are running. It is also possible to make Redfish calls to enable"},{"line_number":214,"context_line":"or disable Secure Boot by specifying which nvram template to load in each case."},{"line_number":215,"context_line":"Make a copy of the stock configuration file and edit it accordingly:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2d3941de_e4ed5529","line":212,"updated":"2024-10-17 08:42:41.000000000","message":"nit: probably need to reduce th words in this line and adjust the next ones to stay below 80 columns","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":209,"context_line":"     ..."},{"line_number":210,"context_line":"   \u003c/domain\u003e"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Because now we need to add this path to the emulator\u0027s configuration matching the VM"},{"line_number":213,"context_line":"architecture we are running. It is also possible to make Redfish calls to enable"},{"line_number":214,"context_line":"or disable Secure Boot by specifying which nvram template to load in each case."},{"line_number":215,"context_line":"Make a copy of the stock configuration file and edit it accordingly:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"95937d2b_5f6581d1","line":212,"in_reply_to":"2d3941de_e4ed5529","updated":"2024-10-17 12:03:53.000000000","message":"Acknowledged","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":322,"context_line":"++++++++++++++++++++++++++++++++++"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"You can use the Ironic driver to manage Ironic baremetal instance to simulated"},{"line_number":325,"context_line":"Redfish API. You may want to do this if you require a redfish-compatible endpoint"},{"line_number":326,"context_line":"but don\u0027t have direct access to the BMC (you only have access via Ironic) or"},{"line_number":327,"context_line":"the BMC doesn\u0027t support redfish."},{"line_number":328,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a6507d90_63231199","line":325,"updated":"2024-10-17 08:42:41.000000000","message":"nit: adjust line and paragraph to get below 80 columns","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":322,"context_line":"++++++++++++++++++++++++++++++++++"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"You can use the Ironic driver to manage Ironic baremetal instance to simulated"},{"line_number":325,"context_line":"Redfish API. You may want to do this if you require a redfish-compatible endpoint"},{"line_number":326,"context_line":"but don\u0027t have direct access to the BMC (you only have access via Ironic) or"},{"line_number":327,"context_line":"the BMC doesn\u0027t support redfish."},{"line_number":328,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4443b786_5f2b7462","line":325,"in_reply_to":"a6507d90_63231199","updated":"2024-10-17 12:03:53.000000000","message":"Acknowledged","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":568,"context_line":"If the currently used *Systems* resource emulation driver supports setting"},{"line_number":569,"context_line":"the boot image, the *VirtualMedia* resource will apply the inserted image onto"},{"line_number":570,"context_line":"all the systems being managed by this manager. Setting the system boot source"},{"line_number":571,"context_line":"to *Cd* and boot mode to *Uefi* will cause the system to boot from the "},{"line_number":572,"context_line":"virtual media image."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"The user can change virtual media devices and their properties through"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ceee4738_302f7b70","line":571,"updated":"2024-10-17 08:42:41.000000000","message":"blank space at the end of the line","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":568,"context_line":"If the currently used *Systems* resource emulation driver supports setting"},{"line_number":569,"context_line":"the boot image, the *VirtualMedia* resource will apply the inserted image onto"},{"line_number":570,"context_line":"all the systems being managed by this manager. Setting the system boot source"},{"line_number":571,"context_line":"to *Cd* and boot mode to *Uefi* will cause the system to boot from the "},{"line_number":572,"context_line":"virtual media image."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"The user can change virtual media devices and their properties through"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cc271cd1_7b08696c","line":571,"in_reply_to":"ceee4738_302f7b70","updated":"2024-10-17 12:03:53.000000000","message":"Acknowledged","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e26516eb1048f91f6a63c8fa9bd517c8e16a8f53","unresolved":true,"context_lines":[{"line_number":692,"context_line":"    },"},{"line_number":693,"context_line":"    ..."},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Knowing the virtual media device name, the client can check out its present state:"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":".. code-block:: bash"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6a52836e_609ec3cd","line":695,"updated":"2024-10-17 08:42:41.000000000","message":"nit: this should also be split in 2 lines\n\nin general, if we\u0027re passing the 80 characters we should probably adjust the words in the line, split the line, and adjust the paragraph\nBut I see we don\u0027t respect this always, so I guess it\u0027s ok if we leave it like this","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"85b5ca3ba83f95c0c6d8f38d81e5050f04a67965","unresolved":false,"context_lines":[{"line_number":692,"context_line":"    },"},{"line_number":693,"context_line":"    ..."},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"Knowing the virtual media device name, the client can check out its present state:"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":".. code-block:: bash"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"59f79d2a_b0c5400f","line":695,"in_reply_to":"6a52836e_609ec3cd","updated":"2024-10-17 12:03:53.000000000","message":"Done","commit_id":"67dcc0d55492c0965cfeaef6f6d1cbbb2309e00e"}]}
