)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"eb708075884423129be7e6d13248083fb5f17861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4694a48_6c36bf9b","updated":"2024-10-17 15:04:00.000000000","message":"Still a work in progress.","commit_id":"0702c625c8221de38c6b2fd8b3a51e37d54c49fb"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ffb514764b51081887eec621feab1b9eafa9e477","unresolved":true,"context_lines":[{"line_number":614,"context_line":"@api_utils.returns_json"},{"line_number":615,"context_line":"def system_reset_action(identity):"},{"line_number":616,"context_line":"    reset_type \u003d flask.request.json.get(\u0027ResetType\u0027)"},{"line_number":617,"context_line":"    if app.config.get(\u0027SUSHY_EMULATOR_DISABLE_POWER_OFF\u0027) is True and \\"},{"line_number":618,"context_line":"            reset_type in (\u0027ForceOff\u0027, \u0027GracefulShutdown\u0027):"},{"line_number":619,"context_line":"        raise error.BadRequest(\u0027Can not request power off transition. It is \u0027"},{"line_number":620,"context_line":"                               \u0027disabled via the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"d35efe4d_a38541d1","line":617,"updated":"2024-10-23 15:53:20.000000000","message":"s/is True//\n\n(you nearly never have to compare boolean values)","commit_id":"84c1e8a8042af2f1e098188581dccd82b6f0b289"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"783237c4986481e044b00ff3bcc0aede4731e4d9","unresolved":false,"context_lines":[{"line_number":614,"context_line":"@api_utils.returns_json"},{"line_number":615,"context_line":"def system_reset_action(identity):"},{"line_number":616,"context_line":"    reset_type \u003d flask.request.json.get(\u0027ResetType\u0027)"},{"line_number":617,"context_line":"    if app.config.get(\u0027SUSHY_EMULATOR_DISABLE_POWER_OFF\u0027) is True and \\"},{"line_number":618,"context_line":"            reset_type in (\u0027ForceOff\u0027, \u0027GracefulShutdown\u0027):"},{"line_number":619,"context_line":"        raise error.BadRequest(\u0027Can not request power off transition. It is \u0027"},{"line_number":620,"context_line":"                               \u0027disabled via the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5db932a_a9263335","line":617,"in_reply_to":"d35efe4d_a38541d1","updated":"2024-10-23 15:55:50.000000000","message":"Acknowledged","commit_id":"84c1e8a8042af2f1e098188581dccd82b6f0b289"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"524c4fafcbc49e094e65a4928823af53089a509e","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        raise error.BadRequest(\u0027Can not request power off transition. It is \u0027"},{"line_number":620,"context_line":"                               \u0027disabled via the \u0027"},{"line_number":621,"context_line":"                               \u0027SUSHY_EMULATOR_DISABLE_POWER_OFF configuration\u0027"},{"line_number":622,"context_line":"                               \u0027option.\u0027)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    app.systems.set_power_state(identity, reset_type)"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"75543ab9_c0904889","line":622,"updated":"2024-10-22 17:02:34.000000000","message":"Just curious: is this the behavior in the real world? Or does it accept the call and silently do nothing on NC-SI hardware?","commit_id":"84c1e8a8042af2f1e098188581dccd82b6f0b289"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ffb514764b51081887eec621feab1b9eafa9e477","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        raise error.BadRequest(\u0027Can not request power off transition. It is \u0027"},{"line_number":620,"context_line":"                               \u0027disabled via the \u0027"},{"line_number":621,"context_line":"                               \u0027SUSHY_EMULATOR_DISABLE_POWER_OFF configuration\u0027"},{"line_number":622,"context_line":"                               \u0027option.\u0027)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    app.systems.set_power_state(identity, reset_type)"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"910dd8a6_6c13632a","line":622,"in_reply_to":"75543ab9_c0904889","updated":"2024-10-23 15:53:20.000000000","message":"It accepts the call, powers off the machine, and your BMC is inaccessible now 😊\n\nThe goal here is to be able to ensure that no power off requests happen. To fail the request is the easiest way.","commit_id":"84c1e8a8042af2f1e098188581dccd82b6f0b289"}]}