)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"12aed8a500eead903115e25092065d95c77de5c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9faffe2a_884ca7f6","updated":"2025-06-05 20:12:56.000000000","message":"This\u0027ll need a release note, too.","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"321115c774076e0d03dca785fb67210c6e133efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70f9e3ad_6b26655a","in_reply_to":"9faffe2a_884ca7f6","updated":"2025-06-06 16:03:20.000000000","message":"Thank you for the review. I have addressed the requested changes. Please let me know if there is anything else to improve.","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a0680556121520e9da2edb652da07ed8c4359add","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        # This is needed for WSGI since it cannot process argv"},{"line_number":86,"context_line":"        self.configure(config_file\u003dos.environ.get(\u0027SUSHY_EMULATOR_CONFIG\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # @self.before_request"},{"line_number":89,"context_line":"        # def reset_cache():"},{"line_number":90,"context_line":"        # self._cache \u003d {}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d335518a_85280c2b","line":88,"updated":"2025-06-05 20:12:46.000000000","message":"We generally don\u0027t commit commented out code.","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"321115c774076e0d03dca785fb67210c6e133efc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # This is needed for WSGI since it cannot process argv"},{"line_number":86,"context_line":"        self.configure(config_file\u003dos.environ.get(\u0027SUSHY_EMULATOR_CONFIG\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # @self.before_request"},{"line_number":89,"context_line":"        # def reset_cache():"},{"line_number":90,"context_line":"        # self._cache \u003d {}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"917291ab_e7cda707","line":88,"in_reply_to":"d335518a_85280c2b","updated":"2025-06-06 16:03:20.000000000","message":"Acknowledged","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"9c6c4609a4e993096fc6e8178632596b3fa9944c","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json(force\u003dTrue)"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"93f80a29_f772800f","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":49},"updated":"2025-07-06 18:31:17.000000000","message":"nit: Maybe, an `is_json` check first, then a log if false, before forcing?","commit_id":"81352b1d34e2908ef2a314d5291e582e7d361e90"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"16f89c04f7b851f7debed476da41fdf4724771e5","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json(force\u003dTrue)"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"93481b2f_cbfd3323","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":49},"in_reply_to":"2f6c92b9_2205d183","updated":"2025-07-14 13:01:39.000000000","message":"Done","commit_id":"81352b1d34e2908ef2a314d5291e582e7d361e90"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a8933e9ba2659f9d11266f5fe2c397984773f6b0","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json(force\u003dTrue)"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a6aed3a6_6281fcd2","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":49},"in_reply_to":"93f80a29_f772800f","updated":"2025-07-07 14:47:59.000000000","message":"good point, let\u0027s do it in a followup","commit_id":"81352b1d34e2908ef2a314d5291e582e7d361e90"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"65a84d826eed00ec0032eb53ea8a319f3bbc688c","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json(force\u003dTrue)"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"2f6c92b9_2205d183","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":49},"in_reply_to":"a6aed3a6_6281fcd2","updated":"2025-07-14 13:00:47.000000000","message":"Thanks for the feedback. I have created a new patch to include the suggestion. It\u0027s here: https://review.opendev.org/c/openstack/sushy-tools/+/954945.","commit_id":"81352b1d34e2908ef2a314d5291e582e7d361e90"}],"sushy_tools/emulator/resources/managers.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a0680556121520e9da2edb652da07ed8c4359add","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        self._datetime_info[uuid] \u003d {"},{"line_number":61,"context_line":"            \u0027DateTime\u0027: datetime_value,"},{"line_number":62,"context_line":"            \u0027DateTimeLocalOffset\u0027: offset_value}"},{"line_number":63,"context_line":"        # print(f\"Datetime set for UUID {uuid}: DateTime\u003d{datetime_value},"},{"line_number":64,"context_line":"        # Offset\u003d{offset_value}\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_datetime(self, uuid):"}],"source_content_type":"text/x-python","patch_set":5,"id":"503b21f7_a24aabdc","line":63,"updated":"2025-06-05 20:12:46.000000000","message":"same","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"321115c774076e0d03dca785fb67210c6e133efc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self._datetime_info[uuid] \u003d {"},{"line_number":61,"context_line":"            \u0027DateTime\u0027: datetime_value,"},{"line_number":62,"context_line":"            \u0027DateTimeLocalOffset\u0027: offset_value}"},{"line_number":63,"context_line":"        # print(f\"Datetime set for UUID {uuid}: DateTime\u003d{datetime_value},"},{"line_number":64,"context_line":"        # Offset\u003d{offset_value}\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_datetime(self, uuid):"}],"source_content_type":"text/x-python","patch_set":5,"id":"43ada11c_323a0465","line":63,"in_reply_to":"503b21f7_a24aabdc","updated":"2025-06-06 16:03:20.000000000","message":"Acknowledged","commit_id":"9bb2ec652437621dfb927a78cb55ce27f723536e"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"96d2e93de763875afdab5d863fc85b225e951975","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        :param datetime_value: The datetime string to set"},{"line_number":58,"context_line":"        :param offset_value: The time zone offset to set (e.g., \"+00:00\")"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self._datetime_info[uuid] \u003d {"},{"line_number":61,"context_line":"            \u0027DateTime\u0027: datetime_value,"},{"line_number":62,"context_line":"            \u0027DateTimeLocalOffset\u0027: offset_value}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1b9cbf69_83de0f27","line":60,"updated":"2025-06-06 19:07:17.000000000","message":"I\u0027m a little unsure if datetime_info should be indexed by uuid. Isn\u0027t an instance of this class representing a Manager? So self._datetime_info is an attribute of the Manager?","commit_id":"5c305eeeac82ec822d5f6dcff04c594f0b8c0b0d"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"54af6f3fc52651db293009fd3b2593fe489389bb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        :param datetime_value: The datetime string to set"},{"line_number":58,"context_line":"        :param offset_value: The time zone offset to set (e.g., \"+00:00\")"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self._datetime_info[uuid] \u003d {"},{"line_number":61,"context_line":"            \u0027DateTime\u0027: datetime_value,"},{"line_number":62,"context_line":"            \u0027DateTimeLocalOffset\u0027: offset_value}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9c44d57c_db3528e3","line":60,"in_reply_to":"1b9cbf69_83de0f27","updated":"2025-06-07 00:09:22.000000000","message":"Thanks for pointing this out. You are absolutely right. That logic was originally added as a workaround for the cache reset behavior, but it can be safely removed now since the reset.cache() has been removed. I will update the code to reflect this.","commit_id":"5c305eeeac82ec822d5f6dcff04c594f0b8c0b0d"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"7cd72c52b1803de0ad74d2818ded8c3db67272d6","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self._systems \u003d systems"},{"line_number":23,"context_line":"        self._chassis \u003d chassis"},{"line_number":24,"context_line":"        self._datetime \u003d None"},{"line_number":25,"context_line":"        self._offset \u003d None"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_manager(self, identity):"},{"line_number":28,"context_line":"        \"\"\"Get a manager by its identity"}],"source_content_type":"text/x-python","patch_set":8,"id":"c33b6ab8_cc881131","line":25,"updated":"2025-06-10 09:47:43.000000000","message":"Lets make this datetimelocaloffset, offset alone might not be immediately clear","commit_id":"58ba04bff892bd501d3a16f0562f1b3147833e9f"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"c667ec91651b5496a07c1d3c430395ddf1437cee","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        self._systems \u003d systems"},{"line_number":23,"context_line":"        self._chassis \u003d chassis"},{"line_number":24,"context_line":"        self._datetime \u003d None"},{"line_number":25,"context_line":"        self._offset \u003d None"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_manager(self, identity):"},{"line_number":28,"context_line":"        \"\"\"Get a manager by its identity"}],"source_content_type":"text/x-python","patch_set":8,"id":"dcab2d83_f94d46e6","line":25,"in_reply_to":"c33b6ab8_cc881131","updated":"2025-06-11 07:44:27.000000000","message":"Thank you for the feedback. The \"offset\" change has been made to provide clarity as suggested.","commit_id":"58ba04bff892bd501d3a16f0562f1b3147833e9f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4419368b193be95a14a7de3c3d0470b6af3f6757","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            )"},{"line_number":52,"context_line":"            return result"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def set_datetime(self, datetime_value, offset_value):"},{"line_number":55,"context_line":"        \"\"\"Set the datetime and offset information for a manager"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :param datetime_value: The datetime string to set"}],"source_content_type":"text/x-python","patch_set":8,"id":"d9a6342c_feb09f98","line":54,"updated":"2025-06-10 16:04:10.000000000","message":"we should probably add unit test for this","commit_id":"58ba04bff892bd501d3a16f0562f1b3147833e9f"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"8e0837c40a882f3c8717f59cff0f76f07edf8711","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            )"},{"line_number":52,"context_line":"            return result"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def set_datetime(self, datetime_value, offset_value):"},{"line_number":55,"context_line":"        \"\"\"Set the datetime and offset information for a manager"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :param datetime_value: The datetime string to set"}],"source_content_type":"text/x-python","patch_set":8,"id":"109d8b4b_3366da7d","line":54,"in_reply_to":"d9a6342c_feb09f98","updated":"2025-06-11 20:44:49.000000000","message":"Acknowledged","commit_id":"58ba04bff892bd501d3a16f0562f1b3147833e9f"}]}