)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"84a52daf01323ca4c9388bb4dc3321d5a23bd459","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c278c3c_6a4a75bf","updated":"2025-07-15 22:10:00.000000000","message":"recheck","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"8bfe7209270df6443744a56ccf820707fea23bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"718ef63d_bf200b2c","updated":"2025-07-15 21:22:14.000000000","message":"recheck","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"58553b580bb06049d852765a3a04a2331c004ebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c4ce416_60e34130","updated":"2025-07-16 07:53:46.000000000","message":"this is ok, but you may want to consider a different way; the -1 is for the logger related comment, not forcing you to change the implementation!","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"c0d3f31b852332d10c9ec2cd6c430ae39aaca1f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e087d206_f59fd1cf","in_reply_to":"3c278c3c_6a4a75bf","updated":"2025-07-15 22:16:09.000000000","message":"(Accidental duplicate recheck, please ignore.)","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"}],"sushy_tools/emulator/main.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"58553b580bb06049d852765a3a04a2331c004ebb","unresolved":true,"context_lines":[{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        if not flask.request.is_json:"},{"line_number":410,"context_line":"            app.logger.warning("},{"line_number":411,"context_line":"                \"PATCH to /Managers/%s missing or invalid JSON\", identity)"},{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"37c61643_148fd45c","line":410,"range":{"start_line":410,"start_character":0,"end_line":410,"end_character":31},"updated":"2025-07-16 07:53:46.000000000","message":"this is actually an error, let\u0027s change it to \u0027app.logger.error\u0027","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"63169a1c6f5f2e4721a9a65bf8f2724140b595cd","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        if not flask.request.is_json:"},{"line_number":410,"context_line":"            app.logger.warning("},{"line_number":411,"context_line":"                \"PATCH to /Managers/%s missing or invalid JSON\", identity)"},{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd0ba3ed_c8f6e993","line":410,"range":{"start_line":410,"start_character":0,"end_line":410,"end_character":31},"in_reply_to":"37c61643_148fd45c","updated":"2025-07-16 22:34:16.000000000","message":"Acknowledged","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"58553b580bb06049d852765a3a04a2331c004ebb","unresolved":true,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        if not flask.request.is_json:"},{"line_number":410,"context_line":"            app.logger.warning("},{"line_number":411,"context_line":"                \"PATCH to /Managers/%s missing or invalid JSON\", identity)"},{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f3c48be_b3d1f6ad","line":411,"range":{"start_line":411,"start_character":17,"end_line":411,"end_character":25},"updated":"2025-07-16 07:53:46.000000000","message":"nit: \u0027PATCH method missing in /Managers/%s\u0027","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"63169a1c6f5f2e4721a9a65bf8f2724140b595cd","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        if not flask.request.is_json:"},{"line_number":410,"context_line":"            app.logger.warning("},{"line_number":411,"context_line":"                \"PATCH to /Managers/%s missing or invalid JSON\", identity)"},{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"39352b28_3a55c331","line":411,"range":{"start_line":411,"start_character":17,"end_line":411,"end_character":25},"in_reply_to":"1f3c48be_b3d1f6ad","updated":"2025-07-16 22:34:16.000000000","message":"Acknowledged","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"58553b580bb06049d852765a3a04a2331c004ebb","unresolved":true,"context_lines":[{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        data \u003d flask.request.get_json()"},{"line_number":416,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":417,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8b5f12c6_5c51da90","line":415,"updated":"2025-07-16 07:53:46.000000000","message":"this implementation is fine, although I guess you could just try on the get_json method, without the force option; in that case, if json decoding fails, it will raise a BadRequest https://tedboy.github.io/flask/generated/generated/flask.Request.get_json.html","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"63169a1c6f5f2e4721a9a65bf8f2724140b595cd","unresolved":true,"context_lines":[{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        data \u003d flask.request.get_json()"},{"line_number":416,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":417,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f2f86472_e8524dc4","line":415,"in_reply_to":"8b5f12c6_5c51da90","updated":"2025-07-16 22:34:16.000000000","message":"Thanks for the feedback. I went ahead and updated the implementation to rely on Flask’s default get_json() behavior without force\u003dTrue, as you suggested. This keeps things cleaner and still handles invalid JSON with a BadRequest.","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"8dbb0b07577c87271914e659e435ddacb051a4f4","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            raise error.BadRequest("},{"line_number":413,"context_line":"                \"Request must be valid JSON with correct Content-Type header\")"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        data \u003d flask.request.get_json()"},{"line_number":416,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":417,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3b33e534_e118af9e","line":415,"in_reply_to":"f2f86472_e8524dc4","updated":"2025-07-16 22:36:29.000000000","message":"Acknowledged","commit_id":"1fec6cefe3b1feb525fb61dc6fbb9663bea0cfc8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ba674b7811f69c481e8d7125f16c1be67fef3cd9","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json()"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8680db05_74a38b5d","line":409,"updated":"2025-07-17 08:44:32.000000000","message":"should we maybe enclose this in a try..except block? we can raise the exception after, but we need to catch it, it will be more clean if we provide a message","commit_id":"fdb7be1962c5eab06465fb72745d3d2902c953a4"},{"author":{"_account_id":37841,"name":"Queensly Kyerewaa Acheampongmaa","display_name":"Queensly Kyerewaa Acheampongmaa","email":"qacheampong@gmail.com","username":"queensly"},"change_message_id":"4a4a27c45edc04decf7b138fb67c5c49d9b9fd85","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        if app.feature_set !\u003d \"full\":"},{"line_number":407,"context_line":"            raise error.MethodNotAllowed(\"PATCH not supported in minimum mode\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        data \u003d flask.request.get_json()"},{"line_number":410,"context_line":"        new_datetime \u003d data.get(\"DateTime\")"},{"line_number":411,"context_line":"        new_offset \u003d data.get(\"DateTimeLocalOffset\")"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1b93b424_b42daa36","line":409,"in_reply_to":"8680db05_74a38b5d","updated":"2025-07-19 14:12:54.000000000","message":"Thanks for the feedback. I have updated the code with try and except to catch the\nBadRequest with an error message.","commit_id":"fdb7be1962c5eab06465fb72745d3d2902c953a4"}]}