)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2cebdfe4c52dab7b67a60fc02add70c1661aa72","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Treat an empty advertised HttpBootUri as already unset. This keeps"},{"line_number":10,"context_line":"Sushy from sending an unnecessary null property in the Settings"},{"line_number":11,"context_line":"PATCH, which some BMCs reject with a 404 status."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2170219"},{"line_number":14,"context_line":"Assisted-by: Codex (GPT-6-luna/extra-high)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4ec6409e_800fd544","line":11,"range":{"start_line":11,"start_character":37,"end_line":11,"end_character":40},"updated":"2026-10-09 07:42:54.000000000","message":"nit: the bug mentions 400, which one is correct ?","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"d637c05d60bbe54feac16e8373763f1f7ae2c0fb","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Treat an empty advertised HttpBootUri as already unset. This keeps"},{"line_number":10,"context_line":"Sushy from sending an unnecessary null property in the Settings"},{"line_number":11,"context_line":"PATCH, which some BMCs reject with a 404 status."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2170219"},{"line_number":14,"context_line":"Assisted-by: Codex (GPT-6-luna/extra-high)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"08b140d1_d6ea4373","line":11,"range":{"start_line":11,"start_character":37,"end_line":11,"end_character":40},"in_reply_to":"4ec6409e_800fd544","updated":"2026-10-09 12:26:50.000000000","message":"ya, sorry... was debugging something else at the same time and had 404 on the brain.  I\u0027ll update that.","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"}],"sushy/resources/system/system.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559584471ba5116f448878f76e87545bad5aff6c","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                boot_data \u003d data"},{"line_number":401,"context_line":"                current_value \u003d None"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            if not only_if_set or current_value:"},{"line_number":404,"context_line":"                boot_data[\u0027Boot\u0027][name] \u003d value"},{"line_number":405,"context_line":"            return True"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6363b83b_84def7c0","line":403,"updated":"2026-10-09 06:58:17.000000000","message":"You bug is talking about sending None as a value, which the previous condition already covered. Maybe the logic is actually wrong about `only_if_set`?","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5377cf496c1c0a0da335bc9ee7f72ebe166ada4b","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                boot_data \u003d data"},{"line_number":401,"context_line":"                current_value \u003d None"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            if not only_if_set or current_value:"},{"line_number":404,"context_line":"                boot_data[\u0027Boot\u0027][name] \u003d value"},{"line_number":405,"context_line":"            return True"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d9c53d17_efcce3a8","line":403,"in_reply_to":"6363b83b_84def7c0","updated":"2026-10-09 07:40:10.000000000","message":"the bug mentions setting the uri to null also with an empty string, which is not None, so I think this is correct","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"d289811d3eac21d8fa7b9cb9e7357222cb5d3e58","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                boot_data \u003d data"},{"line_number":401,"context_line":"                current_value \u003d None"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            if not only_if_set or current_value:"},{"line_number":404,"context_line":"                boot_data[\u0027Boot\u0027][name] \u003d value"},{"line_number":405,"context_line":"            return True"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"197d06b0_c775061b","line":403,"in_reply_to":"ba27b920_b021b145","updated":"2026-10-10 13:16:11.000000000","message":"I should point out that my current patch essentially restores the behaviour prior to Yorick\u0027s change with the same boolean check on the value.   I think it\u0027s best to put it back to that and eliminate the regression and then if a further change is required because sending `null` turns out to be illegal.\n\n```\n    if settings_boot_section.get(\u0027HttpBootUri\u0027):\n        # If the setting is present, and has any value, unset it.\n        data[\u0027Boot\u0027][\u0027HttpBootUri\u0027] \u003d None\n```","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"},{"author":{"_account_id":39370,"name":"Yorick Gersie","display_name":"Yorick","email":"15vinder_aftrap@icloud.com","username":"yorick"},"change_message_id":"db58b0fb34df49ba7314a0e558fef2699b677582","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                boot_data \u003d data"},{"line_number":401,"context_line":"                current_value \u003d None"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            if not only_if_set or current_value:"},{"line_number":404,"context_line":"                boot_data[\u0027Boot\u0027][name] \u003d value"},{"line_number":405,"context_line":"            return True"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f96a18e0_2e299204","line":403,"in_reply_to":"d9c53d17_efcce3a8","updated":"2026-10-09 08:36:09.000000000","message":"Would it make sense to make it explicitly an empty string check rather than relying on Python\u0027s boolean evaluations?\n```\nif not only_if_set or current_value not in (None, \u0027\u0027):\n```","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"},{"author":{"_account_id":25437,"name":"Allain Legacy","email":"alegacy@redhat.com","username":"alegacy"},"change_message_id":"d637c05d60bbe54feac16e8373763f1f7ae2c0fb","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                boot_data \u003d data"},{"line_number":401,"context_line":"                current_value \u003d None"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"            if not only_if_set or current_value:"},{"line_number":404,"context_line":"                boot_data[\u0027Boot\u0027][name] \u003d value"},{"line_number":405,"context_line":"            return True"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba27b920_b021b145","line":403,"in_reply_to":"f96a18e0_2e299204","updated":"2026-10-09 12:26:50.000000000","message":"I could change it to `not in (None, \u0027\u0027)`.  I suppose that would protect other uses against valid Falsey values.  \n\nBut, I wonder if this is the right fix for this.  Digging a little deeper, the DTMF spec seems to say that \u0027\u0027 is the proper uninitialized value for an empty string and that seeing a null would indicate some sort of error... which I guess it would make it fair to interpret setting it as a null an error as well.\n\nSee section 9.5.3 here:\nhttps://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.17.1.html","commit_id":"79aa02986a736d90a6b4460ce2b44537a055b778"}]}
