)]}'
{"sushy/resources/base.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"d8d60d069555ed78d960bb90c773ac15eb1ba334","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class Field(object):"},{"line_number":30,"context_line":"    \"\"\"Definition for fields fetched from JSON.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, field, required\u003dFalse, default\u003dNone, adapter\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"Create a field definition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param field: JSON field to fetch the value from. Either a string,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_dc1649f2","line":32,"range":{"start_line":32,"start_character":60,"end_line":32,"end_character":72},"updated":"2017-05-16 15:33:24.000000000","message":"how about adapter\u003dlambda x: x instead? No need to check the type so hard later on ;)","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"d8d60d069555ed78d960bb90c773ac15eb1ba334","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class Field(object):"},{"line_number":30,"context_line":"    \"\"\"Definition for fields fetched from JSON.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, field, required\u003dFalse, default\u003dNone, adapter\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"Create a field definition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param field: JSON field to fetch the value from. Either a string,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_07ca1e6c","line":32,"range":{"start_line":32,"start_character":23,"end_line":32,"end_character":28},"updated":"2017-05-16 15:33:24.000000000","message":"name perhaps?","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class Field(object):"},{"line_number":30,"context_line":"    \"\"\"Definition for fields fetched from JSON.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, field, required\u003dFalse, default\u003dNone, adapter\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"Create a field definition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param field: JSON field to fetch the value from. Either a string,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_ec76eca4","line":32,"range":{"start_line":32,"start_character":60,"end_line":32,"end_character":72},"in_reply_to":"1f013ff3_dc1649f2","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"d8d60d069555ed78d960bb90c773ac15eb1ba334","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"Create a field definition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param field: JSON field to fetch the value from. Either a string,"},{"line_number":36,"context_line":"            or a list of string in case of a nested field."},{"line_number":37,"context_line":"        :param required: whether this field is required. Missing required"},{"line_number":38,"context_line":"            fields result in MissingAttributeError."},{"line_number":39,"context_line":"        :param default: the default value to use when the field is missing."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_dcfd29b2","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":31},"updated":"2017-05-16 15:33:24.000000000","message":"nit: strings","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"Create a field definition."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param field: JSON field to fetch the value from. Either a string,"},{"line_number":36,"context_line":"            or a list of string in case of a nested field."},{"line_number":37,"context_line":"        :param required: whether this field is required. Missing required"},{"line_number":38,"context_line":"            fields result in MissingAttributeError."},{"line_number":39,"context_line":"        :param default: the default value to use when the field is missing."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_cc79e893","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":31},"in_reply_to":"1f013ff3_dcfd29b2","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self._default \u003d default"},{"line_number":56,"context_line":"        self._adapter \u003d adapter"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def load(self, resource, body, nested_in\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Load this field from a JSON object."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param resource: ResourceBase instance for which the field is loaded."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_0b593f59","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":27},"updated":"2017-05-18 19:01:30.000000000","message":"``resource`` also seems to be for error reporting only. Can it move to be the 2nd place in the parameter list making way for ``body`` to be in the 1st?\n\n    def load(self, body, resource, nested_in\u003dNone):\n      ...","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self._default \u003d default"},{"line_number":56,"context_line":"        self._adapter \u003d adapter"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def load(self, resource, body, nested_in\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Load this field from a JSON object."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param resource: ResourceBase instance for which the field is loaded."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_8c73f0b1","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":27},"in_reply_to":"ff0f0b1f_0b593f59","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param resource: ResourceBase instance for which the field is loaded."},{"line_number":62,"context_line":"        :param body: parsed JSON body."},{"line_number":63,"context_line":"        :param nested_in: parent resource name (for error reporting only)."},{"line_number":64,"context_line":"        :raises: MissingAttributeError if a required field is missing."},{"line_number":65,"context_line":"        :raises: MalformedAttributeError on invalid field value or type."},{"line_number":66,"context_line":"        :returns: loaded and verified value"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_feeea786","line":63,"range":{"start_line":63,"start_character":42,"end_line":63,"end_character":46},"updated":"2017-05-18 19:01:30.000000000","message":"s/name/hierarchy","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param resource: ResourceBase instance for which the field is loaded."},{"line_number":62,"context_line":"        :param body: parsed JSON body."},{"line_number":63,"context_line":"        :param nested_in: parent resource name (for error reporting only)."},{"line_number":64,"context_line":"        :raises: MissingAttributeError if a required field is missing."},{"line_number":65,"context_line":"        :raises: MalformedAttributeError on invalid field value or type."},{"line_number":66,"context_line":"        :returns: loaded and verified value"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_6caf7ce3","line":63,"range":{"start_line":63,"start_character":42,"end_line":63,"end_character":46},"in_reply_to":"ff0f0b1f_feeea786","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"d8d60d069555ed78d960bb90c773ac15eb1ba334","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :returns: loaded and verified value"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        name \u003d self._field[-1]"},{"line_number":69,"context_line":"        for path_item in self._field[:-1]:"},{"line_number":70,"context_line":"            body \u003d body.get(path_item, {})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if name not in body and self._required:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_bc8a5d18","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":42},"updated":"2017-05-16 15:33:24.000000000","message":"I guess self._field is an unfortunate name as this is actually path elements, right? ;)","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :returns: loaded and verified value"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        name \u003d self._field[-1]"},{"line_number":69,"context_line":"        for path_item in self._field[:-1]:"},{"line_number":70,"context_line":"            body \u003d body.get(path_item, {})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if name not in body and self._required:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_cc87a861","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":42},"in_reply_to":"1f013ff3_bc8a5d18","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ce3db7cb5ff3c561bf9d6b07cfa22d198aa47faf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        for path_item in self._field[:-1]:"},{"line_number":70,"context_line":"            body \u003d body.get(path_item, {})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if name not in body and self._required:"},{"line_number":73,"context_line":"            path \u003d (nested_in or []) + self._field"},{"line_number":74,"context_line":"            raise exceptions.MissingAttributeError("},{"line_number":75,"context_line":"                attribute\u003d\u0027/\u0027.join(path),"},{"line_number":76,"context_line":"                resource\u003dresource.path)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            value \u003d body[name]"},{"line_number":80,"context_line":"        except KeyError:"},{"line_number":81,"context_line":"            # Do not run adapter on the default value"},{"line_number":82,"context_line":"            return self._default"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if self._adapter is not None:"},{"line_number":85,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_3fcc0860","line":82,"range":{"start_line":72,"start_character":8,"end_line":82,"end_character":32},"updated":"2017-05-19 09:54:50.000000000","message":"could just do\n\n if name not in body:\n   if self._required:\n     path \u003d (nested_in or []) + self._field\n     raise exceptions.MissingAttributeError(\n       attribute\u003d\u0027/\u0027.join(path),\n       resource\u003dresource.path)\n   return self._default\n\n value \u003d body[name]\n ...","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58d5d081bb3196f95203d6c9484d679c66aee5ed","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        for path_item in self._field[:-1]:"},{"line_number":70,"context_line":"            body \u003d body.get(path_item, {})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if name not in body and self._required:"},{"line_number":73,"context_line":"            path \u003d (nested_in or []) + self._field"},{"line_number":74,"context_line":"            raise exceptions.MissingAttributeError("},{"line_number":75,"context_line":"                attribute\u003d\u0027/\u0027.join(path),"},{"line_number":76,"context_line":"                resource\u003dresource.path)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            value \u003d body[name]"},{"line_number":80,"context_line":"        except KeyError:"},{"line_number":81,"context_line":"            # Do not run adapter on the default value"},{"line_number":82,"context_line":"            return self._default"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if self._adapter is not None:"},{"line_number":85,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_648756b7","line":82,"range":{"start_line":72,"start_character":8,"end_line":82,"end_character":32},"in_reply_to":"ff0f0b1f_3fcc0860","updated":"2017-05-22 14:31:13.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ce3db7cb5ff3c561bf9d6b07cfa22d198aa47faf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self._adapter is not None:"},{"line_number":85,"context_line":"            try:"},{"line_number":86,"context_line":"                value \u003d self._adapter(value)"},{"line_number":87,"context_line":"            except (UnicodeError, ValueError, TypeError) as exc:"},{"line_number":88,"context_line":"                path \u003d (nested_in or []) + self._field"},{"line_number":89,"context_line":"                raise exceptions.MalformedAttributeError("},{"line_number":90,"context_line":"                    attribute\u003d\u0027/\u0027.join(path),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_9f00b469","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":56},"updated":"2017-05-19 09:54:50.000000000","message":"Do we have some constraints on what adapter should do/raise?","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"82530f4d5122a9db7872105376f14bbdb08bf0fe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self._adapter is not None:"},{"line_number":85,"context_line":"            try:"},{"line_number":86,"context_line":"                value \u003d self._adapter(value)"},{"line_number":87,"context_line":"            except (UnicodeError, ValueError, TypeError) as exc:"},{"line_number":88,"context_line":"                path \u003d (nested_in or []) + self._field"},{"line_number":89,"context_line":"                raise exceptions.MalformedAttributeError("},{"line_number":90,"context_line":"                    attribute\u003d\u0027/\u0027.join(path),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_1408c98f","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":56},"in_reply_to":"ff0f0b1f_248dded2","updated":"2017-05-22 15:35:11.000000000","message":"Oh, right, missed this :)","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58d5d081bb3196f95203d6c9484d679c66aee5ed","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self._adapter is not None:"},{"line_number":85,"context_line":"            try:"},{"line_number":86,"context_line":"                value \u003d self._adapter(value)"},{"line_number":87,"context_line":"            except (UnicodeError, ValueError, TypeError) as exc:"},{"line_number":88,"context_line":"                path \u003d (nested_in or []) + self._field"},{"line_number":89,"context_line":"                raise exceptions.MalformedAttributeError("},{"line_number":90,"context_line":"                    attribute\u003d\u0027/\u0027.join(path),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_248dded2","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":56},"in_reply_to":"ff0f0b1f_9f00b469","updated":"2017-05-22 14:31:13.000000000","message":"They\u0027re described in the adapter docstring","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"def _collect_fields(resource):"},{"line_number":98,"context_line":"    \"\"\"Collect fields from the JSON."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    :param resource: ResourceBase instance."},{"line_number":101,"context_line":"    :returns: generator of tuples (key, field)"},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    for attr in dir(resource.__class__):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_be3dcfbc","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":43},"updated":"2017-05-18 19:01:30.000000000","message":"it can also be a CompoundField instance as  in case of l128 here.","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"def _collect_fields(resource):"},{"line_number":98,"context_line":"    \"\"\"Collect fields from the JSON."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    :param resource: ResourceBase instance."},{"line_number":101,"context_line":"    :returns: generator of tuples (key, field)"},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    for attr in dir(resource.__class__):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_ac7eb468","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":43},"in_reply_to":"ff0f0b1f_be3dcfbc","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":110,"context_line":"class CompoundField(Field):"},{"line_number":111,"context_line":"    \"\"\"Base class for fields consisting of several sub-fields.\"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def load(self, resource, body, nested_in\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_4b7617db","line":110,"range":{"start_line":110,"start_character":6,"end_line":110,"end_character":19},"updated":"2017-05-18 19:01:30.000000000","message":"nit: To me, ``CompositeField`` seems to be more apt, but  feel free to ignore. Of course, nicer to name it as either ``CompositeFieldBase`` OR ``CompoundFieldBase``.","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":110,"context_line":"class CompoundField(Field):"},{"line_number":111,"context_line":"    \"\"\"Base class for fields consisting of several sub-fields.\"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def load(self, resource, body, nested_in\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_accc74bc","line":110,"range":{"start_line":110,"start_character":6,"end_line":110,"end_character":19},"in_reply_to":"ff0f0b1f_4b7617db","updated":"2017-05-19 08:33:05.000000000","message":"They seem to be synonyms, but ok","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ce3db7cb5ff3c561bf9d6b07cfa22d198aa47faf","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if value is None:"},{"line_number":124,"context_line":"            return None"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # We need a new instance, as load() is called on a singleton"},{"line_number":127,"context_line":"        instance \u003d copy.copy(self)"},{"line_number":128,"context_line":"        for attr, field in _collect_fields(self):"},{"line_number":129,"context_line":"            # Hide the Field object behind the real value"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_ff02100b","line":126,"range":{"start_line":126,"start_character":37,"end_line":126,"end_character":68},"updated":"2017-05-19 09:54:50.000000000","message":"not really sure what this means :(","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58d5d081bb3196f95203d6c9484d679c66aee5ed","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if value is None:"},{"line_number":124,"context_line":"            return None"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # We need a new instance, as load() is called on a singleton"},{"line_number":127,"context_line":"        instance \u003d copy.copy(self)"},{"line_number":128,"context_line":"        for attr, field in _collect_fields(self):"},{"line_number":129,"context_line":"            # Hide the Field object behind the real value"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_044e5a96","line":126,"range":{"start_line":126,"start_character":37,"end_line":126,"end_character":68},"in_reply_to":"ff0f0b1f_ff02100b","updated":"2017-05-22 14:31:13.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"class MappedField(Field):"},{"line_number":136,"context_line":"    \"\"\"Field taking real value from a mapping.\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, field, mapping, required\u003dFalse, default\u003dNone):"},{"line_number":139,"context_line":"        \"\"\"Create a field definition."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :param field: JSON field to fetch the value from. This can be either"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_b9e3a905","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":37},"updated":"2017-05-18 19:01:30.000000000","message":"do we require any kind of valiation to be done on ``mapping`` before we pass on ``mapping.get`` as adapter?","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"class MappedField(Field):"},{"line_number":136,"context_line":"    \"\"\"Field taking real value from a mapping.\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, field, mapping, required\u003dFalse, default\u003dNone):"},{"line_number":139,"context_line":"        \"\"\"Create a field definition."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :param field: JSON field to fetch the value from. This can be either"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_cc6328b1","line":138,"range":{"start_line":138,"start_character":30,"end_line":138,"end_character":37},"in_reply_to":"ff0f0b1f_b9e3a905","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    \"\"\"Field taking real value from a mapping.\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, field, mapping, required\u003dFalse, default\u003dNone):"},{"line_number":139,"context_line":"        \"\"\"Create a field definition."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :param field: JSON field to fetch the value from. This can be either"},{"line_number":142,"context_line":"            a string or a list of string. In the latter case, the value will"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_b9f5e9cd","line":139,"range":{"start_line":139,"start_character":20,"end_line":139,"end_character":26},"updated":"2017-05-18 19:01:30.000000000","message":"s/field/\"mapped field\"","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    \"\"\"Field taking real value from a mapping.\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, field, mapping, required\u003dFalse, default\u003dNone):"},{"line_number":139,"context_line":"        \"\"\"Create a field definition."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :param field: JSON field to fetch the value from. This can be either"},{"line_number":142,"context_line":"            a string or a list of string. In the latter case, the value will"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_ac359448","line":139,"range":{"start_line":139,"start_character":20,"end_line":139,"end_character":26},"in_reply_to":"ff0f0b1f_b9f5e9cd","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if isinstance(path, six.string_types):"},{"line_number":51,"context_line":"            path \u003d [path]"},{"line_number":52,"context_line":"        elif not path:"},{"line_number":53,"context_line":"            raise ValueError(\u0027Field cannot be empty\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._path \u003d path"},{"line_number":56,"context_line":"        self._required \u003d required"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_c2508f0d","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":35},"updated":"2017-05-19 10:18:48.000000000","message":"nit: Path?","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if isinstance(path, six.string_types):"},{"line_number":51,"context_line":"            path \u003d [path]"},{"line_number":52,"context_line":"        elif not path:"},{"line_number":53,"context_line":"            raise ValueError(\u0027Field cannot be empty\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._path \u003d path"},{"line_number":56,"context_line":"        self._required \u003d required"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_24027e0c","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":35},"in_reply_to":"ff0f0b1f_c2508f0d","updated":"2017-05-22 14:37:01.000000000","message":"Done","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            # Hide the Field object behind the real value"},{"line_number":206,"context_line":"            setattr(self, attr, field.load(self.json, self))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def refresh(self):"},{"line_number":209,"context_line":"        \"\"\"Refresh the resource"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        Freshly retrieves/fetches the resource attributes and invokes"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_9db55cd0","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":15},"updated":"2017-05-19 10:18:48.000000000","message":"makes me wonder whether not to use the __get__, __set__, __delete__ interface here as I think accessing instance-level attributes might be the point of parsing/reloading the json... but unsure O:-)","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            # Hide the Field object behind the real value"},{"line_number":206,"context_line":"            setattr(self, attr, field.load(self.json, self))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def refresh(self):"},{"line_number":209,"context_line":"        \"\"\"Refresh the resource"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        Freshly retrieves/fetches the resource attributes and invokes"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_df2eef90","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":15},"in_reply_to":"ff0f0b1f_9db55cd0","updated":"2017-05-22 14:37:01.000000000","message":"Well, I thought about that, but the resulting interface was actually the same. E.g. we still need to keep attributes on the resource, as descriptors are singletons.","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"94c55f5b7c6b2cb53e1021a65692a57119accf87","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if value is None:"},{"line_number":128,"context_line":"            return None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # We need a new instance, as this method is called a singleton instance"},{"line_number":131,"context_line":"        # that is attached to a class (not instance) of a resource or another"},{"line_number":132,"context_line":"        # CompositeField. We don\u0027t want to end up modifying this instance."},{"line_number":133,"context_line":"        instance \u003d copy.copy(self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3454ed20","line":130,"range":{"start_line":130,"start_character":59,"end_line":130,"end_character":60},"updated":"2017-05-22 15:59:30.000000000","message":"on a\n\nthanks for clarifying!","commit_id":"0c3ebfb3194ecb81f57865076c793f1276409010"}],"sushy/resources/system/processor.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Processor(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":30,"context_line":"    \"\"\"The processor identity string\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    socket \u003d base.Field(\u0027Socket\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_5d68e41f","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":46},"updated":"2017-05-19 10:18:48.000000000","message":"I\u0027m wondering what consequences setting these as class-level attribute instances has... I mean I can imagine something like:\n\n  class Processor(base.ResourceBase):\n      class Identity(base.Field)\n           path \u003d \u0027Id\u0027\n           required \u003d True\n\n\nThen parsing would be rather instantiation from a json:\n\n   P \u003d Processor(json)\n   P.Identity # would be an instance level attribute\n\nCurrently we\u0027ve got the singletons Composites so this way would be instances. But I didn\u0027t have my coffee yet so I doubt about my doubts here O:-)","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Processor(base.ResourceBase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    identity \u003d base.Field(\u0027Id\u0027, required\u003dTrue)"},{"line_number":30,"context_line":"    \"\"\"The processor identity string\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    socket \u003d base.Field(\u0027Socket\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_1f458743","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":46},"in_reply_to":"ff0f0b1f_5d68e41f","updated":"2017-05-22 14:37:01.000000000","message":"Maybe I\u0027m not fully following you, but this looks like an overkill :) What\u0027s the benefit of that? I was trying to be close to sqlalchemy, django.models and wsme in this approach.","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"}],"sushy/resources/system/system.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ce3db7cb5ff3c561bf9d6b07cfa22d198aa47faf","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ActionsField(base.CompoundField):"},{"line_number":36,"context_line":"    reset \u003d ResetActionField(\u0027#ComputerSystem.Reset\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class BootField(base.CompoundField):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_623f8325","line":36,"updated":"2017-05-19 09:54:50.000000000","message":"Is it for future actions that are going to be added?","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58d5d081bb3196f95203d6c9484d679c66aee5ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ActionsField(base.CompoundField):"},{"line_number":36,"context_line":"    reset \u003d ResetActionField(\u0027#ComputerSystem.Reset\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class BootField(base.CompoundField):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_2454be20","line":36,"in_reply_to":"ff0f0b1f_623f8325","updated":"2017-05-22 14:31:13.000000000","message":"Yes, I suspect more actions are possible.","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027BootSourceOverrideTarget@Redfish.AllowableValues\u0027,"},{"line_number":42,"context_line":"        adapter\u003dlist)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    enabled \u003d base.MappedField(\u0027BootSourceOverrideEnabled\u0027,"},{"line_number":45,"context_line":"                               sys_maps.BOOT_SOURCE_ENABLED_MAP)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    mode \u003d base.MappedField(\u0027BootSourceOverrideMode\u0027,"},{"line_number":48,"context_line":"                            sys_maps.BOOT_SOURCE_MODE_MAP)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    target \u003d base.MappedField(\u0027BootSourceOverrideTarget\u0027,"},{"line_number":51,"context_line":"                              sys_maps.BOOT_SOURCE_TARGET_MAP)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class MemorySummaryField(base.CompoundField):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_8b02c8b3","line":51,"range":{"start_line":44,"start_character":4,"end_line":51,"end_character":62},"updated":"2017-05-18 19:01:30.000000000","message":"Won\u0027t this break the ironic code here?\n\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/redfish/management.py#L140-L142\n\nIronic expects ``sushy_system.boot`` to be a dict. And not as a dot operated attribute accessed object. Help me if I am missing something?","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027BootSourceOverrideTarget@Redfish.AllowableValues\u0027,"},{"line_number":42,"context_line":"        adapter\u003dlist)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    enabled \u003d base.MappedField(\u0027BootSourceOverrideEnabled\u0027,"},{"line_number":45,"context_line":"                               sys_maps.BOOT_SOURCE_ENABLED_MAP)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    mode \u003d base.MappedField(\u0027BootSourceOverrideMode\u0027,"},{"line_number":48,"context_line":"                            sys_maps.BOOT_SOURCE_MODE_MAP)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    target \u003d base.MappedField(\u0027BootSourceOverrideTarget\u0027,"},{"line_number":51,"context_line":"                              sys_maps.BOOT_SOURCE_TARGET_MAP)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class MemorySummaryField(base.CompoundField):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_2c22a401","line":51,"range":{"start_line":44,"start_character":4,"end_line":51,"end_character":62},"in_reply_to":"ff0f0b1f_8b02c8b3","updated":"2017-05-19 08:33:05.000000000","message":"Wow, good catch. Yes, it probably will, not sure why CI passes. I\u0027ll change CompositeField class to also be a mapping.","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fd2b667743b264c36bff9cadc65dc9f7159cd5b2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    memory_summary \u003d MemorySummaryField(\u0027MemorySummary\u0027)"},{"line_number":120,"context_line":"    \"\"\"The summary info of memory of the system in general detail"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        It is a namedtuple containing the following:"},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    _processors \u003d None  # ref to ProcessorCollection instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_6b19b477","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":26},"updated":"2017-05-18 19:01:30.000000000","message":"**not** a namedtuple anymore","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abc1342cb831f255b387612501e123e3b35f895e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    memory_summary \u003d MemorySummaryField(\u0027MemorySummary\u0027)"},{"line_number":120,"context_line":"    \"\"\"The summary info of memory of the system in general detail"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        It is a namedtuple containing the following:"},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    _processors \u003d None  # ref to ProcessorCollection instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_ec794cfc","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":26},"in_reply_to":"ff0f0b1f_6b19b477","updated":"2017-05-19 08:33:05.000000000","message":"Done","commit_id":"84f945605db81a8eca415829e4de57d35523b3a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"79c4299918d61ae8830ae67e954504c60ddf8075","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":132,"context_line":"            the object according to schema of the given version."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        super(System, self).__init__(connector, identity, redfish_version)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _get_reset_action_element(self):"},{"line_number":137,"context_line":"        reset_action \u003d self._actions.reset"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_1db4ac34","line":134,"updated":"2017-05-19 09:59:55.000000000","message":"Shouldn\u0027t we still be setting self._processors to None in __init__ or in _parse_attributes?","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":132,"context_line":"            the object according to schema of the given version."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        super(System, self).__init__(connector, identity, redfish_version)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _get_reset_action_element(self):"},{"line_number":137,"context_line":"        reset_action \u003d self._actions.reset"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_6423d6be","line":134,"in_reply_to":"ff0f0b1f_1db4ac34","updated":"2017-05-22 14:37:01.000000000","message":"we do, see line 122 and refresh()","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"47a4aa018456d34439ba592581eb695b97a03983","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :param redfish_version: The version of RedFish. Used to construct"},{"line_number":132,"context_line":"            the object according to schema of the given version."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        super(System, self).__init__(connector, identity, redfish_version)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _get_reset_action_element(self):"},{"line_number":137,"context_line":"        reset_action \u003d self._actions.reset"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_94a4d9a7","line":134,"in_reply_to":"ff0f0b1f_6423d6be","updated":"2017-05-22 15:34:41.000000000","message":"Yes, but I thought apart from line 122 we should be doing it per instance... can be wrong though","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        return self._processors"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def refresh(self):"},{"line_number":270,"context_line":"        super(System, self).refresh()"},{"line_number":271,"context_line":"        self._processors \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class SystemCollection(base.ResourceCollectionBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_02032711","line":271,"range":{"start_line":269,"start_character":0,"end_line":271,"end_character":31},"updated":"2017-05-19 10:18:48.000000000","message":"this call doesn\u0027t seem to be tested in test_system","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        return self._processors"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def refresh(self):"},{"line_number":270,"context_line":"        super(System, self).refresh()"},{"line_number":271,"context_line":"        self._processors \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class SystemCollection(base.ResourceCollectionBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_640cf640","line":271,"range":{"start_line":269,"start_character":0,"end_line":271,"end_character":31},"in_reply_to":"ff0f0b1f_02032711","updated":"2017-05-22 14:37:01.000000000","message":"I think it actually is, though a bit implicitly.","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"94c55f5b7c6b2cb53e1021a65692a57119accf87","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    memory_summary \u003d MemorySummaryField(\u0027MemorySummary\u0027)"},{"line_number":120,"context_line":"    \"\"\"The summary info of memory of the system in general detail\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    _processors \u003d None  # ref to ProcessorCollection instance"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a75e8d73","line":122,"updated":"2017-05-22 15:59:30.000000000","message":"Ah, so noone seems to be writing the class values, so no need to do self._processors in __init__","commit_id":"0c3ebfb3194ecb81f57865076c793f1276409010"}],"sushy/tests/unit/resources/test_base.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        self.assertEqual(3.14, field[\u0027non_existing\u0027])"},{"line_number":232,"context_line":"        self.assertEqual(3.14, field.get(\u0027non_existing\u0027))"},{"line_number":233,"context_line":"        self.assertIsNone(field.get(\u0027foobar\u0027))"},{"line_number":234,"context_line":"        self.assertRaisesRegex(KeyError, \u0027foobar\u0027, lambda: field[\u0027foobar\u0027])"},{"line_number":235,"context_line":"        # Regular attributes cannot be accessed via mapping"},{"line_number":236,"context_line":"        self.assertRaisesRegex(KeyError, \u0027load\u0027, lambda: field[\u0027load\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a200fb68","line":234,"range":{"start_line":234,"start_character":31,"end_line":234,"end_character":74},"updated":"2017-05-19 10:18:48.000000000","message":"Nit: I like this construct but I\u0027d add a comment, perhaps like:\n\n  # to exercise the __getitem__ mapping interface rather than field.get\n  # as field.get wouldn\u0027t raise on a missing key but return None","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        self.assertEqual(3.14, field[\u0027non_existing\u0027])"},{"line_number":232,"context_line":"        self.assertEqual(3.14, field.get(\u0027non_existing\u0027))"},{"line_number":233,"context_line":"        self.assertIsNone(field.get(\u0027foobar\u0027))"},{"line_number":234,"context_line":"        self.assertRaisesRegex(KeyError, \u0027foobar\u0027, lambda: field[\u0027foobar\u0027])"},{"line_number":235,"context_line":"        # Regular attributes cannot be accessed via mapping"},{"line_number":236,"context_line":"        self.assertRaisesRegex(KeyError, \u0027load\u0027, lambda: field[\u0027load\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_5fad3fe7","line":234,"range":{"start_line":234,"start_character":31,"end_line":234,"end_character":74},"in_reply_to":"ff0f0b1f_a200fb68","updated":"2017-05-22 14:37:01.000000000","message":"I expected it to be more or less obvious for people hacking on Python :)","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"839c32fab3b1a9fa5743129d8f7ddae89ec25e57","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        self.assertIsNone(field.get(\u0027foobar\u0027))"},{"line_number":234,"context_line":"        self.assertRaisesRegex(KeyError, \u0027foobar\u0027, lambda: field[\u0027foobar\u0027])"},{"line_number":235,"context_line":"        # Regular attributes cannot be accessed via mapping"},{"line_number":236,"context_line":"        self.assertRaisesRegex(KeyError, \u0027load\u0027, lambda: field[\u0027load\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_02efa7b0","line":236,"range":{"start_line":236,"start_character":64,"end_line":236,"end_character":68},"updated":"2017-05-19 10:18:48.000000000","message":"nit: I just hope some system don\u0027t expose their cpu.load ;)","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59a5d7d5a67ce8f21c65bd8aa8ff75430f0e3573","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        self.assertIsNone(field.get(\u0027foobar\u0027))"},{"line_number":234,"context_line":"        self.assertRaisesRegex(KeyError, \u0027foobar\u0027, lambda: field[\u0027foobar\u0027])"},{"line_number":235,"context_line":"        # Regular attributes cannot be accessed via mapping"},{"line_number":236,"context_line":"        self.assertRaisesRegex(KeyError, \u0027load\u0027, lambda: field[\u0027load\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_bff0dbfe","line":236,"range":{"start_line":236,"start_character":64,"end_line":236,"end_character":68},"in_reply_to":"ff0f0b1f_02efa7b0","updated":"2017-05-22 14:37:01.000000000","message":"weeeelll... this is a good point actually. not sure what to do, use _load instead?","commit_id":"7043d269d712d568d5b1a95299db7f5a30a0112c"}]}
