)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6db6808ba2b7731a90477ab6c631ac8594d2ae49","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create mappings for System Indicator LED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds mappings and constants for the Indicator LED"},{"line_number":10,"context_line":"value in the System class."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5ecad5d81a6ca1487fab2002d2bc8b57736ab4ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_034143a9","line":9,"updated":"2017-07-20 15:45:39.000000000","message":"nit: don\u0027t need to say \"this patch\"\n\nAdd mappings and constants for the ...","commit_id":"6ff47f309b3fcc14bd30756fdd3032f1b4825a28"}],"releasenotes/notes/indicator-led-mappings-e7b34da03f6abb06.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"621943ee63ff72bed349e0650a1f794aa90409c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":5,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f515b1d_f4d644f2","line":2,"updated":"2017-10-09 16:52:33.000000000","message":"s/fixes/features/\n\nand this is a breaking change for API consumers, we need something in \"upgrade\" section","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"bc4305862ae90d4cdf6d4571d6c2b32b23a4ad99","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":5,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_505a232a","line":2,"in_reply_to":"7f515b1d_f4d644f2","updated":"2018-01-15 05:44:24.000000000","message":"\u003e s/fixes/features/\n \u003e \n \u003e and this is a breaking change for API consumers, we need something\n \u003e in \"upgrade\" section\n\n++","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1916c7f8175d3962313682beb56af1e0821b8c8b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new constants for Indicator LED: ``SYSTEM_INDICATOR_LED_LIT``,"},{"line_number":5,"context_line":"    ``SYSTEM_INDICATOR_LED_BLINKING``, ``SYSTEM_INDICATOR_LED_OFF``,"},{"line_number":6,"context_line":"    ``SYSTEM_INDICATOR_LED_UNKNOWN``."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_fea52c05","line":6,"updated":"2018-05-09 12:32:02.000000000","message":"The goal of the upgrade section is to indicate changes that may affect upgrades. The issue with this patch is that is changes the actual string values that the LED field used to return from upper-case to lower-case. For example, if previously my_system.indicator_led used to return \"Lit\", now it will return \"lit\" (matching SYSTEM_INDICATOR_LED_LIT). This may be a breaking change if somebody has code like:\n\n if my_system.indicator_led \u003d\u003d \"Blinking\":\n    # raise an alert\n\nInitially I thought to have an \"upgrade\" note here to explain this problem. While writing this comment I realized that we should better just keep the values intact.\n\nTL;DR maybe delete the upgrade section (sorry for confusion!) and change the constant values to match the actual values?","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ac9a0c512d8b787784b282a76415e4d67ac253c7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new constants for Indicator LED: ``SYSTEM_INDICATOR_LED_LIT``,"},{"line_number":5,"context_line":"    ``SYSTEM_INDICATOR_LED_BLINKING``, ``SYSTEM_INDICATOR_LED_OFF``,"},{"line_number":6,"context_line":"    ``SYSTEM_INDICATOR_LED_UNKNOWN``."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_df0613cf","line":6,"in_reply_to":"5f7c97a3_fea52c05","updated":"2018-05-10 10:17:50.000000000","message":"Changed the constant values to uppercase.","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1916c7f8175d3962313682beb56af1e0821b8c8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added new constants for Indicator LED: ``SYSTEM_INDICATOR_LED_LIT``,"},{"line_number":5,"context_line":"    ``SYSTEM_INDICATOR_LED_BLINKING``, ``SYSTEM_INDICATOR_LED_OFF``,"},{"line_number":6,"context_line":"    ``SYSTEM_INDICATOR_LED_UNKNOWN``."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":10,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_1ea908de","line":7,"updated":"2018-05-09 12:32:02.000000000","message":"This should be changed to \"features\", since what it describes is not a bug fix.","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ac9a0c512d8b787784b282a76415e4d67ac253c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added new constants for Indicator LED: ``SYSTEM_INDICATOR_LED_LIT``,"},{"line_number":5,"context_line":"    ``SYSTEM_INDICATOR_LED_BLINKING``, ``SYSTEM_INDICATOR_LED_OFF``,"},{"line_number":6,"context_line":"    ``SYSTEM_INDICATOR_LED_UNKNOWN``."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":10,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_ff0bcfd2","line":7,"in_reply_to":"5f7c97a3_1ea908de","updated":"2018-05-10 10:17:50.000000000","message":"renamed to \"features\".","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1916c7f8175d3962313682beb56af1e0821b8c8b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":10,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_beafb4e1","line":10,"updated":"2018-05-09 12:32:02.000000000","message":"Just by convention, we\u0027re using present tense in the release note, so they start with \"Adds\".","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ac9a0c512d8b787784b282a76415e4d67ac253c7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Mappings and constants for possible values of the Indicator LED"},{"line_number":10,"context_line":"    value in the System class were added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_5ffa03bd","line":10,"in_reply_to":"5f7c97a3_beafb4e1","updated":"2018-05-10 10:17:50.000000000","message":"rephrased to start with \"Adds\".","commit_id":"67a37bf201e6173e928a16560a01ef471f2ce866"}],"sushy/resources/system/constants.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"990d5347ddd6c9f38ac3eda6984d25cb9d77d255","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Indicator LED Constants"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"SYSTEM_INDICATOR_LED_LIT \u003d \u0027lit\u0027"},{"line_number":50,"context_line":"SYSTEM_INDICATOR_LED_BLINKING \u003d \u0027blinking\u0027"},{"line_number":51,"context_line":"SYSTEM_INDICATOR_LED_OFF \u003d \u0027off\u0027"},{"line_number":52,"context_line":"SYSTEM_INDICATOR_LED_UNKNOWN \u003d \u0027unknown\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_4b864a68","line":49,"updated":"2018-04-26 09:42:55.000000000","message":"Why comment, not docstring?","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61388ca3b8a6d87f77e8cf9f4f927805b6adf7a1","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Indicator LED Constants"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"SYSTEM_INDICATOR_LED_LIT \u003d \u0027lit\u0027"},{"line_number":50,"context_line":"SYSTEM_INDICATOR_LED_BLINKING \u003d \u0027blinking\u0027"},{"line_number":51,"context_line":"SYSTEM_INDICATOR_LED_OFF \u003d \u0027off\u0027"},{"line_number":52,"context_line":"SYSTEM_INDICATOR_LED_UNKNOWN \u003d \u0027unknown\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_04756995","line":49,"in_reply_to":"9f6a8fd7_4b864a68","updated":"2018-05-07 14:42:31.000000000","message":"Added docstrings with text from the spec. Left the comment as section header.","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"}],"sushy/resources/system/mappings.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"6c258fa380e9b4f74cdad5eeb595897307712925","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0027Unknown\u0027: sys_cons.SYSTEM_INDICATOR_LED_UNKNOWN,"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"SYSTEM_INDICATOR_LED_MAP_REV \u003d utils.revert_dictionary("},{"line_number":50,"context_line":"    SYSTEM_INDICATOR_LED_MAP)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"BOOT_SOURCE_TARGET_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_d3455417","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":28},"updated":"2017-07-20 03:28:19.000000000","message":"nit: not required at this point.","commit_id":"6ff47f309b3fcc14bd30756fdd3032f1b4825a28"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"990d5347ddd6c9f38ac3eda6984d25cb9d77d255","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SYSTEM_POWER_STATE_MAP_REV \u003d utils.revert_dictionary(SYSTEM_POWER_STATE_MAP)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"SYSTEM_INDICATOR_LED_MAP \u003d {"},{"line_number":43,"context_line":"    \u0027Lit\u0027: sys_cons.SYSTEM_INDICATOR_LED_LIT,"},{"line_number":44,"context_line":"    \u0027Blinking\u0027: sys_cons.SYSTEM_INDICATOR_LED_BLINKING,"},{"line_number":45,"context_line":"    \u0027Off\u0027: sys_cons.SYSTEM_INDICATOR_LED_OFF,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_2b42f60f","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":24},"updated":"2018-04-26 09:42:55.000000000","message":"Just wondering, why every other map has a \"reversed\" version, but this one does not?\n\nIs it to be able to set the attribute in addition to read its value? According to the schema [1] IndicatorLED is read-write.\n\n1. https://www.dmtf.org/sites/default/files/standards/documents/DSP2046_2017.0a.pdf","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61388ca3b8a6d87f77e8cf9f4f927805b6adf7a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SYSTEM_POWER_STATE_MAP_REV \u003d utils.revert_dictionary(SYSTEM_POWER_STATE_MAP)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"SYSTEM_INDICATOR_LED_MAP \u003d {"},{"line_number":43,"context_line":"    \u0027Lit\u0027: sys_cons.SYSTEM_INDICATOR_LED_LIT,"},{"line_number":44,"context_line":"    \u0027Blinking\u0027: sys_cons.SYSTEM_INDICATOR_LED_BLINKING,"},{"line_number":45,"context_line":"    \u0027Off\u0027: sys_cons.SYSTEM_INDICATOR_LED_OFF,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_04832955","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":24},"in_reply_to":"9f6a8fd7_2b42f60f","updated":"2018-05-07 14:42:31.000000000","message":"\"reversed\" version was added in initial commit, but was removed after Debayan Ray wrote that this is not necessary at this point.","commit_id":"dc838ab3731afd0d3d6f6b836984b6bb41f22fa2"}]}