)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"fee7459282dd8dd98f8c8fa09cd4eaa0a351e906","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Replace usage of HTTP numeric constants with http_client constants."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"For example instead of: 400 use http_client.BAD_REQUEST"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I81b44d0be844d539da2a5ad4a9e40dbc5d903c94"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_ba3320f6","line":12,"updated":"2017-07-27 02:09:19.000000000","message":"A rephrase suggestion:\n\n    For example: use http_client.BAD_REQUEST instead of 400.","commit_id":"c622e5ba7d7dc7dea37c14ba8b68c3be0de9abef"}],"sushy/exceptions.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"736477d0af4384d732ccb058113a4fff7a8fa8a1","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def raise_for_response(method, url, response):"},{"line_number":119,"context_line":"    \"\"\"Raise a correct error class, if needed.\"\"\""},{"line_number":120,"context_line":"    if response.status_code \u003c http_client.BAD_REQUEST:"},{"line_number":121,"context_line":"        return"},{"line_number":122,"context_line":"    elif response.status_code \u003d\u003d http_client.NOT_FOUND:"},{"line_number":123,"context_line":"        raise ResourceNotFoundError(method, url, response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_559bb316","line":120,"updated":"2017-07-28 07:40:16.000000000","message":"nit: using comparison like that you\u0027re actually assuming that BAD_REQUEST \u003d\u003d 400. I guess it still looks cleaner..","commit_id":"c622e5ba7d7dc7dea37c14ba8b68c3be0de9abef"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"5fc3f14a93a37b97bad44e2dda09726d6c3be9ee","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def raise_for_response(method, url, response):"},{"line_number":119,"context_line":"    \"\"\"Raise a correct error class, if needed.\"\"\""},{"line_number":120,"context_line":"    if response.status_code \u003c http_client.BAD_REQUEST:"},{"line_number":121,"context_line":"        return"},{"line_number":122,"context_line":"    elif response.status_code \u003d\u003d http_client.NOT_FOUND:"},{"line_number":123,"context_line":"        raise ResourceNotFoundError(method, url, response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_10b544ee","line":120,"in_reply_to":"ff346bd7_559bb316","updated":"2017-08-29 20:28:51.000000000","message":"That constant from the six library will always \u003d\u003d 400 though right? Or is there a situation where it\u0027s possible it won\u0027t? https://docs.python.org/2/library/httplib.html#module-httplib","commit_id":"c622e5ba7d7dc7dea37c14ba8b68c3be0de9abef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"736477d0af4384d732ccb058113a4fff7a8fa8a1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    elif response.status_code in (http_client.UNAUTHORIZED,"},{"line_number":127,"context_line":"                                  http_client.FORBIDDEN):"},{"line_number":128,"context_line":"        raise AccessError(method, url, response)"},{"line_number":129,"context_line":"    elif response.status_code \u003e\u003d http_client.INTERNAL_SERVER_ERROR:"},{"line_number":130,"context_line":"        raise ServerSideError(method, url, response)"},{"line_number":131,"context_line":"    else:"},{"line_number":132,"context_line":"        raise HTTPError(method, url, response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_359eef06","line":129,"updated":"2017-07-28 07:40:16.000000000","message":"ditto","commit_id":"c622e5ba7d7dc7dea37c14ba8b68c3be0de9abef"}]}
