)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"},{"line_number":16,"context_line":"Co-Authored-By: Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":17,"context_line":"Partial-Bug: 1751143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_a4cd4731","line":17,"updated":"2018-05-25 14:42:41.000000000","message":"Let\u0027s add:\n\nStory: 1668487\nTask: 12506","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"},{"line_number":16,"context_line":"Co-Authored-By: Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":17,"context_line":"Partial-Bug: 1751143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_0ddd0913","line":17,"in_reply_to":"5f7c97a3_a4cd4731","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"771ae6f15cf370d88d679cce04e6fe4182e190e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"base to use that field across all the Redfish resources."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: 1668487"},{"line_number":22,"context_line":"Task: 12506"},{"line_number":23,"context_line":"Partial-Bug: 1751143"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_67a616af","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":11},"updated":"2018-07-19 07:07:26.000000000","message":"Task: 23041","commit_id":"1c0087fc1becb14c5a6ffcc5ada8fa675d407dea"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"8e5c4045bb3de2757021fe7d271c26f31f8fdc86","unresolved":false,"context_lines":[{"line_number":19,"context_line":"base to use that field across all the Redfish resources."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: 1668487"},{"line_number":22,"context_line":"Task: 12506"},{"line_number":23,"context_line":"Partial-Bug: 1751143"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_4763da41","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":11},"in_reply_to":"5f7c97a3_67a616af","updated":"2018-07-19 07:37:37.000000000","message":"Done","commit_id":"1c0087fc1becb14c5a6ffcc5ada8fa675d407dea"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"771ae6f15cf370d88d679cce04e6fe4182e190e2","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: 1668487"},{"line_number":22,"context_line":"Task: 12506"},{"line_number":23,"context_line":"Partial-Bug: 1751143"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_87a1f294","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":20},"updated":"2018-07-19 07:07:26.000000000","message":"May be we can drop LP ID?","commit_id":"1c0087fc1becb14c5a6ffcc5ada8fa675d407dea"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"8e5c4045bb3de2757021fe7d271c26f31f8fdc86","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: 1668487"},{"line_number":22,"context_line":"Task: 12506"},{"line_number":23,"context_line":"Partial-Bug: 1751143"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I512c2507bf78f4a9cf1e2525fd685836387a7581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_27c57e0a","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":20},"in_reply_to":"5f7c97a3_87a1f294","updated":"2018-07-19 07:37:37.000000000","message":"If that\u0027s what the current norm is I would do it. Thanks!","commit_id":"1c0087fc1becb14c5a6ffcc5ada8fa675d407dea"}],"sushy/resources/constants.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f01f2819a8939f28690441ecd55c5ab074e65970","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Values comes from the Redfish System json-schema 1.0.0:"},{"line_number":14,"context_line":"# http://redfish.dmtf.org/schemas/v1/Resource.json"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Health related constants."},{"line_number":17,"context_line":"HEALTH_OK \u003d \u0027ok\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_502b23e9","line":14,"updated":"2018-07-12 18:39:30.000000000","message":"Thanks for the note.","commit_id":"32c8afbea5142337135e0987adee283e1aedb725"}],"sushy/resources/system/simple_storage.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e6612412c869f75595a7b086e424791fd3f7fa11","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Devices(base.ListField):"},{"line_number":26,"context_line":"    \"\"\"The storage device/s associated with SimpleStorage.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    name \u003d base.Field(\u0027Name\u0027, required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7ae8d17a","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":13},"updated":"2018-04-25 10:24:19.000000000","message":"Should we also be capturing the \u0027state\u0027 of the storage device? I think we should consider only devices that are in \u0027Enabled\u0027 state for computation of \u0027max_size_bytes\u0027 in SimpleStorageCollection.\n\nFrom DMTF mockup [1], the \u0027State\u0027 related information about valid values:\n\nAbsent\tThis function or resource is not present or not detected.\nDeferring\tThe element will not process any commands but will queue new requests.\nDisabled\tThis function or resource has been disabled.\nEnabled\tThis function or resource has been enabled.\nInTest\tThis function or resource is undergoing testing.\nQuiesced\tThe element is enabled but only processes a restricted set of commands.\nStandbyOffline\tThis function or resource is enabled, but awaiting an external action to activate it.\nStandbySpare\tThis function or resource is part of a redundancy set and is awaiting a failover or other external action to activate it.\nStarting\tThis function or resource is starting.\nUnavailableOffline\tThis function or resource is present but cannot be used.\nUpdating\tThe element is updating and may be unavailable or degraded.\n\n[1] https://redfish.dmtf.org/redfish/mockups/v1/863#Systems--437XR1138R2--SimpleStorage--1","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Devices(base.ListField):"},{"line_number":26,"context_line":"    \"\"\"The storage device/s associated with SimpleStorage.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    name \u003d base.Field(\u0027Name\u0027, required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aa65dc46","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":13},"in_reply_to":"9f6a8fd7_7ae8d17a","updated":"2018-06-25 09:14:17.000000000","message":"Thanks Shiv for pointing out this one. I have added this as per your remarks. Added the \u0027enabled-only\u0027 filter to be considered for max device size calculation.","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class SimpleStorageCollection(base.ResourceCollectionBase):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    _max_size_bytes \u003d None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a7d9c956","line":54,"updated":"2018-05-25 14:42:41.000000000","message":"Does a docstring make sense here?","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class SimpleStorageCollection(base.ResourceCollectionBase):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    _max_size_bytes \u003d None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aa987c1a","line":54,"in_reply_to":"5f7c97a3_a7d9c956","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def max_size_bytes(self):"},{"line_number":63,"context_line":"        \"\"\"Max size available in bytes among all device resources.\"\"\""},{"line_number":64,"context_line":"        if self._max_size_bytes is None:"},{"line_number":65,"context_line":"            self._max_size_bytes \u003d ("},{"line_number":66,"context_line":"                utils.max_safe([device.capacity_bytes"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_07c2fd59","line":63,"updated":"2018-05-25 14:42:41.000000000","message":"May be add a note here saying that cached value would be returned?","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def max_size_bytes(self):"},{"line_number":63,"context_line":"        \"\"\"Max size available in bytes among all device resources.\"\"\""},{"line_number":64,"context_line":"        if self._max_size_bytes is None:"},{"line_number":65,"context_line":"            self._max_size_bytes \u003d ("},{"line_number":66,"context_line":"                utils.max_safe([device.capacity_bytes"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0a8730b8","line":63,"in_reply_to":"5f7c97a3_07c2fd59","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"}],"sushy/tests/unit/json_samples/simple_storage.json":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        },"},{"line_number":38,"context_line":"        {"},{"line_number":39,"context_line":"            \"@odata.type\": \"#SimpleStorage.v1_1_0.Device\","},{"line_number":40,"context_line":"            \"Name\": \"SATA Bay 3\","},{"line_number":41,"context_line":"            \"Status\": {"},{"line_number":42,"context_line":"                \"@odata.type\": \"#Resource.Status\","},{"line_number":43,"context_line":"                \"State\": \"Absent\""}],"source_content_type":"application/json","patch_set":1,"id":"5f7c97a3_279b7973","line":40,"updated":"2018-05-25 14:42:41.000000000","message":"May be we still should have the (largest) `CapacityBytes` field to make sure non-Enabled devices are not picked up for storage calculation?","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        },"},{"line_number":38,"context_line":"        {"},{"line_number":39,"context_line":"            \"@odata.type\": \"#SimpleStorage.v1_1_0.Device\","},{"line_number":40,"context_line":"            \"Name\": \"SATA Bay 3\","},{"line_number":41,"context_line":"            \"Status\": {"},{"line_number":42,"context_line":"                \"@odata.type\": \"#Resource.Status\","},{"line_number":43,"context_line":"                \"State\": \"Absent\""}],"source_content_type":"application/json","patch_set":1,"id":"5f7c97a3_8a77c008","line":40,"in_reply_to":"5f7c97a3_279b7973","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"}],"sushy/tests/unit/resources/system/test_simple_storage.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        super(SimpleStorageTestCase, self).setUp()"},{"line_number":25,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":26,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":27,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":28,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.simpl_stor \u003d simple_storage.SimpleStorage("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a7e309d8","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":44},"updated":"2018-05-25 14:42:41.000000000","message":"nit: this is the default and can be omitted","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        super(SimpleStorageTestCase, self).setUp()"},{"line_number":25,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":26,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":27,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":28,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.simpl_stor \u003d simple_storage.SimpleStorage("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6aaa6484","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":44},"in_reply_to":"5f7c97a3_a7e309d8","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":26,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":27,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":28,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.simpl_stor \u003d simple_storage.SimpleStorage("},{"line_number":31,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage/1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_67d171fb","line":28,"range":{"start_line":28,"start_character":64,"end_line":28,"end_character":69},"updated":"2018-05-25 14:42:41.000000000","message":"nit: could you use `json.load(f)` ?","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":26,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":27,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":28,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.simpl_stor \u003d simple_storage.SimpleStorage("},{"line_number":31,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage/1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ca985877","line":28,"range":{"start_line":28,"start_character":64,"end_line":28,"end_character":69},"in_reply_to":"5f7c97a3_67d171fb","updated":"2018-06-25 09:14:17.000000000","message":"\u003e nit: could you use `json.load(f)` ?\n\nAha .. I didn\u0027t personally notice this cousin API earlier. Thank you!","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(SimpleStorageCollectionTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":50,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":51,"context_line":"                  \u0027simple_storage_collection.json\u0027, \u0027r\u0027) as f:"},{"line_number":52,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":53,"context_line":"        self.simpl_stor_col \u003d simple_storage.SimpleStorageCollection("},{"line_number":54,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_47ed55b5","line":51,"range":{"start_line":51,"start_character":52,"end_line":51,"end_character":55},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(SimpleStorageCollectionTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":50,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":51,"context_line":"                  \u0027simple_storage_collection.json\u0027, \u0027r\u0027) as f:"},{"line_number":52,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":53,"context_line":"        self.simpl_stor_col \u003d simple_storage.SimpleStorageCollection("},{"line_number":54,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0a3df02a","line":51,"range":{"start_line":51,"start_character":52,"end_line":51,"end_character":55},"in_reply_to":"5f7c97a3_47ed55b5","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":50,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":51,"context_line":"                  \u0027simple_storage_collection.json\u0027, \u0027r\u0027) as f:"},{"line_number":52,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":53,"context_line":"        self.simpl_stor_col \u003d simple_storage.SimpleStorageCollection("},{"line_number":54,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage\u0027,"},{"line_number":55,"context_line":"            redfish_version\u003d\u00271.0.2\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e72b41e8","line":52,"range":{"start_line":52,"start_character":64,"end_line":52,"end_character":69},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.conn \u003d mock.Mock()"},{"line_number":50,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":51,"context_line":"                  \u0027simple_storage_collection.json\u0027, \u0027r\u0027) as f:"},{"line_number":52,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":53,"context_line":"        self.simpl_stor_col \u003d simple_storage.SimpleStorageCollection("},{"line_number":54,"context_line":"            self.conn, \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage\u0027,"},{"line_number":55,"context_line":"            redfish_version\u003d\u00271.0.2\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2a3a2c33","line":52,"range":{"start_line":52,"start_character":64,"end_line":52,"end_character":69},"in_reply_to":"5f7c97a3_e72b41e8","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.conn.get.return_value.json.reset_mock()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":89,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":90,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_070c3da3","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":44},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.conn.get.return_value.json.reset_mock()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":89,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":90,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aa171ca3","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":44},"in_reply_to":"5f7c97a3_070c3da3","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":89,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":90,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_27f05991","line":90,"range":{"start_line":90,"start_character":64,"end_line":90,"end_character":69},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":89,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":90,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4a08c87e","line":90,"range":{"start_line":90,"start_character":64,"end_line":90,"end_character":69},"in_reply_to":"5f7c97a3_27f05991","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.conn.get.return_value.json.reset_mock()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":105,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":106,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_67fad175","line":105,"range":{"start_line":105,"start_character":41,"end_line":105,"end_character":45},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.conn.get.return_value.json.reset_mock()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":105,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":106,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2a230c07","line":105,"range":{"start_line":105,"start_character":41,"end_line":105,"end_character":45},"in_reply_to":"5f7c97a3_67fad175","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9c49a25364dbefb656c881a155b86e8986186873","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":105,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":106,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_87f7ed8b","line":106,"range":{"start_line":106,"start_character":64,"end_line":106,"end_character":69},"updated":"2018-05-25 14:42:41.000000000","message":"ditto","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"d7ff915ed7fee40cccc7bfa783327e2577a41447","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":105,"context_line":"                  \u0027simple_storage.json\u0027, \u0027r\u0027) as f:"},{"line_number":106,"context_line":"            self.conn.get.return_value.json.return_value \u003d json.loads(f.read())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.assertEqual(8000000000000, self.simpl_stor_col.max_size_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ca1b78c8","line":106,"range":{"start_line":106,"start_character":64,"end_line":106,"end_character":69},"in_reply_to":"5f7c97a3_87f7ed8b","updated":"2018-06-25 09:14:17.000000000","message":"Done","commit_id":"714752fc39c267f99520f17e614074698b57ed0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dfeb398dc527caa8603ef39176fe00385f2a0069","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage/1\u0027,"},{"line_number":85,"context_line":"                      redfish_version\u003dself.simpl_stor_col.redfish_version),"},{"line_number":86,"context_line":"        ]"},{"line_number":87,"context_line":"        SimpleStorage_mock.assert_has_calls(calls)"},{"line_number":88,"context_line":"        self.assertIsInstance(members, list)"},{"line_number":89,"context_line":"        self.assertEqual(1, len(members))"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_e5fc5940","line":87,"updated":"2018-07-19 12:43:19.000000000","message":"nit: assert_called_once_with can be used here","commit_id":"d44059483cbcb14a9c38bff25ec3013721e6e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"f24193998505abb4e46ddd2aec17dcd531227bf6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \u0027/redfish/v1/Systems/437XR1138R2/SimpleStorage/1\u0027,"},{"line_number":85,"context_line":"                      redfish_version\u003dself.simpl_stor_col.redfish_version),"},{"line_number":86,"context_line":"        ]"},{"line_number":87,"context_line":"        SimpleStorage_mock.assert_has_calls(calls)"},{"line_number":88,"context_line":"        self.assertIsInstance(members, list)"},{"line_number":89,"context_line":"        self.assertEqual(1, len(members))"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_4958a855","line":87,"in_reply_to":"5f7c97a3_e5fc5940","updated":"2018-07-20 14:17:35.000000000","message":"\u003e nit: assert_called_once_with can be used here\n\nDoing it as part of https://review.openstack.org/#/c/561863/. Kind of unrelated to that patch, but I hope you wouldn\u0027t mind ;)","commit_id":"d44059483cbcb14a9c38bff25ec3013721e6e56c"}]}
