)]}'
{"sushy/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1cc9b8b3b2f16e722e1df47898ebefb651551fcf","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        registries \u003d {}"},{"line_number":303,"context_line":"        standard \u003d self._get_standard_message_registry_collection()"},{"line_number":304,"context_line":"        set1 \u003d {r.registry_prefix + \u0027.\u0027 +"},{"line_number":305,"context_line":"                r.registry_version.rsplit(\u0027.\u0027, 1)[0]: r for r in standard"},{"line_number":306,"context_line":"                if r.language \u003d\u003d self._language}"},{"line_number":307,"context_line":"        registries.update(set1)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_187d37b1","line":304,"updated":"2019-02-28 10:28:56.000000000","message":"nit: s/set1/registries/ (you don\u0027t need another variable)","commit_id":"5ea48c84845628b52b6b548e48675f0e7ea2ac5f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7930a6afc1a7705225d3afc32f1fc9734ddc9d49","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        registries \u003d {}"},{"line_number":303,"context_line":"        standard \u003d self._get_standard_message_registry_collection()"},{"line_number":304,"context_line":"        set1 \u003d {r.registry_prefix + \u0027.\u0027 +"},{"line_number":305,"context_line":"                r.registry_version.rsplit(\u0027.\u0027, 1)[0]: r for r in standard"},{"line_number":306,"context_line":"                if r.language \u003d\u003d self._language}"},{"line_number":307,"context_line":"        registries.update(set1)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_4da3f19e","line":304,"in_reply_to":"9fdfeff1_187d37b1","updated":"2019-02-28 20:30:14.000000000","message":"updated","commit_id":"5ea48c84845628b52b6b548e48675f0e7ea2ac5f"}],"sushy/resources/base.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0bc268bf1979682b3d11140083936651504778d4","unresolved":false,"context_lines":[{"line_number":275,"context_line":"class JsonPublicFileReader(AbstractJsonReader):"},{"line_number":276,"context_line":"    \"\"\"Loads the data from the Internet\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def get_json(self):"},{"line_number":279,"context_line":"        \"\"\"Get JSON file from full URI\"\"\""},{"line_number":280,"context_line":"        return self._conn.get(self._path).json()"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9c2e748c","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":16},"updated":"2018-12-05 09:32:11.000000000","message":"I don\u0027t see any difference of this with ``JsonFileReader`` (or recently renamed as ``JsonDataReader``) defined above.","commit_id":"4ec410a4a5110bd91740cb38e3c021420a022c4c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3bcafac21d5cfc9aae9f7f17a399bbd0727ca290","unresolved":false,"context_lines":[{"line_number":275,"context_line":"class JsonPublicFileReader(AbstractJsonReader):"},{"line_number":276,"context_line":"    \"\"\"Loads the data from the Internet\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def get_json(self):"},{"line_number":279,"context_line":"        \"\"\"Get JSON file from full URI\"\"\""},{"line_number":280,"context_line":"        return self._conn.get(self._path).json()"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_81518b68","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":16},"in_reply_to":"3f79a3b5_9c2e748c","updated":"2018-12-12 19:19:17.000000000","message":"this works with full URL like http://example.com/redfish-registry that are outside Redfish service\nand it will use python `requests` to get the resource;\n\nThe previous JsonFileReader/JsonDataReader uses sushy connector which accepts only `path`, which is relative like `/Systems/xxx-yyy-zzz`\nHere current sushy connector design is built to requests only resources inside initialized Redfish service root with all the authentication etc. which is not necessary when querying resource outside Redfish service.","commit_id":"4ec410a4a5110bd91740cb38e3c021420a022c4c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1cc9b8b3b2f16e722e1df47898ebefb651551fcf","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        return self._conn.get(path\u003dself._path).json()"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class JsonPublicFileReader(AbstractJsonReader):"},{"line_number":277,"context_line":"    \"\"\"Loads the data from the Internet\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_json(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_787243e5","line":276,"updated":"2019-02-28 10:28:56.000000000","message":"How is this different from JsonDataReader?","commit_id":"5ea48c84845628b52b6b548e48675f0e7ea2ac5f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7930a6afc1a7705225d3afc32f1fc9734ddc9d49","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        return self._conn.get(path\u003dself._path).json()"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class JsonPublicFileReader(AbstractJsonReader):"},{"line_number":277,"context_line":"    \"\"\"Loads the data from the Internet\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_json(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_0de1699b","line":276,"in_reply_to":"9fdfeff1_787243e5","updated":"2019-02-28 20:30:14.000000000","message":"JsonDataReader uses path (e.g., /redfish/v1/Systems), this one uses url (http://example.com/redfish/v1/Systems) to fetch resource.","commit_id":"5ea48c84845628b52b6b548e48675f0e7ea2ac5f"}]}