)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"778fa520723d478ef4671db1c022f9174f63744f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update to use mapped field for Message Severity field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although the schema does not have this field as enum, its description"},{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_30fcbc6e","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":53},"updated":"2018-08-15 13:11:26.000000000","message":"nit: which specification?","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ef4dbb2081f59831509cdbb5e834cd3fbefa48dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update to use mapped field for Message Severity field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although the schema does not have this field as enum, its description"},{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_568610bb","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":53},"in_reply_to":"3f79a3b5_30fcbc6e","updated":"2018-08-15 16:05:00.000000000","message":"Done","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"778fa520723d478ef4671db1c022f9174f63744f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although the schema does not have this field as enum, its description"},{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_f0f16496","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":58},"updated":"2018-08-15 13:11:26.000000000","message":"nit: same as `Status`?","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ef4dbb2081f59831509cdbb5e834cd3fbefa48dc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although the schema does not have this field as enum, its description"},{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ca8cb337","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":58},"in_reply_to":"3f79a3b5_f0f16496","updated":"2018-08-15 16:05:00.000000000","message":"Done","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"778fa520723d478ef4671db1c022f9174f63744f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"},{"line_number":16,"context_line":"other and with severity when handling errors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_d030e858","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":50},"updated":"2018-08-15 13:11:26.000000000","message":"nit: with a clarification that it is actually an enum\n?","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ef4dbb2081f59831509cdbb5e834cd3fbefa48dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"says it is defined as Status field from specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"},{"line_number":16,"context_line":"other and with severity when handling errors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_2a98c772","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":50},"in_reply_to":"3f79a3b5_d030e858","updated":"2018-08-15 16:05:00.000000000","message":"Done","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"778fa520723d478ef4671db1c022f9174f63744f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"},{"line_number":16,"context_line":"other and with severity when handling errors."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1595b1705e2d77f5f4e822ebd87bc6959ee6cf53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_b0168ca7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":17},"updated":"2018-08-15 13:11:26.000000000","message":"nit: This change makes Severity field of the same type as Status field what facilitates their comparison and error handling.\n?","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ef4dbb2081f59831509cdbb5e834cd3fbefa48dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"MessageRegistry Message Severity field has the same schema"},{"line_number":13,"context_line":"where enum is defined as string with clarification in description."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Need to have both fields as mapped fields to better compare each"},{"line_number":16,"context_line":"other and with severity when handling errors."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1595b1705e2d77f5f4e822ebd87bc6959ee6cf53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_6a923f59","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":17},"in_reply_to":"3f79a3b5_b0168ca7","updated":"2018-08-15 16:05:00.000000000","message":"Done","commit_id":"8d925c4294339f8f327f966f1ebb44953189b331"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"9e7f2e2c78ffba0ae464184cecb0ce32275af64e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"as MessageRegistry Message Severity field that facilitates"},{"line_number":22,"context_line":"their comparison and error handling."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"MessageRegistry\u0027s Message and Settings\u0027s Message are similar,"},{"line_number":25,"context_line":"but different field types."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://redfish.dmtf.org/schemas/v1/Resource.json"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_44755ecb","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":26},"updated":"2018-09-16 11:12:09.000000000","message":"Just an attempt to clear the confusion, if any, here:\n\nSettings\u0027s Message contains the message arguments (values) to be substituted on the corresponding MessageRegistry\u0027s Message. In other words, MessageRegistry\u0027 message is the template which gets life from the message arguments from any Resource Settings message (MessageArgs property in [1] is what I\u0027m referring to)\n\nAdditionally, also as an afterthought, can there be a possibility to introduce a middle layered abstract Message base class which can hold the common properties of MessageRegistry\u0027s Message and Settings\u0027 Message?\n\n    @six.add_metaclass(abc.ABCMeta)\n    class MessageBase(Field):\n      message \u003d base.Field(\u0027Message\u0027)\n      severity \u003d base.MappedField(\u0027Severity\u0027, res_maps.SEVERITY_VALUE_MAP)\n      resolution \u003d base.Field(\u0027Resolution\u0027)\n      ...\n\n      \n    class MessageListField(base.ListField, MessageBase):\n      message_args \u003d base.Field(\u0027MessageArgs\u0027)\n      ...\n\n    class MessageDictionaryField(base.DictionaryField, MessageBase):\n      description \u003d base.Field(\u0027Description\u0027, required\u003dTrue)\n      number_of_args \u003d base.Field(\u0027NumberOfArgs\u0027, required\u003dTrue)\n      param_types \u003d base.Field(\u0027ParamTypes\u0027, ...)\n      ...\n\nAny thoughts?\n\n[1] http://redfish.dmtf.org/schemas/v1/Message.v1_0_0.json","commit_id":"0c98a4875a4f191ed9999393c9a9101b75249653"}],"sushy/tests/unit/resources/test_settings.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"a7e981e38ed59adc5ecb3c54c7f51e0ad36d491e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushy.resources import constants as res_cons"},{"line_number":20,"context_line":"from sushy.resources import settings"},{"line_number":21,"context_line":"from sushy.tests.unit import base"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_02ea4f0d","line":19,"updated":"2018-09-25 07:39:13.000000000","message":"FWIW these constants are also exposed to users[1]. What say if we make this import as?\n\n    import sushy\n\n    ...\n    self.assertEqual(sushy.SEVERITY_CRITICAL, instance.messages[0].severity)\n    ...\n\n\n[1] https://github.com/openstack/sushy/blob/master/sushy/__init__.py#L20","commit_id":"0c98a4875a4f191ed9999393c9a9101b75249653"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0c2a4a85ae1892250d886799e5c2ec9ef618c03f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushy.resources import constants as res_cons"},{"line_number":20,"context_line":"from sushy.resources import settings"},{"line_number":21,"context_line":"from sushy.tests.unit import base"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_84ef40b0","line":19,"in_reply_to":"3f79a3b5_02ea4f0d","updated":"2018-09-25 18:01:34.000000000","message":"can take a look at this in a brand new patch as this is not the only place where \u0027res_cons\u0027 is used this way. For example, it is also used in ethernet interface (not related to settings at all) - have to review all project for other cases and update if going in this direction.","commit_id":"0c98a4875a4f191ed9999393c9a9101b75249653"}]}