)]}'
{"sushy/resources/settings.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cd56ffffd94349c82ca644babb9b2d4c2f55040","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self._status \u003d status"},{"line_number":38,"context_line":"        self._messages \u003d messages"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\"Update SettingsUpdateStatus\"\"\""},{"line_number":41,"context_line":"    @property"},{"line_number":42,"context_line":"    def status(self):"},{"line_number":43,"context_line":"        return self._status"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_9810475b","line":40,"updated":"2019-02-28 10:31:33.000000000","message":"\"The status of the update\"?","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self._status \u003d status"},{"line_number":38,"context_line":"        self._messages \u003d messages"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\"Update SettingsUpdateStatus\"\"\""},{"line_number":41,"context_line":"    @property"},{"line_number":42,"context_line":"    def status(self):"},{"line_number":43,"context_line":"        return self._status"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_e2be4bad","line":40,"in_reply_to":"9fdfeff1_9810475b","updated":"2019-03-03 18:30:24.000000000","message":"updated","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cd56ffffd94349c82ca644babb9b2d4c2f55040","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            parsed_msgs.append("},{"line_number":185,"context_line":"                message_registry.parse_message(registries, m))"},{"line_number":186,"context_line":"        any_errors \u003d [m for m in parsed_msgs"},{"line_number":187,"context_line":"                      if not m.severity \u003d\u003d res_cons.SEVERITY_OK]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if any_errors:"},{"line_number":190,"context_line":"            status \u003d SettingsUpdateStatus.UPDATE_FAILURE"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_b813cb64","line":187,"updated":"2019-02-28 10:31:33.000000000","message":"++ (unless we want to output these errors)","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bbd0fd7b6a3170e22735366fc9d2c03d7b6a2997","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        for m in self.messages:"},{"line_number":184,"context_line":"            parsed_msgs.append("},{"line_number":185,"context_line":"                message_registry.parse_message(registries, m))"},{"line_number":186,"context_line":"        any_errors \u003d [m for m in parsed_msgs"},{"line_number":187,"context_line":"                      if not m.severity \u003d\u003d res_cons.SEVERITY_OK]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if any_errors:"},{"line_number":190,"context_line":"            status \u003d SettingsUpdateStatus.UPDATE_FAILURE"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_1d777ba2","line":187,"range":{"start_line":186,"start_character":21,"end_line":187,"end_character":64},"updated":"2019-02-27 17:24:48.000000000","message":"may be using `any()` function would be more efficient as it stops on the first occurred element","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            parsed_msgs.append("},{"line_number":185,"context_line":"                message_registry.parse_message(registries, m))"},{"line_number":186,"context_line":"        any_errors \u003d [m for m in parsed_msgs"},{"line_number":187,"context_line":"                      if not m.severity \u003d\u003d res_cons.SEVERITY_OK]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if any_errors:"},{"line_number":190,"context_line":"            status \u003d SettingsUpdateStatus.UPDATE_FAILURE"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_22f3f3a1","line":187,"in_reply_to":"9fdfeff1_b813cb64","updated":"2019-03-03 18:30:24.000000000","message":"updated to use `any`;\nerrors together with any other severity messages are returned in `parsed_msgs`","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ef7d71f3fc07f3aac0bd30845718d59f560ff667","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        return self._settings_object_idref.resource_uri"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_status(self, registries):"},{"line_number":194,"context_line":"        \"\"\"Determines the status of last update based on message id-s and severity"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        :param registries: registries to use to parse message"},{"line_number":197,"context_line":"        :returns: SettingsUpdate"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_2583c2ce","line":194,"updated":"2019-05-22 08:17:01.000000000","message":"nit: please keep lines length below 80 characters","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f2e15e579965e26dc7ccdaf935f070d6612016b6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        return self._settings_object_idref.resource_uri"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_status(self, registries):"},{"line_number":194,"context_line":"        \"\"\"Determines the status of last update based on message id-s and severity"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        :param registries: registries to use to parse message"},{"line_number":197,"context_line":"        :returns: SettingsUpdate"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_c843ddae","line":194,"in_reply_to":"bfb3d3c7_2583c2ce","updated":"2019-05-22 09:16:31.000000000","message":"updated","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ef7d71f3fc07f3aac0bd30845718d59f560ff667","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        \"\"\"Determines the status of last update based on message id-s and severity"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        :param registries: registries to use to parse message"},{"line_number":197,"context_line":"        :returns: SettingsUpdate"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not self.time:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_4586f6dd","line":197,"updated":"2019-05-22 08:17:01.000000000","message":"maybe a bit more details on this ?","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f2e15e579965e26dc7ccdaf935f070d6612016b6","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        \"\"\"Determines the status of last update based on message id-s and severity"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        :param registries: registries to use to parse message"},{"line_number":197,"context_line":"        :returns: SettingsUpdate"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not self.time:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_08233507","line":197,"in_reply_to":"bfb3d3c7_4586f6dd","updated":"2019-05-22 09:16:31.000000000","message":"added more details and link to class when generating docs + cleaned up docstrings in other places in this file","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1f263880e4bc9ac52732bb6ca44db7982e7dd7a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sushy.resources.registry import message_registry"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class SettingsUpdateStatus(object):"},{"line_number":27,"context_line":"    UPDATE_UNKNOWN \u003d 0,"},{"line_number":28,"context_line":"    \"\"\"Update status unknown\"\"\""},{"line_number":29,"context_line":"    UPDATE_SUCCESS \u003d 1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_2b46337e","line":26,"updated":"2019-05-22 10:03:58.000000000","message":"what\u0027s the reason behind defining a class to assign those constants?\nit would be easier to just define them directly at module level","commit_id":"d641b672158a6d08755a1e2c0f0713327a1371e0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"844407a17ce27e8764bf75019f00d6c5d50a48c4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sushy.resources.registry import message_registry"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class SettingsUpdateStatus(object):"},{"line_number":27,"context_line":"    UPDATE_UNKNOWN \u003d 0,"},{"line_number":28,"context_line":"    \"\"\"Update status unknown\"\"\""},{"line_number":29,"context_line":"    UPDATE_SUCCESS \u003d 1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_f82532ac","line":26,"in_reply_to":"bfb3d3c7_2b46337e","updated":"2019-05-23 11:18:47.000000000","message":"It should have been `SettingsUpdateStatus(Enum)` to group the possible statuses together.\n\nBut I see that Enums are not used in sushy, so moved them to constants.\n\nKeeping it in this file (not in one of the constants.py) as these values do not come from Redfish standard, but are internal to sushy implementation.","commit_id":"d641b672158a6d08755a1e2c0f0713327a1371e0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d6a97ed6e33c7bff2bd7df0c3c1d78c34d35be8e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sushy.resources.registry import message_registry"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"UPDATE_UNKNOWN \u003d 0,"},{"line_number":27,"context_line":"\"\"\"Update status unknown\"\"\""},{"line_number":28,"context_line":"UPDATE_SUCCESS \u003d 1,"},{"line_number":29,"context_line":"\"\"\"Update was successful\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_a1aa26cf","line":26,"updated":"2019-05-23 13:29:46.000000000","message":"you don\u0027t need the comma at the end","commit_id":"764ac46b6135fb42f70c062eed0c326c817495ce"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d380dc5d24bc4f7e2e8db889795ae4b92a7860a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sushy.resources.registry import message_registry"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"UPDATE_UNKNOWN \u003d 0,"},{"line_number":27,"context_line":"\"\"\"Update status unknown\"\"\""},{"line_number":28,"context_line":"UPDATE_SUCCESS \u003d 1,"},{"line_number":29,"context_line":"\"\"\"Update was successful\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_7eca794e","line":26,"in_reply_to":"bfb3d3c7_a1aa26cf","updated":"2019-05-24 08:36:49.000000000","message":"removed","commit_id":"764ac46b6135fb42f70c062eed0c326c817495ce"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d6a97ed6e33c7bff2bd7df0c3c1d78c34d35be8e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"UPDATE_UNKNOWN \u003d 0,"},{"line_number":27,"context_line":"\"\"\"Update status unknown\"\"\""},{"line_number":28,"context_line":"UPDATE_SUCCESS \u003d 1,"},{"line_number":29,"context_line":"\"\"\"Update was successful\"\"\""},{"line_number":30,"context_line":"UPDATE_FAILURE \u003d 2,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_41b9ea2b","line":27,"updated":"2019-05-23 13:29:46.000000000","message":"maybe move the descriptions before the definitions","commit_id":"764ac46b6135fb42f70c062eed0c326c817495ce"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d380dc5d24bc4f7e2e8db889795ae4b92a7860a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"UPDATE_UNKNOWN \u003d 0,"},{"line_number":27,"context_line":"\"\"\"Update status unknown\"\"\""},{"line_number":28,"context_line":"UPDATE_SUCCESS \u003d 1,"},{"line_number":29,"context_line":"\"\"\"Update was successful\"\"\""},{"line_number":30,"context_line":"UPDATE_FAILURE \u003d 2,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_9e32cd5d","line":27,"in_reply_to":"bfb3d3c7_41b9ea2b","updated":"2019-05-24 08:36:49.000000000","message":"They need to be below the definitions for docs to be generated correctly. But added newlines - same as in constants.py.","commit_id":"764ac46b6135fb42f70c062eed0c326c817495ce"}],"sushy/resources/system/bios.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cd56ffffd94349c82ca644babb9b2d4c2f55040","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Bios(base.ResourceBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conn, path, registries, *kargs, **kwargs):"},{"line_number":35,"context_line":"        super(Bios, self).__init__(conn, path, *kargs, **kwargs)"},{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_d81a4f7b","line":34,"updated":"2019-02-28 10:31:33.000000000","message":"I\u0027m not sure why it\u0027s a problem, given that only sushy itself instantiates this class.","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bbd0fd7b6a3170e22735366fc9d2c03d7b6a2997","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Bios(base.ResourceBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conn, path, registries, *kargs, **kwargs):"},{"line_number":35,"context_line":"        super(Bios, self).__init__(conn, path, *kargs, **kwargs)"},{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_3dcb5f1e","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":16},"updated":"2019-02-27 17:24:48.000000000","message":"This change makes subclass instantiation signature different from its base class. I am not sure that\u0027s good... Is there anything we could do to smuggle `registries` in without changing the signature? If not, would it make sense to add `registries` to the base class `__init__` as well?","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bbd0fd7b6a3170e22735366fc9d2c03d7b6a2997","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Bios(base.ResourceBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conn, path, registries, *kargs, **kwargs):"},{"line_number":35,"context_line":"        super(Bios, self).__init__(conn, path, *kargs, **kwargs)"},{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_dd0b33d2","line":34,"range":{"start_line":34,"start_character":48,"end_line":34,"end_character":53},"updated":"2019-02-27 17:24:48.000000000","message":"nit: should this be `args`?","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Bios(base.ResourceBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conn, path, registries, *kargs, **kwargs):"},{"line_number":35,"context_line":"        super(Bios, self).__init__(conn, path, *kargs, **kwargs)"},{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_e2a40b4e","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":16},"in_reply_to":"9fdfeff1_3dcb5f1e","updated":"2019-03-03 18:30:24.000000000","message":"packaged registries are static and could be accessed from anywhere, e.g., when in helper/utils class, but there are also registries that could be served by a Redfish service instance from /Registries sub-resource and this way registries are attached to instance of sushy and starting point is at root of service (main.py). Proposed solution works the way it picks up these packaged registries and serviced registries (if any) and  merge them together in 1 collection and pass down to sub-sub-resources that need this.\n\nCurrently, these registries are used only in Bios which is connected to the root via System and that\u0027s why I have chosen not to add registries to base class as majority of resources will not need these registries. As far as I remember there were not many other use for these message registries elsewhere.","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Bios(base.ResourceBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, conn, path, registries, *kargs, **kwargs):"},{"line_number":35,"context_line":"        super(Bios, self).__init__(conn, path, *kargs, **kwargs)"},{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_a29603ef","line":34,"range":{"start_line":34,"start_character":48,"end_line":34,"end_character":53},"in_reply_to":"9fdfeff1_dd0b33d2","updated":"2019-03-03 18:30:24.000000000","message":"renamed to `args`","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cd56ffffd94349c82ca644babb9b2d4c2f55040","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\"Pending BIOS settings resource\"\"\""},{"line_number":68,"context_line":"        return Bios("},{"line_number":69,"context_line":"            self._conn, self._settings.resource_uri,"},{"line_number":70,"context_line":"            registries\u003dNone,"},{"line_number":71,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_f81dd372","line":70,"updated":"2019-02-28 10:31:33.000000000","message":"s/None/self._registries/ ?","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\"Pending BIOS settings resource\"\"\""},{"line_number":68,"context_line":"        return Bios("},{"line_number":69,"context_line":"            self._conn, self._settings.resource_uri,"},{"line_number":70,"context_line":"            registries\u003dNone,"},{"line_number":71,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_e2f64b5e","line":70,"in_reply_to":"9fdfeff1_f81dd372","updated":"2019-03-03 18:30:24.000000000","message":"not necessary as messages will not be parsed for this \u0027pending settings resource\u0027 property which is a sub-resource for this Bios that has the same structure as Bios except it does not have \u0027settings\u0027 section and thus no need to parse messages. As _pending_settings_resource is meant to be private, will not be used by user directly.","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ef7d71f3fc07f3aac0bd30845718d59f560ff667","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":"        \"\"\"A class representing a Bios"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param path: Sub-URI path to the Bios resource"},{"line_number":41,"context_line":"        :param registries: Dict of message registries to be used when"},{"line_number":42,"context_line":"            parsing messages of attribute update status"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_65621a41","line":39,"updated":"2019-05-22 08:17:01.000000000","message":"rename this to conn or better (IMHO) rename the param in the definition to connector, no real need to shorten it","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f2e15e579965e26dc7ccdaf935f070d6612016b6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._registries \u003d registries"},{"line_number":37,"context_line":"        \"\"\"A class representing a Bios"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param connector: A Connector instance"},{"line_number":40,"context_line":"        :param path: Sub-URI path to the Bios resource"},{"line_number":41,"context_line":"        :param registries: Dict of message registries to be used when"},{"line_number":42,"context_line":"            parsing messages of attribute update status"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_085b3554","line":39,"in_reply_to":"bfb3d3c7_65621a41","updated":"2019-05-22 09:16:31.000000000","message":"updated param to \u0027connector\u0027","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ef7d71f3fc07f3aac0bd30845718d59f560ff667","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def update_status(self):"},{"line_number":171,"context_line":"        \"\"\"Status of the last attribute update"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :returns: SettingsUpdate"},{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":"        return self._settings.get_status(self._registries)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_455fd671","line":173,"updated":"2019-05-22 08:17:01.000000000","message":"maybe some more details on this ?","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"f2e15e579965e26dc7ccdaf935f070d6612016b6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def update_status(self):"},{"line_number":171,"context_line":"        \"\"\"Status of the last attribute update"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :returns: SettingsUpdate"},{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":"        return self._settings.get_status(self._registries)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_28b87974","line":173,"in_reply_to":"bfb3d3c7_455fd671","updated":"2019-05-22 09:16:31.000000000","message":"updated","commit_id":"295f28777f61d000bb19fc4ffae79f307c6fae93"}],"sushy/resources/system/system.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bbd0fd7b6a3170e22735366fc9d2c03d7b6a2997","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":133,"context_line":"                 registries\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"A class representing a ComputerSystem"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param connector: A Connector instance"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_3d8eff2d","line":133,"range":{"start_line":133,"start_character":17,"end_line":133,"end_character":27},"updated":"2019-02-27 17:24:48.000000000","message":"here and possibly at other places the docstring is missing for `registries`","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bb8df5393e29dfbbb27add7d54dee9f733ed7774","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    _actions \u003d ActionsField(\u0027Actions\u0027, required\u003dTrue)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, connector, identity, redfish_version\u003dNone,"},{"line_number":133,"context_line":"                 registries\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"A class representing a ComputerSystem"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param connector: A Connector instance"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_42587789","line":133,"range":{"start_line":133,"start_character":17,"end_line":133,"end_character":27},"in_reply_to":"9fdfeff1_3d8eff2d","updated":"2019-03-03 18:30:24.000000000","message":"added here and to bios.py","commit_id":"f5bc938f59f928ca8a75fb29156a5535eb07db4a"}]}