)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5756bc5a729750b27ca29054789a4db68cab16f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add protocol_features_supported property to the root Sushy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"protocol_features_supported is the information about protocol features supported by the service."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5103eabfa56fc049ca0c98bbfc62c82724fcbae9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_948a9562","line":9,"updated":"2018-10-01 15:36:21.000000000","message":"We prefer to wrap lines in commit messages as well, see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"6d2784371850c6e09484b5d6e5159e4f16abbbec"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5756bc5a729750b27ca29054789a4db68cab16f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add protocol_features_supported property to the root Sushy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"protocol_features_supported is the information about protocol features supported by the service."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5103eabfa56fc049ca0c98bbfc62c82724fcbae9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_94dff565","line":10,"updated":"2018-10-01 15:36:21.000000000","message":"To mark this patch as closing your task in storyboard, please use the following syntax here right before Change-Id:\n\n Story: #2003853\n Task: #26649","commit_id":"6d2784371850c6e09484b5d6e5159e4f16abbbec"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"030252acd1eab6227a4f9e7e3090c85653b32604","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dnuka \u003ccsx@tuta.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-02 08:44:58 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add protocol_features_supported property to the root Sushy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"protocol_features_supported is the information about protocol features"},{"line_number":10,"context_line":"supported by the service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_0f5f41e5","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":31},"updated":"2018-10-02 10:30:04.000000000","message":"nit `protocol_features_supported` or may be `ProtocolFeaturesSupported` property of the `Root Service`","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"4dc39b599638c9eac52b1f033c669be0b86a4eda","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dnuka \u003ccsx@tuta.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-02 08:44:58 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add protocol_features_supported property to the root Sushy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"protocol_features_supported is the information about protocol features"},{"line_number":10,"context_line":"supported by the service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_1261a439","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":31},"in_reply_to":"3f79a3b5_0f5f41e5","updated":"2018-10-02 11:47:55.000000000","message":"Done","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"}],"releasenotes/notes/add_product_and_protocol_features_supported-59de3f89b7382434.yaml":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d8a3d4dc1c0905ad39acc0f874e25e1e75e3edf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for Product and ProtocolFeaturesSupported"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_9da399ff","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":58},"updated":"2018-10-01 16:37:00.000000000","message":"What\u0027s the established term for these things? ;-)","commit_id":"f17433b4c7c16562a35df9338618910f40ace695"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"030252acd1eab6227a4f9e7e3090c85653b32604","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds product and protocol_features_supported fields to the "},{"line_number":5,"context_line":"    ``Sushy`` class."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_2f39dda1","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":20},"updated":"2018-10-02 10:30:04.000000000","message":"How about this (if we want to stick with Redfish parlance)?\n\n\"Adds `Product` and `ProductFeaturesSupported` properties support to the Redfish `Root Service`\"\n\n?","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"4dc39b599638c9eac52b1f033c669be0b86a4eda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds product and protocol_features_supported fields to the "},{"line_number":5,"context_line":"    ``Sushy`` class."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_72da58e6","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":20},"in_reply_to":"3f79a3b5_2f39dda1","updated":"2018-10-02 11:47:55.000000000","message":"Done","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e67078e7c8404406cb16e292d718b8b7937e205f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Adds `Product` and `ProductFeaturesSupported` properties support to "},{"line_number":5,"context_line":"    the Redfish `Root Service`\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_5b541722","line":4,"updated":"2018-10-02 13:58:53.000000000","message":"nit: excess white space at the end of the line.","commit_id":"1525e13f60f0c568d0487432e57e48234457d980"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"d2f2ab508bdc4166bf55ca320d14a69163a80bbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Adds `Product` and `ProductFeaturesSupported` properties support to "},{"line_number":5,"context_line":"    the Redfish `Root Service`\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_a67c3220","line":4,"in_reply_to":"3f79a3b5_5b541722","updated":"2018-10-02 14:13:12.000000000","message":"Done","commit_id":"1525e13f60f0c568d0487432e57e48234457d980"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c17de9a10ee284433b5d003e663343fe9d962943","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Adds `Product` and `ProductFeaturesSupported` properties support to"},{"line_number":5,"context_line":"    the Redfish `Root Service`\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_936cd333","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":5},"updated":"2018-10-02 15:25:56.000000000","message":"hmm, no quotes please!","commit_id":"339e979ae3894e79768ce0394bf6c2b4bfb9c91d"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"3637ce2b1837a008a3bb649bdc16c7607c0b3280","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Adds `Product` and `ProductFeaturesSupported` properties support to"},{"line_number":5,"context_line":"    the Redfish `Root Service`\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_b30c6f42","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":5},"in_reply_to":"3f79a3b5_936cd333","updated":"2018-10-02 15:35:36.000000000","message":"Done","commit_id":"339e979ae3894e79768ce0394bf6c2b4bfb9c91d"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"9685756b8d75c8df5b3dfa290fe698f5557fe080","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds `Product` and `ProductFeaturesSupported` properties support to"},{"line_number":5,"context_line":"    the Redfish `Root Service`"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_339ca90b","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":48},"updated":"2018-10-04 14:24:12.000000000","message":"it should be `ProtocolFeaturesSupported`","commit_id":"fbdd61100db140c62b6b116760104fe0f6fe81c9"}],"sushy/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"98d9ca84d0ae94f408d2cf4e7854057812fc52c6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"The product associated with this Redfish service\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    protocol_features_supported \u003d ProtocolFeaturesSupportedField(("},{"line_number":62,"context_line":"        \u0027ProtocolFeaturesSupported\u0027))"},{"line_number":63,"context_line":"    \"\"\"The information about protocol features supported by the service\"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    _systems_path \u003d base.Field([\u0027Systems\u0027, \u0027@odata.id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_193480f9","line":62,"updated":"2018-10-01 15:27:32.000000000","message":"only one set of brackets is enough","commit_id":"6d2784371850c6e09484b5d6e5159e4f16abbbec"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d8a3d4dc1c0905ad39acc0f874e25e1e75e3edf3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ProtocolFeaturesSupportedField(base.CompositeField):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    excerpt_query \u003d base.Field(\u0027ExcerptQuery\u0027)"},{"line_number":32,"context_line":"    \"\"\"The excerpt query parameter is supported\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    expand_query \u003d base.Field(\u0027ExpandQuery\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3dacc5ec","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":46},"updated":"2018-10-01 16:37:00.000000000","message":"typos?","commit_id":"f17433b4c7c16562a35df9338618910f40ace695"}],"sushy/tests/unit/json_samples/root.json":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"98d9ca84d0ae94f408d2cf4e7854057812fc52c6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \"RedfishVersion\": \"1.0.2\","},{"line_number":6,"context_line":"    \"UUID\": \"92384634-2938-2342-8820-489239905423\","},{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": \"ProtocolFeaturesSupported\","},{"line_number":9,"context_line":"    \"Systems\": {"},{"line_number":10,"context_line":"        \"@odata.id\": \"/redfish/v1/Systems\""},{"line_number":11,"context_line":"    },"}],"source_content_type":"application/json","patch_set":1,"id":"3f79a3b5_79333414","line":8,"updated":"2018-10-01 15:27:32.000000000","message":"I\u0027m not sure how it works in unit tests, but this should be a structure, not a string","commit_id":"6d2784371850c6e09484b5d6e5159e4f16abbbec"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d8a3d4dc1c0905ad39acc0f874e25e1e75e3edf3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \"RedfishVersion\": \"1.0.2\","},{"line_number":6,"context_line":"    \"UUID\": \"92384634-2938-2342-8820-489239905423\","},{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": \"ProtocolFeaturesSupported\","},{"line_number":9,"context_line":"    \"Systems\": {"},{"line_number":10,"context_line":"        \"@odata.id\": \"/redfish/v1/Systems\""},{"line_number":11,"context_line":"    },"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_1d88e968","line":8,"range":{"start_line":8,"start_character":34,"end_line":8,"end_character":59},"updated":"2018-10-01 16:37:00.000000000","message":"Let\u0027s use some real-world features, preferribly more than one.","commit_id":"f17433b4c7c16562a35df9338618910f40ace695"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"030252acd1eab6227a4f9e7e3090c85653b32604","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"UUID\": \"92384634-2938-2342-8820-489239905423\","},{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": {"},{"line_number":9,"context_line":"        \"ExcerptQuery\": true,"},{"line_number":10,"context_line":"        \"ExpandQuery\": true,"},{"line_number":11,"context_line":"        \"FilterQuery\": true,"},{"line_number":12,"context_line":"        \"OnlyMemberQuery\": true,"}],"source_content_type":"application/json","patch_set":3,"id":"3f79a3b5_eff0c5fe","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":21},"updated":"2018-10-02 10:30:04.000000000","message":"Typo?","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1fc1b54495008727ff073780cf8d891dad253417","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"UUID\": \"92384634-2938-2342-8820-489239905423\","},{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": {"},{"line_number":9,"context_line":"        \"ExcerptQuery\": true,"},{"line_number":10,"context_line":"        \"ExpandQuery\": true,"},{"line_number":11,"context_line":"        \"FilterQuery\": true,"},{"line_number":12,"context_line":"        \"OnlyMemberQuery\": true,"}],"source_content_type":"application/json","patch_set":3,"id":"3f79a3b5_d377ab3a","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":21},"in_reply_to":"3f79a3b5_528ddcd1","updated":"2018-10-02 15:19:22.000000000","message":"Ah, right, that\u0027s the intended word. Sorry for false alarm! ;-)","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"4dc39b599638c9eac52b1f033c669be0b86a4eda","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"UUID\": \"92384634-2938-2342-8820-489239905423\","},{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": {"},{"line_number":9,"context_line":"        \"ExcerptQuery\": true,"},{"line_number":10,"context_line":"        \"ExpandQuery\": true,"},{"line_number":11,"context_line":"        \"FilterQuery\": true,"},{"line_number":12,"context_line":"        \"OnlyMemberQuery\": true,"}],"source_content_type":"application/json","patch_set":3,"id":"3f79a3b5_528ddcd1","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":21},"in_reply_to":"3f79a3b5_eff0c5fe","updated":"2018-10-02 11:47:55.000000000","message":"https://redfish.dmtf.org/schemas/ServiceRoot.v1_4_0.json\nhas the property like ExcerptQuery, so I kinda went with it :)","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"8c021ec8ff1132d59b27a176d8b04374ec7330a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": {"},{"line_number":9,"context_line":"        \"ExcerptQuery\": true,"},{"line_number":10,"context_line":"        \"ExpandQuery\": true,"},{"line_number":11,"context_line":"        \"FilterQuery\": true,"},{"line_number":12,"context_line":"        \"OnlyMemberQuery\": true,"},{"line_number":13,"context_line":"        \"SelectQuery\": true"}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_3e2b3f7c","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"updated":"2018-10-02 21:03:50.000000000","message":"nit: if we had some of these protocols set to `false` in the sample, then in the unit tests we could make sure that the values actually propagate all the way through the code...","commit_id":"f90d2eeaf9a74b9504ef5401ce2d646330b8492b"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"f5049258d33e8ed40f2b2c7db9cab60d0d8ccb15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \"Product\": \"Product\","},{"line_number":8,"context_line":"    \"ProtocolFeaturesSupported\": {"},{"line_number":9,"context_line":"        \"ExcerptQuery\": true,"},{"line_number":10,"context_line":"        \"ExpandQuery\": true,"},{"line_number":11,"context_line":"        \"FilterQuery\": true,"},{"line_number":12,"context_line":"        \"OnlyMemberQuery\": true,"},{"line_number":13,"context_line":"        \"SelectQuery\": true"}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_781b071b","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"in_reply_to":"3f79a3b5_3e2b3f7c","updated":"2018-10-03 03:37:44.000000000","message":"Done","commit_id":"f90d2eeaf9a74b9504ef5401ce2d646330b8492b"}],"sushy/tests/unit/test_main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"98d9ca84d0ae94f408d2cf4e7854057812fc52c6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from sushy import connector"},{"line_number":22,"context_line":"from sushy import exceptions"},{"line_number":23,"context_line":"from sushy import main"},{"line_number":24,"context_line":"from sushy.main import ProtocolFeaturesSupportedField"},{"line_number":25,"context_line":"from sushy.resources.manager import manager"},{"line_number":26,"context_line":"from sushy.resources.sessionservice import session"},{"line_number":27,"context_line":"from sushy.resources.sessionservice import sessionservice"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_39393cf0","line":24,"updated":"2018-10-01 15:27:32.000000000","message":"it\u0027s preferred to import modules, not classes","commit_id":"6d2784371850c6e09484b5d6e5159e4f16abbbec"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d8a3d4dc1c0905ad39acc0f874e25e1e75e3edf3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(\u002792384634-2938-2342-8820-489239905423\u0027,"},{"line_number":56,"context_line":"                         self.root.uuid)"},{"line_number":57,"context_line":"        self.assertEqual(\u0027Product\u0027, self.root.product)"},{"line_number":58,"context_line":"        self.assertIsInstance(self.root.protocol_features_supported, ("},{"line_number":59,"context_line":"            main.ProtocolFeaturesSupportedField))"},{"line_number":60,"context_line":"        self.assertEqual(\u0027/redfish/v1/Systems\u0027, self.root._systems_path)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027/redfish/v1/Managers\u0027, self.root._managers_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7dec7d27","line":58,"range":{"start_line":58,"start_character":69,"end_line":58,"end_character":70},"updated":"2018-10-01 16:37:00.000000000","message":"nit: do we need these parenthesis?","commit_id":"f17433b4c7c16562a35df9338618910f40ace695"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"030252acd1eab6227a4f9e7e3090c85653b32604","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(\u0027Product\u0027, self.root.product)"},{"line_number":58,"context_line":"        self.assertIsInstance("},{"line_number":59,"context_line":"            self.root.protocol_features_supported,"},{"line_number":60,"context_line":"            main.ProtocolFeaturesSupportedField"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        self.assertEqual(\u0027/redfish/v1/Systems\u0027, self.root._systems_path)"},{"line_number":63,"context_line":"        self.assertEqual(\u0027/redfish/v1/Managers\u0027, self.root._managers_path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4f68d986","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":47},"updated":"2018-10-02 10:30:04.000000000","message":"Should we also make sure that the protocol features get populated properly?","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"4dc39b599638c9eac52b1f033c669be0b86a4eda","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(\u0027Product\u0027, self.root.product)"},{"line_number":58,"context_line":"        self.assertIsInstance("},{"line_number":59,"context_line":"            self.root.protocol_features_supported,"},{"line_number":60,"context_line":"            main.ProtocolFeaturesSupportedField"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        self.assertEqual(\u0027/redfish/v1/Systems\u0027, self.root._systems_path)"},{"line_number":63,"context_line":"        self.assertEqual(\u0027/redfish/v1/Managers\u0027, self.root._managers_path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d2cb2c1a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":47},"in_reply_to":"3f79a3b5_4f68d986","updated":"2018-10-02 11:47:55.000000000","message":"Done","commit_id":"1eed8c7e2a668755aabf90cf2ea421779b5130cd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"8c021ec8ff1132d59b27a176d8b04374ec7330a2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(\u002792384634-2938-2342-8820-489239905423\u0027,"},{"line_number":56,"context_line":"                         self.root.uuid)"},{"line_number":57,"context_line":"        self.assertEqual(\u0027Product\u0027, self.root.product)"},{"line_number":58,"context_line":"        self.assertEqual("},{"line_number":59,"context_line":"            True,"},{"line_number":60,"context_line":"            self.root.protocol_features_supported.excerpt_query)"},{"line_number":61,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_de26cbba","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":24},"updated":"2018-10-02 21:03:50.000000000","message":"nit: there is also the `.assertTrue` shortcut","commit_id":"f90d2eeaf9a74b9504ef5401ce2d646330b8492b"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"f5049258d33e8ed40f2b2c7db9cab60d0d8ccb15","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(\u002792384634-2938-2342-8820-489239905423\u0027,"},{"line_number":56,"context_line":"                         self.root.uuid)"},{"line_number":57,"context_line":"        self.assertEqual(\u0027Product\u0027, self.root.product)"},{"line_number":58,"context_line":"        self.assertEqual("},{"line_number":59,"context_line":"            True,"},{"line_number":60,"context_line":"            self.root.protocol_features_supported.excerpt_query)"},{"line_number":61,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_181693f3","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":24},"in_reply_to":"3f79a3b5_de26cbba","updated":"2018-10-03 03:37:44.000000000","message":"Done","commit_id":"f90d2eeaf9a74b9504ef5401ce2d646330b8492b"}]}