)]}'
{"sushy/tests/unit/json_samples/updateservice.json":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0739c5035d61db78ca4c11d88731dc697db8a3b5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"HttpPushUri\": \"/FWUpdate\","},{"line_number":12,"context_line":"    \"HttpPushUriTargets\": [\"/FWUpdate\"],"},{"line_number":13,"context_line":"    \"HttpPushUriTargetsBusy\": false,"},{"line_number":14,"context_line":"    \"TransferProtocol\": \"HTTP\","},{"line_number":15,"context_line":"    \"FirmwareInventory\": {"},{"line_number":16,"context_line":"        \"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory\""},{"line_number":17,"context_line":"    },"}],"source_content_type":"application/json","patch_set":2,"id":"9fdfeff1_cd2dd746","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":29},"updated":"2019-02-27 04:29:08.000000000","message":"This looks correct value. But as per code it should be \u0027Hypertext Transfer Protocol\u0027 as in [1]. I think there is a problem with the code. It should not have mapping from long form to short form. Also  The \u0027TransferProtocol\u0027 needs to be a single protocol value from description in spec[2]. \n\"\n\"longDescription\": \"This parameter shall contain the network protocol that the Update Service shall use to retreive the software image located at the ImageURI.  If this parameter is not provided (or supported), and a transfer protocol is not specified by a scheme contained within ImageURI, the Update Service shall use HTTP to retrieve the image.\"\n\"\nIn code we are trying to use it as a list of values [3].\n\n[1] https://github.com/openstack/sushy/blob/master/sushy/resources/updateservice/mappings.py#L18-L28\n[2] https://redfish.dmtf.org/schemas/UpdateService.v1_4_0.json\n[3] https://github.com/openstack/sushy/blob/master/sushy/resources/updateservice/updateservice.py#L114-L116","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"927d3762b0a6adb6783a87ff1f38c34e22898034","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \"HttpPushUri\": \"/FWUpdate\","},{"line_number":12,"context_line":"    \"HttpPushUriTargets\": [\"/FWUpdate\"],"},{"line_number":13,"context_line":"    \"HttpPushUriTargetsBusy\": false,"},{"line_number":14,"context_line":"    \"TransferProtocol\": \"HTTP\","},{"line_number":15,"context_line":"    \"FirmwareInventory\": {"},{"line_number":16,"context_line":"        \"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory\""},{"line_number":17,"context_line":"    },"}],"source_content_type":"application/json","patch_set":2,"id":"9fdfeff1_deb8f7c8","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":29},"in_reply_to":"9fdfeff1_cd2dd746","updated":"2019-02-28 11:28:00.000000000","message":"Done","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"}],"sushy/tests/unit/resources/updateservice/test_updateservice.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"72d084e7658c432308dab8e1b1f44030e3602589","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @mock.patch.object(updateservice.LOG, \u0027warning\u0027, autospec\u003dTrue)"},{"line_number":73,"context_line":"    def test_get_allowed_transfer_protocol_values_no_values_specified("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_aa855ed1","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":42},"updated":"2019-02-20 06:49:49.000000000","message":"This will also throw the warning message as there are no \u0027TransferProtocol\u0027 defined in json file.","commit_id":"60b126b283cd78e3c15fe2a925baa3bf43584940"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"179d495733bdc43cf9cbe0394acda72f17c340fd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @mock.patch.object(updateservice.LOG, \u0027warning\u0027, autospec\u003dTrue)"},{"line_number":73,"context_line":"    def test_get_allowed_transfer_protocol_values_no_values_specified("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c2f39408","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":42},"in_reply_to":"9fdfeff1_aa855ed1","updated":"2019-02-25 10:38:04.000000000","message":"Done","commit_id":"60b126b283cd78e3c15fe2a925baa3bf43584940"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"72d084e7658c432308dab8e1b1f44030e3602589","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @mock.patch.object(updateservice.LOG, \u0027warning\u0027, autospec\u003dTrue)"},{"line_number":73,"context_line":"    def test_get_allowed_transfer_protocol_values_no_values_specified("},{"line_number":74,"context_line":"        self, mock_log):"},{"line_number":75,"context_line":"        self.upd_serv.transfer_protocol_values \u003d None"},{"line_number":76,"context_line":"        values \u003d self.upd_serv.get_allowed_transfer_protocol_values()"},{"line_number":77,"context_line":"        expected \u003d set(["},{"line_number":78,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_CIFS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2a716e0d","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":53},"updated":"2019-02-20 06:49:49.000000000","message":"This has no impact.","commit_id":"60b126b283cd78e3c15fe2a925baa3bf43584940"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"72d084e7658c432308dab8e1b1f44030e3602589","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_get_allowed_transfer_protocol_values_no_values_specified("},{"line_number":74,"context_line":"        self, mock_log):"},{"line_number":75,"context_line":"        self.upd_serv.transfer_protocol_values \u003d None"},{"line_number":76,"context_line":"        values \u003d self.upd_serv.get_allowed_transfer_protocol_values()"},{"line_number":77,"context_line":"        expected \u003d set(["},{"line_number":78,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_CIFS,"},{"line_number":79,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_FTP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6ad536b7","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":69},"updated":"2019-02-20 06:49:49.000000000","message":"Also why do we return all the protocols when no \u0027TransferProtocol\u0027 is provided. Shouldn\u0027t it be \u0027HTTP\u0027 as mentioned in standard [1] (see \u0027longDescription\u0027)?\n\"If this parameter is not provided (or supported), and a transfer protocol is not specified by a scheme contained within ImageURI, the Update Service shall use HTTP to retrieve the image.\"\n\n[1] https://redfish.dmtf.org/schemas/UpdateService.v1_4_0.json","commit_id":"60b126b283cd78e3c15fe2a925baa3bf43584940"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"dbb67c5247b9bd38fc0b2f219e7ec395936c8310","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_get_allowed_transfer_protocol_values(self):"},{"line_number":58,"context_line":"        values \u003d self.upd_serv.get_allowed_transfer_protocol_values()"},{"line_number":59,"context_line":"        expected \u003d set(["},{"line_number":60,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_CIFS,"},{"line_number":61,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_FTP,"},{"line_number":62,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_SFTP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3ad60551","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":24},"updated":"2019-02-27 16:57:47.000000000","message":"nit: can it be a literal definition?\n\nexpected \u003d {\n      ups_cons.TRANSFER_PROTOCOL_TYPE_CIFS,\n      ups_cons.TRANSFER_PROTOCOL_TYPE_FTP,\n      ...\n}","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"927d3762b0a6adb6783a87ff1f38c34e22898034","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_get_allowed_transfer_protocol_values(self):"},{"line_number":58,"context_line":"        values \u003d self.upd_serv.get_allowed_transfer_protocol_values()"},{"line_number":59,"context_line":"        expected \u003d set(["},{"line_number":60,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_CIFS,"},{"line_number":61,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_FTP,"},{"line_number":62,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_SFTP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_9ee34fd8","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":24},"in_reply_to":"9fdfeff1_3ad60551","updated":"2019-02-28 11:28:00.000000000","message":"It can :)","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0739c5035d61db78ca4c11d88731dc697db8a3b5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_TFTP,"},{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_simple_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_edd77b22","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":42},"updated":"2019-02-27 04:29:08.000000000","message":"In the json file we pass \u0027TransferProtocol\u0027 has only \u0027HTTP\u0027 as the value. Shouldn\u0027t the returned set be just HTTP?","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"cc582ded38fdeca2985e825f259815c954d9c072","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_TFTP,"},{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_simple_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_a1c71345","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":42},"in_reply_to":"9fdfeff1_3ebd83b0","updated":"2019-02-28 15:07:54.000000000","message":"Is it correct that `get_allowed_transfer_protocol_values` returns all protocols when  the service itself does not advertise any?\n\nReading TransferProtocol description in the schema:\n\n                    \"longDescription\": \"This parameter shall contain the network protocol that the Update Service shall use to retreive the software image located at the ImageURI.  If this parameter is not provided (or supported), and a transfer protocol is not specified by a scheme contained within ImageURI, the Update Service shall use HTTP to retrieve the image.\"\n\nWith current code it seems that if the service does not advertise any TransferProtocol, we (the client) will still agree to use any of the user-specified protocols known from the schema.\n\nDoes it make sense?","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3db447339bff8497e10be88ea6b0694811b64bf1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_TFTP,"},{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_simple_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_17c2dde9","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":42},"in_reply_to":"9fdfeff1_a1c71345","updated":"2019-03-07 13:29:56.000000000","message":"Hold on, perhaps the service never advertises transfer protocols because the schema I am looking into does not have this kind of annotation! Then perhaps my comment does not make sense - it is probably correct that we validate user  transfer protocol against the full list of the schema.\n\nHowever I am confused by the whole UpdateService thing - if the service does not advertise supported protocols, what this condition [1] does? BTW, is not `simple_update_action.transfer_protocol ` just a scalar?\n\nFinally, the `SimpleUpdateActionField` [2] - is it really a field in the sushy sense? It looks being more like POST parameters meaning that the client would assemble it *into* JSON (sushy does not implement that it seems) rather than expecting the server to pass it down to client (like it does in responses).\n\nBTW, we do not seem to use `SimpleUpdateActionField` when POST\u0027ing [3].\n\nSorry for derailing this discussion... Looking for your insights!\n\n1. https://github.com/openstack/sushy/blob/master/sushy/resources/updateservice/updateservice.py#L115\n\n2. https://github.com/openstack/sushy/blob/master/sushy/resources/updateservice/updateservice.py#L31\n\n3. https://github.com/openstack/sushy/blob/master/sushy/resources/updateservice/updateservice.py#L128","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"927d3762b0a6adb6783a87ff1f38c34e22898034","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_TFTP,"},{"line_number":67,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_OEM,"},{"line_number":68,"context_line":"            ups_cons.TRANSFER_PROTOCOL_TYPE_NFS])"},{"line_number":69,"context_line":"        self.assertEqual(expected, values)"},{"line_number":70,"context_line":"        self.assertIsInstance(values, set)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_simple_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3ebd83b0","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":42},"in_reply_to":"9fdfeff1_edd77b22","updated":"2019-02-28 11:28:00.000000000","message":"Yeah! I agree with you. What do you suggest I should do here :)","commit_id":"cc59a89c1f383bd86714a77d7e445ee676222999"}]}
