)]}'
{"sushy/resources/updateservice/updateservice.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                resource\u003dself._path)"},{"line_number":97,"context_line":"        return simple_update_action"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_allowed_transfer_protocol_values(self, transfer_protocol):"},{"line_number":100,"context_line":"        \"\"\"Get the allowed values for transfer protocol."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        :param transfer_protocol: A TransferProtocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_65eebc23","line":99,"range":{"start_line":99,"start_character":51,"end_line":99,"end_character":68},"updated":"2019-03-07 13:25:09.000000000","message":"Do we need to pass the default? If we do may be default it kwargs?\n\nAlso, we seem to have transfer_protocol in `simple_update` defaulted which seems similar to what we have here. Why not handle this whole logic in `simple_update` rather than here? Is it because of potential code reuse?","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def get_allowed_transfer_protocol_values(self, transfer_protocol):"},{"line_number":100,"context_line":"        \"\"\"Get the allowed values for transfer protocol."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        :param transfer_protocol: A TransferProtocol"},{"line_number":103,"context_line":"        :returns: A set of allowed values or a single value"},{"line_number":104,"context_line":"        :raises: MissingAttributeError, if Actions/#UpdateService.SimpleUpdate"},{"line_number":105,"context_line":"            attribute not present."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c5977090","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":52},"updated":"2019-03-07 13:25:09.000000000","message":"The doc is cryptic to me","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027update action for UpdateService %s\u0027, self.identity)"},{"line_number":113,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if transfer_protocol \u003d\u003d \u0027HTTP\u0027:"},{"line_number":116,"context_line":"            return \u0027HTTP\u0027"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP[v] for v in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8563a8dc","line":115,"range":{"start_line":115,"start_character":33,"end_line":115,"end_character":37},"updated":"2019-03-07 13:25:09.000000000","message":"Would it make sense to use a sushy constant here (if there is one)?","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if transfer_protocol \u003d\u003d \u0027HTTP\u0027:"},{"line_number":116,"context_line":"            return \u0027HTTP\u0027"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP[v] for v in"},{"line_number":119,"context_line":"                       simple_update_action.transfer_protocol if v in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a5b58433","line":116,"range":{"start_line":116,"start_character":20,"end_line":116,"end_character":24},"updated":"2019-03-07 13:25:09.000000000","message":"Is it OK to return a scalar here? I suspect it should be some form of a collection (set?)","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if transfer_protocol \u003d\u003d \u0027HTTP\u0027:"},{"line_number":116,"context_line":"            return \u0027HTTP\u0027"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP[v] for v in"},{"line_number":119,"context_line":"                       simple_update_action.transfer_protocol if v in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_25751496","line":116,"updated":"2019-03-07 13:25:09.000000000","message":"nit: may be\n\nif transfer_protocol \u003d\u003d \u0027HTTP\u0027:\n    return set((transfer_protocol,))\n\nreturn set(...)","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"022d7a3b0825083ade71304261b486b24ec78ad0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\"Simple Update is used to update software components\"\"\""},{"line_number":124,"context_line":"        transfer_protocol \u003d transfer_protocol"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        valid_transfer_protocols \u003d \\"},{"line_number":127,"context_line":"            self.get_allowed_transfer_protocol_values(transfer_protocol)"},{"line_number":128,"context_line":"        if transfer_protocol not in valid_transfer_protocols:"},{"line_number":129,"context_line":"            raise exceptions.InvalidParameterValueError("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_05f3380c","line":126,"range":{"start_line":126,"start_character":35,"end_line":126,"end_character":36},"updated":"2019-03-07 13:25:09.000000000","message":"better use (","commit_id":"24a3359412f8d3582c66a822601a216d4ed48ffd"}]}