)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fb0257cc197dcd0aff8e082ef42e3d89d51ababd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This represents the type of the computer system."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf688752791c21c8652e7fc64478ef0307682f1e"},{"line_number":13,"context_line":"Implements: system_type mappings"},{"line_number":14,"context_line":"Story: #2003853"},{"line_number":15,"context_line":"Task: #29805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_43985d74","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":32},"updated":"2019-03-05 05:10:55.000000000","message":"I am sorry I am not aware of this ``Implements`` keyword and its significance here in this context. It also doesn\u0027t create a link markup per se.","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"762149928ac3ea847fbfd96060cfb08de8f25752","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This represents the type of the computer system."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf688752791c21c8652e7fc64478ef0307682f1e"},{"line_number":13,"context_line":"Implements: system_type mappings"},{"line_number":14,"context_line":"Story: #2003853"},{"line_number":15,"context_line":"Task: #29805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_e3495166","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":32},"updated":"2019-03-05 04:43:23.000000000","message":"nit: It\u0027s considered a best practice to put summary related items before change-id [1]\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"762149928ac3ea847fbfd96060cfb08de8f25752","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf688752791c21c8652e7fc64478ef0307682f1e"},{"line_number":13,"context_line":"Implements: system_type mappings"},{"line_number":14,"context_line":"Story: #2003853"},{"line_number":15,"context_line":"Task: #29805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_8859825c","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":12},"updated":"2019-03-05 04:43:23.000000000","message":"As mentioned in the story: \"Please reserve this story and its tasks for Outreachy 2018 interns until end of year 2018.\"\nSo, please don\u0027t use the story #2003853 here :) Create a new story instead.","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"},{"author":{"_account_id":29209,"name":"Dhanuka Warusadura","email":"csx@tuta.io","username":"dnuka"},"change_message_id":"f1835daf14bf58fbe5fcae93ab3dda56408fe214","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf688752791c21c8652e7fc64478ef0307682f1e"},{"line_number":13,"context_line":"Implements: system_type mappings"},{"line_number":14,"context_line":"Story: #2003853"},{"line_number":15,"context_line":"Task: #29805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_235199da","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":12},"in_reply_to":"9fdfeff1_8859825c","updated":"2019-03-05 04:54:22.000000000","message":"Also, feel free to pick up an unassigned task from story #2003853(don\u0027t create new ones)","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"}],"releasenotes/notes/add-system-type-mapping-bf456c5c15a90877.yaml":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"2d6cfde4657f53cfa2773fdb65fd8c449858b723","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Creates mappings for the system_type of the System resource."},{"line_number":5,"context_line":"    This represents the type of the computer system."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fdfeff1_c3420d10","line":4,"updated":"2019-03-05 05:07:54.000000000","message":"I would rephrase it as:\n\nAdds mappings and constants for possible values of System Type in System resource.","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8708fd4e58854233985c252e5b881c3a1f4ef7cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds mappings and constants for possible values of System Type in System resource."},{"line_number":5,"context_line":"    This represents the type of the computer system."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_32806146","line":4,"updated":"2019-03-15 08:39:06.000000000","message":"nit: just best practice to respect the 80 columns limit whenever possible","commit_id":"360b97e0369c4b35a0e37b5f70f9c35c9db46d0e"}],"sushy/resources/system/constants.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"143701e43207ed2c1c147ebe98480b2041af4912","unresolved":false,"context_lines":[{"line_number":152,"context_line":"SYSTEM_TYPE_PHYSICAL \u003d \u0027A computer system.\u0027"},{"line_number":153,"context_line":"SYSTEM_TYPE_VIRTUAL \u003d \u0027A virtual machine instance running on this system.\u0027"},{"line_number":154,"context_line":"SYSTEM_TYPE_OS \u003d \u0027An operating system instance.\u0027"},{"line_number":155,"context_line":"SYSTEM_TYPE_PHYSICALLY_PARTITIONED \u003d \u0027A hardware-based partition of a computer system.\u0027"},{"line_number":156,"context_line":"SYSTEM_TYPE_VIRTUALLY_PARTITIONED \u003d \u0027A virtual or software-based partition of a computer system.\u0027"},{"line_number":157,"context_line":"SYSTEM_TYPE_COMPOSED \u003d \u0027A computer system that has been created by binding resource blocks together.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_dec8b222","line":155,"updated":"2019-03-04 14:50:47.000000000","message":"you should respect the max number of columns which for this project is set to 80","commit_id":"060019390b1258dd05ee0fae7e501e4959991386"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"2d6cfde4657f53cfa2773fdb65fd8c449858b723","unresolved":false,"context_lines":[{"line_number":150,"context_line":"# System type constants"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"SYSTEM_TYPE_PHYSICAL \u003d \"A computer system.\""},{"line_number":153,"context_line":"SYSTEM_TYPE_VIRTUAL \u003d \"A virtual machine instance running on this system.\""},{"line_number":154,"context_line":"SYSTEM_TYPE_OS \u003d \"An operating system instance.\""},{"line_number":155,"context_line":"SYSTEM_TYPE_PHYSICALLY_PARTITIONED \u003d \"A hardware-based partition of a\" \\"},{"line_number":156,"context_line":"                                     \" computer system.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_0386d566","line":153,"range":{"start_line":153,"start_character":22,"end_line":153,"end_character":74},"updated":"2019-03-05 05:07:54.000000000","message":"These are just constants to simplify the ease of use of the variable values for different attributes. You can keep those reasonably small. For instance:\n\n    SYSTEM_TYPE_PHYSICAL \u003d \"physical system type\"\n    \"\"\"A physical computer system\"\"\"\n    SYSTEM_TYPE_VIRTUAL \u003d \"virtual system type\"\n    \"\"\"A virtual machine instance\"\"\"\n    ...\n    ...\n    SYSTEM_TYPE_COMPOSED \u003d \"composed system type\"\n    \"\"\"A computer system created by binding resource blocks together.\"\"\"\n\nand so on and so forth. The specific long description can be provided as docstring to that constant.","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"}],"sushy/resources/system/mappings.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"143701e43207ed2c1c147ebe98480b2041af4912","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    utils.revert_dictionary(PROCESSOR_INSTRUCTIONSET_VALUE_MAP))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"SYSTEM_TYPE_VALUE_MAP \u003d {"},{"line_number":106,"context_line":"    \u0027Physical\u0027: sys.cons.SYSTEM_TYPE_PHYSICAL,"},{"line_number":107,"context_line":"    \u0027Virtual\u0027: sys_cons.SYSTEM_TYPE_VIRTUAL,"},{"line_number":108,"context_line":"    \u0027OS\u0027: sys_cons.SYSTEM_TYPE_OS,"},{"line_number":109,"context_line":"    \u0027PhysicallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_PHYSICALLY_PARTITIONED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5ed4c2bb","line":106,"updated":"2019-03-04 14:50:47.000000000","message":"s/sys.cons/sys_cons","commit_id":"060019390b1258dd05ee0fae7e501e4959991386"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed1aadae877382faf00c76b64f2be5c6e5f82f6f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \u0027PhysicallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_PHYSICALLY_PARTITIONED,"},{"line_number":110,"context_line":"    \u0027VirtuallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_VIRTUALLY_PARTITIONED,"},{"line_number":111,"context_line":"    \u0027Composed\u0027: sys_cons.SYSTEM_TYPE_COMPOSED"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"SYSTEM_TYPE_VALUE_MAP_REV \u003d ("},{"line_number":115,"context_line":"    utils.revert_dictionary(SYSTEM_TYPE_VALUE_MAP))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_6b1734ef","line":112,"updated":"2019-03-11 11:06:49.000000000","message":"This is correct. However, we have already released a version of sushy with old values exposed. If we do this we will break people who expect system.system_type to have values like \"Physical\". I think the best way out is for the new constants to have the same values as the old ones, e.g. SYSTEM_TYPE_PHYSICAL mapping to \"Physical\". It\u0027s suboptimal, but it will keep the backward compatibility.","commit_id":"beeb1b98e709ebb4c4359df40f118fc207fbec72"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"71549bc5a842eb2e41256d101a71232df48549e6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \u0027PhysicallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_PHYSICALLY_PARTITIONED,"},{"line_number":110,"context_line":"    \u0027VirtuallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_VIRTUALLY_PARTITIONED,"},{"line_number":111,"context_line":"    \u0027Composed\u0027: sys_cons.SYSTEM_TYPE_COMPOSED"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"SYSTEM_TYPE_VALUE_MAP_REV \u003d ("},{"line_number":115,"context_line":"    utils.revert_dictionary(SYSTEM_TYPE_VALUE_MAP))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_af9ba363","line":112,"in_reply_to":"5fc1f717_6b1734ef","updated":"2019-03-14 05:22:43.000000000","message":"++","commit_id":"beeb1b98e709ebb4c4359df40f118fc207fbec72"},{"author":{"_account_id":30013,"name":"Varsha Verma","email":"varsha.verma.eee15@itbhu.ac.in","username":"verma-varsha"},"change_message_id":"c2eb9bf0ff99a124b8c9275d164ff82a61744227","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \u0027PhysicallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_PHYSICALLY_PARTITIONED,"},{"line_number":110,"context_line":"    \u0027VirtuallyPartitioned\u0027: sys_cons.SYSTEM_TYPE_VIRTUALLY_PARTITIONED,"},{"line_number":111,"context_line":"    \u0027Composed\u0027: sys_cons.SYSTEM_TYPE_COMPOSED"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"SYSTEM_TYPE_VALUE_MAP_REV \u003d ("},{"line_number":115,"context_line":"    utils.revert_dictionary(SYSTEM_TYPE_VALUE_MAP))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_12c3003a","line":112,"in_reply_to":"5fc1f717_6b1734ef","updated":"2019-03-14 07:14:58.000000000","message":"Hi Dmitry! \nI have made the changes.\nCould you please find time to review them in patch set 4.\nThanks! :)","commit_id":"beeb1b98e709ebb4c4359df40f118fc207fbec72"}],"sushy/tests/unit/resources/system/test_system.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"143701e43207ed2c1c147ebe98480b2041af4912","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.assertEqual(\u0027224071-J23\u0027, self.sys_inst.part_number)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027437XR1138R2\u0027, self.sys_inst.serial_number)"},{"line_number":62,"context_line":"        self.assertEqual(\u00278675309\u0027, self.sys_inst.sku)"},{"line_number":63,"context_line":"        self.assertEqual(sys_cons.SYSTEM_TYPE_PHYSICAL, self.sys_inst.system_type)"},{"line_number":64,"context_line":"        self.assertEqual(\u002738947555-7742-3448-3784-823347823834\u0027,"},{"line_number":65,"context_line":"                         self.sys_inst.uuid)"},{"line_number":66,"context_line":"        self.assertEqual(res_cons.STATE_ENABLED, self.sys_inst.status.state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_def1926c","line":63,"updated":"2019-03-04 14:50:47.000000000","message":"please respect the max number of columns","commit_id":"060019390b1258dd05ee0fae7e501e4959991386"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"2d6cfde4657f53cfa2773fdb65fd8c449858b723","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.assertEqual(\u0027224071-J23\u0027, self.sys_inst.part_number)"},{"line_number":61,"context_line":"        self.assertEqual(\u0027437XR1138R2\u0027, self.sys_inst.serial_number)"},{"line_number":62,"context_line":"        self.assertEqual(\u00278675309\u0027, self.sys_inst.sku)"},{"line_number":63,"context_line":"        self.assertEqual(sys_cons.SYSTEM_TYPE_PHYSICAL,"},{"line_number":64,"context_line":"                         self.sys_inst.system_type)"},{"line_number":65,"context_line":"        self.assertEqual(\u002738947555-7742-3448-3784-823347823834\u0027,"},{"line_number":66,"context_line":"                         self.sys_inst.uuid)"},{"line_number":67,"context_line":"        self.assertEqual(res_cons.STATE_ENABLED, self.sys_inst.status.state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c30a0d1f","line":64,"range":{"start_line":63,"start_character":8,"end_line":64,"end_character":51},"updated":"2019-03-05 05:07:54.000000000","message":"I would rather prefer to have it checked against the publicly exposed sushy constants like:\n\n    self.assertEqual(sushy.SYSTEM_TYPE_PHYSICAL,\n                     self.sys_inst.system_type)\n\nJust an FYI, all the resource level constants are exposed as sushy level constants. Refer: https://github.com/openstack/sushy/blob/master/sushy/__init__.py#L20-L23","commit_id":"9a0ee58331a91eb3bb3a7b9faad4a5124ae95a05"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"71549bc5a842eb2e41256d101a71232df48549e6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(\u0027224071-J23\u0027, self.sys_inst.part_number)"},{"line_number":60,"context_line":"        self.assertEqual(\u0027437XR1138R2\u0027, self.sys_inst.serial_number)"},{"line_number":61,"context_line":"        self.assertEqual(\u00278675309\u0027, self.sys_inst.sku)"},{"line_number":62,"context_line":"        self.assertEqual(sushy.SYSTEM_TYPE_PHYSICAL,"},{"line_number":63,"context_line":"                         self.sys_inst.system_type)"},{"line_number":64,"context_line":"        self.assertEqual(\u002738947555-7742-3448-3784-823347823834\u0027,"},{"line_number":65,"context_line":"                         self.sys_inst.uuid)"},{"line_number":66,"context_line":"        self.assertEqual(res_cons.STATE_ENABLED, self.sys_inst.status.state)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_8fb3470a","line":63,"range":{"start_line":62,"start_character":8,"end_line":63,"end_character":51},"updated":"2019-03-14 05:22:43.000000000","message":"nit: Based on Dmitry\u0027s suggestion it\u0027s better to keep both.","commit_id":"360b97e0369c4b35a0e37b5f70f9c35c9db46d0e"}]}