)]}'
{"releasenotes/notes/fix-update-service-constants-b8c3f48ccee6ce1f.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57c55fec4fa996981ec591ed5b1c4b53a9a9ad68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Exposes ``UpdateService`` constants to ``sushy`` namespace. One of"},{"line_number":5,"context_line":"    side-effects is that ``transfer_protocol`` parameter of the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_88faa672","line":2,"updated":"2019-03-11 10:28:09.000000000","message":"Looks a feature to me.","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6f9a9eeba1bc70f8d0c96c88be1b04bb154a6994","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Exposes ``UpdateService`` constants to ``sushy`` namespace. One of"},{"line_number":5,"context_line":"    side-effects is that ``transfer_protocol`` parameter of the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_fc774e9f","line":2,"in_reply_to":"5fc1f717_88faa672","updated":"2019-04-18 07:27:52.000000000","message":"Done","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57c55fec4fa996981ec591ed5b1c4b53a9a9ad68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Exposes ``UpdateService`` constants to ``sushy`` namespace. One of"},{"line_number":5,"context_line":"    side-effects is that ``transfer_protocol`` parameter of the"},{"line_number":6,"context_line":"    ``UpdateService.simple_update`` method should be given one of the"},{"line_number":7,"context_line":"    newly exposed constants rather than a string literal."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_a8f52285","line":7,"updated":"2019-03-11 10:28:09.000000000","message":"This is a breaking change and should be marked as such.","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6f9a9eeba1bc70f8d0c96c88be1b04bb154a6994","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Exposes ``UpdateService`` constants to ``sushy`` namespace. One of"},{"line_number":5,"context_line":"    side-effects is that ``transfer_protocol`` parameter of the"},{"line_number":6,"context_line":"    ``UpdateService.simple_update`` method should be given one of the"},{"line_number":7,"context_line":"    newly exposed constants rather than a string literal."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_1c7d7a7e","line":7,"in_reply_to":"5fc1f717_a8f52285","updated":"2019-04-18 07:27:52.000000000","message":"Done","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e749cf9721a624618ff16b1aa17acdf8e248482","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``transfer_protocol`` parameter of the ``UpdateService.simple_update``"},{"line_number":5,"context_line":"    method should be given one of the newly exposed constants rather than a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_eee791ab","line":2,"updated":"2019-04-18 13:21:16.000000000","message":"s/fixes/upgrade/ unless we can do it with a deprecation period somehow (then it\u0027s \"deprecations\")","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9df31fb2df7a6dd7d540ba13bcf3883b54396a46","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``transfer_protocol`` parameter of the ``UpdateService.simple_update``"},{"line_number":5,"context_line":"    method should be given one of the newly exposed constants rather than a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_da04317e","line":2,"in_reply_to":"3fce034c_eee791ab","updated":"2019-04-23 03:30:34.000000000","message":"+1, We\u0027re going to need to make sure we bump semver... although the simple update also appears to have never worked so... \\_0_/","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"}],"sushy/__init__.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"086d5b86dbf698a4e01c3590ebbcca975b84a47f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from sushy.resources.fabric.constants import *  # noqa"},{"line_number":23,"context_line":"from sushy.resources.manager.constants import *  # noqa"},{"line_number":24,"context_line":"from sushy.resources.system.constants import *  # noqa"},{"line_number":25,"context_line":"from sushy.resources.updateservice.constants import *  # noqa"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"__all__ \u003d (\u0027Sushy\u0027,)"},{"line_number":28,"context_line":"__version__ \u003d pbr.version.VersionInfo("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_2b7a21b9","line":25,"updated":"2019-05-30 20:35:04.000000000","message":"thanks :)","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1adb60bcbc9167728205ec2da90e61264c381301","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from sushy.resources.fabric.constants import *  # noqa"},{"line_number":23,"context_line":"from sushy.resources.manager.constants import *  # noqa"},{"line_number":24,"context_line":"from sushy.resources.system.constants import *  # noqa"},{"line_number":25,"context_line":"from sushy.resources.updateservice.constants import *  # noqa"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"__all__ \u003d (\u0027Sushy\u0027,)"},{"line_number":28,"context_line":"__version__ \u003d pbr.version.VersionInfo("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b8f93781","line":25,"in_reply_to":"bfb3d3c7_2b7a21b9","updated":"2019-06-04 15:20:25.000000000","message":"Done","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"}],"sushy/resources/constants.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1174297a61fe651fc67d8da14f38333dce057210","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Network protocols constants"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"PROTOCOL_TYPE_CIFS \u003d \u0027common internet file system protocol\u0027"},{"line_number":108,"context_line":"\"\"\"Common Internet File System Protocol\u0027\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"PROTOCOL_TYPE_FTP \u003d \u0027file transfer protocol\u0027"},{"line_number":111,"context_line":"\"\"\"File Transfer Protocol\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_ac94928c","line":108,"updated":"2019-05-21 10:52:44.000000000","message":"nit: remove single \u0027","commit_id":"b2f4fca2f93bcd9e69403c669ccb5509f89c26cf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0e6da3be767982a62c443e36e023f0042c9d19ad","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Network protocols constants"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"PROTOCOL_TYPE_CIFS \u003d \u0027common internet file system protocol\u0027"},{"line_number":108,"context_line":"\"\"\"Common Internet File System Protocol\u0027\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"PROTOCOL_TYPE_FTP \u003d \u0027file transfer protocol\u0027"},{"line_number":111,"context_line":"\"\"\"File Transfer Protocol\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_6cf0da91","line":108,"in_reply_to":"bfb3d3c7_ac94928c","updated":"2019-05-21 11:13:28.000000000","message":"Done","commit_id":"b2f4fca2f93bcd9e69403c669ccb5509f89c26cf"}],"sushy/resources/updateservice/constants.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1174297a61fe651fc67d8da14f38333dce057210","unresolved":false,"context_lines":[{"line_number":22,"context_line":"UPDATE_PROTOCOL_SFTP \u003d res_cons.PROTOCOL_TYPE_SFTP"},{"line_number":23,"context_line":"UPDATE_PROTOCOL_HTTP \u003d res_cons.PROTOCOL_TYPE_HTTP"},{"line_number":24,"context_line":"UPDATE_PROTOCOL_HTTPS \u003d res_cons.PROTOCOL_TYPE_HTTPS"},{"line_number":25,"context_line":"UPDATE_PROTOCOL_SCP \u003d res_cons.PROTOCOL_TYPE_SFTP"},{"line_number":26,"context_line":"UPDATE_PROTOCOL_TFTP \u003d res_cons.PROTOCOL_TYPE_TFTP"},{"line_number":27,"context_line":"UPDATE_PROTOCOL_OEM \u003d res_cons.PROTOCOL_TYPE_OEM"},{"line_number":28,"context_line":"UPDATE_PROTOCOL_NFS \u003d res_cons.PROTOCOL_TYPE_NFS"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_ac3d72bc","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":49},"updated":"2019-05-21 10:52:44.000000000","message":"shouldn\u0027t this be SCP ?","commit_id":"b2f4fca2f93bcd9e69403c669ccb5509f89c26cf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0e6da3be767982a62c443e36e023f0042c9d19ad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"UPDATE_PROTOCOL_SFTP \u003d res_cons.PROTOCOL_TYPE_SFTP"},{"line_number":23,"context_line":"UPDATE_PROTOCOL_HTTP \u003d res_cons.PROTOCOL_TYPE_HTTP"},{"line_number":24,"context_line":"UPDATE_PROTOCOL_HTTPS \u003d res_cons.PROTOCOL_TYPE_HTTPS"},{"line_number":25,"context_line":"UPDATE_PROTOCOL_SCP \u003d res_cons.PROTOCOL_TYPE_SFTP"},{"line_number":26,"context_line":"UPDATE_PROTOCOL_TFTP \u003d res_cons.PROTOCOL_TYPE_TFTP"},{"line_number":27,"context_line":"UPDATE_PROTOCOL_OEM \u003d res_cons.PROTOCOL_TYPE_OEM"},{"line_number":28,"context_line":"UPDATE_PROTOCOL_NFS \u003d res_cons.PROTOCOL_TYPE_NFS"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_6c1e9abb","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":49},"in_reply_to":"bfb3d3c7_ac3d72bc","updated":"2019-05-21 11:13:28.000000000","message":"Ah, uh... That\u0027s why the rest of Redfish emulators compile code from schemas...","commit_id":"b2f4fca2f93bcd9e69403c669ccb5509f89c26cf"}],"sushy/resources/updateservice/mappings.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"086d5b86dbf698a4e01c3590ebbcca975b84a47f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027TFTP\u0027: ups_cons.UPDATE_PROTOCOL_TFTP,"},{"line_number":25,"context_line":"    \u0027OEM\u0027: ups_cons.UPDATE_PROTOCOL_OEM,"},{"line_number":26,"context_line":"    \u0027NFS\u0027: ups_cons.UPDATE_PROTOCOL_NFS,"},{"line_number":27,"context_line":"    \u0027NSF\u0027: ups_cons.UPDATE_PROTOCOL_NFS"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_4b62f50b","line":27,"updated":"2019-05-30 20:35:04.000000000","message":"National Science Foundation?","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7148a5d0900cf427aa0aa5bb4322c522e36e6e80","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027TFTP\u0027: ups_cons.UPDATE_PROTOCOL_TFTP,"},{"line_number":25,"context_line":"    \u0027OEM\u0027: ups_cons.UPDATE_PROTOCOL_OEM,"},{"line_number":26,"context_line":"    \u0027NFS\u0027: ups_cons.UPDATE_PROTOCOL_NFS,"},{"line_number":27,"context_line":"    \u0027NSF\u0027: ups_cons.UPDATE_PROTOCOL_NFS"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_12ccbb5f","line":27,"in_reply_to":"9fb8cfa7_692cf7ab","updated":"2019-07-10 09:27:18.000000000","message":"Done","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"82dd08a47bc047a27fe5478d91ffbdfa1ec191b9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027TFTP\u0027: ups_cons.UPDATE_PROTOCOL_TFTP,"},{"line_number":25,"context_line":"    \u0027OEM\u0027: ups_cons.UPDATE_PROTOCOL_OEM,"},{"line_number":26,"context_line":"    \u0027NFS\u0027: ups_cons.UPDATE_PROTOCOL_NFS,"},{"line_number":27,"context_line":"    \u0027NSF\u0027: ups_cons.UPDATE_PROTOCOL_NFS"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_692cf7ab","line":27,"in_reply_to":"9fb8cfa7_981eb3b8","updated":"2019-06-10 14:51:26.000000000","message":"Wow.","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1adb60bcbc9167728205ec2da90e61264c381301","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027TFTP\u0027: ups_cons.UPDATE_PROTOCOL_TFTP,"},{"line_number":25,"context_line":"    \u0027OEM\u0027: ups_cons.UPDATE_PROTOCOL_OEM,"},{"line_number":26,"context_line":"    \u0027NFS\u0027: ups_cons.UPDATE_PROTOCOL_NFS,"},{"line_number":27,"context_line":"    \u0027NSF\u0027: ups_cons.UPDATE_PROTOCOL_NFS"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_981eb3b8","line":27,"in_reply_to":"bfb3d3c7_4b62f50b","updated":"2019-06-04 15:20:25.000000000","message":"Yeah, that\u0027s the `Not Safe for Files` network storage protocol...\n\nActually, that\u0027s how it is in the schema. I can only guess that was a typo in the standard... Or a practical joke...","commit_id":"f171413d64bafc230ae8e26f2a62dae82544d8ab"}],"sushy/resources/updateservice/updateservice.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57c55fec4fa996981ec591ed5b1c4b53a9a9ad68","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027update action for UpdateService %s\u0027, self.identity)"},{"line_number":113,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        return set([simple_update_action.transfer_protocol])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def simple_update(self, image_uri, targets,"},{"line_number":118,"context_line":"                      transfer_protocol\u003dup_cons.UPDATE_PROTOCOL_HTTP):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c800ae6a","line":115,"updated":"2019-03-11 10:28:09.000000000","message":"nit: {simple_update_action.transfer_protocol}","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6f9a9eeba1bc70f8d0c96c88be1b04bb154a6994","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027update action for UpdateService %s\u0027, self.identity)"},{"line_number":113,"context_line":"            return set(up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        return set([simple_update_action.transfer_protocol])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def simple_update(self, image_uri, targets,"},{"line_number":118,"context_line":"                      transfer_protocol\u003dup_cons.UPDATE_PROTOCOL_HTTP):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_5c5ea212","line":115,"in_reply_to":"5fc1f717_c800ae6a","updated":"2019-04-18 07:27:52.000000000","message":"Done","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57c55fec4fa996981ec591ed5b1c4b53a9a9ad68","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e8032a72","line":127,"updated":"2019-03-11 10:28:09.000000000","message":"This is a breaking change, are we ready for it?","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6f9a9eeba1bc70f8d0c96c88be1b04bb154a6994","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_dca7f20a","line":127,"in_reply_to":"5fc1f717_e8032a72","updated":"2019-04-18 07:27:52.000000000","message":"It is breaking indeed. I hope people do not use update service heavily yet (if we use it at all?).\n\nWhat other alternatives do we have? This problem should be fixed one way or the other. The sooner the better.","commit_id":"59b7f5a258451587e31f372ff0ddb38a1f51ea49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6f62cae3c37ac91e2895617372d9332d35c31fa","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_11181cd1","line":127,"updated":"2019-04-26 13:54:50.000000000","message":"This doesn\u0027t make it acceptable from the stable policy perspective though..","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e749cf9721a624618ff16b1aa17acdf8e248482","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_4ef7c560","line":127,"updated":"2019-04-18 13:21:16.000000000","message":"What if we try to fall back to the provided value for now, issuing a warning? This would avoid a breaking change. Or do we assume nobody is using UpdateService?","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a38c5102c56208c67b55ec8d1db6a03dfd547c9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_3af30da1","line":127,"in_reply_to":"3fce034c_4ef7c560","updated":"2019-04-23 03:31:29.000000000","message":"Looking at the follow-up, I\u0027m fairly sure we know nobody is using it yet. :(","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"46bf30ebb02dc8985abe369f6f12803409d6d230","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                valid_values\u003dvalid_transfer_protocols)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        transfer_protocol \u003d up_maps.TRANSFER_PROTOCOL_TYPE_VALUE_MAP_REV["},{"line_number":127,"context_line":"            transfer_protocol]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._conn.post(data\u003d{"},{"line_number":130,"context_line":"            \u0027ImageURI\u0027: image_uri,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_f32ca948","line":127,"in_reply_to":"ffb9cba7_11181cd1","updated":"2019-05-21 08:41:39.000000000","message":"Done","commit_id":"8b6d62975534857dff071faac668fc64bbcefe30"}]}