)]}'
{"releasenotes/notes/update-apply-time-support-53c5445b58cd3b42.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b21a21a3dde3235659a41441e13ef828a19eb40","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update sushy models to support the Redfish SettingsApplyTime and"},{"line_number":5,"context_line":"    OperationApplyTimeSupport annotations."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_0c1e2c0c","line":5,"updated":"2019-04-11 09:38:25.000000000","message":"could you also add a note in the \"deprecations\" section about the deprecated methods?","commit_id":"5c706e5615ead9723ec81352c54f08e8f612a4f1"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"9ee83c906fe1cc8da7627f8ac438be5a914371a3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update sushy models to support the Redfish SettingsApplyTime and"},{"line_number":5,"context_line":"    OperationApplyTimeSupport annotations."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_e4065021","line":5,"in_reply_to":"3fce034c_0c1e2c0c","updated":"2019-04-11 16:42:27.000000000","message":"Yes, added in patch set #3.","commit_id":"5c706e5615ead9723ec81352c54f08e8f612a4f1"}],"sushy/resources/common.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b21a21a3dde3235659a41441e13ef828a19eb40","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027MaintenanceWindowDurationInSeconds\u0027, adapter\u003dint)"},{"line_number":33,"context_line":"    \"\"\"The expiry time of maintenance window in seconds\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    maintenance_window_resource \u003d IdRefField(\u0027MaintenanceWindowResource\u0027)"},{"line_number":36,"context_line":"    \"\"\"The location of the maintenance window settings\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    maintenance_window_start_time \u003d base.Field("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_ec20804c","line":35,"updated":"2019-04-11 09:38:25.000000000","message":"do we need this public i.e. exposed to users of sushy?","commit_id":"5c706e5615ead9723ec81352c54f08e8f612a4f1"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"9ee83c906fe1cc8da7627f8ac438be5a914371a3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027MaintenanceWindowDurationInSeconds\u0027, adapter\u003dint)"},{"line_number":33,"context_line":"    \"\"\"The expiry time of maintenance window in seconds\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    maintenance_window_resource \u003d IdRefField(\u0027MaintenanceWindowResource\u0027)"},{"line_number":36,"context_line":"    \"\"\"The location of the maintenance window settings\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    maintenance_window_start_time \u003d base.Field("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_8418ac81","line":35,"in_reply_to":"3fce034c_ec20804c","updated":"2019-04-11 16:42:27.000000000","message":"No, this doesn\u0027t need to be public. Fixed in patch set #3.","commit_id":"5c706e5615ead9723ec81352c54f08e8f612a4f1"}],"sushy/resources/settings.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ab10dc9189ad88a5f97d5d4f6e8cc88558a978f0","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    maintenance_window \u003d MaintenanceWindowField(\u0027MaintenanceWindow\u0027)"},{"line_number":115,"context_line":"    \"\"\"Indicates if a given resource has a maintenance window assignment"},{"line_number":116,"context_line":"    for applying settings or operations\"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    messages \u003d MessageListField(\"Messages\")"},{"line_number":119,"context_line":"    \"\"\"Represents the results of the last time the values of the Settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_12c61318","side":"PARENT","line":116,"updated":"2019-03-21 10:28:59.000000000","message":"This looks like a breaking change","commit_id":"fc311f9ddbb5fe8559acc6974e371101ecb9353c"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"15c2dc919a211a98c663c1a0b0a4f442b8b948b8","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    maintenance_window \u003d MaintenanceWindowField(\u0027MaintenanceWindow\u0027)"},{"line_number":115,"context_line":"    \"\"\"Indicates if a given resource has a maintenance window assignment"},{"line_number":116,"context_line":"    for applying settings or operations\"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    messages \u003d MessageListField(\"Messages\")"},{"line_number":119,"context_line":"    \"\"\"Represents the results of the last time the values of the Settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_507aee76","side":"PARENT","line":116,"in_reply_to":"5fc1f717_12c61318","updated":"2019-03-25 20:06:04.000000000","message":"Yes, I removed these because the MaintenanceWindow and OperationApplyTimeSupport are not applicable to the @Redfish.Settings annotation (and if fact cannot appear in the @Redfish.Settings annotation per the Redfish schemas).\n\nI was hesitant to remove them. But I was assuming Openstack Ironic is the only consumer of sushy and there are no references to these 2 fields (maintenance_window and operation_apply_time_support) from the Ironic repo. So I didn\u0027t think anything would break.\n\nBut of course, I want to follow the expectations and contract of the sushy library.\n\nI can add these 2 fields back. But since MaintenanceWindow and OperationApplyTimeSupport properties will not be present in a Redfish @Redfish.Settings annotation, if anyone did use these, they would return None. Given that, would it be OK to add them back as follows?\n\n    maintenance_window \u003d None\n\n    operation_apply_time_support \u003d None\n\nAnd if they are added back, the doc string should be updated to indicate they should not be used and point them to the correct fields in other resources.\n\nSorry for the long reply. Any input or suggestions appreciated.","commit_id":"fc311f9ddbb5fe8559acc6974e371101ecb9353c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122409850408b09171c4fa45aacb4d0d2f57175f","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    maintenance_window \u003d MaintenanceWindowField(\u0027MaintenanceWindow\u0027)"},{"line_number":115,"context_line":"    \"\"\"Indicates if a given resource has a maintenance window assignment"},{"line_number":116,"context_line":"    for applying settings or operations\"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    messages \u003d MessageListField(\"Messages\")"},{"line_number":119,"context_line":"    \"\"\"Represents the results of the last time the values of the Settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_53db2e20","side":"PARENT","line":116,"in_reply_to":"5fc1f717_507aee76","updated":"2019-04-03 15:29:09.000000000","message":"Nearly, I think we need to raise a warning on accessing them, so something like\n\n @property\n def maintenance_window(self):\n     LOG.warn(...)","commit_id":"fc311f9ddbb5fe8559acc6974e371101ecb9353c"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"1ecad8a834163374153b29a18020ad4d22de8335","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    maintenance_window \u003d MaintenanceWindowField(\u0027MaintenanceWindow\u0027)"},{"line_number":115,"context_line":"    \"\"\"Indicates if a given resource has a maintenance window assignment"},{"line_number":116,"context_line":"    for applying settings or operations\"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    messages \u003d MessageListField(\"Messages\")"},{"line_number":119,"context_line":"    \"\"\"Represents the results of the last time the values of the Settings"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_53eece8b","side":"PARENT","line":116,"in_reply_to":"5fc1f717_53db2e20","updated":"2019-04-03 15:43:18.000000000","message":"That makes sense. Will do.","commit_id":"fc311f9ddbb5fe8559acc6974e371101ecb9353c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ab10dc9189ad88a5f97d5d4f6e8cc88558a978f0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    operation_apply_time_support \u003d OperationApplyTimeSupportField("},{"line_number":123,"context_line":"        \u0027OperationApplyTimeSupport\u0027)"},{"line_number":124,"context_line":"    \"\"\"Indicates if a client is allowed to request for a specific apply"},{"line_number":125,"context_line":"    time of a create, delete, or action operation of a given resource\"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def commit(self, connector, value):"},{"line_number":128,"context_line":"        \"\"\"Commits new settings values"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_32cb0f1f","side":"PARENT","line":125,"updated":"2019-03-21 10:28:59.000000000","message":"ditto","commit_id":"fc311f9ddbb5fe8559acc6974e371101ecb9353c"}],"sushy/tests/unit/resources/system/storage/test_volume.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f22b7e2d48bdaf951a328f482d0cc22957ea4421","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from dateutil import parser"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushy.resources.system.storage import volume"},{"line_number":20,"context_line":"from sushy.tests.unit import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8d68a2ba","line":17,"updated":"2019-03-21 10:50:04.000000000","message":"nit: if we consider mock as std lib this is correct, but could you also please remove the blank line between json and mock imports ?","commit_id":"acd0530ee75e3c0aa163e1ebcf17d48c711100db"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"15c2dc919a211a98c663c1a0b0a4f442b8b948b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from dateutil import parser"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sushy.resources.system.storage import volume"},{"line_number":20,"context_line":"from sushy.tests.unit import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_358634bb","line":17,"in_reply_to":"5fc1f717_8d68a2ba","updated":"2019-03-25 20:06:04.000000000","message":"Thanks for the comments. Yes, I\u0027ll fix those 3 occurrences.","commit_id":"acd0530ee75e3c0aa163e1ebcf17d48c711100db"}],"sushy/tests/unit/resources/system/test_bios.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f22b7e2d48bdaf951a328f482d0cc22957ea4421","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from dateutil import parser"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from sushy import exceptions"},{"line_number":22,"context_line":"from sushy.resources.system import bios"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6d5f760e","line":19,"updated":"2019-03-21 10:50:04.000000000","message":"ditto","commit_id":"acd0530ee75e3c0aa163e1ebcf17d48c711100db"}],"sushy/tests/unit/resources/system/test_system.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f22b7e2d48bdaf951a328f482d0cc22957ea4421","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from dateutil import parser"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import sushy"},{"line_number":23,"context_line":"from sushy import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_2d9f2eb5","line":20,"updated":"2019-03-21 10:50:04.000000000","message":"ditto","commit_id":"acd0530ee75e3c0aa163e1ebcf17d48c711100db"}]}
