)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Etingof \u003cetingof@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-03 17:20:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore registry files of unknown type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_34a8f91d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2019-07-05 23:03:24.000000000","message":"nit: I prefer \u0027Disregard\u0027 over \u0027Ignore\u0027, because they are examined and voluntarily set aside.","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Etingof \u003cetingof@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-03 17:20:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore registry files of unknown type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_f467c124","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":37},"updated":"2019-07-05 23:03:24.000000000","message":"nit: unsupported types","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Etingof \u003cetingof@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-03 17:20:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore registry files of unknown type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_d20aca24","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"7faddb67_34a8f91d","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Etingof \u003cetingof@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-03 17:20:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore registry files of unknown type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_2dff3f02","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":37},"in_reply_to":"7faddb67_f467c124","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"},{"line_number":11,"context_line":"`AttributeRegistry` or `PrivilegeRegistry` or who knows what else"},{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_74c8b154","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":44},"updated":"2019-07-05 23:03:24.000000000","message":"A reference to the standard Redfish schema which describes this might be helpful.\n\n[1] http://redfish.dmtf.org/schemas/v1/MessageRegistryFile_v1.xml","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This fix ignores `MessageRegistryFile` if it links anything other"},{"line_number":10,"context_line":"than `MessageRegistry` resource. Apparently, it can also be"},{"line_number":11,"context_line":"`AttributeRegistry` or `PrivilegeRegistry` or who knows what else"},{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_4d2ddb93","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":44},"in_reply_to":"7faddb67_74c8b154","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_ff131fb7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":38},"updated":"2019-07-05 23:03:24.000000000","message":"Please consider adding Mike Raineri as a co-author. His e-mail address is \"mraineri@gmail.com\".","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_3ff3f7a0","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":38},"updated":"2019-07-05 23:03:24.000000000","message":"Thank you so much for listing me as a co-author.\n\nnit: Please change this to all lowercase, \"richard.pioso@dell.com\", to match how it appears in my Gerrit account profile, just in case Gerrit and/or Stackalytics treat e-mail addresses case sensitively.\n\nRecently, I used git-review to submit a new change and passed the reviewers\u0027 e-mail addresses on the command line. An error was reported, because one of them did not match any account. The case was not the same as in the intended user\u0027s profile.\n\nAnd should it be formatted as described by https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references ?\n\n  Co-Authored-By: Richard G. Pioso \u003crichard.pioso@dell.com\u003e","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_cd38ebd4","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":38},"in_reply_to":"7faddb67_3ff3f7a0","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":12,"context_line":"one could fish out of `MessageRegistryFile`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idfd2f1ed4ef78d048ac8bd5297619805db694bf6"},{"line_number":15,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_2d4dff71","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":38},"in_reply_to":"7faddb67_ff131fb7","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"}],"sushy/resources/registry/message_registry_file.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\"Location URI of publicly available schema\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class RegistryFlavor(base.ResourceBase):"},{"line_number":52,"context_line":"    _odata_type \u003d base.Field(\u0027@odata.type\u0027, required\u003dTrue)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_34bc7904","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":20},"updated":"2019-07-05 23:03:24.000000000","message":"Please consider changing this to \u0027Type\u0027 to align with the description in the MessageRegistryFile schema, http://redfish.dmtf.org/schemas/v1/MessageRegistryFile_v1.xml -- \"This Registry can reference any type of Registry, such as a Message Registry, Privilege Registry, or Attribute Registry.\"","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\"Location URI of publicly available schema\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class RegistryFlavor(base.ResourceBase):"},{"line_number":52,"context_line":"    _odata_type \u003d base.Field(\u0027@odata.type\u0027, required\u003dTrue)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_67c9d676","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":20},"in_reply_to":"7faddb67_34bc7904","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            registry \u003d RegistryFlavor(*args, **kwargs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f4d6e14f","line":125,"range":{"start_line":125,"start_character":15,"end_line":125,"end_character":57},"updated":"2019-07-05 23:03:24.000000000","message":"Have you considered making this comparison more discerning? It presently matches \"#MessageRegistry\", \"#MessageRegistryCollection\", \"#MessageRegistryFile\", and \"#MessageRegistryFileCollection\".","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            registry \u003d RegistryFlavor(*args, **kwargs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e7ff0665","line":125,"range":{"start_line":125,"start_character":15,"end_line":125,"end_character":57},"in_reply_to":"7faddb67_f4d6e14f","updated":"2019-07-08 12:54:32.000000000","message":"I\u0027ve been reading on @odata.type structure, so I think you\u0027ve uncovered a bug! \\o/","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                            {\u0027language\u0027: language})"},{"line_number":121,"context_line":"                continue"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            registry \u003d RegistryFlavor(*args, **kwargs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"},{"line_number":129,"context_line":"                        {\u0027registry\u0027: registry._odata_type})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1435bdda","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":72},"updated":"2019-07-05 23:03:24.000000000","message":"Does this result in the entire MessageRegistry being read over the network twice, where the network could be the public internet? I ask, because a MessageRegistry can be quite large.","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                            {\u0027language\u0027: language})"},{"line_number":121,"context_line":"                continue"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            registry \u003d RegistryFlavor(*args, **kwargs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"},{"line_number":129,"context_line":"                        {\u0027registry\u0027: registry._odata_type})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_07610237","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":72},"in_reply_to":"7faddb67_1435bdda","updated":"2019-07-08 12:54:32.000000000","message":"I think so!\n\nDespite sushy having `cache_it`, it only works on the same resource object while here we have two distinct resources.\n\nI tried to use `cache_it` just for this method, but it appears the caching mechanism needs a bit of tweaking to use it here.\n\nDue to JSON, it\u0027s impossible to read just part of it to figure out the type of the object that follows...\n\nPerhaps a followup?","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b2dffe095c5f7efecf8a4076941ce42aba41350e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"},{"line_number":129,"context_line":"                        {\u0027registry\u0027: registry._odata_type})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        LOG.warning(\u0027No message registry found for %(language)s or \u0027"},{"line_number":132,"context_line":"                    \u0027default\u0027, {\u0027language\u0027: language})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_7470b173","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":59},"updated":"2019-07-05 23:03:24.000000000","message":"It would be helpful to have unit test coverage for this, because it is executed when the situation that revealed the bug this change fixes is encountered. A test case could help detect a future regression.","commit_id":"f58060d963eeac54a3b278b492646424976468f0"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1362cf03875d9bf8cbf253b255ebaf07e5f98e13","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if \u0027#MessageRegistry\u0027 in registry._odata_type:"},{"line_number":126,"context_line":"                return message_registry.MessageRegistry(*args, **kwargs)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            LOG.warning(\u0027Ignoring unsupported flavor of registry %(registry)s\u0027,"},{"line_number":129,"context_line":"                        {\u0027registry\u0027: registry._odata_type})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        LOG.warning(\u0027No message registry found for %(language)s or \u0027"},{"line_number":132,"context_line":"                    \u0027default\u0027, {\u0027language\u0027: language})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_722e76a6","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":59},"in_reply_to":"7faddb67_7470b173","updated":"2019-07-08 12:54:32.000000000","message":"Done","commit_id":"f58060d963eeac54a3b278b492646424976468f0"}]}