)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"had access to message registries what proved insufficient."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib1e24ea0b2ab81a4dad207ef8f76f1cef3a799c3"},{"line_number":14,"context_line":"Co-Authored-By: Richard.Pioso@dell.com"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_f5e669b0","line":14,"updated":"2019-08-06 23:42:07.000000000","message":"nit: This should be the following: [1]\n\nCo-Authored-By: Richard G. Pioso \u003crichard.pioso@dell.com\u003e\n\nHowever, Stackalytics seems to grok it \\o/\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"}],"sushy/main.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c4bacf758c641ef6a5c6a48ab9f9f26796f9a57a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        return sessionservice.SessionService("},{"line_number":275,"context_line":"            self._conn, self._session_service_path,"},{"line_number":276,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":277,"context_line":"            registries\u003dself.registries)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_session(self, identity):"},{"line_number":280,"context_line":"        \"\"\"Given the identity return a Session object"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_3a87a912","line":277,"range":{"start_line":277,"start_character":12,"end_line":277,"end_character":39},"updated":"2019-07-22 07:38:47.000000000","message":"We should not pass the registries to session service as to fetch the registries also we need session token which we would not get unless session is created at L146 above when session authentication is used.","commit_id":"b5c25e2ca443a1d84e29bf2cec84732e82a32e18"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"8b89b3b4fee1bfcc96fb3ac2191fb6dd1abc34fa","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        return sessionservice.SessionService("},{"line_number":275,"context_line":"            self._conn, self._session_service_path,"},{"line_number":276,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":277,"context_line":"            registries\u003dself.registries)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_session(self, identity):"},{"line_number":280,"context_line":"        \"\"\"Given the identity return a Session object"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_75877263","line":277,"range":{"start_line":277,"start_character":12,"end_line":277,"end_character":39},"in_reply_to":"7faddb67_3a87a912","updated":"2019-07-22 07:57:22.000000000","message":"Ah, good point!","commit_id":"b5c25e2ca443a1d84e29bf2cec84732e82a32e18"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            raise exceptions.MissingAttributeError("},{"line_number":272,"context_line":"                attribute\u003d\u0027SessionService/@odata.id\u0027, resource\u003dself._path)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        return sessionservice.SessionService("},{"line_number":275,"context_line":"            self._conn, self._session_service_path,"},{"line_number":276,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def get_session(self, identity):"},{"line_number":279,"context_line":"        \"\"\"Given the identity return a Session object"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_7d601fa6","line":276,"range":{"start_line":274,"start_character":0,"end_line":276,"end_character":49},"updated":"2019-08-06 23:42:07.000000000","message":"This unfortunate resource does not get access to the registries. While I understand why this has been done, the exception seems awkward. Why is this resource different from all other resources?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        if self._registries_path:"},{"line_number":312,"context_line":"            return message_registry_file.MessageRegistryFileCollection("},{"line_number":313,"context_line":"                self._conn,"},{"line_number":314,"context_line":"                self._registries_path,"},{"line_number":315,"context_line":"                redfish_version\u003dself.redfish_version)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def get_composition_service(self):"},{"line_number":318,"context_line":"        \"\"\"Get the CompositionService object"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_7dd33f39","line":315,"range":{"start_line":312,"start_character":0,"end_line":315,"end_character":53},"updated":"2019-08-06 23:42:07.000000000","message":"Should this be passed a registries argument?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        for json_file in pkg_resources.resource_listdir("},{"line_number":343,"context_line":"            resource_package_name, STANDARD_REGISTRY_PATH):"},{"line_number":344,"context_line":"                # Not using path.join according to pkg_resources docs"},{"line_number":345,"context_line":"                mes_reg \u003d message_registry.MessageRegistry("},{"line_number":346,"context_line":"                    None, STANDARD_REGISTRY_PATH + json_file,"},{"line_number":347,"context_line":"                    reader\u003dbase.JsonPackagedFileReader(resource_package_name))"},{"line_number":348,"context_line":"                message_registries.append(mes_reg)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        return message_registries"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_169c2868","line":347,"range":{"start_line":345,"start_character":0,"end_line":347,"end_character":78},"updated":"2019-08-06 23:42:07.000000000","message":"Should this be passed a registries argument?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            Registry_name.Major_version.Minor_version and value is registry"},{"line_number":361,"context_line":"            itself."},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":"        if self._registries is None:"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"            standard \u003d self._get_standard_message_registry_collection()"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_153d45dc","line":363,"updated":"2019-08-06 23:42:07.000000000","message":"It appears _registries can be set only once. I imagine that may be insufficient for environments in which the set of registries available through the Redfish service could change, such as the following:\n\n- system in which hardware subsystems can be added and removed over time, and subsystem firmware publishes a message registries to the Redfish service\n- Redfish service aggregator whose managed systems change over time, and each system publishes its registries to the aggregator","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"}],"sushy/resources/system/bios.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @utils.cache_it"},{"line_number":75,"context_line":"    def _pending_settings_resource(self):"},{"line_number":76,"context_line":"        \"\"\"Pending BIOS settings resource\"\"\""},{"line_number":77,"context_line":"        return Bios("},{"line_number":78,"context_line":"            self._conn, self._settings.resource_uri,"},{"line_number":79,"context_line":"            registries\u003dNone,"},{"line_number":80,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @property"},{"line_number":83,"context_line":"    def pending_attributes(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b66d1404","line":80,"range":{"start_line":77,"start_character":15,"end_line":80,"end_character":49},"updated":"2019-08-06 23:42:07.000000000","message":"Should this be passed a registries argument?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"}],"sushy/resources/system/processor.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @utils.cache_it"},{"line_number":119,"context_line":"    def sub_processors(self):"},{"line_number":120,"context_line":"        \"\"\"A reference to the collection of Sub-Processors\"\"\""},{"line_number":121,"context_line":"        return ProcessorCollection("},{"line_number":122,"context_line":"            self.conn, self._get_processor_collection_path,"},{"line_number":123,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ProcessorCollection(base.ResourceCollectionBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_f6506c34","line":123,"range":{"start_line":121,"start_character":15,"end_line":123,"end_character":49},"updated":"2019-08-06 23:42:07.000000000","message":"Should this be passed a registries argument?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"}],"sushy/resources/system/storage/storage.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \"\"\"The protocols which the controller can use tocommunicate with devices\"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Storage(base.ResourceBase):"},{"line_number":56,"context_line":"    \"\"\"This class represents the storage subsystem resources."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    A storage subsystem represents a set of storage controllers (physical or"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_f1887671","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":33},"updated":"2019-08-06 23:42:07.000000000","message":"Should an __init__() method be added to this class?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        return drive.Drive(self._conn, drive_identity,"},{"line_number":84,"context_line":"                           redfish_version\u003dself.redfish_version,"},{"line_number":85,"context_line":"                           registries\u003dself.registries)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    @utils.cache_it"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_562620d0","line":85,"range":{"start_line":85,"start_character":38,"end_line":85,"end_character":53},"updated":"2019-08-06 23:42:07.000000000","message":"Isn\u0027t this None, because this class does not have an __init__() method?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        point). Here only the actual refresh of the sub-resource happens,"},{"line_number":124,"context_line":"        if resource is stale."},{"line_number":125,"context_line":"        \"\"\""},{"line_number":126,"context_line":"        return volume.VolumeCollection("},{"line_number":127,"context_line":"            self._conn, utils.get_sub_resource_path_by(self, \u0027Volumes\u0027),"},{"line_number":128,"context_line":"            redfish_version\u003dself.redfish_version)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    storage_controllers \u003d StorageControllersListField(\u0027StorageControllers\u0027,"},{"line_number":131,"context_line":"                                                      default\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9611f85f","line":128,"range":{"start_line":126,"start_character":15,"end_line":128,"end_character":49},"updated":"2019-08-06 23:42:07.000000000","message":"Should this be passed a registries argument?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8c5782b2bb52b8193b3e733c2850886def61a8b9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\"The storage devices associated with this resource.\"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"class StorageCollection(base.ResourceCollectionBase):"},{"line_number":136,"context_line":"    \"\"\"This class represents the collection of Storage resources\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_917b4279","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":53},"updated":"2019-08-06 23:42:07.000000000","message":"Should an __init__() method be added to this class to receive the registries value?","commit_id":"9351999582e396bf60d286ea25dc67b57687cb5e"}]}