)]}'
{"sushy/main.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"48b383a137384b10dae6d0c5bf8f245d66b1f7e5","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            Registry_name.Major_version.Minor_version and value is registry"},{"line_number":363,"context_line":"            itself."},{"line_number":364,"context_line":"        \"\"\""},{"line_number":365,"context_line":"        if self._registries is None:"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            standard \u003d self._get_standard_message_registry_collection()"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_516fd591","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":36},"updated":"2019-07-23 09:31:01.000000000","message":"With this check in place, it would always will have a value after retrieving it first time. Are we invalidating it anywhere?","commit_id":"a009312bb71b925699f0474ee6f808ba9f993f65"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"510f177e6ee77830834dbd91eabc6f0908ba2291","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            Registry_name.Major_version.Minor_version and value is registry"},{"line_number":363,"context_line":"            itself."},{"line_number":364,"context_line":"        \"\"\""},{"line_number":365,"context_line":"        if self._registries is None:"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            standard \u003d self._get_standard_message_registry_collection()"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_51e27503","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":36},"in_reply_to":"7faddb67_516fd591","updated":"2019-07-23 09:33:42.000000000","message":"And we may not required to invalidate it as any update to message registries will come as part firmware update which would invariably reset BMC.","commit_id":"a009312bb71b925699f0474ee6f808ba9f993f65"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3c94db665de5706188122fbe3576d00d3d162fd6","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            Registry_name.Major_version.Minor_version and value is registry"},{"line_number":363,"context_line":"            itself."},{"line_number":364,"context_line":"        \"\"\""},{"line_number":365,"context_line":"        if self._registries is None:"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            standard \u003d self._get_standard_message_registry_collection()"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2e9b5666","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":36},"in_reply_to":"7faddb67_516fd591","updated":"2019-07-31 13:07:11.000000000","message":"Done","commit_id":"a009312bb71b925699f0474ee6f808ba9f993f65"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3c94db665de5706188122fbe3576d00d3d162fd6","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            Registry_name.Major_version.Minor_version and value is registry"},{"line_number":363,"context_line":"            itself."},{"line_number":364,"context_line":"        \"\"\""},{"line_number":365,"context_line":"        if self._registries is None:"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            standard \u003d self._get_standard_message_registry_collection()"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4e901244","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":36},"in_reply_to":"7faddb67_51e27503","updated":"2019-07-31 13:07:11.000000000","message":"That\u0027s a good point, though should we rather address it within the ubiquitous caching mechanism we have in sushy?\n\nIn our recent discussions, @rpioso mentioned the possibility of composable hardware going forward. That would lead to other resources to change over time. May be we could mitigate that by expiring our cache over time. That expiration mechanics would expire message registries as well, I suppose.\n\nBTW, I\u0027ve removed that condition you\u0027ve mentioned - I just came to realization that with cache decorator in place, we just do not need that condition.","commit_id":"a009312bb71b925699f0474ee6f808ba9f993f65"}]}