)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a164aed2522b4374d37a3499287110445fed60c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-21 17:18:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update documentation adding Dell EMC Oem extension usage for sushy task number: #36779"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icf22b9d38e307a07f59112a6c462d48a8ec6c3d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_bd74c5d1","line":7,"updated":"2019-10-21 20:19:23.000000000","message":"Too long line (read up on git commit message)","commit_id":"14288ae07269ebbecb402e0bc499fb9cf12b1855"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a164aed2522b4374d37a3499287110445fed60c4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-10-21 17:18:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update documentation adding Dell EMC Oem extension usage for sushy task number: #36779"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icf22b9d38e307a07f59112a6c462d48a8ec6c3d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7d7e4db0","line":8,"updated":"2019-10-21 20:19:23.000000000","message":"Please, add:\n\nStory: XXX\nTask: YYY\n\ninstead of the title","commit_id":"14288ae07269ebbecb402e0bc499fb9cf12b1855"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9b7a89c081a53136bfb1d5bd44593d53bb949cca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-23 16:37:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Story: 2006610"},{"line_number":8,"context_line":"Task: 36779"},{"line_number":9,"context_line":"Change-Id: Icf22b9d38e307a07f59112a6c462d48a8ec6c3d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_38a67f11","line":7,"updated":"2019-10-23 15:46:04.000000000","message":"You should give a proper title to the commit message and a brief description of what the patch does.","commit_id":"c736702547217f2c404fdf8bdeddb027d851bcb8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f337fe3a7d7f634752892693a04f2dc131c77cd6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-23 16:33:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Story: 2006610"},{"line_number":8,"context_line":"Task: 36779"},{"line_number":9,"context_line":"Change-Id: Icf22b9d38e307a07f59112a6c462d48a8ec6c3d6"},{"line_number":10,"context_line":"Documentation about using OEM Dell EMC extension with sushy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_73de5811","line":7,"updated":"2019-10-23 16:45:31.000000000","message":"put the title here, leave one blank line, then a short description\nyou need to leave another blank line before adding the tags of Story and Task","commit_id":"fbcf4ca7ab66a15c408b687156a7528e1c2a839d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5463826b2be1224b9c66749a6c1445d339177e6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     khansa \u003ckhansa.amrouni@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-28 10:01:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using OEM extension Documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It contains a simple script example about using"},{"line_number":10,"context_line":"OEM Dell EMC extension with sushy."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_7a8b4fbf","line":7,"updated":"2019-10-28 11:32:13.000000000","message":"Should be like: \"Add OEM extension example script\"","commit_id":"5c5f718853c73cc4ac29f413c3336dea8c69022b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5463826b2be1224b9c66749a6c1445d339177e6d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using OEM extension Documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It contains a simple script example about using"},{"line_number":10,"context_line":"OEM Dell EMC extension with sushy."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2006610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_fab89f75","line":9,"updated":"2019-10-28 11:32:13.000000000","message":"Should be like: \"This change adds a simple example script illustrating OEM extension call based on Dell/EMC sushy extension package\"","commit_id":"5c5f718853c73cc4ac29f413c3336dea8c69022b"}],"doc/source/reference/usage.rst":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a164aed2522b4374d37a3499287110445fed60c4","unresolved":false,"context_lines":[{"line_number":299,"context_line":"run a Redfish emulator."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"-------------------------------------------------"},{"line_number":302,"context_line":"Using OEM extensions: Dell EMC OEM extension"},{"line_number":303,"context_line":"-------------------------------------------------"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_fd431d6b","line":302,"updated":"2019-10-21 20:19:23.000000000","message":"In general, I am not sure it\u0027s a good idea to refer to any concrete 3-rd party extension here. May be we could keep this example vendor-neutral, while in the vendor packages we could do more concrete examples...","commit_id":"14288ae07269ebbecb402e0bc499fb9cf12b1855"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a164aed2522b4374d37a3499287110445fed60c4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"-------------------------------------------------"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":".. code-block:: python"},{"line_number":306,"context_line":"  import logging"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"  import os"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_7d572d28","line":306,"updated":"2019-10-21 20:19:23.000000000","message":"Please, read up on PEP8 coding style conventions. And run `tox -e pep8` locally to catch issues.","commit_id":"14288ae07269ebbecb402e0bc499fb9cf12b1855"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0c903d6933beb15050c7237ddfb97e08eb2f6db4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"-------------------------------------------------"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":".. code-block:: python"},{"line_number":306,"context_line":"  import logging"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"  import os"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01d48fbc","line":306,"in_reply_to":"3fa7e38b_7d572d28","updated":"2019-10-22 08:02:38.000000000","message":"and -edocs","commit_id":"14288ae07269ebbecb402e0bc499fb9cf12b1855"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c42b4523ca789a672cc11955ca8c0d12146411e0","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"  import logging"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  import os"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  import sys"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_bb2ca6ac","line":309,"updated":"2019-10-23 19:24:02.000000000","message":"this module is not used, no need to import it","commit_id":"d074f6bfd7dd0e74ea4490b9b5074c5fd0bd98b8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c42b4523ca789a672cc11955ca8c0d12146411e0","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  import os"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  import sys"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  import sushy"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9b1bea7e","line":311,"updated":"2019-10-23 19:24:02.000000000","message":"this module is not used, no need to import it","commit_id":"d074f6bfd7dd0e74ea4490b9b5074c5fd0bd98b8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c42b4523ca789a672cc11955ca8c0d12146411e0","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  import sushy"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"  from sushy_oem_idrac import utils"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  # Enable logging at DEBUG level"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_3e5504fb","line":315,"updated":"2019-10-23 19:24:02.000000000","message":"I don\u0027t think you need this also","commit_id":"d074f6bfd7dd0e74ea4490b9b5074c5fd0bd98b8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c42b4523ca789a672cc11955ca8c0d12146411e0","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  # Enable logging at DEBUG level"},{"line_number":319,"context_line":"  LOG.setLevel(logging.INFO)"},{"line_number":320,"context_line":"  handler \u003d logging.StreamHandler()"},{"line_number":321,"context_line":"  handler.setLevel(logging.INFO)"},{"line_number":322,"context_line":"  LOG.addHandler(handler)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_fb0bfe27","line":319,"updated":"2019-10-23 19:24:02.000000000","message":"you have to initialize LOG first in some way\nalso it seems you set the level to INFO, not DEBUG, you\u0027ll have to change it","commit_id":"d074f6bfd7dd0e74ea4490b9b5074c5fd0bd98b8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c42b4523ca789a672cc11955ca8c0d12146411e0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"          # Read Dell manager extension"},{"line_number":350,"context_line":"          print(manager_oem.get_extension())"},{"line_number":351,"context_line":"          # set boot device to sushy.VIRTUAL_MEDIA_CD"},{"line_number":352,"context_line":"          oem_manager.set_virtual_boot_device("},{"line_number":353,"context_line":"                        sushy.VIRTUAL_MEDIA_CD,"},{"line_number":354,"context_line":"                        persistent\u003dFalse,"},{"line_number":355,"context_line":"                        manager\u003dmanager)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_3e07441b","line":352,"updated":"2019-10-23 19:24:02.000000000","message":"oem_manager is not initialized, maybe manager_oem ?","commit_id":"d074f6bfd7dd0e74ea4490b9b5074c5fd0bd98b8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"54147381642def9b99753ce9aba0aa740f71b1eb","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  # Enable logging at DEBUG level"},{"line_number":312,"context_line":"  LOG \u003d logging.getLogger(\u0027sushy\u0027)"},{"line_number":313,"context_line":"  LOG.setLevel(logging.DEBUG)"},{"line_number":314,"context_line":"  handler \u003d logging.StreamHandler()"},{"line_number":315,"context_line":"  handler.setLevel(logging.DEBUG)"},{"line_number":316,"context_line":"  LOG.addHandler(handler)"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_97688fba","line":314,"updated":"2019-10-24 12:18:42.000000000","message":"this is ok, but if you remove the handler variable and just use the method as param of L316 you save one line :)","commit_id":"e16d8ec39098348d682bd3334fc521c2646e1e80"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"54147381642def9b99753ce9aba0aa740f71b1eb","unresolved":false,"context_lines":[{"line_number":312,"context_line":"  LOG \u003d logging.getLogger(\u0027sushy\u0027)"},{"line_number":313,"context_line":"  LOG.setLevel(logging.DEBUG)"},{"line_number":314,"context_line":"  handler \u003d logging.StreamHandler()"},{"line_number":315,"context_line":"  handler.setLevel(logging.DEBUG)"},{"line_number":316,"context_line":"  LOG.addHandler(handler)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  s \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_f72303a6","line":315,"updated":"2019-10-24 12:18:42.000000000","message":"you don\u0027t need to set the log level of the handler if it\u0027s the same of the logging","commit_id":"e16d8ec39098348d682bd3334fc521c2646e1e80"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"54147381642def9b99753ce9aba0aa740f71b1eb","unresolved":false,"context_lines":[{"line_number":337,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":340,"context_line":"              LOG.info(\u0027Dell OEM not found\u0027)"},{"line_number":341,"context_line":"              continue"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"          # Read Dell manager extension"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_576217da","line":340,"range":{"start_line":340,"start_character":14,"end_line":340,"end_character":22},"updated":"2019-10-24 12:18:42.000000000","message":"this is an error so let\u0027s change this to LOG.error","commit_id":"e16d8ec39098348d682bd3334fc521c2646e1e80"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"716372c03d153cdc46cd71a4bcc07f8a36d9ed12","unresolved":false,"context_lines":[{"line_number":294,"context_line":"  sess_serv.close_session(sess_col.members_identities[0])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"If you do not have any real baremetal machine that supports the Redfish"},{"line_number":298,"context_line":"protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":299,"context_line":"run a Redfish emulator."},{"line_number":300,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_7aab61d5","line":297,"updated":"2019-10-25 15:02:34.000000000","message":"let\u0027s move this line and the next 2 lines at the end of the doc","commit_id":"f0ad44cb85243d148b3028cddc82b6f7a43ec8f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"716372c03d153cdc46cd71a4bcc07f8a36d9ed12","unresolved":false,"context_lines":[{"line_number":299,"context_line":"run a Redfish emulator."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"--------------------------------------------"},{"line_number":302,"context_line":"Using OEM extensions: Dell EMC OEM extension"},{"line_number":303,"context_line":"--------------------------------------------"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_3a43a941","line":302,"range":{"start_line":302,"start_character":22,"end_line":302,"end_character":44},"updated":"2019-10-25 15:02:34.000000000","message":"as suggested by Ilya, let\u0027s make this generic, so remove this reference to Dell","commit_id":"f0ad44cb85243d148b3028cddc82b6f7a43ec8f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"716372c03d153cdc46cd71a4bcc07f8a36d9ed12","unresolved":false,"context_lines":[{"line_number":332,"context_line":"              continue"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"          try:"},{"line_number":335,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":338,"context_line":"              LOG.error(\u0027Dell OEM not found\u0027)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_1a5fcd0f","line":335,"range":{"start_line":335,"start_character":55,"end_line":335,"end_character":59},"updated":"2019-10-25 15:02:34.000000000","message":"make this generic, you can use a fictional manufacturer, like Contoso or Acme :)","commit_id":"f0ad44cb85243d148b3028cddc82b6f7a43ec8f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"716372c03d153cdc46cd71a4bcc07f8a36d9ed12","unresolved":false,"context_lines":[{"line_number":335,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Dell\u0027)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":338,"context_line":"              LOG.error(\u0027Dell OEM not found\u0027)"},{"line_number":339,"context_line":"              continue"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"          # Read Dell manager extension"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_3a5c0918","line":338,"range":{"start_line":338,"start_character":25,"end_line":338,"end_character":29},"updated":"2019-10-25 15:02:34.000000000","message":"same here, use a fictional generic name","commit_id":"f0ad44cb85243d148b3028cddc82b6f7a43ec8f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9c50828aea32a7af0e1014a2ae2dbc720217e257","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions: Acme OEM extension"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_2fbcbbda","line":298,"range":{"start_line":298,"start_character":22,"end_line":298,"end_character":40},"updated":"2019-10-28 09:34:00.000000000","message":"sorry, I think I didn\u0027t express myself correctly in the precedent comment, you can actually entirely remove this","commit_id":"42cd55b91deaa693bd9153f410e6c321e0d853bb"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9c50828aea32a7af0e1014a2ae2dbc720217e257","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                        sushy.VIRTUAL_MEDIA_CD,"},{"line_number":342,"context_line":"                        persistent\u003dFalse,"},{"line_number":343,"context_line":"                        manager\u003dmanager)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"  If you do not have any real baremetal machine that supports the Redfish"},{"line_number":346,"context_line":"  protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":347,"context_line":"  run a Redfish emulator."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_0fde9f3d","line":344,"updated":"2019-10-28 09:34:00.000000000","message":"let\u0027s add one more blank line here since the next lines are not part of the same block, also indentation of L345 to L347 should be zero","commit_id":"42cd55b91deaa693bd9153f410e6c321e0d853bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5463826b2be1224b9c66749a6c1445d339177e6d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  import logging"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_5a7c53b5","line":300,"updated":"2019-10-28 11:32:13.000000000","message":"We should not that the script bellow is dependent on sushy OEM package to be present on the system.","commit_id":"5c5f718853c73cc4ac29f413c3336dea8c69022b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5463826b2be1224b9c66749a6c1445d339177e6d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  import logging"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_9a5f2b40","line":301,"updated":"2019-10-28 11:32:13.000000000","message":"Oh, this virtual media example is actually too complicated... The complications have nothing to do with OEM per se. May be we should somehow note that this system-\u003emanagers lookup chain is irrelevant to OEM, it\u0027s just the way how we should get hold of virtual media resource.","commit_id":"5c5f718853c73cc4ac29f413c3336dea8c69022b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5463826b2be1224b9c66749a6c1445d339177e6d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"              continue"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"          try:"},{"line_number":331,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":334,"context_line":"              LOG.error(\u0027Acme OEM not found\u0027)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_baaea72b","line":331,"updated":"2019-10-28 11:32:13.000000000","message":"Why Acme, not Dell, as noted in commit message? Either of these is wrong.","commit_id":"5c5f718853c73cc4ac29f413c3336dea8c69022b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d85780b131c85dddaf08314f79d1e873ff7aa714","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  import logging"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_4690cb43","line":300,"updated":"2019-10-31 09:34:48.000000000","message":"I\u0027d probably add a bit of explanation here. It would be useful to tell the reader that OEM extensions may or may not exists within each Redfish resource. To look them up you need vendor ID. In the following example we are looking up `Acme` vendor extension to Redfish Manager resource.","commit_id":"a0a6244c320e1d7c3cf5b7b911a51ae5e32a3902"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d85780b131c85dddaf08314f79d1e873ff7aa714","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  import logging"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  import sushy"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_e6c77744","line":303,"updated":"2019-10-31 09:34:48.000000000","message":"Do you think it makes sense to clutter the example code with unrelated logging? If we want to debug sushy, I\u0027d rather introduce a separate section in the docs explaining how to enable debugging... WDYT?","commit_id":"a0a6244c320e1d7c3cf5b7b911a51ae5e32a3902"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d85780b131c85dddaf08314f79d1e873ff7aa714","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  LOG.setLevel(logging.DEBUG)"},{"line_number":310,"context_line":"  LOG.addHandler(logging.StreamHandler())"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  s \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027,"},{"line_number":313,"context_line":"                  username\u003d\u0027foo\u0027, password\u003d\u0027bar\u0027)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"  # Instantiate a system object"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_06af337d","line":312,"updated":"2019-10-31 09:34:48.000000000","message":"Let\u0027s call it more descriptively - root_resource or service_root or just root?","commit_id":"a0a6244c320e1d7c3cf5b7b911a51ae5e32a3902"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d85780b131c85dddaf08314f79d1e873ff7aa714","unresolved":false,"context_lines":[{"line_number":324,"context_line":"      print (manager.identity)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"      for v_media in manager.virtual_media.get_members():"},{"line_number":327,"context_line":"          if sushy.VIRTUAL_MEDIA_CD not in v_media.media_types:"},{"line_number":328,"context_line":"              continue"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"          try:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_06e413df","line":327,"updated":"2019-10-31 09:34:48.000000000","message":"This feels sort of irrelevant to OEM... May be we could drop this, and change `set_virtual_boot_device` to some other (imaginary?) call that does not require this check at all?","commit_id":"a0a6244c320e1d7c3cf5b7b911a51ae5e32a3902"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b079b9a9193e10e3cb04d5133030e12da1eb3b4a","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  # The OEM extension may not be presence within each Redfish resource. To look them up you need vendor ID"},{"line_number":304,"context_line":"  # In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"  import sushy"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_b4e3ded7","line":303,"range":{"start_line":303,"start_character":33,"end_line":303,"end_character":41},"updated":"2019-10-31 19:07:53.000000000","message":"present","commit_id":"5a01bea4e0830cf13b1a120824cb88dd891322cb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b079b9a9193e10e3cb04d5133030e12da1eb3b4a","unresolved":false,"context_lines":[{"line_number":301,"context_line":".. code-block:: python"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  # The OEM extension may not be presence within each Redfish resource. To look them up you need vendor ID"},{"line_number":304,"context_line":"  # In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"  import sushy"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_34d7eef0","line":304,"updated":"2019-10-31 19:07:53.000000000","message":"Let\u0027s move this whole paragraph out of the code? Can it be part of the doc rather than part of the code?","commit_id":"5a01bea4e0830cf13b1a120824cb88dd891322cb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b079b9a9193e10e3cb04d5133030e12da1eb3b4a","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  # Instantiate a system object"},{"line_number":312,"context_line":"  system \u003d root_resource.get_system(\u0027/redfish/v1/Systems/437XR1138R2\u0027)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  # Read system resource"},{"line_number":315,"context_line":"  print(system.identity)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  for manager in system.managers:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_94682221","line":314,"updated":"2019-10-31 19:07:53.000000000","message":"nit: I\u0027d not say any \"reading\" happens here...","commit_id":"5a01bea4e0830cf13b1a120824cb88dd891322cb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource,to look them up you need vendor ID."},{"line_number":301,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_152c2900","line":300,"updated":"2019-11-01 08:00:47.000000000","message":"Let\u0027s wrap the lines by 80 chars max. Look at other docs for layout guidance.\n\nI wonder how flake passes CI test at all...","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource,to look them up you need vendor ID."},{"line_number":301,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_952819e2","line":300,"range":{"start_line":300,"start_character":66,"end_line":300,"end_character":68},"updated":"2019-11-01 08:00:47.000000000","message":"missing space","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  import sushy"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"  root_resource \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027,"},{"line_number":308,"context_line":"                  username\u003d\u0027foo\u0027, password\u003d\u0027bar\u0027)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  # Instantiate a system object"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_f50dcd8e","line":307,"updated":"2019-11-01 08:00:47.000000000","message":"I think if you use `system` and `manager` down the road, it makes sense to use just `root` here for naming consistency. WDYT?","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":324,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":327,"context_line":"              print(\u0027ERROR: Acme OEM not found\u0027)"},{"line_number":328,"context_line":"              continue"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"          # print Acme manager extension"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_d531b15a","line":327,"updated":"2019-11-01 08:00:47.000000000","message":"Perhaps we should add manager ID where OEM extension is not found.","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":328,"context_line":"              continue"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"          # print Acme manager extension"},{"line_number":331,"context_line":"          print(manager_oem.get_extension())"},{"line_number":332,"context_line":"          # set boot device to a virtual media device image"},{"line_number":333,"context_line":"          manager_oem.set_virtual_boot_device("},{"line_number":334,"context_line":"                        ramdisk.iso,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_f534ed4a","line":331,"updated":"2019-11-01 08:00:47.000000000","message":"Also, let\u0027s add manager ID?","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c31d9fbd0ad9cbb39fbbd9be65d4656d09aa7d10","unresolved":false,"context_lines":[{"line_number":331,"context_line":"          print(manager_oem.get_extension())"},{"line_number":332,"context_line":"          # set boot device to a virtual media device image"},{"line_number":333,"context_line":"          manager_oem.set_virtual_boot_device("},{"line_number":334,"context_line":"                        ramdisk.iso,"},{"line_number":335,"context_line":"                        persistent\u003dFalse,"},{"line_number":336,"context_line":"                        manager\u003dmanager)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_7540fda2","line":334,"updated":"2019-11-01 08:00:47.000000000","message":"What is this `ramdisk.iso` variable? Do you mean a string literal here?","commit_id":"d02c7fddaee23cb3222c64c393bc68c4651bd682"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource, to look them up you need vendor"},{"line_number":301,"context_line":"ID."},{"line_number":302,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_4be3e434","line":300,"updated":"2019-11-01 11:19:06.000000000","message":"Let\u0027s make it similar to the reset of documentation. Please, take a look at the rest of this file.\n\nFor example, here we miss an empty line. If the second sentence is supposed to be its own paragraph, another new line would be nice to have.","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource, to look them up you need vendor"},{"line_number":301,"context_line":"ID."},{"line_number":302,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_6bdee06a","line":300,"range":{"start_line":300,"start_character":87,"end_line":300,"end_character":91},"updated":"2019-11-01 11:19:06.000000000","message":"need to know or need to specify","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bfa0b96e3a0decaa79d9e22f55170be0d96bc05d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"--------------------------------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"--------------------------------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource, to look them up you need vendor"},{"line_number":301,"context_line":"ID."},{"line_number":302,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish Manager resource."},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_eb409008","line":300,"in_reply_to":"3fa7e38b_4be3e434","updated":"2019-11-01 11:19:45.000000000","message":"s/reset/rest","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":312,"context_line":"  system \u003d root.get_system(\u0027/redfish/v1/Systems/437XR1138R2\u0027)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  # print system resource"},{"line_number":315,"context_line":"  print(system.identity)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  for manager in system.managers:"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_8bc6bc99","line":315,"updated":"2019-11-01 11:19:06.000000000","message":"May be \u0027Working on system resource %s\u0027 % system.identity) ?","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":317,"context_line":"  for manager in system.managers:"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"      # print manager identity"},{"line_number":320,"context_line":"      print (manager.identity)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"      for v_media in manager.virtual_media.get_members():"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_4bbc4405","line":320,"updated":"2019-11-01 11:19:06.000000000","message":"Ditto","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":325,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":328,"context_line":"              print(\u0027ERROR: Acme OEM not found in manager \u0027+manager.identity)"},{"line_number":329,"context_line":"              continue"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"          # print Acme manager extension"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_0bd3ac61","line":328,"range":{"start_line":328,"start_character":59,"end_line":328,"end_character":60},"updated":"2019-11-01 11:19:06.000000000","message":"Let\u0027s use \u0027%s\u0027 interpolation","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"83f29d14f5a1d28fd708e04a362bb330466dad63","unresolved":false,"context_lines":[{"line_number":329,"context_line":"              continue"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"          # print Acme manager extension"},{"line_number":332,"context_line":"          print(\"Manager ID: \"+manager.identity+\"\\n Manager OEM extension: \"+manager_oem.get_extension())"},{"line_number":333,"context_line":"          # set boot device to a virtual media device image"},{"line_number":334,"context_line":"          manager_oem.set_virtual_boot_device("},{"line_number":335,"context_line":"                        ramdisk.iso,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_0b388c9d","line":332,"updated":"2019-11-01 11:19:06.000000000","message":"This long line must fail the CI job. You may want to read up on PEP8","commit_id":"e206bc2fe8586712146c78f19a2bf5ab1dd90428"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"---------------------"},{"line_number":298,"context_line":"Using OEM extensions"},{"line_number":299,"context_line":"---------------------"},{"line_number":300,"context_line":"The OEM extension may not be present within each Redfish resource, to look"},{"line_number":301,"context_line":"them up you need to specify the vendor ID."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_4e4c52c7","line":299,"range":{"start_line":299,"start_character":0,"end_line":299,"end_character":21},"updated":"2019-11-01 13:41:31.000000000","message":"nit: new line is missing","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":308,"context_line":"  import sushy"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  root \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027,"},{"line_number":311,"context_line":"                  username\u003d\u0027foo\u0027, password\u003d\u0027bar\u0027)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  # Instantiate a system object"},{"line_number":314,"context_line":"  system \u003d root.get_system(\u0027/redfish/v1/Systems/437XR1138R2\u0027)"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_4e73f216","line":311,"range":{"start_line":311,"start_character":18,"end_line":311,"end_character":48},"updated":"2019-11-01 13:41:31.000000000","message":"We may consider dropping this as irrelevant for this example","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"  # Instantiate a system object"},{"line_number":314,"context_line":"  system \u003d root.get_system(\u0027/redfish/v1/Systems/437XR1138R2\u0027)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"  # print system resource"},{"line_number":317,"context_line":"  print(\u0027Working on system resource %s\u0027 % system.identity)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"  for manager in system.managers:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_2e66b652","line":316,"updated":"2019-11-01 13:41:31.000000000","message":"This and the following comments are now too obvious, may be drop them?","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":327,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"          except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":330,"context_line":"              print(\u0027ERROR: Acme OEM not found in Manager %s\u0027"},{"line_number":331,"context_line":"                     % manager.identity)"},{"line_number":332,"context_line":"              continue"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_ce58428b","line":330,"range":{"start_line":330,"start_character":36,"end_line":330,"end_character":37},"updated":"2019-11-01 13:41:31.000000000","message":"extension","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"          # set boot device to a virtual media device image"},{"line_number":339,"context_line":"          manager_oem.set_virtual_boot_device("},{"line_number":340,"context_line":"                        ramdisk.iso,"},{"line_number":341,"context_line":"                        persistent\u003dFalse,"},{"line_number":342,"context_line":"                        manager\u003dmanager)"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_8e56ca5b","line":340,"range":{"start_line":340,"start_character":0,"end_line":340,"end_character":36},"updated":"2019-11-01 13:41:31.000000000","message":"This is still a bug","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"725aaa89eeebd1b0ba86c75be975be45af4cd65a","unresolved":false,"context_lines":[{"line_number":338,"context_line":"          # set boot device to a virtual media device image"},{"line_number":339,"context_line":"          manager_oem.set_virtual_boot_device("},{"line_number":340,"context_line":"                        ramdisk.iso,"},{"line_number":341,"context_line":"                        persistent\u003dFalse,"},{"line_number":342,"context_line":"                        manager\u003dmanager)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_ae514664","line":341,"range":{"start_line":341,"start_character":0,"end_line":341,"end_character":41},"updated":"2019-11-01 13:41:31.000000000","message":"We can drop this as irrelevant","commit_id":"94192bba2dcaaab0fa10584bcd7b651b3687d469"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c7564b9c49ea84ad2c879ac382deb5050a9546f4","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  import sushy"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  VIRTUAL_MEDIA_CD\u003d \u0027cd\u0027"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  root \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3fa7e38b_24c01550","line":311,"range":{"start_line":311,"start_character":18,"end_line":311,"end_character":19},"updated":"2019-11-01 15:10:06.000000000","message":"PEP8: missing space","commit_id":"f9c74e875f191926237621bec4ded9947f743364"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"18709d5985b9bed0d860f6f9a118bf1828cf051a","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"      print (\u0027Using System manager %s\u0027 % manager.identity)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"      for v_media in manager.virtual_media.get_members():"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"          try:"},{"line_number":327,"context_line":"              manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3fa7e38b_ff4da671","line":324,"updated":"2019-11-01 15:49:01.000000000","message":"With the removal of supported virtual media types verification, I guess this second loop (for v_media) can be removed as well.","commit_id":"5fe5a3ae36d5eb90f69404c74d9c418a7290d39d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"18709d5985b9bed0d860f6f9a118bf1828cf051a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"              continue"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"          print(\u0027%s is an OEM extension of Manager %s\u0027"},{"line_number":335,"context_line":"                 % (manager_oem.get_extension(),manager.identity))"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"          # set boot device to a virtual media device image"},{"line_number":338,"context_line":"          manager_oem.set_virtual_boot_device(VIRTUAL_MEDIA_CD,"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3fa7e38b_1f03e20e","line":335,"range":{"start_line":335,"start_character":48,"end_line":335,"end_character":49},"updated":"2019-11-01 15:49:01.000000000","message":"Ah, another missing whitespace","commit_id":"5fe5a3ae36d5eb90f69404c74d9c418a7290d39d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a8b5d0dafe241adc9c1580d2e1ad15ce5ec68e6e","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  import sushy"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  VIRTUAL_MEDIA_CD\u003d \u0027cd\u0027"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  root \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3fa7e38b_1f3202a8","line":311,"range":{"start_line":311,"start_character":18,"end_line":311,"end_character":19},"updated":"2019-11-01 16:13:16.000000000","message":"whitespace is missing","commit_id":"5bbcd102bfed8be6889918339e988a3906aa3c8a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2d6ad16764de2d08736a656b66cc706a1ac3f09a","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  import sushy"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  VIRTUAL_MEDIA_CD \u003d \u0027cd\u0027"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  root \u003d sushy.Sushy(\u0027http://localhost:8000/redfish/v1\u0027)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"3fa7e38b_9f791230","line":311,"updated":"2019-11-01 16:17:30.000000000","message":"Actually, this constant already exists as `sushy.VIRTUAL_MEDIA_CD` so we can drop it from here. Sorry for the afterthought!","commit_id":"e145c312aa0d74c0e717af45499b8a95cce65ec8"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d9e76718fdd4e89cc011e474e4e806afc52ce65f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"---------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"The OEM extension may not be present within each Redfish resource, to search"},{"line_number":302,"context_line":"for them you need to specify the vendor ID."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish"},{"line_number":305,"context_line":"Manager resource."}],"source_content_type":"text/x-rst","patch_set":21,"id":"3fa7e38b_ac8a9c17","line":302,"updated":"2019-11-04 11:16:59.000000000","message":"May be we should also mention the need to have a sushy OEM extension package installed on the system for requested OEM object to be handled. In other words, for this script to work two things are required: (1) Redfish BMC to include OEM piece in the requested resource for specific vendor and (2) sushy OEM extension package installed on the system for the same vendor.\n\nYou may want to check the code (get_oem_extension) to see for yourself how it works and the exact requirements for the whole thing to succeed.","commit_id":"d7e84ade54ed135f6c4ade459047bb50af3713fb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9e0e684ee4a4749f4e00222cc778d49db70c6caa","unresolved":false,"context_lines":[{"line_number":299,"context_line":"---------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Before running this example, please make sure you have a Redfish BMC that"},{"line_number":302,"context_line":"include the OEM piece for a specific vendor as well as the sushy OEM extension"},{"line_number":303,"context_line":"package installed in the system for the same vendor."},{"line_number":304,"context_line":"You should also take in consideration that the OEM extension may not be present"},{"line_number":305,"context_line":"within each Redfish resource, you need to specify the vendor ID to search"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_b12de5af","line":302,"range":{"start_line":302,"start_character":43,"end_line":302,"end_character":44},"updated":"2019-11-07 11:13:08.000000000","message":"Please, fix punctuation.","commit_id":"57700501de38af22486649c6a3cdc3caf0eed347"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9e0e684ee4a4749f4e00222cc778d49db70c6caa","unresolved":false,"context_lines":[{"line_number":299,"context_line":"---------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Before running this example, please make sure you have a Redfish BMC that"},{"line_number":302,"context_line":"include the OEM piece for a specific vendor as well as the sushy OEM extension"},{"line_number":303,"context_line":"package installed in the system for the same vendor."},{"line_number":304,"context_line":"You should also take in consideration that the OEM extension may not be present"},{"line_number":305,"context_line":"within each Redfish resource, you need to specify the vendor ID to search"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_f1559d1f","line":302,"range":{"start_line":302,"start_character":0,"end_line":302,"end_character":7},"updated":"2019-11-07 11:13:08.000000000","message":"includes","commit_id":"57700501de38af22486649c6a3cdc3caf0eed347"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9e0e684ee4a4749f4e00222cc778d49db70c6caa","unresolved":false,"context_lines":[{"line_number":302,"context_line":"include the OEM piece for a specific vendor as well as the sushy OEM extension"},{"line_number":303,"context_line":"package installed in the system for the same vendor."},{"line_number":304,"context_line":"You should also take in consideration that the OEM extension may not be present"},{"line_number":305,"context_line":"within each Redfish resource, you need to specify the vendor ID to search"},{"line_number":306,"context_line":"for them."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_b1164558","line":305,"range":{"start_line":305,"start_character":30,"end_line":305,"end_character":49},"updated":"2019-11-07 11:13:08.000000000","message":"This holds true for all resources and vendors regardless OEM extension presence. So you always need searching, your search may or may not succeed.","commit_id":"57700501de38af22486649c6a3cdc3caf0eed347"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"9e0e684ee4a4749f4e00222cc778d49db70c6caa","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"If you do not have any real baremetal machine that supports the Redfish"},{"line_number":343,"context_line":"protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":344,"context_line":"run a Redfish emulator."}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_6c055610","line":344,"range":{"start_line":343,"start_character":57,"end_line":344,"end_character":3},"updated":"2019-11-07 11:13:08.000000000","message":"Good point, though, may be we should note that presently neither of the emulators (static/dynamic) readily expose any OEM. So for the user to run the above mentioned example, they would probably need to manually add some OEM resource to emulators\u0027 templates. Perhaps it\u0027s easier with static emulator.","commit_id":"57700501de38af22486649c6a3cdc3caf0eed347"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3a725c3ea7eaff9e9a02e6b43d66f1fa30c480bd","unresolved":false,"context_lines":[{"line_number":302,"context_line":"includes the OEM piece for a specific vendor, as well as the sushy OEM"},{"line_number":303,"context_line":"extension package installed in the system for the same vendor."},{"line_number":304,"context_line":"You should also ensure the presence of the OEM extension within each Redfish"},{"line_number":305,"context_line":"resource by specifying the vendor ID and search for them."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"In the folowing example we are looking up \"Acme\" vendor extension to Redfish"},{"line_number":308,"context_line":"Manager resource."}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_9b921ffc","line":305,"range":{"start_line":305,"start_character":9,"end_line":305,"end_character":36},"updated":"2019-11-12 11:30:53.000000000","message":"You can\u0027t ensure the presence of vendor extension on the server by changing your client query, right? The server either serves OEM branch for a resource to the clients or not. If it does not, then this example script won\u0027t work and the client can\u0027t do anything about that.\n\nOnce you have BMC that serves OEM extension for a resource, the client can search for it by vendor ID. This search might succeed if OEM branch is in place.\n\nI\u0027d suggest you going through sushy code to have a clear picture of how this OEM lookup works (get_oem_extension), then express the logic behind that in English. Reading Redfish OEM spec can also be revealing.","commit_id":"9588b97cc8263ebb9db5e41c1537f819d5868fe8"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3a725c3ea7eaff9e9a02e6b43d66f1fa30c480bd","unresolved":false,"context_lines":[{"line_number":341,"context_line":"If you do not have any real baremetal machine that supports the Redfish"},{"line_number":342,"context_line":"protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":343,"context_line":"run a Redfish emulator."},{"line_number":344,"context_line":"In case of the OEM extension example, presently, both of the emulators"},{"line_number":345,"context_line":"(static/dynamic) do not expose any OEM, as a result, users may need to add"},{"line_number":346,"context_line":"manually some OEM resources to emulators\u0027templates. It may be easier to"},{"line_number":347,"context_line":"start with a static emulator."}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_0615763d","line":344,"range":{"start_line":344,"start_character":0,"end_line":344,"end_character":2},"updated":"2019-11-12 11:30:53.000000000","message":"Please, follow established style of sushy documentation. Also, may be running some sort of a linter on the docs you push would improve the quality of the patches you propose.\n\nAnother advice would be to code-review your own patches first. These typos and malformed formatting is not something your fellow code reviewers would crave for.","commit_id":"9588b97cc8263ebb9db5e41c1537f819d5868fe8"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3a725c3ea7eaff9e9a02e6b43d66f1fa30c480bd","unresolved":false,"context_lines":[{"line_number":343,"context_line":"run a Redfish emulator."},{"line_number":344,"context_line":"In case of the OEM extension example, presently, both of the emulators"},{"line_number":345,"context_line":"(static/dynamic) do not expose any OEM, as a result, users may need to add"},{"line_number":346,"context_line":"manually some OEM resources to emulators\u0027templates. It may be easier to"},{"line_number":347,"context_line":"start with a static emulator."}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_1b22afbb","line":346,"range":{"start_line":346,"start_character":40,"end_line":346,"end_character":41},"updated":"2019-11-12 11:30:53.000000000","message":"missing space?","commit_id":"9588b97cc8263ebb9db5e41c1537f819d5868fe8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"18a8c29d04fb6efa842d3172b0eac6953ea44e62","unresolved":false,"context_lines":[{"line_number":301,"context_line":"Before running this example, please make sure you have a Redfish BMC that"},{"line_number":302,"context_line":"includes the OEM piece for a specific vendor, as well as the Sushy OEM"},{"line_number":303,"context_line":"extension package installed in the system for the same vendor."},{"line_number":304,"context_line":"You can check the presence of the OEM extension within each Redfish"},{"line_number":305,"context_line":"resource by specifying the vendor ID and search for them."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"In the following example, we are looking up \"Acme\" vendor extension to Redfish"}],"source_content_type":"text/x-rst","patch_set":24,"id":"3fa7e38b_526e13c8","line":304,"updated":"2019-11-25 21:56:03.000000000","message":"If you want to start a different paragraph, you will have the leave another blank line from the paragraph above.","commit_id":"09eee0a6fe518bf52bd4ef8965dc269956ea3ba5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"18a8c29d04fb6efa842d3172b0eac6953ea44e62","unresolved":false,"context_lines":[{"line_number":349,"context_line":"If you do not have any real baremetal machine that supports the Redfish"},{"line_number":350,"context_line":"protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":351,"context_line":"run a Redfish emulator."},{"line_number":352,"context_line":"For the OEM extension example, presently, both of the emulators"},{"line_number":353,"context_line":"(static/dynamic) do not expose any OEM, as a result, users may need to add"},{"line_number":354,"context_line":"manually some OEM resources to emulators\u0027 templates. It may be easier to"},{"line_number":355,"context_line":"start with a static emulator."}],"source_content_type":"text/x-rst","patch_set":24,"id":"3fa7e38b_f2685fba","line":352,"updated":"2019-11-25 21:56:03.000000000","message":"ditto","commit_id":"09eee0a6fe518bf52bd4ef8965dc269956ea3ba5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"18a8c29d04fb6efa842d3172b0eac6953ea44e62","unresolved":false,"context_lines":[{"line_number":350,"context_line":"protocol you can look at the :ref:`contributing` page to learn how to"},{"line_number":351,"context_line":"run a Redfish emulator."},{"line_number":352,"context_line":"For the OEM extension example, presently, both of the emulators"},{"line_number":353,"context_line":"(static/dynamic) do not expose any OEM, as a result, users may need to add"},{"line_number":354,"context_line":"manually some OEM resources to emulators\u0027 templates. It may be easier to"},{"line_number":355,"context_line":"start with a static emulator."}],"source_content_type":"text/x-rst","patch_set":24,"id":"3fa7e38b_72feaf05","line":353,"range":{"start_line":353,"start_character":38,"end_line":353,"end_character":39},"updated":"2019-11-25 21:56:03.000000000","message":"semicolon here might be a better choice","commit_id":"09eee0a6fe518bf52bd4ef8965dc269956ea3ba5"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7db7e78cc76562ae2e14d9e2115008bcc46b9fa5","unresolved":false,"context_lines":[{"line_number":326,"context_line":"      # Get a list of OEM extension names for the system manager"},{"line_number":327,"context_line":"      oem_vendors \u003d manager.oem_vendors"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"      print(\u0027Listing OEM extension name(s) for the System manager %s\u0027"},{"line_number":330,"context_line":"             % manager.identity )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      print(*oem_vendors, sep \u003d \"\\n\")"}],"source_content_type":"text/x-rst","patch_set":25,"id":"3fa7e38b_506832f3","line":329,"updated":"2019-11-27 12:23:50.000000000","message":"nit: arguably better formatting here and everywhere:\n\n    print(\u0027Listing OEM extension name(s) for the System \u0027\n             \u0027manager %s\u0027 % manager.identity )","commit_id":"175b3dc575d59e6087b40e51ac26da2af7128f96"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"7db7e78cc76562ae2e14d9e2115008bcc46b9fa5","unresolved":false,"context_lines":[{"line_number":329,"context_line":"      print(\u0027Listing OEM extension name(s) for the System manager %s\u0027"},{"line_number":330,"context_line":"             % manager.identity )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      print(*oem_vendors, sep \u003d \"\\n\")"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"      try:"},{"line_number":335,"context_line":"          manager_oem \u003d manager.get_oem_extension(\u0027Acme\u0027)"}],"source_content_type":"text/x-rst","patch_set":25,"id":"3fa7e38b_706d2e02","line":332,"updated":"2019-11-27 12:23:50.000000000","message":"no spaces around \u003d in kw args","commit_id":"175b3dc575d59e6087b40e51ac26da2af7128f96"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e2dafee37eb5954f3c98a06a97c38db49ff4fe74","unresolved":false,"context_lines":[{"line_number":327,"context_line":"      oem_vendors \u003d manager.oem_vendors"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"      print(\u0027Listing OEM extension name(s) for the System \u0027"},{"line_number":330,"context_line":"                 \u0027manager %s\u0027 % manager.identity )"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      print(*oem_vendors, sep\u003d\"\\n\")"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"3fa7e38b_579a456f","line":330,"updated":"2019-11-29 17:56:52.000000000","message":"nit: wrong indentation (pep8 violation)","commit_id":"0ce74b2ff1eeae73a971eed2180bc10ccee359ea"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e2dafee37eb5954f3c98a06a97c38db49ff4fe74","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"      except sushy.exceptions.OEMExtensionNotFoundError:"},{"line_number":338,"context_line":"          print(\u0027ERROR: Acme OEM extension not found in \u0027"},{"line_number":339,"context_line":"                        \u0027Manager %s\u0027 % manager.identity)"},{"line_number":340,"context_line":"          continue"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"      print(\u0027%s is an OEM extension of Manager %s\u0027"}],"source_content_type":"text/x-rst","patch_set":26,"id":"3fa7e38b_77974147","line":339,"updated":"2019-11-29 17:56:52.000000000","message":"ditto","commit_id":"0ce74b2ff1eeae73a971eed2180bc10ccee359ea"}]}