)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"9a91e94d949b3614b378e05d666e53a3b0a4b2fc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for SimpleStorage, the type of CapacityBytes can be either integer or"},{"line_number":13,"context_line":"null [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The Dell integrated Dell Remote Access Controller (iDRAC) 9 running"},{"line_number":16,"context_line":"Lifecycle Controller firmware version 3.30.30.30 returns that for a Dell"},{"line_number":17,"context_line":"EMC PowerEdge R740xd containing a Dell HBA 330 12Gbps SAS Host Bus"},{"line_number":18,"context_line":"Adapter Controller (non-RAID), MiniCard (HBA 330 Mini) [2]. The HBA 330"},{"line_number":19,"context_line":"Mini firmware version is 16.17.00.03."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The same was observed against an R740xd running Lifecycle Controller"},{"line_number":22,"context_line":"firmware version 3.34.34.34."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This changes the SimpleStorageCollection.disks_size_bytes property to"},{"line_number":25,"context_line":"process only Disks with CapacityByes not set to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_fb0d3e36","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":28},"updated":"2019-12-20 02:57:12.000000000","message":"do we really need to go to this level of details?\nI think this fix will work for any physical RAID controller and disks that return NULL.\n\nThere maybe be other idrac FW versions and other RAID controllers that exhibit the same behavior; Dell and non-Dell.","commit_id":"9d01756833ec97a05f301a4fa1e8b2511d7c5c74"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0938eee1ff84d3b04341331981563c4439e589ef","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for SimpleStorage, the type of CapacityBytes can be either integer or"},{"line_number":13,"context_line":"null [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The Dell integrated Dell Remote Access Controller (iDRAC) 9 running"},{"line_number":16,"context_line":"Lifecycle Controller firmware version 3.30.30.30 returns that for a Dell"},{"line_number":17,"context_line":"EMC PowerEdge R740xd containing a Dell HBA 330 12Gbps SAS Host Bus"},{"line_number":18,"context_line":"Adapter Controller (non-RAID), MiniCard (HBA 330 Mini) [2]. The HBA 330"},{"line_number":19,"context_line":"Mini firmware version is 16.17.00.03."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The same was observed against an R740xd running Lifecycle Controller"},{"line_number":22,"context_line":"firmware version 3.34.34.34."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This changes the SimpleStorageCollection.disks_size_bytes property to"},{"line_number":25,"context_line":"process only Disks with CapacityByes not set to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f0fb1478","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":28},"in_reply_to":"3fa7e38b_fb0d3e36","updated":"2019-12-20 13:55:36.000000000","message":"It conveys to the reader really in what circumstances it was found, which I think helps the reader properly put into context \"this is a thing\" and \"this thing happened\". You raise a really good point at the same time, but context is always key for an initial read of the commit message.","commit_id":"9d01756833ec97a05f301a4fa1e8b2511d7c5c74"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"9a91e94d949b3614b378e05d666e53a3b0a4b2fc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"firmware version 3.34.34.34."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This changes the SimpleStorageCollection.disks_size_bytes property to"},{"line_number":25,"context_line":"process only Disks with CapacityByes not set to None."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://redfish.dmtf.org/schemas/SimpleStorage.v1_2_3.json"},{"line_number":28,"context_line":"[2] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2019-12-11.log.html#t2019-12-11T07:24:17"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7bfaae11","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":36},"updated":"2019-12-20 02:57:12.000000000","message":"bytes","commit_id":"9d01756833ec97a05f301a4fa1e8b2511d7c5c74"}],"sushy/resources/system/simple_storage.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"9a91e94d949b3614b378e05d666e53a3b0a4b2fc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return sorted(device.capacity_bytes"},{"line_number":74,"context_line":"                      for simpl_stor in self.get_members()"},{"line_number":75,"context_line":"                      for device in simpl_stor.devices"},{"line_number":76,"context_line":"                      if (device.status.state \u003d\u003d res_cons.STATE_ENABLED"},{"line_number":77,"context_line":"                          and device.capacity_bytes is not None))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @property"},{"line_number":80,"context_line":"    def max_size_bytes(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3b043614","line":77,"range":{"start_line":76,"start_character":22,"end_line":77,"end_character":65},"updated":"2019-12-20 02:57:12.000000000","message":"nice simple fix.","commit_id":"9d01756833ec97a05f301a4fa1e8b2511d7c5c74"}]}