)]}'
{"id":"openstack%2Fsushy~711925","triplet_id":"openstack%2Fsushy~master~Ie8f867c7d824db156af8b874acae45d6496014a7","project":"openstack/sushy","branch":"master","topic":"relax-registry-req","hashtags":[],"change_id":"Ie8f867c7d824db156af8b874acae45d6496014a7","subject":"Make MessageRegistryFile.Registry attribute non-required","status":"MERGED","created":"2020-03-09 14:03:58.000000000","updated":"2020-04-03 15:18:01.000000000","submitted":"2020-03-24 19:49:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"711925-1585079353297-354c625b","meta_rev_id":"b17d20b8b3f9ccf66d7a09ab6c8e41bc41c433a7","_number":711925,"virtual_id_number":711925,"owner":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-24 19:49:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-10 11:18:43.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"date":"2020-03-11 17:58:14.000000000","_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":2,"date":"2020-03-24 05:27:12.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":2,"date":"2020-03-23 20:24:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":1,"date":"2020-03-24 18:58:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-10 11:18:43.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-24 05:27:12.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2020-03-24 18:58:32.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-03-24 19:49:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"28a236e7388e442f92c0d19e0608ab106bf66166","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-09 14:03:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c6d5dc702ebc59db9cc455f8b8757eafed0f1633","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-09 14:07:42.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d6defed8bbdc9d17b626c34395afae7cc0f82c6a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-09 15:00:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1765a0acc0774e36ab07a833b5a928d1 : SUCCESS in 6m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f4ae70702abe48daa9625cfb49efa7b3 : SUCCESS in 5m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f21ce3fbb68e417a9806e20d732d266c : SUCCESS in 5m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4254907a6d044e69a171d04f7e460fa : SUCCESS in 3m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6e304a7b085148ff90cb6f00a467810a : SUCCESS in 11m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b17db2d919a747e290c8a5cc26ca4ddb : SUCCESS in 5m 04s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5611edeb0d948b880e61df337475768 : SUCCESS in 14m 40s\n- sushy-tempest-ironic-partition-redfish-src https://zuul.opendev.org/t/openstack/build/bb97c304b2d9480ead592fe85572ef45 : SUCCESS in 50m 03s","accounts_in_message":[],"_revision_number":2},{"id":"79157614d2afd5f8aa8aae74ca9ace9e7b00e4f3","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-10 11:18:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"acb044bcb9466a51737f751eeeba657015851f82","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-11 17:58:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"43e54ca8066721d24ba7d71e6a62b5eca1426f8d","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-03-23 20:24:29.000000000","message":"Patch Set 2: Code-Review+2\n\nLikely ought to consider major version bump due to default value change.","accounts_in_message":[],"_revision_number":2},{"id":"0260a93093547f15d12681995df155086639926b","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2020-03-24 05:27:12.000000000","message":"Patch Set 2: Code-Review+2\n\nThank you Ilya.","accounts_in_message":[],"_revision_number":2},{"id":"6e9c00c159c4e759cbce64f0ecfc0534b8beb599","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-03-24 18:58:32.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bed2303a2e8694a646f6af164fadb1ed9b0c564d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 18:58:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"eadfd7a335003d209d3b6e43e4dee9c05225e878","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 19:49:12.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0e8c09b3778045daabd2b2346715be45 : SUCCESS in 4m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/83507be1d8074f81866230875e3a7332 : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b6d291ef9b544187980d84c51e28e3d3 : SUCCESS in 6m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/db8a8953b52a4b2ea202019ee3e5810d : SUCCESS in 7m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe20e3882c684a1891f60ab6008b6fa7 : SUCCESS in 9m 06s\n- sushy-tempest-ironic-partition-redfish-src https://zuul.opendev.org/t/openstack/build/6b2f2b30be354f0b892c05c106cce7de : SUCCESS in 47m 53s","accounts_in_message":[],"_revision_number":2},{"id":"233cd03589bf9a3aa41b600ce882e45565573b3a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 19:49:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"7bb1d06e20356d8e41fbdfb2382db677fecec802","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 19:52:23.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/56a6adaaf50e448db2b0d9da2be70c04 : SUCCESS in 2m 06s","accounts_in_message":[],"_revision_number":2},{"id":"1e840a336d718dede50dfd0f2c40f46c464d8d56","author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"date":"2020-04-03 15:18:01.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit e905df30c878d7348b842116aabbacb1a40a2a53","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8177e66462ac83e527cc96f92e4ea6c391737570","revisions":{"ffde423a3c05f80e32533a53c30225406dc67b2c":{"kind":"REWORK","_number":1,"created":"2020-03-09 14:03:58.000000000","uploader":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"ref":"refs/changes/25/711925/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy","ref":"refs/changes/25/711925/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy refs/changes/25/711925/1"}}},"commit":{"parents":[{"commit":"e5b8c8724edbc334478010214e5829ae8881943e","subject":"Fix incorrect usage of assertRaisesRegex in unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/e5b8c8724edbc334478010214e5829ae8881943e"}]}],"author":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-03-09 14:02:45.000000000","tz":60},"committer":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-03-09 14:02:45.000000000","tz":60},"subject":"Make MessageRegistryFile.Registry attribute non-required","message":"Make MessageRegistryFile.Registry attribute non-required\n\nAccording to Redfish schema, MessageRegistryFile.Registry\nattribute is required and should specify some prefix for\nthe accompanying messages.\n\nIt turned out, that certain vendor does not supply this\nattribute in Redfish response message. That makes sushy\nexploding on attempt to fetch any resource from BMC.\n\nThis patch makes the above mentioned attribute defaulted\nto some nonsense what will make sushy logging the problem,\nbut not exploding.\n\nIt is not entirely clear if the client could make sense\nof the messages without this \"Registry\" prefix though.\n\nChange-Id: Ie8f867c7d824db156af8b874acae45d6496014a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/ffde423a3c05f80e32533a53c30225406dc67b2c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/ffde423a3c05f80e32533a53c30225406dc67b2c"}]},"branch":"refs/heads/master"},"8177e66462ac83e527cc96f92e4ea6c391737570":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-03-09 14:07:42.000000000","uploader":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"ref":"refs/changes/25/711925/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/sushy","ref":"refs/changes/25/711925/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/sushy refs/changes/25/711925/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/sushy refs/changes/25/711925/2"}}},"commit":{"parents":[{"commit":"e5b8c8724edbc334478010214e5829ae8881943e","subject":"Fix incorrect usage of assertRaisesRegex in unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/e5b8c8724edbc334478010214e5829ae8881943e"}]}],"author":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-03-09 14:02:45.000000000","tz":60},"committer":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-03-09 14:06:53.000000000","tz":60},"subject":"Make MessageRegistryFile.Registry attribute non-required","message":"Make MessageRegistryFile.Registry attribute non-required\n\nAccording to Redfish schema, MessageRegistryFile.Registry\nattribute is required and should specify some prefix for\nthe accompanying messages.\n\nIt turned out, that certain vendor does not supply this\nattribute in Redfish response message. That makes sushy\nexploding on attempt to fetch any resource from BMC.\n\nThis patch makes the above mentioned attribute defaulted\nto some nonsense what will make sushy logging the problem,\nbut not exploding.\n\nIt is not entirely clear if the client could make sense\nof the messages without this \"Registry\" prefix though.\n\nStory: 2006641\nTask: 36864\nChange-Id: Ie8f867c7d824db156af8b874acae45d6496014a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/8177e66462ac83e527cc96f92e4ea6c391737570"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/sushy/commit/8177e66462ac83e527cc96f92e4ea6c391737570"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
