)]}'
{"sushy/resources/updateservice/updateservice.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"782b8b994bac9fcab6f0c944f5fe0374114d19c6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def software_inventory(self):"},{"line_number":156,"context_line":"        \"\"\"Property to reference SoftwareInventoryCollection instance\"\"\""},{"line_number":157,"context_line":"        return softwareinventory.SoftwareInventoryCollection("},{"line_number":158,"context_line":"            self._conn, self._get_software_inventory_collection_path,"},{"line_number":159,"context_line":"            redfish_version\u003dself.redfish_version, registries\u003dself.registries)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fa80d848","side":"PARENT","line":158,"updated":"2020-08-03 14:23:57.000000000","message":"The bug in the original code was that the above line passed a method name, instead of calling the method.  Missing () after the method name.","commit_id":"c4ae144fb6034185fe890d5acfd8dbe1853c1f70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"782b8b994bac9fcab6f0c944f5fe0374114d19c6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def firmware_inventory(self):"},{"line_number":164,"context_line":"        \"\"\"Property to reference SoftwareInventoryCollection instance\"\"\""},{"line_number":165,"context_line":"        return softwareinventory.SoftwareInventoryCollection("},{"line_number":166,"context_line":"            self._conn, self._get_software_inventory_collection_path,"},{"line_number":167,"context_line":"            redfish_version\u003dself.redfish_version, registries\u003dself.registries)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_faf578ee","side":"PARENT","line":166,"updated":"2020-08-03 14:23:57.000000000","message":"In addition to incorrectly passing the method name on the line above, this code was getting the path for SoftwareInventory when it should have been getting the path for FirmwareInventory.","commit_id":"c4ae144fb6034185fe890d5acfd8dbe1853c1f70"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"740aed5cb0e5af13f418b26b109deddc06ae588d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"\"\"Property to reference SoftwareInventoryCollection instance\"\"\""},{"line_number":153,"context_line":"        return softwareinventory.SoftwareInventoryCollection("},{"line_number":154,"context_line":"            self._conn,"},{"line_number":155,"context_line":"            self._software_inventory_path,"},{"line_number":156,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":157,"context_line":"            registries\u003dself.registries)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bba778a7","line":155,"updated":"2020-08-04 10:47:20.000000000","message":"Do we need explicit handling for empty path as we used to have in the method?","commit_id":"b87ca42d45056f80bdb637a94867fa0097101841"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"518c7861293aa891ee0cd9c69102257ccfe21c33","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"\"\"Property to reference SoftwareInventoryCollection instance\"\"\""},{"line_number":153,"context_line":"        return softwareinventory.SoftwareInventoryCollection("},{"line_number":154,"context_line":"            self._conn,"},{"line_number":155,"context_line":"            self._software_inventory_path,"},{"line_number":156,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":157,"context_line":"            registries\u003dself.registries)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8c0fdc35","line":155,"in_reply_to":"9f560f44_bba778a7","updated":"2020-08-04 14:18:35.000000000","message":"I don\u0027t believe so. I tested both of these methods against a Dell server with recent firmware.  It had a FirmwareInventory resource that contained data, but it did not have a SoftwareInventory resource.  In the SoftwareInventory case the code returns a SoftwareInventoryCollection that returns an empty list when get_members() is called:\nhttps://github.com/openstack/sushy/blob/master/sushy/resources/base.py#L609\nSo I don\u0027t believe we need special handling for empty path.  This is a behavior change (returning basically empty list vs raising an ex), but the methods never worked anyway, so I don\u0027t think that matters either, and returning the empty list appears to be what it should do since that\u0027s what the infrastructure does.","commit_id":"b87ca42d45056f80bdb637a94867fa0097101841"}]}