)]}'
{"sushy/resources/system/bios.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eaf986180f7112aff42c78e6ac47f49e1447542b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            set by the system."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        payload \u003d {\u0027Attributes\u0027: value}"},{"line_number":153,"context_line":"        if apply_time:"},{"line_number":154,"context_line":"            prop \u003d \u0027@Redfish.SettingsApplyTime\u0027"},{"line_number":155,"context_line":"            payload[prop] \u003d {"},{"line_number":156,"context_line":"                \u0027@odata.type\u0027: \u0027#Settings.v1_0_0.PreferredApplyTime\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fe85995a","line":153,"updated":"2020-09-03 10:43:48.000000000","message":"nit: warning or raise when maintenance parameters are provided but apply_time is not.","commit_id":"1bcc6d2ab8b803740d2bb38d1e060b5c5b7919bb"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"47da3d520875739ff7f00c3c97c5b66928bf2b89","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            set by the system."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        payload \u003d {\u0027Attributes\u0027: value}"},{"line_number":153,"context_line":"        if apply_time:"},{"line_number":154,"context_line":"            prop \u003d \u0027@Redfish.SettingsApplyTime\u0027"},{"line_number":155,"context_line":"            payload[prop] \u003d {"},{"line_number":156,"context_line":"                \u0027@odata.type\u0027: \u0027#Settings.v1_0_0.PreferredApplyTime\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a1c81474","line":153,"in_reply_to":"9f560f44_fe85995a","updated":"2020-09-04 08:26:31.000000000","message":"added to raise an error to prevent from making an invalid call to BMC. (In case of just logged warning, call to BMC will be made and then there should be an error logged, warning would duplicate that).","commit_id":"1bcc6d2ab8b803740d2bb38d1e060b5c5b7919bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eaf986180f7112aff42c78e6ac47f49e1447542b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                payload[prop][\u0027MaintenanceWindowStartTime\u0027] \u003d\\"},{"line_number":161,"context_line":"                    maint_window_start_time.isoformat()"},{"line_number":162,"context_line":"                payload[prop][\u0027MaintenanceWindowDurationInSeconds\u0027] \u003d\\"},{"line_number":163,"context_line":"                    maint_window_duration"},{"line_number":164,"context_line":"        self._settings.commit(self._conn,"},{"line_number":165,"context_line":"                              payload)"},{"line_number":166,"context_line":"        utils.cache_clear(self, force_refresh\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5e7da56c","line":163,"updated":"2020-09-03 10:43:48.000000000","message":"nit: raise if only one parameter is provided","commit_id":"1bcc6d2ab8b803740d2bb38d1e060b5c5b7919bb"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"47da3d520875739ff7f00c3c97c5b66928bf2b89","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                payload[prop][\u0027MaintenanceWindowStartTime\u0027] \u003d\\"},{"line_number":161,"context_line":"                    maint_window_start_time.isoformat()"},{"line_number":162,"context_line":"                payload[prop][\u0027MaintenanceWindowDurationInSeconds\u0027] \u003d\\"},{"line_number":163,"context_line":"                    maint_window_duration"},{"line_number":164,"context_line":"        self._settings.commit(self._conn,"},{"line_number":165,"context_line":"                              payload)"},{"line_number":166,"context_line":"        utils.cache_clear(self, force_refresh\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_81c35057","line":163,"in_reply_to":"9f560f44_5e7da56c","updated":"2020-09-04 08:26:31.000000000","message":"ditto","commit_id":"1bcc6d2ab8b803740d2bb38d1e060b5c5b7919bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"007fc84f045177fc6ed47ce2d4012897a0fd1136","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            set by the system."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        payload \u003d {\u0027Attributes\u0027: value}"},{"line_number":153,"context_line":"        if (maint_window_start_time or maint_window_duration)\\"},{"line_number":154,"context_line":"            and not apply_time:"},{"line_number":155,"context_line":"            raise ValueError(\u0027\"apply_time\" missing when passing maintenance \u0027"},{"line_number":156,"context_line":"                             \u0027window settings\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_01d3c0d6","line":153,"updated":"2020-09-04 08:52:41.000000000","message":"nit: please avoid combining brackets with \\\n\n if ((...)\n       or ...):","commit_id":"0c86b6b4d85e5a21bf4ca7bc185c5440bac4cf56"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"007fc84f045177fc6ed47ce2d4012897a0fd1136","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                \u0027@odata.type\u0027: \u0027#Settings.v1_0_0.PreferredApplyTime\u0027,"},{"line_number":161,"context_line":"                \u0027ApplyTime\u0027: res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":162,"context_line":"            }"},{"line_number":163,"context_line":"            if (maint_window_start_time and not maint_window_duration):"},{"line_number":164,"context_line":"                raise ValueError(\u0027\"maint_window_duration\" missing\u0027)"},{"line_number":165,"context_line":"            if (not maint_window_start_time and maint_window_duration):"},{"line_number":166,"context_line":"                raise ValueError(\u0027\"maint_window_start_time\" missing\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_61d9dcf2","line":163,"updated":"2020-09-04 08:52:41.000000000","message":"nit: redundant brackets","commit_id":"0c86b6b4d85e5a21bf4ca7bc185c5440bac4cf56"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"007fc84f045177fc6ed47ce2d4012897a0fd1136","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            }"},{"line_number":163,"context_line":"            if (maint_window_start_time and not maint_window_duration):"},{"line_number":164,"context_line":"                raise ValueError(\u0027\"maint_window_duration\" missing\u0027)"},{"line_number":165,"context_line":"            if (not maint_window_start_time and maint_window_duration):"},{"line_number":166,"context_line":"                raise ValueError(\u0027\"maint_window_start_time\" missing\u0027)"},{"line_number":167,"context_line":"            if maint_window_start_time and maint_window_duration:"},{"line_number":168,"context_line":"                payload[prop][\u0027MaintenanceWindowStartTime\u0027] \u003d\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_41d498bb","line":165,"updated":"2020-09-04 08:52:41.000000000","message":"ditto","commit_id":"0c86b6b4d85e5a21bf4ca7bc185c5440bac4cf56"}]}