)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Bill Dodd \u003cbilldodd@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-10 13:31:49 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OperationApplyTime support to Volume methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The supported_values property in the OperationApplyTimeSupportField"},{"line_number":10,"context_line":"class returns an unmapped list of OperationApplyTime values supported"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2ccecf9b_46fa0462","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2020-12-28 18:17:05.000000000","message":"nit: If only this could fit in 50 chars, then including `TaskMonitor` would benefit for better visibility of what\u0027s included in this commit.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Bill Dodd \u003cbilldodd@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-10 13:31:49 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OperationApplyTime support to Volume methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The supported_values property in the OperationApplyTimeSupportField"},{"line_number":10,"context_line":"class returns an unmapped list of OperationApplyTime values supported"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"68108cdb_9a8e14d3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"in_reply_to":"2ccecf9b_46fa0462","updated":"2020-12-28 22:29:58.000000000","message":"Yes, given the 50 char limit, I think it would be hard to add that without taking out away other important words.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"e1fbc8d8b73bef9be1c3da6dc997b427572e4665","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bill Dodd \u003cbilldodd@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-10 13:31:49 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add OperationApplyTime support to Volume methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The supported_values property in the OperationApplyTimeSupportField"},{"line_number":10,"context_line":"class returns an unmapped list of OperationApplyTime values supported"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"342461fb_19146440","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"in_reply_to":"68108cdb_9a8e14d3","updated":"2021-01-04 08:18:10.000000000","message":"Ack","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"}],"sushy/resources/common.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"237d811414365db223f0396412afdc13cbb8a7be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    Deprecated: Use `mapped_supported_values`."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    mapped_supported_values \u003d base.MappedListField("},{"line_number":53,"context_line":"        \u0027SupportedValues\u0027, res_maps.APPLY_TIME_VALUE_MAP, required\u003dTrue)"},{"line_number":54,"context_line":"    \"\"\"The types of apply times that the client is allowed request when"},{"line_number":55,"context_line":"    performing a create, delete, or action operation returned as a mapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_06fffa66","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":11},"updated":"2020-11-13 12:28:30.000000000","message":"so far in sushy don\u0027t add \"mapped\" prefix to indicate mapped field, it is what it is. Adding this could mislead that other such fields are not mapped. Don\u0027t know how cases like this where keeping the same name would be better are handled.","commit_id":"04022286de60a3095fe422f7d1015de3bc3fcfe5"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"b3b99c2007bb96d80e4e06380d2d8118e2006583","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    Deprecated: Use `mapped_supported_values`."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    mapped_supported_values \u003d base.MappedListField("},{"line_number":53,"context_line":"        \u0027SupportedValues\u0027, res_maps.APPLY_TIME_VALUE_MAP, required\u003dTrue)"},{"line_number":54,"context_line":"    \"\"\"The types of apply times that the client is allowed request when"},{"line_number":55,"context_line":"    performing a create, delete, or action operation returned as a mapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f7a386fe","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":11},"in_reply_to":"1f621f24_06fffa66","updated":"2020-11-13 15:50:43.000000000","message":"Keeping the same name would be a breaking change, so I don\u0027t think that is an option. But I\u0027m open to other ideas.\n\nCore team: Suggestions here?","commit_id":"04022286de60a3095fe422f7d1015de3bc3fcfe5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c053de56c43e2f5c0529028658a429c0ac813e7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    Deprecated: Use `mapped_supported_values`."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    mapped_supported_values \u003d base.MappedListField("},{"line_number":53,"context_line":"        \u0027SupportedValues\u0027, res_maps.APPLY_TIME_VALUE_MAP, required\u003dTrue)"},{"line_number":54,"context_line":"    \"\"\"The types of apply times that the client is allowed request when"},{"line_number":55,"context_line":"    performing a create, delete, or action operation returned as a mapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"822d9c5c_3f5b48c2","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":11},"in_reply_to":"1f621f24_f7a386fe","updated":"2020-12-03 16:35:49.000000000","message":"It would be breaking because of the continuity break. In this case it is deprecated and there is a forward path, so I think this is okay.","commit_id":"04022286de60a3095fe422f7d1015de3bc3fcfe5"}],"sushy/resources/system/storage/volume.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                    intersection(action.allowed_values)])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def initialize_volume(self, value\u003dstore_cons.VOLUME_INIT_TYPE_FAST,"},{"line_number":94,"context_line":"                          apply_time\u003dNone, timeout\u003d500):"},{"line_number":95,"context_line":"        \"\"\"Initialize the volume."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param value: The InitializeType value."}],"source_content_type":"text/x-python","patch_set":2,"id":"eed618aa_e32f188d","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":54},"updated":"2020-12-28 18:17:05.000000000","message":"I don\u0027t know about history of blocking/non-blocking in Ironic, and how long is considered too long. So asking, will it be OK generally and in Ironic to allow waiting over 8 minutes by default in the worst case scenario? Could default timeout this big indicate that this should be async all the time?","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8fe01c3b06fb262056c723444f58b38ec6fed94a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                    intersection(action.allowed_values)])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def initialize_volume(self, value\u003dstore_cons.VOLUME_INIT_TYPE_FAST,"},{"line_number":94,"context_line":"                          apply_time\u003dNone, timeout\u003d500):"},{"line_number":95,"context_line":"        \"\"\"Initialize the volume."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param value: The InitializeType value."}],"source_content_type":"text/x-python","patch_set":2,"id":"bb5f2278_bc5a2457","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":54},"in_reply_to":"3d4b8d60_06865a9e","updated":"2020-12-29 08:46:50.000000000","message":"just for some data: for iDRAC most of controllers support \u0027Immediate\u0027, but it only eliminates need for reboot that saves some time. Operation itself will take on average 60-90 seconds, it\u0027s not 8 minutes, but also not instant.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"8d9f883f83261c32d1cfc0b8077bc9e1fc27497c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    intersection(action.allowed_values)])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def initialize_volume(self, value\u003dstore_cons.VOLUME_INIT_TYPE_FAST,"},{"line_number":94,"context_line":"                          apply_time\u003dNone, timeout\u003d500):"},{"line_number":95,"context_line":"        \"\"\"Initialize the volume."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param value: The InitializeType value."}],"source_content_type":"text/x-python","patch_set":2,"id":"32b91f4f_4eac88c9","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":54},"in_reply_to":"bb5f2278_bc5a2457","updated":"2020-12-30 20:58:34.000000000","message":"Ack","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                    intersection(action.allowed_values)])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def initialize_volume(self, value\u003dstore_cons.VOLUME_INIT_TYPE_FAST,"},{"line_number":94,"context_line":"                          apply_time\u003dNone, timeout\u003d500):"},{"line_number":95,"context_line":"        \"\"\"Initialize the volume."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param value: The InitializeType value."}],"source_content_type":"text/x-python","patch_set":2,"id":"3d4b8d60_06865a9e","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":54},"in_reply_to":"eed618aa_e32f188d","updated":"2020-12-28 22:29:58.000000000","message":"Ironic operations taking multiple minutes don\u0027t seem unusual to me (in my limited experience). But I\u0027ll let others chime in.\n\n(Note that we\u0027ll only be trying to do sync operation if the service advertises that it supports \"Immediate\".)","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            APPLY_TIME_ON_RESET - On reset,"},{"line_number":101,"context_line":"            APPLY_TIME_MAINT_START - During specified maintenance time"},{"line_number":102,"context_line":"            APPLY_TIME_MAINT_RESET - On reset during specified maintenance time"},{"line_number":103,"context_line":"        :param timeout: Max time in seconds to wait for blocking async call."},{"line_number":104,"context_line":"        :raises: InvalidParameterValueError, if the target value is not"},{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"}],"source_content_type":"text/x-python","patch_set":2,"id":"de85c515_a33f02a2","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":76},"updated":"2020-12-28 18:17:05.000000000","message":"for this and other methods perhaps add this change to release note?","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"8d9f883f83261c32d1cfc0b8077bc9e1fc27497c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            APPLY_TIME_ON_RESET - On reset,"},{"line_number":101,"context_line":"            APPLY_TIME_MAINT_START - During specified maintenance time"},{"line_number":102,"context_line":"            APPLY_TIME_MAINT_RESET - On reset during specified maintenance time"},{"line_number":103,"context_line":"        :param timeout: Max time in seconds to wait for blocking async call."},{"line_number":104,"context_line":"        :raises: InvalidParameterValueError, if the target value is not"},{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcdbb434_12afac07","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":76},"in_reply_to":"be80248c_5b9b4482","updated":"2020-12-30 20:58:34.000000000","message":"Done","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            APPLY_TIME_ON_RESET - On reset,"},{"line_number":101,"context_line":"            APPLY_TIME_MAINT_START - During specified maintenance time"},{"line_number":102,"context_line":"            APPLY_TIME_MAINT_RESET - On reset during specified maintenance time"},{"line_number":103,"context_line":"        :param timeout: Max time in seconds to wait for blocking async call."},{"line_number":104,"context_line":"        :raises: InvalidParameterValueError, if the target value is not"},{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"}],"source_content_type":"text/x-python","patch_set":2,"id":"be80248c_5b9b4482","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":76},"in_reply_to":"de85c515_a33f02a2","updated":"2020-12-28 22:29:58.000000000","message":"I\u0027ll update release note as appropriate.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"},{"line_number":107,"context_line":"        :raises: HTTPError"},{"line_number":108,"context_line":"        :returns: TaskMonitor if async task or None if successful init"},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        valid_values \u003d self.get_allowed_initialize_volume_values()"},{"line_number":111,"context_line":"        if value not in valid_values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b6d5867f_38f8e725","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":70},"updated":"2020-12-28 18:17:05.000000000","message":"for this and other methods perhaps add this change to release note?","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"8d9f883f83261c32d1cfc0b8077bc9e1fc27497c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"},{"line_number":107,"context_line":"        :raises: HTTPError"},{"line_number":108,"context_line":"        :returns: TaskMonitor if async task or None if successful init"},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        valid_values \u003d self.get_allowed_initialize_volume_values()"},{"line_number":111,"context_line":"        if value not in valid_values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"af3cc670_14d8a814","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":70},"in_reply_to":"1bb8caf9_a300eb07","updated":"2020-12-30 20:58:34.000000000","message":"Done","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            allowed."},{"line_number":106,"context_line":"        :raises: ConnectionError"},{"line_number":107,"context_line":"        :raises: HTTPError"},{"line_number":108,"context_line":"        :returns: TaskMonitor if async task or None if successful init"},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        valid_values \u003d self.get_allowed_initialize_volume_values()"},{"line_number":111,"context_line":"        if value not in valid_values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bb8caf9_a300eb07","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":70},"in_reply_to":"b6d5867f_38f8e725","updated":"2020-12-28 22:29:58.000000000","message":"ditto","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        value \u003d store_maps.VOLUME_INIT_TYPE_MAP_REV[value]"},{"line_number":115,"context_line":"        payload \u003d {\u0027InitializeType\u0027: value}"},{"line_number":116,"context_line":"        blocking \u003d False"},{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."}],"source_content_type":"text/x-python","patch_set":2,"id":"65361496_8a5679da","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"updated":"2020-12-28 18:17:05.000000000","message":"maybe move this outside of the method to avoid duplication in other methods and allow re-use across all methods that need this?","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"8d9f883f83261c32d1cfc0b8077bc9e1fc27497c","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        value \u003d store_maps.VOLUME_INIT_TYPE_MAP_REV[value]"},{"line_number":115,"context_line":"        payload \u003d {\u0027InitializeType\u0027: value}"},{"line_number":116,"context_line":"        blocking \u003d False"},{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."}],"source_content_type":"text/x-python","patch_set":2,"id":"66a5d33d_50215d90","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"in_reply_to":"4fba83d3_c7841516","updated":"2020-12-30 20:58:34.000000000","message":"I did not find an existing file that has Redfish specified constants defined. The file resources/constants.py only contains mapped constants. For now, not adding a constant. Perhaps this can be done in follow-up if someone has a good suggestion.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        value \u003d store_maps.VOLUME_INIT_TYPE_MAP_REV[value]"},{"line_number":115,"context_line":"        payload \u003d {\u0027InitializeType\u0027: value}"},{"line_number":116,"context_line":"        blocking \u003d False"},{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."}],"source_content_type":"text/x-python","patch_set":2,"id":"4fba83d3_c7841516","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"in_reply_to":"65361496_8a5679da","updated":"2020-12-28 22:29:58.000000000","message":"I\u0027ll look into it to see if I can find a good place to add that.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"6f97986123d6fca489c2ba0502d9aa51c91e8b0a","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        value \u003d store_maps.VOLUME_INIT_TYPE_MAP_REV[value]"},{"line_number":115,"context_line":"        payload \u003d {\u0027InitializeType\u0027: value}"},{"line_number":116,"context_line":"        blocking \u003d False"},{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."}],"source_content_type":"text/x-python","patch_set":2,"id":"77d1f808_b6594835","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"in_reply_to":"66a5d33d_50215d90","updated":"2021-01-04 08:17:28.000000000","message":"I was thinking maybe just a local variable in this module, don\u0027t think there is something else for this in sushy, but not a big deal.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d5613e1b0015bbc332a6cb11bf2386de439b7ca","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."},{"line_number":121,"context_line":"                APPLY_TIME_VALUE_MAP_REV[res_cons.APPLY_TIME_IMMEDIATE]):"},{"line_number":122,"context_line":"            blocking \u003d True"},{"line_number":123,"context_line":"        target_uri \u003d self._get_initialize_action_element().target_uri"},{"line_number":124,"context_line":"        r \u003d self._conn.post(target_uri, data\u003dpayload, blocking\u003dblocking,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2809b921_711225c5","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":73},"updated":"2020-12-28 18:17:05.000000000","message":"why not just `apply_time \u003d\u003d res_cons.APPLY_TIME_IMMEDIATE` (it would be shorter and don\u0027t have to look up values)?","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"14ede024ebafcb9848fd161bcd84ffa21dff0360","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."},{"line_number":121,"context_line":"                APPLY_TIME_VALUE_MAP_REV[res_cons.APPLY_TIME_IMMEDIATE]):"},{"line_number":122,"context_line":"            blocking \u003d True"},{"line_number":123,"context_line":"        target_uri \u003d self._get_initialize_action_element().target_uri"},{"line_number":124,"context_line":"        r \u003d self._conn.post(target_uri, data\u003dpayload, blocking\u003dblocking,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfceb708_e7c169cc","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":73},"in_reply_to":"2809b921_711225c5","updated":"2020-12-28 22:29:58.000000000","message":"It is a a bit long with the reverse map usage. But doing it like this ensures that the logic works if the OperationApplyTime annotation is passed in via the apply_time param or the directly in the payload.","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"6f97986123d6fca489c2ba0502d9aa51c91e8b0a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        oat_prop \u003d \u0027@Redfish.OperationApplyTime\u0027"},{"line_number":118,"context_line":"        if apply_time:"},{"line_number":119,"context_line":"            payload[oat_prop] \u003d res_maps.APPLY_TIME_VALUE_MAP_REV[apply_time]"},{"line_number":120,"context_line":"        if (payload and payload.get(oat_prop) \u003d\u003d res_maps."},{"line_number":121,"context_line":"                APPLY_TIME_VALUE_MAP_REV[res_cons.APPLY_TIME_IMMEDIATE]):"},{"line_number":122,"context_line":"            blocking \u003d True"},{"line_number":123,"context_line":"        target_uri \u003d self._get_initialize_action_element().target_uri"},{"line_number":124,"context_line":"        r \u003d self._conn.post(target_uri, data\u003dpayload, blocking\u003dblocking,"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb1f3ac7_fa659ba0","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":73},"in_reply_to":"bfceb708_e7c169cc","updated":"2021-01-04 08:17:28.000000000","message":"Ack","commit_id":"e0286fe9a09798cbdb46b377c85ac07497ba5ec6"}]}