)]}'
{"sushy/connector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a8a5404258e802aa5d5e5271532dd6e31a4c0594","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                raise exceptions.ConnectionError(url\u003durl, error\u003dm)"},{"line_number":167,"context_line":"            timeout_at \u003d time.time() + timeout"},{"line_number":168,"context_line":"            mon \u003d TaskMonitor.get_task_monitor(self, response, path)"},{"line_number":169,"context_line":"            while mon.check_is_processing:"},{"line_number":170,"context_line":"                LOG.debug(\u0027Blocking for in-progress %(method)s call to \u0027"},{"line_number":171,"context_line":"                          \u0027%(url)s; sleeping for %(sleep)s seconds\u0027,"},{"line_number":172,"context_line":"                          {\u0027method\u0027: method, \u0027url\u0027: url,"}],"source_content_type":"text/x-python","patch_set":4,"id":"60530f0b_1e1ef87c","line":169,"updated":"2021-02-24 10:15:24.000000000","message":"nit: this while loop should become something like mon.wait(timeout)","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5b90331f5bce1315aec26ba03537af5c18c45c61","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                raise exceptions.ConnectionError(url\u003durl, error\u003dm)"},{"line_number":167,"context_line":"            timeout_at \u003d time.time() + timeout"},{"line_number":168,"context_line":"            mon \u003d TaskMonitor.get_task_monitor(self, response, path)"},{"line_number":169,"context_line":"            while mon.check_is_processing:"},{"line_number":170,"context_line":"                LOG.debug(\u0027Blocking for in-progress %(method)s call to \u0027"},{"line_number":171,"context_line":"                          \u0027%(url)s; sleeping for %(sleep)s seconds\u0027,"},{"line_number":172,"context_line":"                          {\u0027method\u0027: method, \u0027url\u0027: url,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a5c3e84_36d5b553","line":169,"in_reply_to":"60530f0b_1e1ef87c","updated":"2021-02-26 09:55:13.000000000","message":"done at https://review.opendev.org/c/openstack/sushy/+/777733","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"}],"sushy/taskmonitor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a8a5404258e802aa5d5e5271532dd6e31a4c0594","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def task_monitor(self):"},{"line_number":108,"context_line":"        \"\"\"The TaskMonitor URI"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        Deprecated: Use task_monitor_uri"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        :returns: The TaskMonitor URI."},{"line_number":113,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"933056aa_32bff3e5","line":110,"updated":"2021-02-24 10:15:24.000000000","message":"nit: deprecated function should be moved to the deprecated class","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5b90331f5bce1315aec26ba03537af5c18c45c61","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def task_monitor(self):"},{"line_number":108,"context_line":"        \"\"\"The TaskMonitor URI"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        Deprecated: Use task_monitor_uri"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        :returns: The TaskMonitor URI."},{"line_number":113,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"971dac8c_a8616fe1","line":110,"in_reply_to":"933056aa_32bff3e5","updated":"2021-02-26 09:55:13.000000000","message":"currently the deprecated class redirects here, so this is both the deprecated and new, but in different location. Did this way to avoid duplicating code and keep things simple.","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a8a5404258e802aa5d5e5271532dd6e31a4c0594","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def retry_after(self):"},{"line_number":149,"context_line":"        \"\"\"The amount of time to sleep before retrying"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        Deprecated: use sleep_for. This is not working with Retry-After header"},{"line_number":152,"context_line":"            in date format."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        :returns: The amount of time in seconds to wait before calling"}],"source_content_type":"text/x-python","patch_set":4,"id":"cfa747d3_f1ed1df2","line":151,"updated":"2021-02-24 10:15:24.000000000","message":"ditto","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5b90331f5bce1315aec26ba03537af5c18c45c61","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def retry_after(self):"},{"line_number":149,"context_line":"        \"\"\"The amount of time to sleep before retrying"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        Deprecated: use sleep_for. This is not working with Retry-After header"},{"line_number":152,"context_line":"            in date format."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        :returns: The amount of time in seconds to wait before calling"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a52219d_b6c107ef","line":151,"in_reply_to":"cfa747d3_f1ed1df2","updated":"2021-02-26 09:55:13.000000000","message":"ditto","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a8a5404258e802aa5d5e5271532dd6e31a4c0594","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                         registries\u003dself._registries)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @staticmethod"},{"line_number":220,"context_line":"    def get_task_monitor(conn, response, target_uri, redfish_version\u003dNone,"},{"line_number":221,"context_line":"                         registries\u003dNone):"},{"line_number":222,"context_line":"        \"\"\"Construct TaskMonitor instance from received response."},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c6ff564e_347e8bbb","line":220,"updated":"2021-02-24 10:15:24.000000000","message":"nit: I\u0027d call it from_response (esp. since TaskMonitor.get_task_monitor is tautology)","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5b90331f5bce1315aec26ba03537af5c18c45c61","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                         registries\u003dself._registries)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @staticmethod"},{"line_number":220,"context_line":"    def get_task_monitor(conn, response, target_uri, redfish_version\u003dNone,"},{"line_number":221,"context_line":"                         registries\u003dNone):"},{"line_number":222,"context_line":"        \"\"\"Construct TaskMonitor instance from received response."},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e4ee00c5_25eb85fe","line":220,"in_reply_to":"c6ff564e_347e8bbb","updated":"2021-02-26 09:55:13.000000000","message":"done at https://review.opendev.org/c/openstack/sushy/+/777733","commit_id":"7a9a2b6020d9b16a671339e6cefaebd0baff99ec"}]}