)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"410015da4a66d107c4cec9cb5293c027a1cfc111","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of Inserted and WriteProtected attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redefish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b5dae9e7_cc79b1b3","line":9,"updated":"2021-07-28 14:17:55.000000000","message":"I\u0027m entirely missing \"why\" other than this seems simpler and cleaner at the cost of being maybe breaking in some cases based on the release note. Can we get some more clarity? What is actually driving this?","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5314754a4de8c1e028daa3ee7f5be8a13c3c8a0d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of Inserted and WriteProtected attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redefish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5cb4ac59_f357d733","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":65},"updated":"2021-07-28 17:00:16.000000000","message":"nit: These are actually optional parameters to the Redfish VirtualMedia InsertMedia action [1]. If I correctly understand, when the action is executed, their values affect the values of the VirtualMedia resource properties with the same names.\n\n[1] https://redfish.dmtf.org/schemas/v1/VirtualMedia.v1_2_2.json","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of Inserted and WriteProtected attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redefish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8f0c9f8d_bcd4d408","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":65},"in_reply_to":"5cb4ac59_f357d733","updated":"2021-07-29 01:08:35.000000000","message":"You\u0027re right Richard. I changed syntax of these parameters to match what we have in insert_media() function in sushy as this is what the change is about.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of Inserted and WriteProtected attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redefish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"04693528_f98c6e13","line":9,"in_reply_to":"b5dae9e7_cc79b1b3","updated":"2021-07-29 01:08:35.000000000","message":"I\u0027m adding the upstream story/task which should shed more light on the why. In terms of this specific change - in my view, it is really a follow-up to just make things simpler\u0026cleaner, the end result does not change. I don\u0027t particularly like how the original (backportable) change works (taking these attributes but not putting them in the Redfish request payload) but this is what needed to be done for backports. In my view, this one does things in a cleaner, easier to read/follow way without being constrained by backport requirements.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"410015da4a66d107c4cec9cb5293c027a1cfc111","unresolved":true,"context_lines":[{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"},{"line_number":13,"context_line":"removing them from payload."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e79e4562_cf5c4df3","line":15,"updated":"2021-07-28 14:17:55.000000000","message":"Upstream uses storyboard Story/Task format, we attempt to avoid using rhbz as the primary reference because comments can be private and hidden from contributors and partners, and comments can have vital context required to really understand \"why\"","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"},{"line_number":13,"context_line":"removing them from payload."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ieab097c63f218c3c262f013c29495f5393dd3cfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"eb0e72a8_18552bda","line":15,"in_reply_to":"e79e4562_cf5c4df3","updated":"2021-07-29 01:08:35.000000000","message":"Added story/task references.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7b97e01af8f9707e266d44fce69a77d2b21371d1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of \u0027inserted\u0027 and \u0027write_protected\u0027 attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redfish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"},{"line_number":13,"context_line":"removing them from payload."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: 2009086"},{"line_number":16,"context_line":"Task: 42907"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"18e2e42b_4d11f92a","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":27},"updated":"2021-08-20 12:53:13.000000000","message":"would wrap this at 72 chars","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3768f624a11d7ac19532ff1c63963657c70a6045","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change defaults - optional insert_media attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating default values of \u0027inserted\u0027 and \u0027write_protected\u0027 attributes in"},{"line_number":10,"context_line":"VirtualMedia::insert_media() to None. This is a more simple and clear way of"},{"line_number":11,"context_line":"removing these fields from the Redfish API request payload than the previous"},{"line_number":12,"context_line":"approach of checking these attributes are set to defaults and if this the case"},{"line_number":13,"context_line":"removing them from payload."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: 2009086"},{"line_number":16,"context_line":"Task: 42907"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"f6192ea2_a70a7cc5","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":27},"in_reply_to":"18e2e42b_4d11f92a","updated":"2021-08-23 01:43:14.000000000","message":"Done. Apologies for going over earlier!","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"}],"releasenotes/notes/change-vmedia-insert-default-parameters-48308dbfa4bdb5a8.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"410015da4a66d107c4cec9cb5293c027a1cfc111","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":12,"context_line":"    in VirtualMedia::insert_media() from True to None. This should have no"},{"line_number":13,"context_line":"    impact on most platforms, caution is advised in deployments that depend on"},{"line_number":14,"context_line":"    setting these values to True."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"824880b4_1f49c1ca","line":13,"range":{"start_line":12,"start_character":55,"end_line":13,"end_character":29},"updated":"2021-07-28 14:17:55.000000000","message":"Please indicate what this been tested against. I\u0027d rather us not upset our partners.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":12,"context_line":"    in VirtualMedia::insert_media() from True to None. This should have no"},{"line_number":13,"context_line":"    impact on most platforms, caution is advised in deployments that depend on"},{"line_number":14,"context_line":"    setting these values to True."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c154db48_5385c644","line":13,"range":{"start_line":12,"start_character":55,"end_line":13,"end_character":29},"in_reply_to":"824880b4_1f49c1ca","updated":"2021-07-29 01:08:35.000000000","message":"Done","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f02b9694f2c26ce147c880b7a6ba07a710ef1a31","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":5,"context_line":"    in VirtualMedia::insert_media() from True and False to None. This makes"},{"line_number":6,"context_line":"    handling of these fields more clear than the previous implementation which"},{"line_number":7,"context_line":"    checks if they are set to Redfish default values and removes them from the"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"23df325e_823e6b52","line":4,"updated":"2021-08-23 09:31:01.000000000","message":"nit: Changes","commit_id":"84353d34ab9e230d45d1b5bb53563fb097a93756"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f02b9694f2c26ce147c880b7a6ba07a710ef1a31","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    payload if this is the case."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":12,"context_line":"    in VirtualMedia::insert_media() from True to None. This requires Ironic"},{"line_number":13,"context_line":"    version which no longer specifies \"Inserted\" and \"WriteProtected\""},{"line_number":14,"context_line":"    parameters."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3b72324c_348cfede","line":11,"updated":"2021-08-23 09:31:01.000000000","message":"same","commit_id":"84353d34ab9e230d45d1b5bb53563fb097a93756"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f02b9694f2c26ce147c880b7a6ba07a710ef1a31","unresolved":false,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":12,"context_line":"    in VirtualMedia::insert_media() from True to None. This requires Ironic"},{"line_number":13,"context_line":"    version which no longer specifies \"Inserted\" and \"WriteProtected\""},{"line_number":14,"context_line":"    parameters."},{"line_number":15,"context_line":"    This change should have no impact on most platforms (Redfish InsertMedia"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"b7f51dd4_d4bf3893","line":12,"updated":"2021-08-23 09:31:01.000000000","message":"I don\u0027t think it actually requires (if yes, it\u0027s pretty bad). It\u0027s the other way around: Ironic will require this version before it can remove the default values.","commit_id":"84353d34ab9e230d45d1b5bb53563fb097a93756"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dabfe64b61f32e87d7623eee928a8b228754855d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"},{"line_number":12,"context_line":"    in VirtualMedia::insert_media() from True to None. This requires Ironic"},{"line_number":13,"context_line":"    version which no longer specifies \"Inserted\" and \"WriteProtected\""},{"line_number":14,"context_line":"    parameters."},{"line_number":15,"context_line":"    This change should have no impact on most platforms (Redfish InsertMedia"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"77914079_b43091a4","line":12,"in_reply_to":"b7f51dd4_d4bf3893","updated":"2021-08-23 10:04:41.000000000","message":"I think if we had the current Ironic behaviour and this sushy patch in at the same time, this would un-do the SuperMicro fix.","commit_id":"84353d34ab9e230d45d1b5bb53563fb097a93756"}],"releasenotes/notes/fix-insert-media-payload-48308dbfa4bdb5a8.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"71ca62cb72e6cf3f657eb90d09f565b0184dbc4f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adding support for vMedia on SuperMicro X11 and X12 platforms."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b77e61e9_49b78f1b","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"updated":"2021-07-28 07:34:07.000000000","message":"s/ Inserted/ ``Inserted`` /","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"71ca62cb72e6cf3f657eb90d09f565b0184dbc4f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adding support for vMedia on SuperMicro X11 and X12 platforms."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f2e5f604_9d002082","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":62},"updated":"2021-07-28 07:34:07.000000000","message":"s/ WriteProtected / \u0027\u0027WriteProtected\u0027\u0027 /","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adding support for vMedia on SuperMicro X11 and X12 platforms."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"78bfc24b_eebbdde6","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"in_reply_to":"b77e61e9_49b78f1b","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adding support for vMedia on SuperMicro X11 and X12 platforms."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e70de4e6_7a6fd006","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":62},"in_reply_to":"f2e5f604_9d002082","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"71ca62cb72e6cf3f657eb90d09f565b0184dbc4f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"31aafdda_9a396da6","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":16},"updated":"2021-07-28 07:34:07.000000000","message":"s/ insert_media / VirtualMedia::insert_media()","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"71ca62cb72e6cf3f657eb90d09f565b0184dbc4f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a7f559c8_e29d6264","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":74},"updated":"2021-07-28 07:34:07.000000000","message":"s/ vMedia / virtual media /","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2c28a8fa_7c79ad5c","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":16},"in_reply_to":"31aafdda_9a396da6","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of Inserted and WriteProtected parameters in"},{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"24e77374_c94cbc57","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":74},"in_reply_to":"a7f559c8_e29d6264","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4c8fd76bf7bf346c699f022f91bd556890a43e4d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"},{"line_number":12,"context_line":"    on the BMC side, so this change is not expected to not alter the current"},{"line_number":13,"context_line":"    behaviour on already-supported platforms."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f539462a_5daf36b8","line":11,"range":{"start_line":11,"start_character":75,"end_line":11,"end_character":77},"updated":"2021-07-28 07:38:52.000000000","message":"nit: remove duplicate \u0027on\u0027","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    insert_media to None, so that these aren\u0027t added to the RedFish vMedia"},{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"},{"line_number":12,"context_line":"    on the BMC side, so this change is not expected to not alter the current"},{"line_number":13,"context_line":"    behaviour on already-supported platforms."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"64f54665_4d838235","line":11,"range":{"start_line":11,"start_character":75,"end_line":11,"end_character":77},"in_reply_to":"f539462a_5daf36b8","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4c8fd76bf7bf346c699f022f91bd556890a43e4d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"},{"line_number":12,"context_line":"    on the BMC side, so this change is not expected to not alter the current"},{"line_number":13,"context_line":"    behaviour on already-supported platforms."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"969b80f3_d4f23086","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":65},"updated":"2021-07-28 07:38:52.000000000","message":"I would avoid the double negative","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    insert request unless specifically requested. Some BMCs (e.g. SuperMicro"},{"line_number":10,"context_line":"    X11/X12 platforms) treat these fields as read-only and setting them"},{"line_number":11,"context_line":"    causes vMedia insert failures. These attributes should default to True on"},{"line_number":12,"context_line":"    on the BMC side, so this change is not expected to not alter the current"},{"line_number":13,"context_line":"    behaviour on already-supported platforms."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"814a175f_a31bc991","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":65},"in_reply_to":"969b80f3_d4f23086","updated":"2021-07-28 10:16:17.000000000","message":"Done","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59deafe82cb495028fb75dcf89b7fb3c92d020b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding support for vMedia on SuperMicro X11 and X12 platforms."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"27b81058_238ce6e5","line":4,"updated":"2021-07-28 10:37:17.000000000","message":"We don\u0027t consider fixing broken platforms a feature","commit_id":"a73e029b644e2d9161a1ec48f8f79bfd5365354f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"59deafe82cb495028fb75dcf89b7fb3c92d020b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    BMCs (e.g. SuperMicro X11/X12 platforms) treat these fields as read-only"},{"line_number":11,"context_line":"    and setting them causes vMedia insert failures. These attributes should"},{"line_number":12,"context_line":"    default to True on the BMC side, so this change is not expected to alter"},{"line_number":13,"context_line":"    the current behaviour on already-supported platforms."},{"line_number":14,"context_line":"upgrade:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Changing the default values of \"Inserted\" and \"WriteProtected\" parameters"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"00c32363_225e7660","line":13,"updated":"2021-07-28 10:37:17.000000000","message":"This will need to be reworked once you create the temporary fix we plan on backporting.","commit_id":"a73e029b644e2d9161a1ec48f8f79bfd5365354f"}],"sushy/resources/manager/virtual_media.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6f8c1dcb2201acc99aa0fc3a48935650710f1498","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dTrue, write_protected\u003dFalse):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d9e552c_8d846f71","line":96,"updated":"2021-07-27 11:41:19.000000000","message":"You\u0027re ignoring these arguments now. I suggest you change the defaults to None in both cases and only send them if the values are not None.","commit_id":"9e080105475f5bbd52dc8d05b7d521073ce23c53"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"80cc99ca27d89c74afb8dac4ed9dc9888c9d38e2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dTrue, write_protected\u003dFalse):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":2,"id":"f2336575_8b891d35","line":96,"in_reply_to":"87ed62f4_9c4299dd","updated":"2021-07-28 00:29:59.000000000","message":"Done.","commit_id":"9e080105475f5bbd52dc8d05b7d521073ce23c53"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"acd25d67896eab780ddfa5f1bd8cacde0f500b16","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dTrue, write_protected\u003dFalse):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":2,"id":"87ed62f4_9c4299dd","line":96,"in_reply_to":"9d9e552c_8d846f71","updated":"2021-07-27 12:09:54.000000000","message":"Thank you for your review Dmitry. This is a great suggestion - initially I was thinking removing inserted and write_protected from parameters list completely (just haven\u0027t done it yet not to cause breakage prior to initial testing) but this is better. I will add this in tomorrow.","commit_id":"9e080105475f5bbd52dc8d05b7d521073ce23c53"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"71ca62cb72e6cf3f657eb90d09f565b0184dbc4f","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":6,"id":"8c56d5d7_67fe8baf","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":69},"updated":"2021-07-28 07:34:07.000000000","message":"Changing the default value may cause breakage to other libraries that are relying on these values to be passed as \u0027True\u0027. May be it would be better to document it in releasenotes as upgrade notes.","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4c8fd76bf7bf346c699f022f91bd556890a43e4d","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a751cc0_7b1c685e","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":69},"in_reply_to":"8c56d5d7_67fe8baf","updated":"2021-07-28 07:38:52.000000000","message":"I agree, this is a potential breaking change","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d1863dc223d224eba007bfc709ef4e99f91367d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ca02993_c0ea84af","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":69},"in_reply_to":"9a751cc0_7b1c685e","updated":"2021-07-28 10:16:17.000000000","message":"After the discussion on IRC I added additional \"upgrade\" section detailing changes in default behaviour.","commit_id":"2601b60d13b5759eef69f7d7a98785a4a0f7cbb8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"410015da4a66d107c4cec9cb5293c027a1cfc111","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":8,"id":"5b50c5ea_8c8f9d57","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":71},"updated":"2021-07-28 14:17:55.000000000","message":"For the record, I don\u0027t believe this can be backported as we\u0027re changing overall default behavior. The consumers of the library would need to be aware and adjust, that is unless they already operate/interact properly.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6de5de803b3135a5154c3680f536b53c31b3034a","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":8,"id":"f4a05438_1d53b0d3","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":71},"in_reply_to":"5b50c5ea_8c8f9d57","updated":"2021-07-28 15:35:52.000000000","message":"We probably could, given how minor it is (and how unlikely it is that we have any consumers other than ironic). But the backportable version of this change is actually https://review.opendev.org/c/openstack/sushy/+/802690, this one is a clean up for master only.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":8,"id":"251959db_d58d3912","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":71},"in_reply_to":"8334ee23_4e6be6cd","updated":"2021-07-29 01:08:35.000000000","message":"Julia, Dmitry - thank you for your comments.\n\nRichard - thank you for your insights, here are some thoughts:\n\nre 1\u00262 - all makes sense to me\nre 3: I do not understand the purpose of Inserted either. Based on partial information I have it does feel like a leftover from previous implementations that didn\u0027t have InsertMedia call (and relied on PATCHing vMedia attributes instead, including setting Inserted?). I haven\u0027t seen a machine doing this though.\n\nre 4: I don\u0027t understand why\u0027s that either. I had a brief chat to Dmitry and it seems like it may have been a mistake, but not sure. If other reviewers know please share!\n\nre 5: correct\n\nI think the code you proposed may be a superior way of achieving what I did in  https://review.opendev.org/c/openstack/sushy/+/802690/4/sushy/resources/manager/virtual_media.py#105 - IIUC it should produce identical results but it is more readable and elegant than my \"backportable\" patch.\n\nHowever going forward I do see value in going the path proposed in this change. Reason being if we abandon the Ironic change and implement your suggestion, we\u0027ll have Ironic passing unnecessary/RF-default values (True, True) to insert_media(image, inserted\u003dTrue, write_protected\u003dFalse) (which seems to have the wrong default for write_protected) which then drops inserted and write_protected which were never needed in the first place and only passes the image to the BMC. It will work but seems convoluted and hard to follow. I guess legacy brought us to this but from my perspective it is tempting to clear this out if possible at reasonable level of effort/risk. So - my proposal:\n\n* replace the code in the \"backportable\" change (link above) with your proposal, go ahead with this and backport as required\n* still go ahead with this change and Ironic change but make them master only.\n\nWhat do you think?","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5314754a4de8c1e028daa3ee7f5be8a13c3c8a0d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            eject_uri \u003d eject_media.target_uri"},{"line_number":94,"context_line":"        return eject_uri, use_patch"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"}],"source_content_type":"text/x-python","patch_set":8,"id":"8334ee23_4e6be6cd","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":71},"in_reply_to":"f4a05438_1d53b0d3","updated":"2021-07-28 17:00:16.000000000","message":"I am wondering if the existing default values of the optional arguments inserted and write_protected need to be changed at all. First, several observations:\n\n1. Both are used to convey optional parameters to the Redfish InsertMedia action, Inserted and WriteProtected.\n2. When a client does not provide those optional parameters, the BMC Redfish \"service shall default this value to be true.\" [1] That has been the case since the VirtualMedia schema introduced the InsertMedia action [2].\n3. They seem to be orthogonal. (I also do not understand the purpose of Inserted.)\n4. I do not understand why the default value of write_protected is False. Does anyone have any insights on that?\n5. Ironic has been calling this method with both explicitly set to True.\n\nIf the existing default values were left as-is, the logic below could be changed to add the optional parameters only if they evaluate to False.\n\n    payload \u003d {\n        \u0027Image\u0027: image\n    }\n    if not inserted:\n        payload[\u0027Inserted\u0027] \u003d False\n    if not write_protected:\n        payload[\u0027WriteProtected\u0027] \u003d False\n\nIt seems to me this approach would eliminate the need for a backportable version and the  related ironic change [3].\n\nCaveat: AfAIK, this has not been tested against the iDRAC, yet.\n\n[1] https://redfish.dmtf.org/schemas/v1/VirtualMedia.v1_4_0.json\n[2] https://redfish.dmtf.org/schemas/v1/VirtualMedia.v1_2_0.json\n[3] https://review.opendev.org/c/openstack/ironic/+/802643","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"798fc7900e8710b5014a3367d9a6b5490011d765","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        payload \u003d {"},{"line_number":106,"context_line":"            \u0027Image\u0027: image"},{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":"        if inserted is not None:"},{"line_number":109,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"},{"line_number":110,"context_line":"        if write_protected is not None:"},{"line_number":111,"context_line":"            payload[\u0027WriteProtected\u0027] \u003d write_protected"},{"line_number":112,"context_line":"        if use_patch:"},{"line_number":113,"context_line":"            headers \u003d None"},{"line_number":114,"context_line":"            etag \u003d self._get_etag()"},{"line_number":115,"context_line":"            if etag is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2170ebd6_6a63f346","line":112,"range":{"start_line":108,"start_character":0,"end_line":112,"end_character":0},"updated":"2021-07-28 18:44:15.000000000","message":"Would not this encounter the issue being addressed when the caller passes True for either of the optional arguments?\n\n    insert_media, image, inserted\u003dTrue, write_protected\u003dTrue)","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d41fc4000a500bf6dc346dad53e2964b4fb932fe","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        payload \u003d {"},{"line_number":106,"context_line":"            \u0027Image\u0027: image"},{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":"        if inserted is not None:"},{"line_number":109,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"},{"line_number":110,"context_line":"        if write_protected is not None:"},{"line_number":111,"context_line":"            payload[\u0027WriteProtected\u0027] \u003d write_protected"},{"line_number":112,"context_line":"        if use_patch:"},{"line_number":113,"context_line":"            headers \u003d None"},{"line_number":114,"context_line":"            etag \u003d self._get_etag()"},{"line_number":115,"context_line":"            if etag is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8506d306_ad9cb0a1","line":112,"range":{"start_line":108,"start_character":0,"end_line":112,"end_character":0},"in_reply_to":"2170ebd6_6a63f346","updated":"2021-07-29 01:08:35.000000000","message":"You are right Richard, this would still cause failures on SuperMicro X11/X12. However if this change and Ironic change merge, Ironic will never send these and hence insert_media will default to None for Inserted and WriteProtected and will not include them in the payload, leaving it to the BMC to set the Redfish-specified defaults. Does this make sense?","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"e48ee005aa4467ed431e62589d88c812480cbfaf","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        payload \u003d {"},{"line_number":106,"context_line":"            \u0027Image\u0027: image"},{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":"        if inserted is not None:"},{"line_number":109,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"},{"line_number":110,"context_line":"        if write_protected is not None:"},{"line_number":111,"context_line":"            payload[\u0027WriteProtected\u0027] \u003d write_protected"},{"line_number":112,"context_line":"        if use_patch:"},{"line_number":113,"context_line":"            headers \u003d None"},{"line_number":114,"context_line":"            etag \u003d self._get_etag()"},{"line_number":115,"context_line":"            if etag is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0cc756cd_0fcb49d0","line":112,"range":{"start_line":108,"start_character":0,"end_line":112,"end_character":0},"in_reply_to":"8506d306_ad9cb0a1","updated":"2021-07-29 22:04:42.000000000","message":"I understand the related ironic change and its interaction with this one. My concern is that the default values of inserted and write_protected and processing of them proposed here would continue to make it easy for consumers of sushy to unknowingly set themselves up to trip over the failure; just pass True. I suggest we make it more challenging.\n\nAFAIU, among sushy\u0027s goals is to encapsulate accommodations for BMC Redfish service implementations which make them sing. That said, it would be nice to offer the flexibility to send true for those optional Redfish payload parameters should they be needed for development work or other reasons. How about this?\n\n    def insert_media(self, image, inserted\u003dNone, write_protected\u003dNone, send_true\u003dFalse)\n\nAlso, I suggest the docstring mention the interoperability risk of passing True for those parameters.","commit_id":"8a46c321b2de0175b21cd38ee82a4af0d4e3b39d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7b97e01af8f9707e266d44fce69a77d2b21371d1","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"},{"line_number":100,"context_line":"        :param inserted: specify if the image is to be treated as inserted upon"},{"line_number":101,"context_line":"            completion of the action."},{"line_number":102,"context_line":"        :param write_protected: indicates the media is write protected"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        # NOTE(janders) Inserted and WriteProtected attributes are optional"}],"source_content_type":"text/x-python","patch_set":14,"id":"f3173a6c_7c723e75","line":102,"range":{"start_line":100,"start_character":7,"end_line":102,"end_character":70},"updated":"2021-08-20 12:53:13.000000000","message":"could add here to say that default is True for systems that support PATCH, if end-users will be able to make decision what they need..","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3768f624a11d7ac19532ff1c63963657c70a6045","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \"\"\"Attach remote media to virtual media"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param image: a URI providing the location of the selected image"},{"line_number":100,"context_line":"        :param inserted: specify if the image is to be treated as inserted upon"},{"line_number":101,"context_line":"            completion of the action."},{"line_number":102,"context_line":"        :param write_protected: indicates the media is write protected"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        # NOTE(janders) Inserted and WriteProtected attributes are optional"}],"source_content_type":"text/x-python","patch_set":14,"id":"4aa661a8_6e545253","line":102,"range":{"start_line":100,"start_character":7,"end_line":102,"end_character":70},"in_reply_to":"f3173a6c_7c723e75","updated":"2021-08-23 01:43:14.000000000","message":"Done. Do you think the way I phrased it is clear enough? Thank you.","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"}],"sushy/tests/unit/resources/manager/test_virtual_media.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7b97e01af8f9707e266d44fce69a77d2b21371d1","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            data\u003d{\"Image\": \"https://www.dmtf.org/freeImages/Sardine.img\"}"},{"line_number":104,"context_line":"        )"},{"line_number":105,"context_line":"        self.assertTrue(self.sys_virtual_media._is_stale)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_insert_media_fallback(self):"},{"line_number":108,"context_line":"        self.conn.get.return_value.headers \u003d {\u0027Allow\u0027: \u0027GET,HEAD,PATCH\u0027}"},{"line_number":109,"context_line":"        self.sys_virtual_media._actions.insert_media \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"9fc09908_711b437e","line":106,"updated":"2021-08-20 12:53:13.000000000","message":"need a test case for non-None values and use_patch\u003dTrue","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3768f624a11d7ac19532ff1c63963657c70a6045","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            data\u003d{\"Image\": \"https://www.dmtf.org/freeImages/Sardine.img\"}"},{"line_number":104,"context_line":"        )"},{"line_number":105,"context_line":"        self.assertTrue(self.sys_virtual_media._is_stale)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_insert_media_fallback(self):"},{"line_number":108,"context_line":"        self.conn.get.return_value.headers \u003d {\u0027Allow\u0027: \u0027GET,HEAD,PATCH\u0027}"},{"line_number":109,"context_line":"        self.sys_virtual_media._actions.insert_media \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"0e39e0c1_db9a7f80","line":106,"in_reply_to":"9fc09908_711b437e","updated":"2021-08-23 01:43:14.000000000","message":"Added test_insert_media_not_none_patch. Do you think it\u0027s sufficient?","commit_id":"f15826107e0862e8fd380044e585e6dae3e90b47"}]}