)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing \"Inserted\" and \"WriteProtected\" from the"},{"line_number":10,"context_line":"VirtualMedia::insert_media() API call payload when set to default values"},{"line_number":11,"context_line":"as per Redfish specification (\"Inserted\": true, \"WriteProtected\": True)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"Inserted\" and \"WriteProtected\" attributes to VirtualMedia::insert_media()"},{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"77f732af_7e91b25c","line":11,"updated":"2021-07-28 14:05:45.000000000","message":"Is there a link or reference. Where in the specification?\n\nThis sounds like we\u0027re making a major behavior change, What hardware has this change been tested against?","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b0f0712e63086b10d656cf5ee9ab0d202834d43","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing \"Inserted\" and \"WriteProtected\" from the"},{"line_number":10,"context_line":"VirtualMedia::insert_media() API call payload when set to default values"},{"line_number":11,"context_line":"as per Redfish specification (\"Inserted\": true, \"WriteProtected\": True)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"Inserted\" and \"WriteProtected\" attributes to VirtualMedia::insert_media()"},{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"eef2b786_b15d772e","line":11,"in_reply_to":"77f732af_7e91b25c","updated":"2021-07-28 15:37:49.000000000","message":"Yeah, should be clarified. Inserted:true and WriteProtected:true are the defaults per https://redfish.dmtf.org/schemas/v1/VirtualMedia.v1_3_0.json. So there is no point in sending them (unless we\u0027re dealing with an incompatible BMC).","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing \"Inserted\" and \"WriteProtected\" from the"},{"line_number":10,"context_line":"VirtualMedia::insert_media() API call payload when set to default values"},{"line_number":11,"context_line":"as per Redfish specification (\"Inserted\": true, \"WriteProtected\": True)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"Inserted\" and \"WriteProtected\" attributes to VirtualMedia::insert_media()"},{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b80d8393_53fac96d","line":11,"in_reply_to":"eef2b786_b15d772e","updated":"2021-07-29 00:05:33.000000000","message":"I added the link (thank you Dmitry).\n\nOn API level I tested it across Dell, HP and a few SuperMicros (essentially, all the testing done here https://docs.google.com/document/d/1LzuzhPFjiEYEpvrOCJL4HmmQ-j23I0iBp1a3UwyrMWY/edit#heading\u003dh.u78ejt4aalij has used the API call format without Inserted/WriteProtected) and I haven\u0027t observed a single issue with this.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."},{"line_number":15,"context_line":"Specifying them in every insert_media call can cause issues on those BMCs that"},{"line_number":16,"context_line":"treat them as read-only and not specifying these attributes at all should"},{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f0e73634_27e21268","line":17,"updated":"2021-07-28 14:05:45.000000000","message":"I guess I\u0027m reading this and kind of confused, is this a bug, or is this a feature? Ultimately, I\u0027m still trying to understand what is attempting to be achieved from a bigger point of view because I don\u0027t have the same context, nor would external reviewers have that context.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."},{"line_number":15,"context_line":"Specifying them in every insert_media call can cause issues on those BMCs that"},{"line_number":16,"context_line":"treat them as read-only and not specifying these attributes at all should"},{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2fb36820_2baaea0f","line":17,"in_reply_to":"a051317b_303db3b9","updated":"2021-07-29 00:05:33.000000000","message":"I created story/tasks as discussed on IRC. Adding relevant references now. I also added a little more clarification on what hardware isn\u0027t currently supported and can be supported with this fix.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b0f0712e63086b10d656cf5ee9ab0d202834d43","unresolved":true,"context_lines":[{"line_number":14,"context_line":"are optional and should have reasonable default values on the BMC side."},{"line_number":15,"context_line":"Specifying them in every insert_media call can cause issues on those BMCs that"},{"line_number":16,"context_line":"treat them as read-only and not specifying these attributes at all should"},{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a051317b_303db3b9","line":17,"in_reply_to":"f0e73634_27e21268","updated":"2021-07-28 15:37:49.000000000","message":"Should be clarified too. TL;DR some SuperMicro hardware does not support setting Inserted and WriteProtected, so if you specify them, insertion fails.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":16,"context_line":"treat them as read-only and not specifying these attributes at all should"},{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I975b3a4aa53704906cb13c859b61a254de79933f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7df694d1_ce5d262b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":18},"updated":"2021-07-28 14:05:45.000000000","message":"If this somehow were to ever need to be backported downstream, the expected downstream format is rhbz#NNNNNNN\n\nFor what it is worth, reviewers shouldn\u0027t need to click this to understand what the overall goal is for this patch and what it leads into.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":16,"context_line":"treat them as read-only and not specifying these attributes at all should"},{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I975b3a4aa53704906cb13c859b61a254de79933f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b2380982_f10e5bf0","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":18},"in_reply_to":"7df694d1_ce5d262b","updated":"2021-07-29 00:05:33.000000000","message":"Changed BZ reference format as requested.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I975b3a4aa53704906cb13c859b61a254de79933f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bda0b33d_27ab2538","line":20,"updated":"2021-07-28 14:05:45.000000000","message":"is there an upstream storyboard reference? An associated task to track whatever the larger piece of work is?","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":17,"context_line":"not cause issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1986238"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I975b3a4aa53704906cb13c859b61a254de79933f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"082277d7_de81d9f1","line":20,"in_reply_to":"bda0b33d_27ab2538","updated":"2021-07-29 00:05:33.000000000","message":"Added these now.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"}],"releasenotes/notes/fix-insert-media-payload-b5d4c707f81d9603.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Inserted\" and \"WriteProtected\" optional attributes are no longer present"},{"line_number":5,"context_line":"    in the InsertMedia API call payload when default values {\"Inserted\": True,"},{"line_number":6,"context_line":"    \"WriteProtected\": True} are specified."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Removing \"Inserted\" and \"WriteProtected\" parameters from the Redfish"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9b52ff9e_5165eda0","line":6,"range":{"start_line":6,"start_character":28,"end_line":6,"end_character":42},"updated":"2021-07-28 14:05:45.000000000","message":"Specified by what? By the BMC? The user?\n\nKeep in mind, these are intended as notes or actions for someone upgrading this package, if there is no effect then upgrade might not be the right place for these. It almost sounds like something which would fall into the other category as it is developer centric information.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \"Inserted\" and \"WriteProtected\" optional attributes are no longer present"},{"line_number":5,"context_line":"    in the InsertMedia API call payload when default values {\"Inserted\": True,"},{"line_number":6,"context_line":"    \"WriteProtected\": True} are specified."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Removing \"Inserted\" and \"WriteProtected\" parameters from the Redfish"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9bf0699e_518793f0","line":6,"range":{"start_line":6,"start_character":28,"end_line":6,"end_character":42},"in_reply_to":"9b52ff9e_5165eda0","updated":"2021-07-29 00:05:33.000000000","message":"I clarified this point. I was specifically asked to add upgrade section in previous reviews hence a little hesitant to remove it completely. Is the current one good?","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Removing \"Inserted\" and \"WriteProtected\" parameters from the Redfish"},{"line_number":10,"context_line":"    VirtualMedia::insert_media() API call payload when default values"},{"line_number":11,"context_line":"    {\"Inserted\": True, \"WriteProtected\": True} are set. Those parameters"},{"line_number":12,"context_line":"    are optional as per Redfish schema 2021.1. Some BMCs"},{"line_number":13,"context_line":"    (e.g. SuperMicro X11/X12 platforms) treat these fields as read-only and"},{"line_number":14,"context_line":"    setting them causes vMedia insert failures. These attributes should"},{"line_number":15,"context_line":"    default to True on the BMC side, so this change is not expected to alter"},{"line_number":16,"context_line":"    current behaviour on other platforms."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"84d15a79_27878bd6","line":13,"range":{"start_line":11,"start_character":4,"end_line":13,"end_character":58},"updated":"2021-07-28 14:05:45.000000000","message":"This should be in the commit message as well.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    are optional as per Redfish schema 2021.1. Some BMCs"},{"line_number":13,"context_line":"    (e.g. SuperMicro X11/X12 platforms) treat these fields as read-only and"},{"line_number":14,"context_line":"    setting them causes vMedia insert failures. These attributes should"},{"line_number":15,"context_line":"    default to True on the BMC side, so this change is not expected to alter"},{"line_number":16,"context_line":"    current behaviour on other platforms."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0b8b6565_850f520d","line":16,"range":{"start_line":15,"start_character":37,"end_line":16,"end_character":41},"updated":"2021-07-28 14:05:45.000000000","message":"Make this a separate sentence.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    are optional as per Redfish schema 2021.1. Some BMCs"},{"line_number":13,"context_line":"    (e.g. SuperMicro X11/X12 platforms) treat these fields as read-only and"},{"line_number":14,"context_line":"    setting them causes vMedia insert failures. These attributes should"},{"line_number":15,"context_line":"    default to True on the BMC side, so this change is not expected to alter"},{"line_number":16,"context_line":"    current behaviour on other platforms."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ef0f0f5a_e6a94b36","line":16,"range":{"start_line":15,"start_character":37,"end_line":16,"end_character":41},"in_reply_to":"0b8b6565_850f520d","updated":"2021-07-29 00:05:33.000000000","message":"Done","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"}],"sushy/resources/manager/virtual_media.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"31363df1004d81425a4bbc5c0d526a1b773967fb","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        :param write_protected: indicates the media is write protected"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        if inserted and write_protected:"},{"line_number":106,"context_line":"            payload \u003d {\"Image\": image}"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            payload \u003d {\"Image\": image, \"Inserted\": inserted,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8ef87926_69f3fc02","line":105,"updated":"2021-07-28 12:30:45.000000000","message":"Can you please add unit tests? \u003d)","commit_id":"c2726efb3042c8c5f789436b1620f990b702094b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6298bb7f0cf5a4bad99fc88a6909aea668007f3a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        :param write_protected: indicates the media is write protected"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        if inserted and write_protected:"},{"line_number":106,"context_line":"            payload \u003d {\"Image\": image}"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            payload \u003d {\"Image\": image, \"Inserted\": inserted,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c583ad6_d27d8c83","line":105,"in_reply_to":"8ef87926_69f3fc02","updated":"2021-07-28 12:39:56.000000000","message":"Thank you for your review Iury. I added https://review.opendev.org/c/openstack/sushy/+/802690/3/sushy/tests/unit/resources/manager/test_virtual_media.py#96 - is this sufficient?","commit_id":"c2726efb3042c8c5f789436b1620f990b702094b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c20aab6dde392a3d3d7c982f6401487c9ab9cc95","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        if inserted and write_protected:"},{"line_number":106,"context_line":"            payload \u003d {\"Image\": image}"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            payload \u003d {\"Image\": image, \"Inserted\": inserted,"},{"line_number":109,"context_line":"                       \"WriteProtected\": write_protected}"},{"line_number":110,"context_line":"        if use_patch:"},{"line_number":111,"context_line":"            headers \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"07d1a25f_76f19cfe","line":108,"range":{"start_line":107,"start_character":13,"end_line":108,"end_character":60},"updated":"2021-07-28 14:05:45.000000000","message":"Would there ever be a case where the api consumer and bmc would only want/need to send image and inserted? Granted, Inserted itself seems redundant in this.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6572a5f6cc081f437393188eaeb2a5813f497835","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        target_uri, use_patch \u003d self._get_insert_media_uri()"},{"line_number":105,"context_line":"        if inserted and write_protected:"},{"line_number":106,"context_line":"            payload \u003d {\"Image\": image}"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            payload \u003d {\"Image\": image, \"Inserted\": inserted,"},{"line_number":109,"context_line":"                       \"WriteProtected\": write_protected}"},{"line_number":110,"context_line":"        if use_patch:"},{"line_number":111,"context_line":"            headers \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c078d8b_ffcf2509","line":108,"range":{"start_line":107,"start_character":13,"end_line":108,"end_character":60},"in_reply_to":"07d1a25f_76f19cfe","updated":"2021-07-29 00:05:33.000000000","message":"I do not believe Inserted needs to be set anymore. This is to remove problem-causing Inserted and WriteProtected attributes from payload of Redfish request to the BMC if this function is called with the parameters hardcoded in Ironic for the time being (True and True) while not changing behaviour in other cases. In the master-only (not backportable) change it will be done in a cleaner way.","commit_id":"4bf499a965e8eb0185b73faa0204ecfb3d765adb"}]}