)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"7bba3e78b7708335b89be207c945daea6f346ad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"304220db_63446c3f","updated":"2021-10-13 19:14:23.000000000","message":"I hope I got that dependency-stuff for changes right :)","commit_id":"57f3204a734df0f2457741e3393b9d901b4526f7"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"79c403deb54218d97fe5ae18ea087ed626a3270f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d93478db_05fe8ae2","updated":"2021-10-14 11:47:14.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e Build failed.\n\u003e \n\u003e - hpe-gen10-dsvm-sushy-standalone-wholedisk-uefi-redfish-virtual-media-direct-python3 https://hpproliant.github.io/hpeproliant.github.io/logs/50/813850/4/check/hpe-gen10-dsvm-sushy-standalone-wholedisk-uefi-redfish-virtual-media-direct-python3/d169edf/d169edf.html : FAILURE in 5m 56s\n\nrecheck","commit_id":"e5ce3da5daebf390f06213c3a5b0fd610a4cf66c"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"d1adaa9cff79139d69ba56ac692defca1b778202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f4131434_73a386bd","updated":"2021-10-14 16:54:42.000000000","message":"recheck","commit_id":"e5ce3da5daebf390f06213c3a5b0fd610a4cf66c"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"34aa6664c91a2cd6656514e88f3141698878cba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ba92680_fb20860a","updated":"2021-10-15 08:41:29.000000000","message":"thanks for the patch, some questions inline.","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a8894b9290ff6e94644e35b0a4088a9fc8f79fc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"89bac2c3_b0e46934","updated":"2021-11-10 19:25:32.000000000","message":"Looks good, but appears to need a rebase.","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"bb25283ec00e12c2e305c3b2751a4d7799f02703","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f7bc93c_316fb6e0","updated":"2021-10-15 14:24:46.000000000","message":"Thanks for your input. I adapted my changes.","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7d116f4fbb32594ec2374246c8bad22d11165aca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c721c8d4_c02e5c35","updated":"2021-10-18 07:45:09.000000000","message":"thank you","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"6d375fef479022f78ade752e9ea8e513a5bf1c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9592209d_61b61d8d","in_reply_to":"89bac2c3_b0e46934","updated":"2021-11-18 22:06:18.000000000","message":"Done, thanks :)","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f3a90a65f9d96c1fdf500baba9992ac03300fbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9fd6f4ac_8782bbd1","updated":"2021-11-23 15:18:21.000000000","message":"Must have been a completely clean rebase because it didn\u0027t remove my -1.  8|","commit_id":"f9c2e3b5b09bb92a40702359bfe3ebbad38f10db"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"6d375fef479022f78ade752e9ea8e513a5bf1c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ed3c751_75e0c01f","updated":"2021-11-18 22:06:18.000000000","message":"Thanks for your feedback :) I rebased.","commit_id":"f9c2e3b5b09bb92a40702359bfe3ebbad38f10db"}],"sushy/resources/system/network/adapter.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"34aa6664c91a2cd6656514e88f3141698878cba2","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    @utils.cache_it"},{"line_number":51,"context_line":"    def network_device_functions(self):"},{"line_number":52,"context_line":"        return device_function.NetworkDeviceFunctionCollection("},{"line_number":53,"context_line":"            self._conn,"},{"line_number":54,"context_line":"            path\u003dutils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":5,"id":"8b331708_f05de85a","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":32},"updated":"2021-10-15 08:41:29.000000000","message":"could add some docstring , same for `network_ports` below.","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"bb25283ec00e12c2e305c3b2751a4d7799f02703","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    @utils.cache_it"},{"line_number":51,"context_line":"    def network_device_functions(self):"},{"line_number":52,"context_line":"        return device_function.NetworkDeviceFunctionCollection("},{"line_number":53,"context_line":"            self._conn,"},{"line_number":54,"context_line":"            path\u003dutils.get_sub_resource_path_by("}],"source_content_type":"text/x-python","patch_set":5,"id":"ad202dc0_14bed1d8","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":32},"in_reply_to":"8b331708_f05de85a","updated":"2021-10-15 14:24:46.000000000","message":"Done","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"34aa6664c91a2cd6656514e88f3141698878cba2","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                \"NetworkDeviceFunctions\""},{"line_number":57,"context_line":"            ),"},{"line_number":58,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":59,"context_line":"            registries\u003dself.registries,"},{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7cb918f_a652edfb","line":59,"updated":"2021-10-15 08:41:29.000000000","message":"no `root` here?","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"bb25283ec00e12c2e305c3b2751a4d7799f02703","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                \"NetworkDeviceFunctions\""},{"line_number":57,"context_line":"            ),"},{"line_number":58,"context_line":"            redfish_version\u003dself.redfish_version,"},{"line_number":59,"context_line":"            registries\u003dself.registries,"},{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"e65367a9_cb2431fd","line":59,"in_reply_to":"c7cb918f_a652edfb","updated":"2021-10-15 14:24:46.000000000","message":"Done","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"}],"sushy/resources/system/network/device_function.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"34aa6664c91a2cd6656514e88f3141698878cba2","unresolved":true,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return [port.NetworkPort(self._conn, path,"},{"line_number":177,"context_line":"                                 redfish_version\u003dself.redfish_version,"},{"line_number":178,"context_line":"                                 registries\u003dself.registries)"},{"line_number":179,"context_line":"                for path in paths]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4451b268_d18a80d2","line":178,"updated":"2021-10-15 08:41:29.000000000","message":"no `root` in init?","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"bb25283ec00e12c2e305c3b2751a4d7799f02703","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return [port.NetworkPort(self._conn, path,"},{"line_number":177,"context_line":"                                 redfish_version\u003dself.redfish_version,"},{"line_number":178,"context_line":"                                 registries\u003dself.registries)"},{"line_number":179,"context_line":"                for path in paths]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"231b6b1a_c6c42685","line":178,"in_reply_to":"4451b268_d18a80d2","updated":"2021-10-15 14:24:46.000000000","message":"Done","commit_id":"7e88b1bc5c44bcd87e6cdb2617c3dd6bd674c288"}],"sushy/tests/unit/json_samples/network_device_function.json":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a8894b9290ff6e94644e35b0a4088a9fc8f79fc0","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  \"FibreChannel\": {"},{"line_number":34,"context_line":"    \"BootTargets\": ["},{"line_number":35,"context_line":"      {"},{"line_number":36,"context_line":"        \"LUNID\": \"1234\","},{"line_number":37,"context_line":"        \"WWPN\": \"ABCEDFG\""},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":6,"id":"2bc725bb_90ac9cdc","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":23},"updated":"2021-11-10 19:25:32.000000000","message":"fwiw, I\u0027m not sure a lun number can be this big. :)","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"},{"author":{"_account_id":32469,"name":"Manuel Schönlaub","email":"manuel.schoenlaub@gmail.com","username":"mschoenlaub"},"change_message_id":"6d375fef479022f78ade752e9ea8e513a5bf1c46","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  \"FibreChannel\": {"},{"line_number":34,"context_line":"    \"BootTargets\": ["},{"line_number":35,"context_line":"      {"},{"line_number":36,"context_line":"        \"LUNID\": \"1234\","},{"line_number":37,"context_line":"        \"WWPN\": \"ABCEDFG\""},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":"    ],"}],"source_content_type":"application/json","patch_set":6,"id":"615eecae_a54c62d6","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":23},"in_reply_to":"2bc725bb_90ac9cdc","updated":"2021-11-18 22:06:18.000000000","message":"Thanks for pointing that out.\nUnfortunately I don\u0027t have any hardware here that would be using that field. \nMy guess was based on https://datatracker.ietf.org/doc/html/rfc4455#section-3.2.9, which specifies it as a 64bit integer, indicating that it could be this big indeed. Am i missing something here? :)","commit_id":"15a46b612fd0e08f8a1a36283e5146f3e7c20270"}]}