)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61e1afe16fc1dba640adc83251b1f728b5988fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a46046d_a44974f5","updated":"2021-10-18 07:56:49.000000000","message":"thanks for the patch, some comment inline","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8dae82b796c6f4599fe5f42ad479cdcb6ba1596a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"002fb68b_43355cbf","updated":"2021-10-22 10:26:58.000000000","message":"thanks","commit_id":"caa9313b6f67f998f6c34f7be32823707ed0acda"}],"sushy/resources/manager/virtual_media.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61e1afe16fc1dba640adc83251b1f728b5988fd0","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                payload[\u0027TransferMethod\u0027] \u003d \\"},{"line_number":141,"context_line":"                    mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV[transfer_method]"},{"line_number":142,"context_line":"            except KeyError:"},{"line_number":143,"context_line":"                raise exceptions.InvalidParameterValueError("},{"line_number":144,"context_line":"                    parameter\u003d\u0027transfer_method\u0027,"},{"line_number":145,"context_line":"                    value\u003dtransfer_method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"038d01c0_d1911ebc","line":142,"range":{"start_line":142,"start_character":12,"end_line":142,"end_character":28},"updated":"2021-10-18 07:56:49.000000000","message":"unit test coverage missing for exception","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"371f2f10bbaf688403fdb13ead44fd83d580b629","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                payload[\u0027TransferMethod\u0027] \u003d \\"},{"line_number":141,"context_line":"                    mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV[transfer_method]"},{"line_number":142,"context_line":"            except KeyError:"},{"line_number":143,"context_line":"                raise exceptions.InvalidParameterValueError("},{"line_number":144,"context_line":"                    parameter\u003d\u0027transfer_method\u0027,"},{"line_number":145,"context_line":"                    value\u003dtransfer_method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d05b2c75_5f771a89","line":142,"range":{"start_line":142,"start_character":12,"end_line":142,"end_character":28},"in_reply_to":"038d01c0_d1911ebc","updated":"2021-10-22 09:01:16.000000000","message":"Done","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61e1afe16fc1dba640adc83251b1f728b5988fd0","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                payload[\u0027TransferMethod\u0027] \u003d \\"},{"line_number":141,"context_line":"                    mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV[transfer_method]"},{"line_number":142,"context_line":"            except KeyError:"},{"line_number":143,"context_line":"                raise exceptions.InvalidParameterValueError("},{"line_number":144,"context_line":"                    parameter\u003d\u0027transfer_method\u0027,"},{"line_number":145,"context_line":"                    value\u003dtransfer_method,"},{"line_number":146,"context_line":"                    valid_values\u003d\u0027, \u0027.join("},{"line_number":147,"context_line":"                        mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if use_patch:"},{"line_number":150,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1b9d095_7370b582","line":147,"range":{"start_line":142,"start_character":11,"end_line":147,"end_character":64},"updated":"2021-10-18 07:56:49.000000000","message":"usually in sushy this is checked proactively, like here [1]\n\n[1] https://opendev.org/openstack/sushy/src/commit/5b62aae3626f6f94f422621bf2a71818f52a80ef/sushy/resources/system/system.py#L245-L249","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"371f2f10bbaf688403fdb13ead44fd83d580b629","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                payload[\u0027TransferMethod\u0027] \u003d \\"},{"line_number":141,"context_line":"                    mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV[transfer_method]"},{"line_number":142,"context_line":"            except KeyError:"},{"line_number":143,"context_line":"                raise exceptions.InvalidParameterValueError("},{"line_number":144,"context_line":"                    parameter\u003d\u0027transfer_method\u0027,"},{"line_number":145,"context_line":"                    value\u003dtransfer_method,"},{"line_number":146,"context_line":"                    valid_values\u003d\u0027, \u0027.join("},{"line_number":147,"context_line":"                        mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if use_patch:"},{"line_number":150,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9bd8e10_ce2ca45a","line":147,"range":{"start_line":142,"start_character":11,"end_line":147,"end_character":64},"in_reply_to":"f1b9d095_7370b582","updated":"2021-10-22 09:01:16.000000000","message":"IIRC catching an exception is considered more Pythonic (and avoids doing the same thing twice).","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8dae82b796c6f4599fe5f42ad479cdcb6ba1596a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                payload[\u0027TransferMethod\u0027] \u003d \\"},{"line_number":141,"context_line":"                    mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV[transfer_method]"},{"line_number":142,"context_line":"            except KeyError:"},{"line_number":143,"context_line":"                raise exceptions.InvalidParameterValueError("},{"line_number":144,"context_line":"                    parameter\u003d\u0027transfer_method\u0027,"},{"line_number":145,"context_line":"                    value\u003dtransfer_method,"},{"line_number":146,"context_line":"                    valid_values\u003d\u0027, \u0027.join("},{"line_number":147,"context_line":"                        mgr_maps.TRANSFER_METHOD_VALUE_MAP_REV))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if use_patch:"},{"line_number":150,"context_line":"            payload[\u0027Inserted\u0027] \u003d inserted"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb2c0be3_c9f4897d","line":147,"range":{"start_line":142,"start_character":11,"end_line":147,"end_character":64},"in_reply_to":"f9bd8e10_ce2ca45a","updated":"2021-10-22 10:26:58.000000000","message":"sure, this was more about consistency across the project","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"61e1afe16fc1dba640adc83251b1f728b5988fd0","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def set_verify_certificate(self, verify_certificate):"},{"line_number":198,"context_line":"        \"\"\"Enable or disable certificate validation.\"\"\""},{"line_number":199,"context_line":"        if not isinstance(verify_certificate, bool):"},{"line_number":200,"context_line":"            raise exceptions.InvalidParameterValueError("},{"line_number":201,"context_line":"                parameter\u003d\u0027verify_certificate\u0027, value\u003dverify_certificate,"},{"line_number":202,"context_line":"                valid_values\u003d\u0027boolean (True, False)\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fede32c8_1eeb36a4","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":52},"updated":"2021-10-18 07:56:49.000000000","message":"unit test coverage missing for unhappy path","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"371f2f10bbaf688403fdb13ead44fd83d580b629","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def set_verify_certificate(self, verify_certificate):"},{"line_number":198,"context_line":"        \"\"\"Enable or disable certificate validation.\"\"\""},{"line_number":199,"context_line":"        if not isinstance(verify_certificate, bool):"},{"line_number":200,"context_line":"            raise exceptions.InvalidParameterValueError("},{"line_number":201,"context_line":"                parameter\u003d\u0027verify_certificate\u0027, value\u003dverify_certificate,"},{"line_number":202,"context_line":"                valid_values\u003d\u0027boolean (True, False)\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"34a65e86_28b5bac2","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":52},"in_reply_to":"fede32c8_1eeb36a4","updated":"2021-10-22 09:01:16.000000000","message":"Done","commit_id":"ad4026bc5766c78c98eeed44b09ccd2251ccff3f"}]}