)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"46e367d4d9f489afd4e72c229342903da525c80b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee826b7b_c1692f53","updated":"2021-11-09 12:48:42.000000000","message":"thanks for the patch, some comments inline","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fd10b87a69cd3d11c5d73ecde46644f22a7f4db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a4698d1_f83ae447","updated":"2021-11-10 06:23:23.000000000","message":"Thank you for your review Aija. My responses in-line. I look forward to further feedback. Thanks, Jacob.","commit_id":"70e8faf5511c213fe62658638be53f770b54c6cc"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b19454174770bef09990dc0e5b688ef203ea808f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0c7e7da8_8ee587a7","updated":"2021-11-10 16:25:31.000000000","message":"thanks for the updates. Generally, seems OK. Just if anyone really will want to use physical CD with Supermicro it will not be possible. Though not sure if anyone is expecting such use case.","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1fecee7299a06841702ffa90854de21e19863b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ced37b41_206b8cd7","in_reply_to":"0c7e7da8_8ee587a7","updated":"2021-11-11 00:25:15.000000000","message":"Thank you for your feedback, Aija, it\u0027s been very helpful.\n\nAt this stage, I am not expecting anyone to try to boot a SuperMicro from a physical CD - I do not think the models we\u0027re working with (X11, X12) even have an option to fit one.\n\nI have one more question though: am I referencing constants/mappings in https://review.opendev.org/c/openstack/sushy/+/817137/7/sushy/resources/system/system.py#249 in an optimal way? It seems a little convoluted but this is the best way I got to so far while using constants.\n\nThe previous version was slightly off (it was attempting to send \"BootSourceOverrideTarget\": \"usb cd\" as opposed to \"BootSourceOverrideTarget\": \"UsbCd\" which we need hence changing this).","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"6020a6b2b6fe1d92525559fc24a9c52eadfc32f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"252e6f7d_70b8bd21","updated":"2021-11-18 11:47:05.000000000","message":"LGTM, thanks, Jacob!\n\nThe only comment I would have is whether all supermicro machines behave like this. But in the end I think it is sensible to start with this assumption and then adapt when needed, rather than listing known models and keep adding. ","commit_id":"f7c873fe4ad6caf3fb8e780611e02e0ab71a4241"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b57b1393_52c0ff59","updated":"2021-11-18 10:12:06.000000000","message":"Thank you for your review Dmitry.\n\nI uploaded an updated revision of the patch.\n\nPlease let me know if you have further comments.\n\nThank you,\nJacob","commit_id":"f7c873fe4ad6caf3fb8e780611e02e0ab71a4241"}],"sushy/resources/system/constants.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e37cdb9e9f692f189e14e6baa0ba3ebd523fd202","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\"\"\"Boot from a UEFI HTTP network location\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"BOOT_SOURCE_TARGET_USB_CD \u003d \u0027usb cd\u0027"},{"line_number":92,"context_line":"\"\"\"Boot from a USB CD device as specified by the system BIOS\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Boot source mode constants"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"97d15cdf_cd2b160a","line":92,"updated":"2021-11-16 12:42:23.000000000","message":"Let\u0027s be explicit that it\u0027s not a standard value and explain the situation in the docstring (same as you did in the code, maybe just refer to it?).","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"\"\"\"Boot from a UEFI HTTP network location\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"BOOT_SOURCE_TARGET_USB_CD \u003d \u0027usb cd\u0027"},{"line_number":92,"context_line":"\"\"\"Boot from a USB CD device as specified by the system BIOS\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Boot source mode constants"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3e766420_757599be","line":92,"in_reply_to":"97d15cdf_cd2b160a","updated":"2021-11-18 10:12:06.000000000","message":"Done. Let me know if you would like me to make any edits.","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"}],"sushy/resources/system/system.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"46e367d4d9f489afd4e72c229342903da525c80b","unresolved":true,"context_lines":[{"line_number":236,"context_line":"                    valid_values\u003dvalid_targets)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb4eab9a_e100b92e","line":239,"updated":"2021-11-09 12:48:42.000000000","message":"for this block will need to add unit test coverage","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5be383be2d0de8861a7581c0d4313b6bb5f429b3","unresolved":true,"context_lines":[{"line_number":236,"context_line":"                    valid_values\u003dvalid_targets)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfe25f3d_9d30dabc","line":239,"in_reply_to":"52d5b763_c3662cf9","updated":"2021-11-10 08:20:47.000000000","message":"as you have suggested in the comment - assert the PATCH input params, for example see other tests for this method, e.g., `test_set_system_boot_options`","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fd10b87a69cd3d11c5d73ecde46644f22a7f4db6","unresolved":true,"context_lines":[{"line_number":236,"context_line":"                    valid_values\u003dvalid_targets)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"52d5b763_c3662cf9","line":239,"in_reply_to":"bb4eab9a_e100b92e","updated":"2021-11-10 06:23:23.000000000","message":"Thank you Aija. I started adding a test ( https://review.opendev.org/c/openstack/sushy/+/817137/4/sushy/tests/unit/resources/system/test_system.py#679 ). Do you have any suggestions on what to check for to make sure this conditional works as expected? Should I look inside data variable and check if BootSourceOverrideTarget is set to UsbCd? Or is there a better way? Thank you.","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b41f8d04df3f211269a1d45024cea0caa47b7136","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                    valid_values\u003dvalid_targets)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"56245bd3_7122c7c1","line":239,"in_reply_to":"dfe25f3d_9d30dabc","updated":"2021-11-10 10:33:40.000000000","message":"Thank you Aija. Done!","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"46e367d4d9f489afd4e72c229342903da525c80b","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"},{"line_number":243,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"}],"source_content_type":"text/x-python","patch_set":2,"id":"ced135f3_9bc17ae4","line":240,"range":{"start_line":240,"start_character":47,"end_line":240,"end_character":52},"updated":"2021-11-09 12:48:42.000000000","message":"could use constant `BOOT_SOURCE_TARGET_CD` instead of literal string from here - https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/system/constants.py#L60","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fd10b87a69cd3d11c5d73ecde46644f22a7f4db6","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"},{"line_number":243,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"}],"source_content_type":"text/x-python","patch_set":2,"id":"803c0d97_4a73f04b","line":240,"range":{"start_line":240,"start_character":47,"end_line":240,"end_character":52},"in_reply_to":"ced135f3_9bc17ae4","updated":"2021-11-10 06:23:23.000000000","message":"Done","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"46e367d4d9f489afd4e72c229342903da525c80b","unresolved":true,"context_lines":[{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"},{"line_number":243,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f3564d5_70b426a2","line":241,"range":{"start_line":241,"start_character":24,"end_line":241,"end_character":31},"updated":"2021-11-09 12:48:42.000000000","message":"could add \u0027UsbCd\u0027 to `BOOT_SOURCE_TARGET_*` set [1] even if it\u0027s not part of the Redfish standard and use that here.\n\n[1] https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/system/constants.py#L49","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fd10b87a69cd3d11c5d73ecde46644f22a7f4db6","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV[target]"},{"line_number":239,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":240,"context_line":"                    and fishy_target.lower() \u003d\u003d \u0027cd\u0027"},{"line_number":241,"context_line":"                    and \u0027UsbCd\u0027 in self.boot.allowed_values):"},{"line_number":242,"context_line":"                fishy_target \u003d \u0027UsbCd\u0027"},{"line_number":243,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0c1c0fac_4865dce3","line":241,"range":{"start_line":241,"start_character":24,"end_line":241,"end_character":31},"in_reply_to":"3f3564d5_70b426a2","updated":"2021-11-10 06:23:23.000000000","message":"Done","commit_id":"9eba3ccfc9c9ac71851e2d75e7580231609137c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e37cdb9e9f692f189e14e6baa0ba3ebd523fd202","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":246,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":247,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":248,"context_line":"                    and fishy_target.lower() \u003d\u003d sys_cons.BOOT_SOURCE_TARGET_CD"},{"line_number":249,"context_line":"                    and sys_maps.BOOT_SOURCE_TARGET_MAP_REV["},{"line_number":250,"context_line":"                        sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":251,"context_line":"                    in self.boot.allowed_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ed989bf1_e149da0a","line":248,"updated":"2021-11-16 12:42:23.000000000","message":"nit: no lower() on constants please","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":246,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":247,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":248,"context_line":"                    and fishy_target.lower() \u003d\u003d sys_cons.BOOT_SOURCE_TARGET_CD"},{"line_number":249,"context_line":"                    and sys_maps.BOOT_SOURCE_TARGET_MAP_REV["},{"line_number":250,"context_line":"                        sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":251,"context_line":"                    in self.boot.allowed_values):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8146df_87424790","line":248,"in_reply_to":"ed989bf1_e149da0a","updated":"2021-11-18 10:12:06.000000000","message":"Done.","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e37cdb9e9f692f189e14e6baa0ba3ebd523fd202","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                        sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":251,"context_line":"                    in self.boot.allowed_values):"},{"line_number":252,"context_line":"                fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV["},{"line_number":253,"context_line":"                    sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":254,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if enabled is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"172adc02_32d5db55","line":253,"updated":"2021-11-16 12:42:23.000000000","message":"let\u0027s issue a debug message here","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                        sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":251,"context_line":"                    in self.boot.allowed_values):"},{"line_number":252,"context_line":"                fishy_target \u003d sys_maps.BOOT_SOURCE_TARGET_MAP_REV["},{"line_number":253,"context_line":"                    sys_cons.BOOT_SOURCE_TARGET_USB_CD]"},{"line_number":254,"context_line":"            data[\u0027Boot\u0027][\u0027BootSourceOverrideTarget\u0027] \u003d fishy_target"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if enabled is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff350b0e_50a52ef4","line":253,"in_reply_to":"172adc02_32d5db55","updated":"2021-11-18 10:12:06.000000000","message":"Done.","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"}],"sushy/tests/unit/json_samples/system.json":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e37cdb9e9f692f189e14e6baa0ba3ebd523fd202","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            \"Diags\","},{"line_number":38,"context_line":"            \"SDCard\","},{"line_number":39,"context_line":"            \"UefiTarget\","},{"line_number":40,"context_line":"\t    \"UsbCd\""},{"line_number":41,"context_line":"        ],"},{"line_number":42,"context_line":"        \"BootSourceOverrideMode\": \"UEFI\","},{"line_number":43,"context_line":"        \"UefiTargetBootSourceOverride\": \"/0x31/0x33/0x01/0x01\""}],"source_content_type":"application/json","patch_set":7,"id":"55c0c67e_0518ebd3","line":40,"updated":"2021-11-16 12:42:23.000000000","message":"Let\u0027s not put the non-standard value to the samples that are taken from DMTF (largely)","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            \"Diags\","},{"line_number":38,"context_line":"            \"SDCard\","},{"line_number":39,"context_line":"            \"UefiTarget\","},{"line_number":40,"context_line":"\t    \"UsbCd\""},{"line_number":41,"context_line":"        ],"},{"line_number":42,"context_line":"        \"BootSourceOverrideMode\": \"UEFI\","},{"line_number":43,"context_line":"        \"UefiTargetBootSourceOverride\": \"/0x31/0x33/0x01/0x01\""}],"source_content_type":"application/json","patch_set":7,"id":"9c01282f_1155f09d","line":40,"in_reply_to":"55c0c67e_0518ebd3","updated":"2021-11-18 10:12:06.000000000","message":"Done.","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"}],"sushy/tests/unit/resources/system/test_system.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b19454174770bef09990dc0e5b688ef203ea808f","unresolved":true,"context_lines":[{"line_number":677,"context_line":"        self.assertIs(self.sys_inst, contoso_system_extn_inst._parent_resource)"},{"line_number":678,"context_line":"        self.assertEqual(\u0027Contoso\u0027, contoso_system_extn_inst._vendor_id)"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def test_supermicro_usb_cd_boot(self):"},{"line_number":681,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":682,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":683,"context_line":"            sushy.BOOT_SOURCE_TARGET_USB_CD,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a9ecc709_dbf882a9","line":680,"updated":"2021-11-10 16:25:31.000000000","message":"move this test together with other tests for this `set_system_boot_options` method (line 277-333) and\nrename the test name to follow the pattern test_tested_method_name[_something_descriptive], e.g., in this case test_set_system_boot_options_supermicro_usb_cd_boot or test_set_system_boot_options_supermicro if shorter preferred.","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1fecee7299a06841702ffa90854de21e19863b8c","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        self.assertIs(self.sys_inst, contoso_system_extn_inst._parent_resource)"},{"line_number":678,"context_line":"        self.assertEqual(\u0027Contoso\u0027, contoso_system_extn_inst._vendor_id)"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def test_supermicro_usb_cd_boot(self):"},{"line_number":681,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":682,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":683,"context_line":"            sushy.BOOT_SOURCE_TARGET_USB_CD,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bd660408_e66e0486","line":680,"in_reply_to":"a9ecc709_dbf882a9","updated":"2021-11-11 00:25:15.000000000","message":"Done","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b19454174770bef09990dc0e5b688ef203ea808f","unresolved":true,"context_lines":[{"line_number":680,"context_line":"    def test_supermicro_usb_cd_boot(self):"},{"line_number":681,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":682,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":683,"context_line":"            sushy.BOOT_SOURCE_TARGET_USB_CD,"},{"line_number":684,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"},{"line_number":685,"context_line":"        self.sys_inst._conn.patch.assert_called_once_with("},{"line_number":686,"context_line":"            \u0027/redfish/v1/Systems/437XR1138R2\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c364c9ea_afebef75","line":683,"range":{"start_line":683,"start_character":12,"end_line":683,"end_character":43},"updated":"2021-11-10 16:25:31.000000000","message":"this is not testing what should be tested, the input parameter should be here just CD (BOOT_SOURCE_TARGET_CD), otherwise line 251 is never executed. Now test is passing for the wrong reason.","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1fecee7299a06841702ffa90854de21e19863b8c","unresolved":false,"context_lines":[{"line_number":680,"context_line":"    def test_supermicro_usb_cd_boot(self):"},{"line_number":681,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":682,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":683,"context_line":"            sushy.BOOT_SOURCE_TARGET_USB_CD,"},{"line_number":684,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"},{"line_number":685,"context_line":"        self.sys_inst._conn.patch.assert_called_once_with("},{"line_number":686,"context_line":"            \u0027/redfish/v1/Systems/437XR1138R2\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c1646ed_c34b9e2c","line":683,"range":{"start_line":683,"start_character":12,"end_line":683,"end_character":43},"in_reply_to":"c364c9ea_afebef75","updated":"2021-11-11 00:25:15.000000000","message":"Wow, well spotted, thank you for pointing this out. Fixed it now.","commit_id":"4c285f620b4f791c42e1ba801ea241fd606989f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e37cdb9e9f692f189e14e6baa0ba3ebd523fd202","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                enabled\u003d\u0027invalid-enabled\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def test_set_system_boot_options_supermicro_usb_cd_boot(self):"},{"line_number":336,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":337,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":338,"context_line":"            sushy.BOOT_SOURCE_TARGET_CD,"},{"line_number":339,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b99f48f_8cb703e4","line":336,"updated":"2021-11-16 12:42:23.000000000","message":"also add USB CD to the allowed value.\n\nanother test should check SuperMicro without USB CD in the allowed values","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"696cbb0bdf335a835e249359ed18085fb1b1308a","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                enabled\u003d\u0027invalid-enabled\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def test_set_system_boot_options_supermicro_usb_cd_boot(self):"},{"line_number":336,"context_line":"        self.sys_inst.manufacturer \u003d \"supermicro\""},{"line_number":337,"context_line":"        self.sys_inst.set_system_boot_options("},{"line_number":338,"context_line":"            sushy.BOOT_SOURCE_TARGET_CD,"},{"line_number":339,"context_line":"            enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f99ca02e_5d6479a7","line":336,"in_reply_to":"2b99f48f_8cb703e4","updated":"2021-11-18 10:12:06.000000000","message":"Done.","commit_id":"eb104e0c136152ee338e8424060593b376247a3c"}]}