)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3d26a739dd49717c2296fc78b011e102a7fb1371","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Attempt using Redfish settings resource to get URI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the ability to use RedFish Settings Resource to determine whether"},{"line_number":10,"context_line":"a SettingsObject URI needs to be used for operations such as setting"},{"line_number":11,"context_line":"BootSourceOverride."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"6d148310_8594beda","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":33},"updated":"2022-03-01 08:57:39.000000000","message":"nit: Redfish","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d2157947ed3e492c58c719ce4ac2a152d8de9ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53010c1c_5c11ee50","updated":"2022-02-28 10:08:16.000000000","message":"Thank you for your comments Dmitry and Riccardo. I think I addressed them all now.","commit_id":"ffba3ffe6214bd27d6992aaaefd03526e9aa19ff"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d907db71c7d307df4a2030990ca2e655629e8b14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec686027_d2b5a8c3","updated":"2022-02-28 13:45:39.000000000","message":"probably need to update unit tests","commit_id":"1d8893d037d1acab66791008aee177834595ccb7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6f24c1f1db2b30ae9a291686d78eca8ae21bf361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"af444594_a753b4c5","updated":"2022-03-01 01:37:17.000000000","message":"Added unit tests.","commit_id":"4226850f2e54ee7f7decf75367f4028a21e04c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3d26a739dd49717c2296fc78b011e102a7fb1371","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"07c0874f_4ade3461","updated":"2022-03-01 08:57:39.000000000","message":"thanks","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"}],"releasenotes/notes/retry-bootsourceoverride-alt-uri-12a332f9905d64ce.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aade503591b831a70f4ac97f11289bb54d149408","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding capability to retry setting BootSourceOverrideTarget if the original"},{"line_number":5,"context_line":"    request fails indicating that a non-standard URI needs to be used for this"},{"line_number":6,"context_line":"    particular functionality. For example, this is required on Nokia servers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"58b6639f_38c3fbe4","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2022-02-23 13:20:18.000000000","message":"nit: Adds","commit_id":"4bb2d996bb1aef44989a2dfd5628d73bcb0efa11"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d2157947ed3e492c58c719ce4ac2a152d8de9ea0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding capability to retry setting BootSourceOverrideTarget if the original"},{"line_number":5,"context_line":"    request fails indicating that a non-standard URI needs to be used for this"},{"line_number":6,"context_line":"    particular functionality. For example, this is required on Nokia servers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d8f8d47_c6ff0d00","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"in_reply_to":"58b6639f_38c3fbe4","updated":"2022-02-28 10:08:16.000000000","message":"Done","commit_id":"4bb2d996bb1aef44989a2dfd5628d73bcb0efa11"}],"sushy/resources/system/system.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3e52d23ee809f64d448eb6cb606f703c49502263","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                # suceeds. Working around it for the time being, to discuss"},{"line_number":294,"context_line":"                # with fellow contributors."},{"line_number":295,"context_line":"                # headers \u003d {\u0027If-Match\u0027: self._get_etag()}"},{"line_number":296,"context_line":"                resp \u003d self._conn.get(revised_path)"},{"line_number":297,"context_line":"                headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":298,"context_line":"                self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    # TODO(etingof): we should remove this method, eventually"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ce4973b_4fafcc39","line":297,"range":{"start_line":296,"start_character":0,"end_line":297,"end_character":60},"updated":"2022-02-23 07:19:20.000000000","message":"This is here to replicate running a GET request via curl, extracting the eTag and including it in the subsequent PATCH request as this is the only approach that worked so far. Using the code similar to L277-279 doesn\u0027t work (the Nokia BMC doesn\u0027t like the resulting eTag). Not sure why, I\u0027d welcome any hints.","commit_id":"981adbac2a9bcdaa006eab98445187fedd8d4e68"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36f6455b3948f5ee99ed5b28b5bb9ea4cdc3ae23","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                # suceeds. Working around it for the time being, to discuss"},{"line_number":294,"context_line":"                # with fellow contributors."},{"line_number":295,"context_line":"                # headers \u003d {\u0027If-Match\u0027: self._get_etag()}"},{"line_number":296,"context_line":"                resp \u003d self._conn.get(revised_path)"},{"line_number":297,"context_line":"                headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":298,"context_line":"                self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    # TODO(etingof): we should remove this method, eventually"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f072caf_e760226a","line":297,"range":{"start_line":296,"start_character":0,"end_line":297,"end_character":60},"in_reply_to":"4ce4973b_4fafcc39","updated":"2022-02-23 10:05:28.000000000","message":"Well, this is expected: the revised_path is a different resource, its E-tag is different from the parent resource.","commit_id":"981adbac2a9bcdaa006eab98445187fedd8d4e68"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d2157947ed3e492c58c719ce4ac2a152d8de9ea0","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                # suceeds. Working around it for the time being, to discuss"},{"line_number":294,"context_line":"                # with fellow contributors."},{"line_number":295,"context_line":"                # headers \u003d {\u0027If-Match\u0027: self._get_etag()}"},{"line_number":296,"context_line":"                resp \u003d self._conn.get(revised_path)"},{"line_number":297,"context_line":"                headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":298,"context_line":"                self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    # TODO(etingof): we should remove this method, eventually"}],"source_content_type":"text/x-python","patch_set":1,"id":"e275c922_d3d0e1a2","line":297,"range":{"start_line":296,"start_character":0,"end_line":297,"end_character":60},"in_reply_to":"6f072caf_e760226a","updated":"2022-02-28 10:08:16.000000000","message":"Done","commit_id":"981adbac2a9bcdaa006eab98445187fedd8d4e68"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36f6455b3948f5ee99ed5b28b5bb9ea4cdc3ae23","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            if (response.code \u003d\u003d \"Ami.1.0.OperationSupportedInFutureStateURI\""},{"line_number":287,"context_line":"                    and response.body[\u0027@Message.ExtendedInfo\u0027][0]"},{"line_number":288,"context_line":"                    [\u0027RelatedProperties\u0027][0] \u003d\u003d \"#/Boot\"):"},{"line_number":289,"context_line":"                revised_path \u003d self.path + \"/SD\""},{"line_number":290,"context_line":"                # NOTE(janders) for some reason _get_etag() returns incorrect"},{"line_number":291,"context_line":"                # value (at least on Nokia servers) and the request below"},{"line_number":292,"context_line":"                # fails. If grabbing etag from GET request header the request"}],"source_content_type":"text/x-python","patch_set":2,"id":"93bbb23c_cba284e6","line":289,"updated":"2022-02-23 10:05:28.000000000","message":"I\u0027d rather have us calculate this rather than hardcoding \"/SD\".","commit_id":"4bb2d996bb1aef44989a2dfd5628d73bcb0efa11"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d2157947ed3e492c58c719ce4ac2a152d8de9ea0","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            if (response.code \u003d\u003d \"Ami.1.0.OperationSupportedInFutureStateURI\""},{"line_number":287,"context_line":"                    and response.body[\u0027@Message.ExtendedInfo\u0027][0]"},{"line_number":288,"context_line":"                    [\u0027RelatedProperties\u0027][0] \u003d\u003d \"#/Boot\"):"},{"line_number":289,"context_line":"                revised_path \u003d self.path + \"/SD\""},{"line_number":290,"context_line":"                # NOTE(janders) for some reason _get_etag() returns incorrect"},{"line_number":291,"context_line":"                # value (at least on Nokia servers) and the request below"},{"line_number":292,"context_line":"                # fails. If grabbing etag from GET request header the request"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f13824e_41092f03","line":289,"in_reply_to":"93bbb23c_cba284e6","updated":"2022-02-28 10:08:16.000000000","message":"Done","commit_id":"4bb2d996bb1aef44989a2dfd5628d73bcb0efa11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"26bb377f6cf4ee106168ff94defcb12b7ad9da28","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        # NOTE(janders)"},{"line_number":287,"context_line":"        # Trying to check if @Redfish.Settings are present and if so updating"},{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"8876dca0_b6ac433f","line":289,"updated":"2022-02-28 11:29:37.000000000","message":"nit: redundant brackets","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fca6fae55fc78586e3291817e73cfe4b1c0492a4","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        # NOTE(janders)"},{"line_number":287,"context_line":"        # Trying to check if @Redfish.Settings are present and if so updating"},{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"89497d10_07f6d4e0","line":289,"in_reply_to":"8876dca0_b6ac433f","updated":"2022-02-28 12:26:30.000000000","message":"Done","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"26bb377f6cf4ee106168ff94defcb12b7ad9da28","unresolved":true,"context_lines":[{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"29f4c471_920c6b6b","line":291,"updated":"2022-02-28 11:29:37.000000000","message":"nit: maybe use head instead of get since we don\u0027t need the body?","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fca6fae55fc78586e3291817e73cfe4b1c0492a4","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"6ead6176_e3a3dfb0","line":291,"in_reply_to":"29f4c471_920c6b6b","updated":"2022-02-28 12:26:30.000000000","message":"Done","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"0ca1c4a5f1528164ceb4584dd10e34e7209e1aa2","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ef5f5124_b98cee1f","line":291,"in_reply_to":"2c4db85b_290da4d6","updated":"2022-02-28 12:45:33.000000000","message":"Nah scratch that I don\u0027t think this is get/head problem.","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3c3d2a00ee3ef60c4ea24f6c1da8f63265c70581","unresolved":true,"context_lines":[{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2c4db85b_290da4d6","line":291,"in_reply_to":"6ead6176_e3a3dfb0","updated":"2022-02-28 12:43:59.000000000","message":"I tried this and got the error below - I wonder if I stuffed something up or is it better to leave GET here? WDYT?\n\n[rhjanders@bastion2 bmctest]$ python3 boot.py \nsys_inst._settings:  /redfish/v1/Systems/Self/SD\nTraceback (most recent call last):\n  File \"boot.py\", line 17, in \u003cmodule\u003e\n    sys_inst.set_system_boot_options(None, \u0027Disabled\u0027)\n  File \"/home/rhjanders/.local/lib/python3.6/site-packages/sushy/resources/system/system.py\", line 285, in set_system_boot_options\n    resp \u003d self._conn.head(path)\nAttributeError: \u0027Connector\u0027 object has no attribute \u0027head\u0027\n[rhjanders@bastion2 bmctest]$","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7c3ddcfd15fd68bc06c8ac502400ef3d52e2fabc","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        # path to match the resource_uri provided. Also getting new ETag."},{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"c409f290_5dedd3f8","line":291,"in_reply_to":"ef5f5124_b98cee1f","updated":"2022-02-28 12:59:51.000000000","message":"Still couldn\u0027t get it to work using just the headers, but cleaned it up a bit nonetheless. Let me know if this is good enough. Thanks Dmitry! 😊","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"26bb377f6cf4ee106168ff94defcb12b7ad9da28","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            self._conn.patch(self.path, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":8,"id":"2b88006f_cbd6a320","line":292,"updated":"2022-02-28 11:29:37.000000000","message":"The ETag *should* be there, but you know... Let\u0027s make it optional.\n\nAlso check the logic in _get_etag.","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fca6fae55fc78586e3291817e73cfe4b1c0492a4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        if (self._settings and self._settings.resource_uri):"},{"line_number":290,"context_line":"            revised_path \u003d self._settings.resource_uri"},{"line_number":291,"context_line":"            resp \u003d self._conn.get(revised_path)"},{"line_number":292,"context_line":"            headers \u003d {\u0027If-Match\u0027: resp.headers[\u0027ETag\u0027]}"},{"line_number":293,"context_line":"            self._conn.patch(revised_path, data\u003ddata, headers\u003dheaders)"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            self._conn.patch(self.path, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":8,"id":"8dccb4fa_604671b6","line":292,"in_reply_to":"2b88006f_cbd6a320","updated":"2022-02-28 12:26:30.000000000","message":"DONE - I think.","commit_id":"41e3fa98e604016fced2b5c9186fb25ce6d33db1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d907db71c7d307df4a2030990ca2e655629e8b14","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":285,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":286,"context_line":"            etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":287,"context_line":"        else:"},{"line_number":288,"context_line":"            path \u003d self.path"},{"line_number":289,"context_line":"            etag \u003d self._get_etag()"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"47d5c80b_a59bf0d8","line":287,"updated":"2022-02-28 13:45:39.000000000","message":"nit: this works fine, I would have avoided the else defining path and etag right before the if","commit_id":"1d8893d037d1acab66791008aee177834595ccb7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e4ce471acec0ebd7ea2cdb1fadb389656a14d9a0","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":285,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":286,"context_line":"            etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":287,"context_line":"        else:"},{"line_number":288,"context_line":"            path \u003d self.path"},{"line_number":289,"context_line":"            etag \u003d self._get_etag()"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7ee27fae_c5595eed","line":287,"in_reply_to":"47d5c80b_a59bf0d8","updated":"2022-03-01 00:27:56.000000000","message":"Good idea, thank you Riccardo. I\u0027m not sure why I even changed this in the first place, it wasn\u0027t needed.","commit_id":"1d8893d037d1acab66791008aee177834595ccb7"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3d26a739dd49717c2296fc78b011e102a7fb1371","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        etag \u003d self._get_etag()"},{"line_number":281,"context_line":"        path \u003d self.path"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # NOTE(janders): checking if @RedFish.Settings are available; if so"},{"line_number":284,"context_line":"        # using the URI from the SettingsObject. Also ensuring the ETag URI"},{"line_number":285,"context_line":"        # matches in this case (the one above would not be valid for new URI)."},{"line_number":286,"context_line":"        if self._settings and self._settings.resource_uri:"}],"source_content_type":"text/x-python","patch_set":13,"id":"25d71766_aae7009f","line":283,"range":{"start_line":283,"start_character":38,"end_line":283,"end_character":45},"updated":"2022-03-01 08:57:39.000000000","message":"Redfish","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6c6a41c6512f38ee46667108decf8c824fb9c77a","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        etag \u003d self._get_etag()"},{"line_number":281,"context_line":"        path \u003d self.path"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        # NOTE(janders): checking if @RedFish.Settings are available; if so"},{"line_number":284,"context_line":"        # using the URI from the SettingsObject. Also ensuring the ETag URI"},{"line_number":285,"context_line":"        # matches in this case (the one above would not be valid for new URI)."},{"line_number":286,"context_line":"        if self._settings and self._settings.resource_uri:"}],"source_content_type":"text/x-python","patch_set":13,"id":"b77cfb16_6cae151c","line":283,"range":{"start_line":283,"start_character":38,"end_line":283,"end_character":45},"in_reply_to":"25d71766_aae7009f","updated":"2022-03-01 09:47:12.000000000","message":"Thank you Aija. 100%. I\u0027ve spent a few hours today figuring out why conditionals don\u0027t trigger and it was all case mismatch for the F/f. Will fix this in follow-up as well.","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d7bb0c8d1df1ce48a55048d83ba7a77a45f9ea9e","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        if self._settings and self._settings.resource_uri:"},{"line_number":287,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":288,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":289,"context_line":"            if resp:"},{"line_number":290,"context_line":"                etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # TODO(lucasagomes): Check the return code and response body ?"}],"source_content_type":"text/x-python","patch_set":13,"id":"01bf058e_147c3594","line":289,"updated":"2022-03-01 09:30:26.000000000","message":"I don\u0027t think resp can be None if the request succeeds","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1ab0562c14ec8ac3598b30ddc395a8d329985b18","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        if self._settings and self._settings.resource_uri:"},{"line_number":287,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":288,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":289,"context_line":"            if resp:"},{"line_number":290,"context_line":"                etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # TODO(lucasagomes): Check the return code and response body ?"},{"line_number":293,"context_line":"        #                    Probably we should call refresh() as well."}],"source_content_type":"text/x-python","patch_set":13,"id":"e609ce08_d8cf5681","line":290,"range":{"start_line":289,"start_character":0,"end_line":290,"end_character":43},"updated":"2022-03-01 10:05:14.000000000","message":"@Dmitry should we do this instead:\n\n289             if resp.headers[\u0027ETag\u0027]:\n290                 etag \u003d resp.headers[\u0027ETag\u0027]\n\nMaking sure I understood correctly. Thanks!","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d7bb0c8d1df1ce48a55048d83ba7a77a45f9ea9e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":288,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":289,"context_line":"            if resp:"},{"line_number":290,"context_line":"                etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # TODO(lucasagomes): Check the return code and response body ?"},{"line_number":293,"context_line":"        #                    Probably we should call refresh() as well."}],"source_content_type":"text/x-python","patch_set":13,"id":"24c4003b_e0127097","line":290,"updated":"2022-03-01 09:30:26.000000000","message":"I\u0027d still prefer not to rely on presence of ETag...","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"9f7b490ec566e874ce5cd4eb085368e8617fbf92","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":288,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":289,"context_line":"            if resp:"},{"line_number":290,"context_line":"                etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # TODO(lucasagomes): Check the return code and response body ?"},{"line_number":293,"context_line":"        #                    Probably we should call refresh() as well."}],"source_content_type":"text/x-python","patch_set":13,"id":"718e8e00_07a1fd17","line":290,"in_reply_to":"24c4003b_e0127097","updated":"2022-03-01 09:43:57.000000000","message":"Thanks Dmitry. I can fix these two in a follow-up patch if that\u0027s OK?","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"07b3756b0f01e882a8e1d9bfed4065dbfb8f0d7f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        if self._settings and self._settings.resource_uri:"},{"line_number":287,"context_line":"            path \u003d self._settings.resource_uri"},{"line_number":288,"context_line":"            resp \u003d self._conn.get(path)"},{"line_number":289,"context_line":"            if resp:"},{"line_number":290,"context_line":"                etag \u003d resp.headers[\u0027ETag\u0027]"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # TODO(lucasagomes): Check the return code and response body ?"},{"line_number":293,"context_line":"        #                    Probably we should call refresh() as well."}],"source_content_type":"text/x-python","patch_set":13,"id":"2a6888db_d4b6b39c","line":290,"range":{"start_line":289,"start_character":0,"end_line":290,"end_character":43},"in_reply_to":"e609ce08_d8cf5681","updated":"2022-03-01 10:34:50.000000000","message":"Not quite but in any case the follow-up change is here: https://review.opendev.org/c/openstack/sushy/+/831355","commit_id":"1ddf9d70598d4fc1a1b2ebe2cc15518d2f92143b"}]}